| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Looks like this was an off by one copy/paste. MOVI is video/sgi and is just before moov in magic.mime
BUG=b/11637229
Review URL: https://codereview.chromium.org/67863004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
VP9 support was added to android in Kitkat. Changing canPlayType to return
probably/maybe if running on kitkat or higher.
Review URL: https://codereview.chromium.org/66863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Handle file error as a failure rather than handling it as empty file.
* Change Chrome Frame error handling for URLRequest failure, from DCHECK hit to ignoring failing input file.
BUG=310548, 317432
Review URL: https://codereview.chromium.org/39203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other parts of the network stack are processing and fetching results from
invalid DNS names, but TransportSecurityState was rejecting them and therefore
HSTS policies didn't apply.
This change removes the sanity checking so that TransportSecurityState is more
promiscuous in what it'll try and process.
BUG=312689
Review URL: https://codereview.chromium.org/54623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added default implementations for methods in net::NetworkDelegate to make it easier to implement, and more likely for implementations to be correct.
BUG=310297
Review URL: https://codereview.chromium.org/38303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently it uses a delayed task with a WeakPtrFactory, and checks
the existence of weak pointers to determine whether there is a task
in flight. This is dangerous, since future changes could inadvertently
use the WeakPtrFactory for something unrelated.
Change names to make it clear that a timer is running and
not the backup job itself.
BUG=166689
R=mmenke@chromium.org
Review URL: https://codereview.chromium.org/46053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch to logging an event before calling into delegates, and after
they return instead of only in the case that they block. This allows
delegates to log events as they take turns blocking a network
request.
Also allows delegates to log events when delaying the start of
a request, and when delaying the start of reading the body of a
request (But not between normal body reads).
Also allows delegates to log delegate information that will not be
displayed to the user.
BUG=294920
Review URL: https://codereview.chromium.org/25097004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make it easier to add support for reprioritization as
PriorityQueue allows for removal of arbitrary elements.
Add support for iterating through a PriorityQueue.
BUG=166689
R=mmenke@chromium.org
Review URL: https://codereview.chromium.org/28953008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=305270
Review URL: https://codereview.chromium.org/26465008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Services Code Point for each package. Will be used by webrtc to hopefully improve performance. (See bug for how we will test this.)
BUG=277022
Review URL: https://codereview.chromium.org/22381012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN errors to be handled by the SSL interstitial, so that we can present a single unified non-overridable warning.
BUG=276540
R=rsleevi@chromium.org
TBR=abarth@chromium.org
Review URL: https://codereview.chromium.org/23908005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=agl@chromium.org,rsleevi@chromium.org
BUG=306959
TEST=none
Review URL: https://codereview.chromium.org/27266002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce MAXIMUM_PRIORITY instead and use this when appropriate.
This is so that one can assume that a RequestPriority instance contains
only a valid priority.
BUG=307757
R=rch@chromium.org
TBR=simonjam@chromium.org
Review URL: https://codereview.chromium.org/27213004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The avc3 codec string is used for H.264 content where the SPS & PPS are
included at the beginning of each access point instead of in the file
headers. This change just allows these streams to be played since our
decoders already support this. In fact, our avc1 code essentially creates
avc3 style streams for the decoder anyways.
BUG=306545
TEST=PipelineIntegrationTest.BasicPlayback_MediaSource_VideoOnly_MP4_AVC3
Review URL: https://codereview.chromium.org/27374002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(which will happen over TCP).
Review URL: https://codereview.chromium.org/27181004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is to avoid confusion with whether higher numbers are higher priority.
BUG=307757
R=rch@chromium.org
Review URL: https://codereview.chromium.org/26297006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
net/base/net_util.h, and fix missing #includes elsewhere as a result.
Review URL: https://codereview.chromium.org/25183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add #includes of <algorithm> for std::min/max.
R=rsleevi@chromium.org
BUG=288948
Review URL: https://codereview.chromium.org/27060002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change in http://crrev.com/209100 is too general; this makes
the effects specific to embedded identities.
BUG=303046
R=cbentzel@chromium.org
Review URL: https://codereview.chromium.org/26745002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the effective-TLD data file to:
06c405ba54b3 2013-09-17 17:54 +0100
It includes changes from a number of Mozilla bugs, listed on
https://hg.mozilla.org/mozilla-central/log/06c405ba54b3/netwerk/dns/effective_tld_names.dat
between f8a861253c57 (2013-05-14 17:35 +0100) and 06c405ba54b3
(2013-09-17 17:54 +0100)
BUG=37436
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/26610006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds an extension management policy provider that allows
explicitly whitelisted apps/extensions to be installed in public sessions.
Right now, QuickOffice and all hosted apps are whitelisted.
BUG=296868
TEST=New browser and unit tests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226494
Review URL: https://codereview.chromium.org/24261010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
TBR=mark, acolwell, agl, alexeypa, markus, brettw
Review URL: https://codereview.chromium.org/25849004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most likely cause of test failures at
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/9496
Failed tests:
BrowserGuestSessionNavigatorTest.Disposition_Settings_UseIncognitoWindow
UserTypeInstantiation/AccessibilityManagerUserTypeTest.EnableOnLoginScreenAndLogin/1
> Allow explicitly whitelisted apps/extensions in public sessions
>
> This CL adds an extension management policy provider that allows
> explicitly whitelisted apps/extensions to be installed in public sessions.
> Right now, QuickOffice and all hosted apps are whitelisted.
>
> BUG=296868
> TEST=New browser and unit tests
>
> Review URL: https://codereview.chromium.org/24261010
TBR=bartfab@chromium.org
Review URL: https://codereview.chromium.org/25757003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds an extension management policy provider that allows
explicitly whitelisted apps/extensions to be installed in public sessions.
Right now, QuickOffice and all hosted apps are whitelisted.
BUG=296868
TEST=New browser and unit tests
Review URL: https://codereview.chromium.org/24261010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make UploadDataStream::Reset public.
Call Reset() from HttpNetworkTransaction's dtor.
Add tests.
BUG=244725
TEST=net_unittests --gtest_filter="*HttpNetworkTransactionTest.CancelDuringInitRequestBody*"
Review URL: https://codereview.chromium.org/25217002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
XP has no OnLinkPrefixLength so we need to use FirstPrefix list instead.
Review URL: https://codereview.chromium.org/25167002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Use size_t for network prefix for consistency with other code.
Use ParseCIDRBlock to split address and network.
Review URL: https://codereview.chromium.org/24674003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UTS 46 provides a migration path from IDNA 2003 to IDNA 2008.
1. Use the up-to-date Unicode data; new characters were
added and some case-folding/mapping have changed since Unicode 3.2 on which
IDNA 2003 is based.
2. Define a case folding/mapping as is the case with IDNA 2003.
3. Use transitional mechanism for 4 deviant characters : German sharp-S,
Greek final-sigma, ZWJ and ZWNJ. That is, the former two are mapped to
'ss' and regular sigma and the latter two are dropped. All the major
browsers do this at the moment so allowing them does not do any good.
We'll review this later as the consensus builds among browser vendors
and registrars. We can also consider handling them separately. For instance,
ZWJ/ZWNJ can be allowed with ContextJ rules, which requires a minor change
in ICU's UTS 46 implementation.
4. Symbol and punctuations continue to be allowed.
We also do the following:
1. Continue to "violate" STD3 rules about non-LDH (Letter, digits and
hyphens) by allowing non-LDH's. That is no change from the current
implementation.
2. Do not allow unassigned code points any more. With an up-to-date
Unicode data, this does not make much difference. And the chance of
new characters not yet reflected in our Unicode data popping up in
a domain name is extremely low.
3. Continue to use CHECK_BIDI. The Bidi rule in IDNA 2008 is more
permissive than in IDNA 2003.
References:
1. http://unicode.org/reports/tr46/ and references therein
to IDNA 2003 and 2008 RFCs.
2. What IE 10 does : http://goo.gl/3XBhqw
3. Mozilla bug : https://bugzilla.mozilla.org/show_bug.cgi?id=479520
BUG=61328
TEST=url_unittests (URLCanonTest.Host), net_unittests (NetUtilTest.IDNToU*),
unittests (X509CertificateModelTest.*)
R=brettw@chromium.org, pkasting@chromium.org, rsleevi@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/23642003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There is not way to run try jobs there.
This patch is temprorary. I'll revert it after few runs on bots.
NOTRY=true
Review URL: https://codereview.chromium.org/24637003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously native messaging ports were kept open even after native messaging
host has closed stdout pipe which is used to send messages to the connected
webapp. That behavior makes it hard to detect the case when the host exists
but fails to start. Now chrome will close the native messaging port as soon
as it reads EOF from the pipe.
BUG=297380
Review URL: https://codereview.chromium.org/24409004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=295997
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225303
R=szym@chromium.org
Review URL: https://codereview.chromium.org/23726043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Added NetworkInterface::network_prefix.
>
> BUG=295997
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/23726043
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/24530007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=295997
NOTRY=true
Review URL: https://codereview.chromium.org/23726043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, brettw@chromium.org, sergeyu@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/24616002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ctor
ScopedVector supports Pass() method.
Use of Pass() makes it clear that the ownership of the readers moves to the newly created UploadDataStream.
BUG=None
TEST=git cl try
TBR=sky@chromium.org for content/browser, mpcomplete@chromium.org for chrome/browser/extensions/api/web_request
Review URL: https://chromiumcodereview.appspot.com/23929005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=254066
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/24155002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PnaCl's translation cache is currently using the DISK_CACHE backend,
but we don't want to mix the UMA statistics for these caches. Also,
because we expect PNaCl's cache to have a small number of files, which
will be much larger than most HTTP cache files, we remove the restriction
that files can take up no more than 1/8 of the cache. For machines with
little available disk space (and thus small caches), this may mean the
difference between being able to store any files in the cache, or not.
R=rvargas@chromium.org,jvoung@chromium.org
BUG=none
TEST= unit_tests PnaclTranslationCacheTest.* (and no net_unittests break)
Review URL: https://chromiumcodereview.appspot.com/24208003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, if there's no WPAD host on the local network, we have to wait up to
two seconds for ProxyScriptDecider to time out, during which all requests are
stalled waiting to find out what proxy to use. This is a pretty crappy
experience when you have proxy autodetection turned on and no WPAD host.
Therefore, add a new state to ProxyScriptDecider's state machine: "QuickCheck".
When we're in this state, we are doing a DNS query only for WPAD, with a timeout
of 1 second; if this query doesn't succeed, we abort the entire WPAD process. We
also upload an UMA report saying how long the WPAD resolution took to succeed.
In future, once we have a good idea how long WPAD requests usually actually
take, we'll turn this timeout down, probably to something extremely low (from
experiments, IE appears to use a timeout of 50ms).
TEST=unit,trybot,manual
BUG=chromium:161826
Review URL: https://chromiumcodereview.appspot.com/23181010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a DCHECK that ProcessRawData will not be called with zero data length.
Merge internal change: 52068687
Removed reinterpret_cast<QuicFecBuilderInterface*>. Minor comment fix.
Merge internal change: 52051673
Replace QuicConnectionVisitorInterface::OnPacket with OnStreamFrames
Merge internal change: 52049491
Remove unused OnAck method from QuicConnectionVisitorInterface.
This is a bit of an abstraction violation, since nothing above
the Connection knows about packets. The AckNotifier interface
provides the "right" abstraction.
Merge internal change: 52027657
Add state to session to indicate that a crypto stream is blocked, so
that we can properly set the IS_HANDSHAKE argument when asking the
congestion manager if we CanWrite().
Merge internal change: 51983405
Break out the tracking of sent packet from QuicConnection to a new
QuicSentPacketManager class.
Merge internal change: 51969314
Delay the RTO every time an ack is received, per TCP RTO spec.
Merge internal change: 51954312
Sending ConnectionClose frames via the PacketGenerator so they get
properly queued if they cannot be sent immediately. Prevents multiple
different connection close packets from being sent, a potential
infinite loop, and from dropping connection close packets which can't
be sent due to a write block from being dropped entirely.
Merge internal change: 51890780
Increse the default max_tcp_congestion_window to 100 from 50, now that
the RTO has been increased to the TCP standard of 60 seconds.
Merge internal change: 51854728
Added large (1 Mb) POST tests.
Verified that without the fix from cl/51829697 these tests timeout due
to receiver cwnd dropping to zero after sending ACKs.
Merge internal change: 51854636
Refactored and replaced SendStreamAndNotifyWhenAck() to work with
SendvStreamData().
Merge internal change: 51848330
Remove unused client2 scoped_ptrs from end_to_end_tests
Merge internal change: 51835589
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23691073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass HasRetransmittableData to the congestion manager and the send
algorithm. This allows tcp_cubic_sender to not count ACK-only packets
against the congestion window.
Merge internal change: 51829697
If a previously zombie'd QUIC stream is closed and the headers have been
decompressed, remove that entry from the zombie stream map.
Merge internal change: 51697989
Change the value used to set the sequence number with to both correctly
calculate the widest packet spread currently outstanding and fix a
DCHECK failure in EndToEnd's Uber test when packets were transmitted
sufficiently out of order that the packet being sent was less than the
last packet the peer was awaiting.
Merge internal change: 51644967
Fix a bug where frames are queued and not enough room for the next
stream frame is available, but we attempt to create a STREAM frame
anyway in ConsumeData.
Merge internal change: 51604946
Changed Delayed Ack Timer to go off before the sender's retransmission
timer goes off.
Merge internal change: 51594956
Using the priorities sent by the client, including bounds checking,
and bumping the priority of initial writes to avoid the HOL header
blocking issue.
Merge internal change: 51586426
Fix memory leak uncovered by https://codereview.chromium.org/23587004
Merge internal change: 51569066
Added logging of QUIC version negotiated.
Export number of QUIC sessions and streams for each QUIC version.
Merge internal change: 51540178
A refactor of QuicFdWrapper's writev to pass the iovec all the way to
QuicConnection, allowing better packet packing.
Merge internal change: 51530908
Enabled priorities in chrome quic streams.
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23597045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, conservatively assume that non-empty NRPT or unknown DnsConfig could mean
DirectAccess is used, and disable IPv6 probing in that case.
BUG=259792
Review URL: https://chromiumcodereview.appspot.com/23522036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes memory leaks in UploadFileElementReader and UploadDataStream tests.
BUG=290897
R=rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23872030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In the code added in crrev.com/223192 the buffer passed to write is not
initialized which causes valgrind warnings.
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/23587022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the test was trying to read/write from a NULL buffer
to get an error returned from read() and write(). That causes
memcheck warnings. Rewrote the tests to try writing into
read-only file descriptor and vice versa. Also removed DCHECK()
that prevented E_INVALID_HANDLE from even being returned - it
seems wrong given that FileStream() may accept file descriptors
from outside.
BUG=178424
R=akalin@chromium.org
Review URL: https://codereview.chromium.org/23549030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, URLFetchers closed the file in parallel with calling the
delegate, which causes races on whether or not the file has been closed.
Implementing this change required the addition of a Close() function to
the API of FileStream.
BUG=265840
Review URL: https://chromiumcodereview.appspot.com/23500006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems to have been added in order to debug a trybot failure for
http://crrev.com/102560 , but was not removed before landing the cl.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/23480059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
worldview to an "offsets point between characters" worldview.
This more closely aligns with how the omnibox autocomplete code (which is what
this was originally written for) expects things to behave.
Direct fallout from this change:
* An input offset of 0 will always map to an output offset of 0.
* An input offset of (length of string) will always map to the length of the
output string, instead of npos.
* It's possible for multiple unique input offsets to map to a single non-npos
output offset, if they e.g. point to the start and end of a collapsed
sequence.
* Input offsets pointing into the middle of a completely-removed sequence may
not be set to npos if they fall on the boundaries of a subsequence processed
by the transformer. For example, when running FormatUrlWithOffsets() on
"http://user:pass@domain.com/" and directing it to omit both the scheme and
username/password, an input offset of "7" that points in between the scheme
and the username/password will be transformed to an output offset of 0
instead of npos.
Indirect fallout:
* A caller like SearchProvider::NavigationToMatch() will now mark certain
matches as "allowed to be default" that it didn't before. Specifically, if
the user's input string ends at the same point as the desired
|fill_into_edit|, the autocomplete offset will be calculated as (length of
string) instead of npos, and thus the match will be thought of as "inlinable"
and thus "allowed to be default".
BUG=284781
TEST=none
R=msw@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/23619016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=285016
TEST=YouTube playback works for videos that are available in the VP9 format.
Review URL: https://chromiumcodereview.appspot.com/23463020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the main message loop for async operations in FileStream tests. Previously they were scheduled in base::WorkerPool.
Removes dependency on deprecated code and plugs memory leaks.
BUG=248513
R=rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23872004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now a reserved name is not allowed on any component of the path.
BUG=none
test=net_unittests
R=asanka@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23464037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221882 0039d316-1c4b-4281-b951-d872f2087c98
|