| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two motivations:
(1) There are currently clients in src/crypto that need the same logic.
(2) There is soon to be a client in src/chrome/common that needs the 64-bit version of this logic, which is currently inlined in a src/crypto implementation file.
BUG=103480
TEST=compiles
Review URL: http://codereview.chromium.org/8949026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove two no-op (i.e. always true) boolean functions, each of which was
only used once. Having a DomainState at all is equivalent to having a
DomainState and ShouldCertificateErrorsBeFatal /
ShouldMixedScriptingBeBlocked.
The reason to simplify TransportSecurityState is that agl and I want to
re-factor this class because it is getting too confusing. Doing some
straightforward clean-up now will help accelerate the real re-factoring.
Review URL: http://codereview.chromium.org/9019034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to download and apply a delta update to our current CRLSet and
then save the result to disk.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/8958006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=groby
Review URL: http://codereview.chromium.org/9035013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9023014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8741007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=102949
Review URL: http://codereview.chromium.org/9020021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Initialize test from raw time value to work around inability to parse dates past 2038 on 32-bit linux.)
BUG=107047
TEST=net_unittests, unit_tests
Review URL: http://codereview.chromium.org/9016002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=100358,100392,100393,101544,101545,101778,102025,102052,102053,102320,
102347,102394
BUG=none
TEST=none
R=gbillock
Review URL: http://codereview.chromium.org/9006026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=102949
Review URL: http://codereview.chromium.org/9021006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ajwong
Review URL: http://codereview.chromium.org/8956019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
types.
Specifically, ensure that certificates whose subjects or issuers contain values
encoded as BMPStrings, T61Strings, or UniversalStrings can be properly decoded
and normalized to UTF-8.
BUG=108033
TEST=net_unittests:X509TypesTest.*
Review URL: http://codereview.chromium.org/9006041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows to remove the dependency from BrowsingDataRemover to CookieMonster.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9004016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=101462, 101458, 101437, 101471, 101467
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9006023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=107047
TEST=net_unittests, unit_tests
Review URL: http://codereview.chromium.org/8890073
TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/8965065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=6462,16392,16996,17268,100987,101018,102401,102417,102476,102484,102513
102546,102552,102567,102617,102674,102677,102678,102679,102681,102685,
102714,102750,102751,102781
BUG=none
TEST=none
R=groby
Review URL: http://codereview.chromium.org/9005015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=6462,16392,16996,17268,100987,101018,102401,102417,102476,102484,102513
102546,102552,102567,102617,102674,102677,102678,102679,102681,102685,
102714,102750,102751,102781
BUG=none
TEST=none
R=groby
Review URL: http://codereview.chromium.org/9005015
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8965062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=6462,16392,16996,17268,100987,101018,102401,102417,102476,102484,102513
102546,102552,102567,102617,102674,102677,102678,102679,102681,102685,
102714,102750,102751,102781
BUG=none
TEST=none
R=groby
Review URL: http://codereview.chromium.org/9005015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107047
TEST=net_unittests, unit_tests
Review URL: http://codereview.chromium.org/8890073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID= 101435, 101591, 101592, 101512, 100534
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8965046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make HttpPipelinedConnection its own NetLog::Source
- Report when pipelines are constructed and deleted
- Report pipelining feedback
- Add a HTTP Pipelining tab with status, active pipelines, and known hosts.
BUG=None
TEST=chrome://net-internals
Review URL: http://codereview.chromium.org/8947012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=106841
Review URL: http://codereview.chromium.org/8970023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=groby
Review URL: http://codereview.chromium.org/8989003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object directly."
This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch.
Also makes the static type checking a bit more strict when assigning into a Callback<>.
BUG=none
TEST=new unittests
Review URL: http://codereview.chromium.org/8915024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're now using Omaha to distribute the CRLSets, we don't need these values.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/8992019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
URL_REQUEST they were attached to. With source_dependencies
now being clickable, this makes navigation between
URLRequests on the same socket a little easier.
BUG=107000
Review URL: http://codereview.chromium.org/8930014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108009
TBR=mattm
Review URL: http://codereview.chromium.org/8988004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert due to compile breakage on ChromeOS.
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8990002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8984007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::Bind: Remove even moar OldCompletionCallback.
BUG=none
TEST=none
R=dpapad
Review URL: http://codereview.chromium.org/8947024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/8963019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=dpapad
Review URL: http://codereview.chromium.org/8947024
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8966031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=dpapad
Review URL: http://codereview.chromium.org/8947024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=wtc
Review URL: http://codereview.chromium.org/8971005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"Small" means less than 1024 bits.
BUG=102949
TEST=net_unittests, X509CertificateTest.*
Review URL: http://codereview.chromium.org/8568040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Now that Chrome 16 is out the door, the blacklist erosion process is resuming.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8898036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the following:-
1. Get rid of the dummy AtlModule registration in the chrome frame net test suite. This is no longer needed
as there is an Atlmodule instance instantiated by the content code.
2. The TestSuite and NetTestSuite classes now provide special protected constructors which allow
test instances to control whether an AtExitManager instance is created for the duration of the
test. The ChromeFrame net test suite reuses the AtExitManager instance created in BrowserMain.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435
BUG=105435
TEST=ChromeFrame net tests should now run on the builders.
Review URL: http://codereview.chromium.org/8907054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object directly.
This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch.
BUG=none
TEST=new unittests
Review URL: http://codereview.chromium.org/8738001
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8914022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch.
BUG=none
TEST=new unittests
Review URL: http://codereview.chromium.org/8738001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When encountering certificates signed with md5, interstitial the page with an error about md5 being a weak signing algorithm.
This excludes checking the signatures of root certificates (trust anchors), as their self-signed signatures are not relevant to the security of the chain.
R=wtc@chromium.org
BUG=101123
Review URL: http://codereview.chromium.org/8374020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is primarily a rename, with the exception that the initialization of ProxyResolver (i.e. the javascript runtime environment for the PAC script) is no longer done inside of ProxyScriptDecider.
The motivation for doing this is to make it possible to poll our automatic proxy settings (PAC URLs or WPAD) in the background, _without_ needing to feed the scripts into the javascript parser for validation.
There likely won't be any user-visible consequence of this change, however the new mechanism is weaker than the original -- it is possible for the PAC selection to now choose a PAC script which fails to parse as javascript, even though there was a later fallback choice which does parse. This should be rare though (the bad response would need to contain the substring "FindProxyForURL").
BUG=TODO (bugtracker down right now)
Review URL: http://codereview.chromium.org/8896019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
never allowed to use these ports anyways, this wasn't a
security issue, but just doesn't seem like a good idea.
BUG=93326
Review URL: http://codereview.chromium.org/8898008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.
BUG=87634
R=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/8929002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fetching the default nickname.
BUG=none
TEST=imported user certs successfully.
Review URL: http://codereview.chromium.org/8919020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114150 0039d316-1c4b-4281-b951-d872f2087c98
|