| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Test breakages caused by this change have been fixed here or in other changelists.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/5024003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds a little more infrastructure to assist in openssl error handling.
BUG=None
TEST=base_unittests RSA* and Sign*
Review URL: http://codereview.chromium.org/5105003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(in particular defined by macros) to wide string constants.
Convert existing locally-defined stringizing to use the shared macros.
Unit tests for the shared macros.
This also fixes a minor bug in ceee_module_util.cc where I
accidentally quoted a string constant I only meant to convert to wide
(this caused no bug, but was unintended, so the change in semantics
in that file in the current change is intentional).
BUG=none
TEST=automated tests
Review URL: http://codereview.chromium.org/5103001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(landing on behalf of kristianm)
Suppress Android warnings
Android generates warnings for comparing signed and unsigned numbers.
The ones in this CL should be safe.
BUG=62949
TEST=None
Review URL: http://codereview.chromium.org/5035002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the base/crypto methods to call EnsureOpenSSLInit.
Also factors out the SSL_CTX and X509_STORE to be more closely associated with their consumers (ssl socket and X509Certificate resp.) rather than process wide globals.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63258
TEST=net_unittests --gtest_filter=CookieMonsterTest.ForceSessionOnly
Review URL: http://codereview.chromium.org/4967004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There's nothing OpenSSL specific about this implementation, other than this is the only platform that does not already supply an implementation of this method.
BUG=60719
TEST=net_unittests --gtest_filter=X509CertificateCertificateNameVerifyTest.*
Review URL: http://codereview.chromium.org/4184004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-joinable threads.
Fix all known instances or explicitly allow them. Usually the fix involves switching from Default traits to Lazy traits.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/4635012
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/4980001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix all known instances or explicitly allow them. Usually the fix involves switching from Default traits to Lazy traits.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/4635012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in ascending order.
R=rvargas
BUG=41267
TEST=none
Review URL: http://codereview.chromium.org/4871001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Based on private communication with davidben.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Split out of http://codereview.chromium.org/4691003/
BUG=None
TEST=builds...
Review URL: http://codereview.chromium.org/4696004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
use. Restricting SSLClientSocketWin is handled by the existing Windows system policy (which deals in algorithms, not cipher suites).
R=wtc
BUG=58831
TEST=SSLClientSocketTest.CipherSuiteDisables
Review URL: http://codereview.chromium.org/3845005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I forgot to init a member in r65677.
BUG=none
TEST=valgrind
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In IsAllowedBadCert, the pointer compare doesn't always work. Creating a
certificate by X509Certificate::CreateFromBytes and putting it in the
allowed bad list doesn't match the same certificate from a server.
InvalidateSessionIfBadCertificate: I'm sure that there's history here
that I don't know, so please review carefully. In order to test
resumption against a server with a test certificate we need to avoid
destroying the session.
ClearSessionCache, AdoptSocket: only for testing
BUG=none
TEST=none
http://codereview.chromium.org/4558004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59630
TEST=none
Review URL: http://codereview.chromium.org/4119020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Reland of r65385, reverted in r65387. r65402 and r65421 should have
fixed the issues.)
(details of the contents given privately.)
BUG=none
TEST=net_unittests
http://codereview.chromium.org/4598003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not clear what's happening because I don't have a Windows machine
and this was all done via try server runs:
I think the problem is that the new False Start blacklist is larger than
fread on Windows will read in one lump. That was causing the processing
to fail on Windows.
However, the simple fix of calling fread until its done didn't work
because it never reads enough bytes. What's happening is that ftell is
returning the true size of the file, but fread was converting \r\n to \n
so the reported number of bytes read was too small.
Why that wasn't happening before I'm not sure. I suspect that the file
on disk on the Windows builders is \n and it's patch on the tryserver
which is writing the file out with the extra \r bytes.
Either way, this hopefully makes everything work.
BUG=none
TEST=net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows fails to build if any strings are > 64K long. Since the next
blacklist update breaks this limit, we have to switch the blacklist to
being a char array.
BUG=none
TEST=net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r65385
VC: "string exceeds 65535 bytes in length"
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(details given privately.)
BUG=none
TEST=net_unittests
http://codereview.chromium.org/4598003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Needed for the next list update.)
BUG=none
TEST=net_unittests
http://codereview.chromium.org/4599002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Requested by Ian Gallagher.
BUG=none
TEST=net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
destruction, so that
it doesn't crash if the SSLClientSocket is leaked.
BUG=chromium-os:8179
TEST=None
Linux browser tests are consistently failing. Example stack:
SSLUITest.TestDisplaysInsecureContentTwoTabs:
[11279:11279:1107/212311:929558354690:WARNING:chrome/installer/util/master_preferences.cc(56)] Failed to read master prefs file.
[11279:11279:1107/212311:929558354814:ERROR:chrome/installer/util/master_preferences.cc(137)] Failed to parse /mnt/data/build/slave/Linux_Builder__Views_dbg_/build/src/out/Debug/master_preferences
[11279:11279:1107/212311:929558672237:WARNING:views/widget/widget_gtk.cc(293)] compositing not supported; allowing anyway
LEAK: 4 WebCoreNode
[11279:11291:1107/212312:929559555051:FATAL:base/message_loop.cc(200)] Check failed: this == current().
Backtrace:
base::debug::StackTrace::StackTrace() [0x124edb6]
logging::LogMessage::~LogMessage() [0x126455b]
MessageLoop::RemoveDestructionObserver() [0x126695d]
net::CertVerifier::Request::Cancel() [0x1944eb5]
net::CertVerifier::Request::~Request() [0x194505a]
base::RefCountedThreadSafe<>::DeleteInternal() [0x194544c]
base::DefaultRefCountedThreadSafeTraits<>::Destruct() [0x1945420]
base::RefCountedThreadSafe<>::Release() [0x19452ec]
RunnableMethodTraits<>::ReleaseCallee() [0x1945628]
RunnableMethod<>::ReleaseCallee() [0x194559c]
RunnableMethod<>::~RunnableMethod() [0x19454ce]
(anonymous namespace)::WorkerThread::ThreadMain() [0x12c904f]
ThreadFunc() [0x12860bf]
start_thread [0x2afc1af6d9ca]
0x2afc1d5156fd
[11279:11291:1107/212312:929559555051:FATAL:base/message_loop.cc(200)] Check failed: this == current().
Backtrace:
base::debug::StackTrace::StackTrace() [0x124edb6]
logging::LogMessage::~LogMessage() [0x126455b]
MessageLoop::RemoveDestructionObserver() [0x126695d]
net::CertVerifier::Request::Cancel() [0x1944eb5]
net::CertVerifier::Request::~Request() [0x194505a]
base::RefCountedThreadSafe<>::DeleteInternal() [0x194544c]
base::DefaultRefCountedThreadSafeTraits<>::Destruct() [0x1945420]
base::RefCountedThreadSafe<>::Release() [0x19452ec]
RunnableMethodTraits<>::ReleaseCallee() [0x1945628]
RunnableMethod<>::ReleaseCallee() [0x194559c]
RunnableMethod<>::~RunnableMethod() [0x19454ce]
(anonymous namespace)::WorkerThread::ThreadMain() [0x12c904f]
ThreadFunc() [0x12860bf]
start_thread [0x2afc1af6d9ca]
0x2afc1d5156fd
Killed (timed out).
Review URL: http://codereview.chromium.org/4299001
TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/4669003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it doesn't crash if the SSLClientSocket is leaked.
BUG=chromium-os:8179
TEST=None
Review URL: http://codereview.chromium.org/4299001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r62209 we added code to detect ESET and NetNanny and to give users
instructions for disabling their HTTPS scanning. This was because these
products intercept Chrome's HTTPS connections and break because of False
Start.
NetNanny has been responsive to the issue and is rolling out a fix. In
the mean time, we silently disable False Start when NetNanny is detected
to give them time to update their users etc.
BUG=59798
TEST=Navigate to https://www.paypal.com on Windows with NetNanny installed.
http://codereview.chromium.org/4449003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
X509Certificate::Verify, so that we call the Windows
CertGetCertificateChain function only once in the
common case. This allows us to do EV verification,
with little overhead, even if the caller doesn't ask
for it. This requires adding new methods to the
EVRootCAMetadata class.
R=rvargas
BUG=41267
TEST=none
Review URL: http://codereview.chromium.org/4124012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
http://codereview.chromium.org/4448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960
Review URL: http://codereview.chromium.org/4222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
header (RFC 5987).
It's not generic, but is only used for 'filename' param.
The CL is originally by James Simonsen I reviewed at http://codereview.chromium.org/4254001/show
I added a check for ASCIIness for RFC 5987 extended header and a few tests to NetUti*.GetFileNameFromCD
(net_unittests) and I*.ConvertCo*Norma* (base_unittests). I also replaced '\uxxxx' notation with
the corresponding UTF-8 byte sequence because Visual Studio does not understand it yet.
BUG=57830
TEST="net_unittests --gtest_filter=NetU*.GetFil*", "base_unittests --gtest_filter=I*.Conver*Norm*" and tests
at http://greenbytes.de/tech/tc2231/
Original CL / Review: By James Simonsen; at http://codereview.chromium.org/4254001/show
Review URL: http://codereview.chromium.org/4435001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL causes Snap Start to only trigger if the certificate
verification has completed by the time we are ready to send out the
handshake message.
It also adds a couple of NetLog entries and histograms around the Snap
Start code.
BUG=none
TEST=none
http://codereview.chromium.org/4408001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Review URL: http://codereview.chromium.org/4222005
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/4431001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=60211
Review URL: http://codereview.chromium.org/4222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix conflicts like:
2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope
2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare'
Reported-by: Jeff Timanus <twiz@google.com>
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4366001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=cert manager no longer has a "people" tab, any certs that were there are now in "other" tab.
Review URL: http://codereview.chromium.org/4310004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check for TLS 1.1 and TLS 1.2 (not yet supported)
version numbers to be future-proof.
Avoid a null pointer dereference when SSL client
authentication is used with SSL 2.0. This will
be removed when we remove SSL 2.0 support.
Define the SSL_CONNECTION_VERSION_xxx enum constants
separately so we can assert their values are in range
at compile time.
R=eroman
BUG=53659
TEST=none
Review URL: http://codereview.chromium.org/4211006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2826041
I then did quite a bit of manual editing to fix style issues.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4291001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61488
TEST=d:\mediatests\still.webp
Review URL: http://codereview.chromium.org/4232003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
operations return an access is denied error.
This is in preparation for adding new error text suggesting
a firewall may be causing the problem, which would be a little
embarrassing to do when an SSPI logon fails, or when trying to
open a local file one doesn't have permissions to.
BUG=57108
TEST=Install firewall, block Chrome, verify that you get
ERR_NETWORK_ACCESS_DENIED. Unblock it, fail an SSPI logon
(Or any other event that should generate an ERR_ACCESS_DENIED)
and verify that you still get an ERR_ACCESS_DENIED.
Review URL: http://codereview.chromium.org/3976004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=19991
BUG=chromium-os:7946
TEST=delete button should be disabled on built-in certs, and enabled on user-imported certs
Review URL: http://codereview.chromium.org/4130002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None (trybots).
Review URL: http://codereview.chromium.org/4196001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60015
TEST=net_unittests CookieMonsterTest.* (flakiness was rare enough that the only real test will be committing and seeing if the problem is fixed).
Review URL: http://codereview.chromium.org/4131001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A/B tests suggest that large numbers of parallel
resolutions may cause the DNS failure rate
(re: ratio of "host not found" to "found") to
rise. To stay safely away from that threshold,
this change lowers the maximum parallel resolutions
to 8, and restricts the speculative resolutions
to 3.
We are also running A/B tests which will look at the
impact of modulating either of these values.
BUG=3041
r=eroman
Review URL: http://codereview.chromium.org/4111004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60149
TEST=None
Review URL: http://codereview.chromium.org/4216001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have SSL_PeerCertificateChain, we can remove uses of
CERT_GetCertChainFromCert. The latter would return a constructed
certificate chain rather than the actual chain returned from the
server. Thus we can also remove the Comodo cert workaround.
BUG=none
TEST=net_unittests
http://codereview.chromium.org/4185001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3693001
TBR=agayev@chromium.org
Review URL: http://codereview.chromium.org/4208002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3693001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor SSLClientSocketNSS::GetSSLInfo -- the code that sets
ssl_info->connection_status is moved to a new
UpdateConnectionStatus method, and CheckSecureRenegotiation
is subsumed by UpdateConnectionStatus.
R=agl,finnur
BUG=53659
TEST=none
Review URL: http://codereview.chromium.org/4198003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=60672
TEST=Navigate to https://customers.internap.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64071 0039d316-1c4b-4281-b951-d872f2087c98
|