| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When viewing a local text file with spaces in filename, it is still urlencoded. Filename should be displayed with spaces, not with urlencoding. It would be more user-friendly.
Since net::FormatURL is already implemented, using it would be great. But it doesn't escape SPACES, just NORMAL, it doesn't even escape unicode. I plumbed out a unescapeurl that could be used whether we allow conversion of spaces or not.
BUG=8775 (http://crbug.com/8775)
TEST=Tested whether the input is escaped in the navigational context and ran the net tests
New Review: http://codereview.chromium.org/118059
Review URL: http://codereview.chromium.org/56053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
BUG=http://crbug.com/12190
TEST=ForceTLSStateTest.BogusHeaders, ForceTLSStateTest.ValidHeaders
Review URL: http://codereview.chromium.org/118049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All versions have implemented valid_expiry(), so we can use
common code for X509Certificate::HasExpired.
R=wtc
Review URL: http://codereview.chromium.org/118069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the code now does range request without any caching
the code path for passing file handle is not used any more.
Changes:
1. Remove response_data_file in webkit_glue::ResourceResponseHead
2. Remove response_data_file in net::ResourceInfo
3. Remove code that passes file handle using IPC
4. Remove code that passes file hadnle from network layer to ResourceDispatcherHost
5. Remove MediaResourceHandler
6. Remove code in disk_cache that expose the file handle
7. Remove ChromeURLRequestContext::CreateOffTheRecordForMedia() so no more OTR request context for media, in OTR mode simply memory cache is used
8. Reset cache size for media cache to default
BUG=12249
BUG=12256
Review URL: http://codereview.chromium.org/113931
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added code path from WebKit to net::mimt_util to query
supported mime-types for media files.
BUG=12777
Review URL: http://codereview.chromium.org/114060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
Review URL: http://codereview.chromium.org/115870
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10911
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/115700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The threads in our thread pool terminate after we have called
PR_Cleanup. Unless we detach them from NSPR, if we use
CertVerifier, net_unittests dies with segfault on shutdown.
BUG=10911
TEST=net_unittests passes with code that uses CertVerifier.
Review URL: http://codereview.chromium.org/115856
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use CERT_PKIXVerifyCert() with CRL to verify certificate.
With OCSP, CERT_PKIXVerifyCert() failed with
SEC_ERROR_INVALID_ARGS.
Increase stack size. It was not enough size if we use
CERT_PKIXVerifyCert() on some sites. For example,
https://www.google.com/ works, but https://bugs.webkit.org/
or https://www.thawte.com/ would die by SIGSEGV. This is
because pkix_List_Destroy() routine destroys PKIX_List
recursively, so if there are some long PKIX_Lists, it
consumes stack a lot and dies by stack overflow.
Note that X509Certificate::Verify isn't used in SSLClientSocketNSS yet.
BUG=10911
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/113578
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in some distributions.
BUG=11380
TEST=Start chrome with empty resolv.conf, fix resolv.conf; chrome should
be able to resolve sites.
Review URL: http://codereview.chromium.org/113904
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit name for this piece of data.
R=jackson
BUG=None
TEST=No behavior change
Review URL: http://codereview.chromium.org/115743
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the first step towards writing tests for FtpNetworkTransaction.
http://crbug.com/12409
Review URL: http://codereview.chromium.org/115646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Bookmark Manager
- Edit Bookmark dialog opened by Bookmark Manager
- Edit Bookmark dialog opened by the star on the left of the address bar
Introduces new function, net::FormatUrl(), which has the following
parameters in addition to gfx::GetCleanStringFromUrl().
- bool omit_username_password
- bool unescape
and moves gfx::GetClienStringFromUrl() to net:: namespace, and removed
the last two parameters.
BUG=3991
Checked in for tkent
Original review = http://codereview.chromium.org/115346
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
after."
Review URL: http://codereview.chromium.org/113760
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113759
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix TCPClientSocketLibevent::DidCompleteConnect(). Should call Connect(write_callback_).
TBR=wtc
Review URL: http://codereview.chromium.org/115697
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
applies to Windows. I forgot that this file is used by all
platforms.
R=eroman
http://crbug.com/5234
TEST=N/A
Review URL: http://codereview.chromium.org/113729
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Revert "Disable the flaky fullduplex tests."
Review URL: http://codereview.chromium.org/113749
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc
Review URL: http://codereview.chromium.org/115671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main thing is not to share the same MessageLoopForIO::FileDescriptorWatcher object for both reads and writes.
Fixed tcp_client_socket_unittest.cc's full duplex test. In doing so, I also had to fix up some other stuff.
(1) Put everything in the net::(anonymous) namespace.
(2) Keep calling Write() until ERR_IO_PENDING happens.
(3) Make the server socket pause its reads so that the buffers (both client and server side) eventually fill up.
(4) Discovered that after the first Read(), the server socket will close. Further Write() calls will lead to a TCP RST, which breaks the FullDuplex_WriteFirst test, since it wants to do a Write() at the end. Fix this by changing DidRead() not to automatically close the server socket. Added a CloseServerSocket() member function to make this explicit. Fixed up the Read() tests. Made them more exact too.
BUG=http://www.crbug.com/11888
TEST=Go to gmail, compose a message, attach a large file (say 1MB or so). It shouldn't crash.
Review URL: http://codereview.chromium.org/115504
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of "www.foo.com" it will say "www.foo.com:80". We need to include the port number since otherwise it can be ambiguous what the actual target server is.
This change also introduces utility function "GetHostAnd[Optional]Port()" to help with forming <host> [":" <port>] strings.
BUG=12073
Review URL: http://codereview.chromium.org/112041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to ERR_CERT_AUTHORITY_INVALID.
R=ukai
BUG=12359
TEST=Visit https://www.grounation.org/. The SSL error page
should say "The site's security certificate is not trusted!"
rather than "Invalid Server Certificate".
Review URL: http://codereview.chromium.org/115597
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12052
Review URL: http://codereview.chromium.org/113642
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
escaping.BUG=http://crbug.com/11431TEST=base_unittests.exe --gtest_filter=StringEscapeTest.Json*
Review URL: http://codereview.chromium.org/113606
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of turning on strict HTTPS error processing for every site, we now track which sites have opted in. Our implementation is still experimental and hidden behing the command line switch --force-https.
R=darin
TEST=No tests yet because this is just an experiment.
Review URL: http://codereview.chromium.org/113503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Nor do we have support for alternate file formats; nor do we have a default icon.
BUG=http://crbug.com/8631
Review URL: http://codereview.chromium.org/113571
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=wtc
Review URL: http://codereview.chromium.org/113535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Neither the nss or Windows GetSSLInfo methods check this
condition, which can be called in error situations.
Review URL: http://codereview.chromium.org/113559
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Document that GetHostAndPort returns an IPv6 literal
address with square brackets.
Document that the host parameter to the ProxyServer
constructor takes an IPv6 literal address with square
brackets.
R=eroman
BUG=N/A
TEST=N/A
Review URL: http://codereview.chromium.org/113494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and ClientSocketHandle."""
Revert "Fix a memory leak in client_socket_pool_unittest.cc."
Guess I still fail. kasperl pointed out that this managed to break layout tests and some reliability tests too.
Review URL: http://codereview.chromium.org/113517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Need to run the MessageLoop one time to run a task to delete the canceled ConnectingSocket.
Also reorder the test to help hide the minor race condition here.
Review URL: http://codereview.chromium.org/115455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketHandle.""
This reverts commit c235c719f964cc8f7f9343177ae6d5af724be6c0.
Fixes a use of deleted memory by making a copy instead of keeping a reference to the deleted memory.
Review URL: http://codereview.chromium.org/113512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketHandle."
Broke net_unittests on windows.
Review URL: http://codereview.chromium.org/113510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Provide a new api in ClientSocketPool and ClientSocketHandle for clients (notably HttpNetworkTransaction) to request connected sockets, rather than having to allocate and Connect() sockets themselves. Add a bunch of tests for it. Have not begun switching clients over to using this.
Review URL: http://codereview.chromium.org/99143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
layout test.
Remove a NOTIMPLEMENTED that was breaking layout tests.
TBR=estade
Review URL: http://codereview.chromium.org/113500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
"image/x-ico" entry whereas the rest of the world uses "image/x-icon".
TBR=estade
Review URL: http://codereview.chromium.org/115440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10049
Review URL: http://codereview.chromium.org/113168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that IP addresses in certificate names are encoded
in binary form (octet strings -- 4 octets for IPv4 and
16 octets for IPv6).
R=eroman
http://crbug.com/12005
TEST=covered by current tests
Review URL: http://codereview.chromium.org/113438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behavior is ON by default. Using AI_ADDRCONFIG can
actually be harmful, as it causes getaddrinfo to fail
to resolve "localhost" when the computer is not
connected to a network.
R=eroman
http://crbug.com/5234
TEST=See bug 5234 for instructions
Review URL: http://codereview.chromium.org/115424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
connect will ever return 0, and therefore we don't know if the
event object will be signaled in that case.
R=rvargas
http://crbug.com/9258
TEST=N/A
Review URL: http://codereview.chromium.org/113474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10502
Review URL: http://codereview.chromium.org/87047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also changed the name of all the SDCH histograms so that
there would be no confusion about the data.
I also added one new problem code, but that recordation
doesn't have any semantic impact. I added it to help
make it easier to diagnose dictionary specification
errors in SDCH.
bug=12012
R=wtc
Review URL: http://codereview.chromium.org/115377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Modify CookieMonster to support overriding the "cookieable schemes".
Review URL: http://codereview.chromium.org/115204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now wait with a zero timeout. If the wait times out,
we take the same code path as WSAEWOULDBLOCK/WSA_IO_PENDING.
R=rvargas
http://crbug.com/9258
TEST=Covered by existing unit tests
Review URL: http://codereview.chromium.org/113371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
certificate errors, do not map them to our (server)
certificate errors because the errors are referring to the
(missing) client certificate. If we incorrectly handle
them as server certificate errors, we will crash because
we can't get the server certificate from Schannel when the
handshake fails.
Fumitoshi Ukai of Google tracked down the bug and proposed
an alternative fix.
R=rvargas,ukai
BUG=http://crbug.com/11646
TEST=Visit https://www.cdep.ro/. Chromium should not crash.
Review URL: http://codereview.chromium.org/113375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unregister the sdch_dictionary_fetcher so that it destroys any pending
URLFetcher instances when we are nearing shutdown time. Dictionaries
are only *potentially* useful (and not needed) for future SDCH
fetches, so abandoning any pending items is safe and harmless.
b=9669
r=wtc
Review URL: http://codereview.chromium.org/113235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Enable IDNToUnicodeFast test under Valgrind.
BUG=9172
Review URL: http://codereview.chromium.org/113370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that part of the socket can outlive the socket destruction.
This is the second part of removing infinite waits from
the IO loop.
BUG=9258
TEST=none
Review URL: http://codereview.chromium.org/113291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15895 0039d316-1c4b-4281-b951-d872f2087c98
|