| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=58437
TEST=go to <https://2029.globalsign.com> and verify the EV status
Unit Test (This test has been DISABLED because it fails
when "./netunittests" is run, though it passes individually.):
"net_unittests --gtest_filter=X509CertificateTest.GlobalSignR3EVTest"
Review URL: http://codereview.chromium.org/7037031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79694
TEST=Download a torrent file from http://ca.isohunt.com. It should complete.
Review URL: http://codereview.chromium.org/6881106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tlslite does some autodetection which when m2crypto is installed and importable is more strict when parsing certificate files. This CL makes our certificate files acceptable by both the more strict and more lenient versions of code used by tlslite.
Swap the certificate and private key in [ok|expired]_cert.pem, so that
s.startswith() will return true for OpenSSL_RSAKey. tlslite.X509 uses
s.find() to locate the BEGIN CERTIFICATE, so it should be unaffected.
For more info see http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/903f65ad685da9b2#
Review URL: http://codereview.chromium.org/6814045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix detection of KOI8-R and possibly other encodings
- fix parsing Russian month names
When detecting the listing encoding, we need to not only
check whether the data can be converted using given encoding,
but also whether the result can be parsed as a valid directory listing.
Also, we only need to compare the first three characters of the
abbreviated month name, because that's how they're abbreviated
in FTP directory listings.
Finally, the Russian directory listings have swapped the "month" and "day of month" columns.
BUG=65917
Review URL: http://codereview.chromium.org/6718043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have several places where a need to distinguish `real' root CAs from
user-added root CAs will be useful:
1) Monoscope wants to inspect correctly signed, but unknown certificates, but
doesn't want to deal with proxy MITM certificates.
2) HSTS is likely to add a method for pinning to a certificate, but we don't
want to break every proxy MITM with it.
This change adds several lists of known, `real' roots. These lists present an
ongoing maintainance issue. However, in the event that the lists are incomplete
in the future, we fail open. This is because roots not in these lists are
treated as user-added and user-added roots have more authority than `real'
roots.
In some sense, this is a problem because it might be a security issue that new
roots are given too much authority. On the other hand, we're not breaking
things when we're behind on updating the lists so the maintainance issue isn't
too pressing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6793041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(No code changes.)
nist.der contains a certificate issued directly from a root. This will be used
in a future unittest however, committing it now allows the try servers to
process the unittest before it's landed.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detection of KOI8-R and possibly other encodings- fix parsing Russian month namesWhen detecting the listing encoding, we need to not onlycheck whether the data can be converted using given encoding,but also whether the result can be parsed as a valid directory listing.Also, we only need to compare the first three characters of theabbreviated month name, because that's how they're abbreviatedin FTP directory listings.Finally, the Russian directory listings have swapped the "month" and "day of month" columns.BUG=65917Review URL: http://codereview.chromium.org/6718043
TBR=phajdan.jr@chromium.org
Failures (Windows only, both Vista and XP):
FtpDirectoryListingBufferTest.Parse:
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".."
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: ..
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[25]: dir-listing-ls-25
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".message"
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[25]: dir-listing-ls-25
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".."
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: ..
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[26]: dir-listing-ls-26
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".message"
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[26]: dir-listing-ls-26
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".."
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: ..
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[27]: dir-listing-ls-27
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".message"
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[27]: dir-listing-ls-27
FtpDirectoryListingParserLsTest.Good:
c:\b\build\slave\cr-win-rel\build\src\net/ftp/ftp_directory_listing_parser_unittest.h(47): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(test_case.filename)
Which is: L"test"
Google Test trace:
.\ftp\ftp_directory_listing_parser_ls_unittest.cc(109): Test[21]: -rwxrwxr-x 1 ftp ftp 123 23 май 2011 test
c:\b\build\slave\cr-win-rel\build\src\net/ftp/ftp_directory_listing_parser_unittest.h(47): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(test_case.filename)
Which is: L"dir"
Google Test trace:
.\ftp\ftp_directory_listing_parser_ls_unittest.cc(109): Test[22]: drwxrwxr-x 1 ftp ftp 4096 19 окт 2011 dir
Review URL: http://codereview.chromium.org/6802006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix detection of KOI8-R and possibly other encodings
- fix parsing Russian month names
When detecting the listing encoding, we need to not only
check whether the data can be converted using given encoding,
but also whether the result can be parsed as a valid directory listing.
Also, we only need to compare the first three characters of the
abbreviated month name, because that's how they're abbreviated
in FTP directory listings.
Finally, the Russian directory listings have swapped the "month" and "day of month" columns.
BUG=65917
Review URL: http://codereview.chromium.org/6718043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
X509CertificateTest.EmptySubject unit test.
Original code review URL: http://codereview.chromium.org/6656015
R=rsleevi
BUG=63988
TEST=none
Review URL: http://codereview.chromium.org/6665019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
upcoming X509CertificateTest.InvalidKeyUsage unit test.
Original code review URL: http://codereview.chromium.org/6626033
TBR=rsleevi
BUG=70293
TEST=none
Review URL: http://codereview.chromium.org/6658007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
removed in r34047, as well as supporting code in testserver.py.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6591051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=62085
TEST=none
TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/6519028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some servers, for example smallftpd, add an empty line
at the end of the listing. We should not fail on those.
I think this bug was introduced in 2009 by http://codereview.chromium.org/449011
Now we have more test cases, and this change shouldn't introduce
new compatibility problems.
BUG=72060
TEST=net_unittests
Review URL: http://codereview.chromium.org/6515009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=69135
TEST=none
TBR=gavinp
Review URL: http://codereview.chromium.org/6300009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67797
TEST=net_unittests
Review URL: http://codereview.chromium.org/6096006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Test files used by SSLServerSocktNSS
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6065006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used for various tests in net_unittests, now that Windows can temporarily trust certificates for the duration of tests.
In addition, add unittests for net::TestRootCerts, which depend on the certs being tested not being trusted by the system beforehand.
BUG=8470, 5552
TEST=TestRootCertsTest.*
Review URL: http://codereview.chromium.org/5535006
TBR=rsleevi@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests in net_unittests, now that Windows can temporarily trust certificates for the duration of tests.
In addition, add unittests for net::TestRootCerts, which depend on the certs being tested not being trusted by the system beforehand.
BUG=8470, 5552
TEST=TestRootCertsTest.*
Review URL: http://codereview.chromium.org/5535006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some FTP servers send MLSD listings with no facts, just
the file names. This is a valid RFC-3659 listing, but
is useless for web browsers.
In theory we could check whether a server advertises
MLSD support in FEAT response, or use LIST when MLSD
only returns file names, but the extra complexity
is not worth it.
All servers supporting MLSD must also support LIST,
so this should not regress compatibility.
This change also removes the "HPRC" directory listing parser.
Actually, it was just MLSD listing with no facts.
BUG=65328, 65584
TEST=net_unittests, also see the bugs
Review URL: http://codereview.chromium.org/5669001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is wrong.
Instead of using ICU's first guessed encoding immediately,
we ask it for all possible encodings, try them in order,
and use the first one that works.
For some sites this still results in a gibberish being displayed,
but at least the links are clickable so the site navigation
is possible.
BUG=61073
TEST=see bug
Review URL: http://codereview.chromium.org/4967001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=38859
TEST=none
Review URL: http://codereview.chromium.org/5112002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the "ls -l" parser ignores lines with empty file names
instead of failing.
BUG=60065
TEST=net_unittests
Review URL: http://codereview.chromium.org/4182002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tools/valgrind/gtest_exclude
If I receive an LGTM, I'll land this patch (with updated .txt files of course)
during the weekend in the Europe afternoon to minimize possible damages.
Then I'll update all the docs accordingly
For the record,
I got the list of the files by doing
find . | grep -v "\.svn" | grep "valgrind.*gtest" | sed "s/\.gtest.*$//" | \
sed "s/\/[a-z_]\+$//" | sort | uniq | tee list_dirs
And then
for F in `cat list_dirs`; do svn mv $F/*.txt tools/valgrind/gtest_exclude/; done
TEST=ran a few tests locally under Valgrind and TSan
Review URL: http://codereview.chromium.org/4054004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59642
TEST=win32 tsan bot goes green.
Review URL: http://codereview.chromium.org/3808011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57686
TEST=net_unittests CookieMonsterTest.* on Linux, running original valgrind test and confirming that it completed.
Review URL: http://codereview.chromium.org/3752004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58963
TEST=net_unittests
Review URL: http://codereview.chromium.org/3774002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=none
Review URL: http://codereview.chromium.org/3548018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hangs forever.
BUG=57686
TEST=Valgrind net_unittests
Review URL: http://codereview.chromium.org/3571012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tests on Windows.
TBR=glider
Review URL: http://codereview.chromium.org/3616001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56547
TEST=net_unittests
Review URL: http://codereview.chromium.org/3448029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=56547
TEST=net_unittests
Review URL: http://codereview.chromium.org/3448029
TBR=phajdan.jr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56547
TEST=net_unittests
Review URL: http://codereview.chromium.org/3448029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=TSan/Win bot should go green
BUG=51145
Review URL: http://codereview.chromium.org/3316006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
also remove obsolete excludes for TSan issue 11 and bug 36657
TBR=glider
BUG=51145,36657
TEST=TSan/Mac should remain green, TSan/Win should go green
Review URL: http://codereview.chromium.org/3350010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51145
TBR=timurrrr
Review URL: http://codereview.chromium.org/3308009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to just 'Spdy'.
Now, instead of tests being named:
SpdyNetworkingTest/SpdyNetworkTransactionTest.Foo
they are
Spdy/SpdyNetworkingTest.Foo
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3354007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable CertDatabaseNSSTest.ImportFromPKCS12 back, since the leaks are
suppressible now.
TBR=mattm
BUG=51988
Review URL: http://codereview.chromium.org/3218011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(For http://codereview.chromium.org/3106028/show)
BUG=19991
TEST=none
TBR=wtc
Review URL: http://codereview.chromium.org/3214010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LRU list when an entry is created. This means that
we don't update the list anymore when an entry is
accessed, even if we are writing to the entry.
The general idea is that now we should be able to
open an AppCache and read from it without modifying
the contents of the cache, so that if the browser
crashes, we won't find "dirty" entries to discard.
By minimizing writes to the LRU list, we reduce the
chances that the list will get corrupt beyond the
point where we cannot trust it anymore if the whole
system crashes (and not just the browser).
BUG=51870
TEST=net_unittests
Review URL: http://codereview.chromium.org/3186032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/3267001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ sortIpAddressList()
+ isInNetEx()
BUG=25407
r=eroman
Review URL: http://codereview.chromium.org/2818006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53304
TBR=glider
Review URL: http://codereview.chromium.org/3122040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=53141
TEST=none
Review URL: http://codereview.chromium.org/3159035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=51145
TBR=glider
Review URL: http://codereview.chromium.org/3174018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
HttpNetworkTransactionTest.UseAlternateProtocolForNpnSpdyWithExistingSpdySession under ThreadSanitizer on Windows
TBR=glider
BUG=52699
Review URL: http://codereview.chromium.org/3126019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
can't be suppressed cleanly.
BUG=51988,51332,51330,51328
TEST=heapcheck bot should go green
Review URL: http://codereview.chromium.org/3112007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
will fail randomly.
BUG=51087
TEST=none
Review URL: http://codereview.chromium.org/3030052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=none
Review URL: http://codereview.chromium.org/3050037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Mac.
Disable SpdyNetworkingTest/SpdyNetworkTransactionTest.SocketWriteReturnsZero*
and SpdyNetworkingTest/SpdyNetworkTransactionTest.CancelledTransactionSendRst*
under ThreadSanitizer on all platforms (crash on Mac and Win)
BUG=51145,51144,50918
TBR=timurrrr
Review URL: http://codereview.chromium.org/3074028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54880 0039d316-1c4b-4281-b951-d872f2087c98
|