| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=122953
Review URL: http://codereview.chromium.org/10068016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=121153
TEST=X509CertificateTest.ParseSubjectAltName
R=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9950065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to all my reviewers, you are legion. I hope I didn't waste too
much of your time.
BUG=None
Review URL: http://codereview.chromium.org/9854039
Review URL: http://codereview.chromium.org/9854043
Review URL: http://codereview.chromium.org/9863058
Review URL: http://codereview.chromium.org/9863059
Review URL: http://codereview.chromium.org/9887005
Review URL: http://codereview.chromium.org/9890002
Review URL: http://codereview.chromium.org/9891002
Review URL: http://codereview.chromium.org/9895003
Review URL: http://codereview.chromium.org/9896002
Review URL: http://codereview.chromium.org/9896003
Review URL: http://codereview.chromium.org/9897002
Review URL: http://codereview.chromium.org/9897003
Review URL: http://codereview.chromium.org/9903004
Review URL: http://codereview.chromium.org/9904003
Review URL: http://codereview.chromium.org/9904002
Review URL: http://codereview.chromium.org/9904004
Review URL: http://codereview.chromium.org/9906002
Review URL: http://codereview.chromium.org/9906001
Review URL: http://codereview.chromium.org/9906003
Review URL: http://codereview.chromium.org/9909001
Review URL: http://codereview.chromium.org/9909002
Review URL: http://codereview.chromium.org/9909003
Review URL: http://codereview.chromium.org/9909004
Review URL: http://codereview.chromium.org/9910001
Review URL: http://codereview.chromium.org/9910002
Review URL: http://codereview.chromium.org/9910010
Review URL: http://codereview.chromium.org/9911001
Review URL: http://codereview.chromium.org/9912001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL seems to have broken the Win & Win Aura builds.
I reused the Comodo certificate since it's valid for > year and it's the
last one that I touched.
BUG=111893
TEST=net_unittests
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9815015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I reused the Comodo certificate since it's valid for > year and it's the
last one that I touched.
BUG=111893
TEST=net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CRLSet has expired.""
(First landed in r127757, reverted in r127773 because a unittest failed
in debug mode.)
After this change our CRLSet logic is:
* If we have a fresh CRLSet then we don't do online revocation checks unless the
user has configured them. (It can be configured either via the settings UI,
or with the EnableOnlineRevocationChecks policy option.)
* If we don't have a CRLSet, or if it has expired, and we're trying EV verification,
then we require a positive online revocation check in order to show the EV badge.
An invalid revocation check reply will prevent the EV badge, but not hard-fail
the whole verification.
BUG=none
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9699043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CRLSet has expired.
After this change our CRLSet logic is:
* If we have a fresh CRLSet then we don't do online revocation checks unless the
user has configured them. (It can be configured either via the settings UI,
or with the EnableOnlineRevocationChecks policy option.)
* If we don't have a CRLSet, or if it has expired, and we're trying EV verification,
then we require a positive online revocation check in order to show the EV badge.
An invalid revocation check reply will prevent the EV badge, but not hard-fail
the whole verification.
BUG=none
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9699043
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9783001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this change our CRLSet logic is:
* If we have a fresh CRLSet then we don't do online revocation checks unless the
user has configured them. (It can be configured either via the settings UI,
or with the EnableOnlineRevocationChecks policy option.)
* If we don't have a CRLSet, or if it has expired, and we're trying EV verification,
then we require a positive online revocation check in order to show the EV badge.
An invalid revocation check reply will prevent the EV badge, but not hard-fail
the whole verification.
BUG=none
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9699043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(First landed in r127486, reverted in r127493 because it broke on
Windows XP, relanded in r127518 and reverted in r127520 because Android got
upset about an unused function.)
I was getting increasingly unhappy altering EV and revocation checking
semantics without any tests. We historically haven't had tests because
online revocation checking is inherently flaky so I amended testserver
with the minimum code to be able to sign and vend OCSP responses.
These tests do not test the final EV/CRLSet/revocation checking
semantics. They are intended to be altered in future CLs.
BUG=none
TEST=net_unittests
https://chromiumcodereview.appspot.com/9663017/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r127518.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(First landed in r127486, reverted in r127493 because it broke on
Windows XP.)
I was getting increasingly unhappy altering EV and revocation checking
semantics without any tests. We historically haven't had tests because
online revocation checking is inherently flaky so I amended testserver
with the minimum code to be able to sign and vend OCSP responses.
These tests do not test the final EV/CRLSet/revocation checking
semantics. They are intended to be altered in future CLs.
BUG=none
TEST=net_unittests
https://chromiumcodereview.appspot.com/9663017/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r127486. Looks like it's broken on Windows XP only.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was getting increasingly unhappy altering EV and revocation checking
semantics without any tests. We historically haven't had tests because
online revocation checking is inherently flaky so I amended testserver
with the minimum code to be able to sign and vend OCSP responses.
These tests do not test the final EV/CRLSet/revocation checking
semantics. They are intended to be altered in future CLs.
BUG=none
TEST=net_unittests
https://chromiumcodereview.appspot.com/9663017/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116984
TEST=On a Windows machine, run `certutil -urlcache * delete` on the command line. Then start Chrome and ensure that https://www.paypal.com shows a green EV indication in the URL bar.
Review URL: http://codereview.chromium.org/9619007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, SSLInfo was given the cert chain as served by the server. It is
more useful and correct to provide higher layers the cert chain as
validated.
BUG=77757, 87303, 115312
TEST=net_unittests SSLClientSocketTest.VerifyReturnChainProperlyOrdered
Review URL: http://codereview.chromium.org/9442001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=113705
Review URL: http://codereview.chromium.org/9383010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chains.
NSS bug 721288 causes CERT_PKIXVerifyCert to continue extending the
certificate chain after it has reached a root certificate. Detect that
bug and ignore such extraneous root certificates in certificate chains
when checking for weak signature algorithms.
R=rsleevi@chromium.org
BUG=108514
TEST=a new unit test (to be added) that uses the certificate chain sent
by https://images.etrade.wallst.com/ during SSL handshake.
Review URL: http://codereview.chromium.org/9271060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's #ifdef'ed USE_NSS for now because we don't yet have implementations for
Windows and OS X.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/9152011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/8890073/
(Failed to add by commit queue in r114525)
BUG=107047
TEST=none
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/8976007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"Small" means less than 1024 bits.
BUG=102949
TEST=net_unittests, X509CertificateTest.*
Review URL: http://codereview.chromium.org/8568040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/8890073/
BUG=107047
TEST=none
Review URL: http://codereview.chromium.org/8890074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stringified form
On Windows, rather than converting the entire certificate
name to a string and attempting to parse out the components
and values, iterate through the relativeDistinguishedName
and AttributeTypeAndValue pairs to extract each name
component.
This is to ensure that:
1) When multiple AVAs are present in an RDN, ALL AVAs are
parsed.
2) When converting an AVA to a string, no extra escaping is
applied.
This also fixes domainComponent parsing on OS X, so that
unittests with a domainComponent can pass.
BUG=101009, 102839
TEST=net_unittests:X509CertificateTest has two new regression
tests. Additionally, sample a variety of SSL sites and ensure no
regressions, paying attention to internationalized domains.
Review URL: http://codereview.chromium.org/8608003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
EntryStore and RankingsNode now have a new member that
verifies that whatever we read from disk is what we
wrote before.
BUG=100125
TEST=none
Review URL: http://codereview.chromium.org/8658001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's been 2 years and three months since the pointer
member of RankingsNode was deprecated. These test files
were saved before that.
BUG=100125
TEST=none
Review URL: http://codereview.chromium.org/8637022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101123
TEST=net_unittests:X509CertificateWeakDigestTest.*
Review URL: http://codereview.chromium.org/8391036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
issued by a VeriSign intermediate CA.
Change the CertVerifier cache to identify a certificate chain by the
hash of the entire chain rather than just the server certificate.
This requires adding X509Certificate::chain_fingerprint(), and the
X509Certificate::CalculateChainFingerprint() method to compute the
chain fingerprint.
R=agl@chromium.org,rsleevi@chromium.org
BUG=101555
TEST=X509CertificateTest.ChainFingerprints and
CertVerifierTest.DifferentCACerts in net_unittests
Review URL: http://codereview.chromium.org/8400075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56373
TEST=URLRequestTestHTTP.Redirect30*Tests
Review URL: http://codereview.chromium.org/8375002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=99185
Review URL: http://codereview.chromium.org/8302019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99185
Review URL: http://codereview.chromium.org/8289023
TBR=palmer@chromium.org
Review URL: http://codereview.chromium.org/8267018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=99185
Review URL: http://codereview.chromium.org/8289023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reportingfeature. Phase Two of this feature ishttp://codereview.chromium.org/8055027/, and Phase Three ishttp://codereview.chromium.org/8120016/.This feature will be under heavy development, including additional,end-to-end unit testing, throughout Q4 2011. Manual testing shows thatthe basic SendReport functionality works, and that is all we need inthe immediate, pre-Stable short-term.BUG=99185Review URL: http://codereview.chromium.org/8037039
The build failure on windows shared library build:
http://build.chromium.org/p/chromium/builders/Win%20Builder%20%28dbg%29%28shared%29/builds/15800/steps/compile/logs/stdio
56>browser.lib(chrome_fraudulent_certificate_reporter.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: virtual __thiscall net::FraudulentCertificateReporter::~FraudulentCertificateReporter(void)" (__imp_??1FraudulentCertificateReporter@net@@UAE@XZ) referenced in function __unwindfunclet$??0ChromeFraudulentCertificateReporter@chrome_browser_net@@QAE@PAVURLRequestContext@net@@@Z$0
56>browser.lib(chrome_fraudulent_certificate_reporter.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall net::FraudulentCertificateReporter::FraudulentCertificateReporter(void)" (__imp_??0FraudulentCertificateReporter@net@@QAE@XZ) referenced in function "public: __thiscall chrome_browser_net::ChromeFraudulentCertificateReporter::ChromeFraudulentCertificateReporter(class net::URLRequestContext *)" (??0ChromeFraudulentCertificateReporter@chrome_browser_net@@QAE@PAVURLRequestContext@net@@@Z)
TBR=palmer@chromium.org
Review URL: http://codereview.chromium.org/8301018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
feature. Phase Two of this feature is
http://codereview.chromium.org/8055027/, and Phase Three is
http://codereview.chromium.org/8120016/.
This feature will be under heavy development, including additional,
end-to-end unit testing, throughout Q4 2011. Manual testing shows that
the basic SendReport functionality works, and that is all we need in
the immediate, pre-Stable short-term.
BUG=99185
Review URL: http://codereview.chromium.org/8037039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to nahi on Twitter for pointing out that I had the wrong certificate for
DigiNotar's Cyber CA and thus blocked the wrong public key. According to the
audit report, this isn't panic-worthy as the misissued certs off this
intermediate have expired.
BUG=96252
TEST=net_unittests
Review URL: http://codereview.chromium.org/7865027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The certificate has expired and broken the build
TBR=wtc
Review URL: http://codereview.chromium.org/7831054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove duplicate certificate data in google_diginotar.pem and
diginotar_public_ca_2025.pem.
R=agl@chromium.org
BUG=94673
TEST=none
Review URL: http://codereview.chromium.org/7792077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94673
TEST=Visit https://www.diginotar.com and expect an invalid authority error.
Review URL: http://codereview.chromium.org/7795014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
TEST=Heapchecker bots turn green again
Review URL: http://codereview.chromium.org/7664008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92154
TEST=navigate to ftp://ftp.os4.su/ - no errors should appear
Review URL: http://codereview.chromium.org/7590011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=90807
Review URL: http://codereview.chromium.org/7584018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for a unit test used in a separate CL.
(http://codereview.chromium.org/7466006)
Written by Gaurav Shah <gauravsh@chromium.org>.
Original review URL: http://codereview.chromium.org/7539008/
R=wtc@chromium.org
BUG=chromium-os:15838
TEST=none
Review URL: http://codereview.chromium.org/7466044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65540
TEST=net_unittests --gtest_filter=X509CertificateTest.VerifyReturn*
Review URL: http://codereview.chromium.org/6874039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=58437
TEST=go to <https://2029.globalsign.com> and verify the EV status
Unit Test (This test has been DISABLED because it fails
when "./netunittests" is run, though it passes individually.):
"net_unittests --gtest_filter=X509CertificateTest.GlobalSignR3EVTest"
Review URL: http://codereview.chromium.org/7037031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79694
TEST=Download a torrent file from http://ca.isohunt.com. It should complete.
Review URL: http://codereview.chromium.org/6881106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tlslite does some autodetection which when m2crypto is installed and importable is more strict when parsing certificate files. This CL makes our certificate files acceptable by both the more strict and more lenient versions of code used by tlslite.
Swap the certificate and private key in [ok|expired]_cert.pem, so that
s.startswith() will return true for OpenSSL_RSAKey. tlslite.X509 uses
s.find() to locate the BEGIN CERTIFICATE, so it should be unaffected.
For more info see http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/903f65ad685da9b2#
Review URL: http://codereview.chromium.org/6814045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix detection of KOI8-R and possibly other encodings
- fix parsing Russian month names
When detecting the listing encoding, we need to not only
check whether the data can be converted using given encoding,
but also whether the result can be parsed as a valid directory listing.
Also, we only need to compare the first three characters of the
abbreviated month name, because that's how they're abbreviated
in FTP directory listings.
Finally, the Russian directory listings have swapped the "month" and "day of month" columns.
BUG=65917
Review URL: http://codereview.chromium.org/6718043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have several places where a need to distinguish `real' root CAs from
user-added root CAs will be useful:
1) Monoscope wants to inspect correctly signed, but unknown certificates, but
doesn't want to deal with proxy MITM certificates.
2) HSTS is likely to add a method for pinning to a certificate, but we don't
want to break every proxy MITM with it.
This change adds several lists of known, `real' roots. These lists present an
ongoing maintainance issue. However, in the event that the lists are incomplete
in the future, we fail open. This is because roots not in these lists are
treated as user-added and user-added roots have more authority than `real'
roots.
In some sense, this is a problem because it might be a security issue that new
roots are given too much authority. On the other hand, we're not breaking
things when we're behind on updating the lists so the maintainance issue isn't
too pressing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6793041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(No code changes.)
nist.der contains a certificate issued directly from a root. This will be used
in a future unittest however, committing it now allows the try servers to
process the unittest before it's landed.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detection of KOI8-R and possibly other encodings- fix parsing Russian month namesWhen detecting the listing encoding, we need to not onlycheck whether the data can be converted using given encoding,but also whether the result can be parsed as a valid directory listing.Also, we only need to compare the first three characters of theabbreviated month name, because that's how they're abbreviatedin FTP directory listings.Finally, the Russian directory listings have swapped the "month" and "day of month" columns.BUG=65917Review URL: http://codereview.chromium.org/6718043
TBR=phajdan.jr@chromium.org
Failures (Windows only, both Vista and XP):
FtpDirectoryListingBufferTest.Parse:
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".."
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: ..
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[25]: dir-listing-ls-25
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".message"
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[25]: dir-listing-ls-25
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".."
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: ..
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[26]: dir-listing-ls-26
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".message"
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[26]: dir-listing-ls-26
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".."
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: ..
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[27]: dir-listing-ls-27
.\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(name)
Which is: L".message"
Google Test trace:
.\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message
.\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[27]: dir-listing-ls-27
FtpDirectoryListingParserLsTest.Good:
c:\b\build\slave\cr-win-rel\build\src\net/ftp/ftp_directory_listing_parser_unittest.h(47): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(test_case.filename)
Which is: L"test"
Google Test trace:
.\ftp\ftp_directory_listing_parser_ls_unittest.cc(109): Test[21]: -rwxrwxr-x 1 ftp ftp 123 23 май 2011 test
c:\b\build\slave\cr-win-rel\build\src\net/ftp/ftp_directory_listing_parser_unittest.h(47): error: Value of: entry.name
Actual: L""
Expected: UTF8ToUTF16(test_case.filename)
Which is: L"dir"
Google Test trace:
.\ftp\ftp_directory_listing_parser_ls_unittest.cc(109): Test[22]: drwxrwxr-x 1 ftp ftp 4096 19 окт 2011 dir
Review URL: http://codereview.chromium.org/6802006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix detection of KOI8-R and possibly other encodings
- fix parsing Russian month names
When detecting the listing encoding, we need to not only
check whether the data can be converted using given encoding,
but also whether the result can be parsed as a valid directory listing.
Also, we only need to compare the first three characters of the
abbreviated month name, because that's how they're abbreviated
in FTP directory listings.
Finally, the Russian directory listings have swapped the "month" and "day of month" columns.
BUG=65917
Review URL: http://codereview.chromium.org/6718043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80587 0039d316-1c4b-4281-b951-d872f2087c98
|