| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is meant for M21 Satble
BUG=135233
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10690049
TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/10703051
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@144959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
released before invoking the callbacks.
BUG=131272
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10542068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of all uses of NetLogEventParameters in net/disk_cache.
R=eroman@chromium.org
BUG=126243
Review URL: https://chromiumcodereview.appspot.com/10543114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=128140
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10454093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended for the beta channel.
BUG=130443
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10446092
TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/10442120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is intended for the beta channel.
BUG=130443
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10446092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123295
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10417002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10383229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=gavinp
Review URL: https://chromiumcodereview.appspot.com/10332050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=gavinp
Review URL: https://chromiumcodereview.appspot.com/10317023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10148001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123295
TEST=none
Review URL: http://codereview.chromium.org/10066045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
because that may cause failures with other tests.
BUG=122005
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10140031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
By design, there's no ScopedAllowWait that is reachable by all code. From experience with ScopedAllowIO, it will be abused. So instead the existing callers (which should all be fixed other than two) are friends with ThreadRestrictions.
Review URL: https://chromiumcodereview.appspot.com/10151009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=122005
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10204005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
renaming the cache folder.
BUG=122005
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10152002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10116006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75548,113300
TEST=existing tests should pass
Review URL: https://chromiumcodereview.appspot.com/9949011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=102809
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9864047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=103629
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9864055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=15982
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9860046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageLoop with orphaned tasks.
This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time.
* The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL.
A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer).
As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states.
BUG=117451,103667,119714,119750
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506
Review URL: https://chromiumcodereview.appspot.com/9655006
TBR=jbates@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9791009
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9860014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
orphaned tasks.
This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time.
* The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL.
A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer).
As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states.
BUG=117451,103667,119714,119750
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506
Review URL: https://chromiumcodereview.appspot.com/9655006
TBR=jbates@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9791009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time.
* The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL.
A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer).
As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states.
BUG=117451,103667,119714,119750
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506
Review URL: https://chromiumcodereview.appspot.com/9655006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm interested in InFlightIO::io_list_, which is of type
std::set<scoped_refptr<BackgroundIO> >, so it holds refs to the
underlying objects.
On the primary/callback thread, the erase call in
InFlightIO::InvokeCallback can delete the operation if the list holds
the last reference. This typically can't happen because the pending
tasks hold a reference to the operation; this is good: it means that
operations are deleted/newed on the background thread, I believe.
This DCHECK() is useful for when you make changes that can delete an
operation in the primary thread, like we found with some of the posix
races in http://codereview.chromium.org/9702059/
Question: for debugging I like the use of scoped_refptr<BackgroundIO>;
but since we never want to delete here, wouldn't a set<BackgroundIO*>
on non-debug builds be more in line with our use?
BUG=None
Review URL: http://codereview.chromium.org/9758002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
No real code change.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9839040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tasks."
This reverts commit r128412, which is causing DCHECKs in thread
destruction in media unittests.
BUG=119714,119750
TBR=sky@chromium.org,petermayo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9839059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time.
* The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL.
A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer).
As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states.
BUG=117451,103667
Review URL: http://codereview.chromium.org/9655006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
No real code change.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9812031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cache destructor.
The default setting for unit tests is still to perform full
synchronization so we make sure that all work is performed, and
that there are no leaks.
However, when not running unit tests, all in progress operations are
simply dropped on the flor, so they should result in dirty entries
for the next run.
BUG=74623
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9702059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
===============================================
Disk cache: Enable DiskCacheBackendTest.AppCacheEnumerations
Not flaky anymore.
BUG=74387
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9392023
TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/9664022
TBR=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9677022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for read_only caches.
BUG=117598
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9668027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
===============================================
Disk cache: Enable DiskCacheBackendTest.AppCacheEnumerations
Not flaky anymore.
BUG=74387
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9392023
TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/9664022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/9595007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9586001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/9572036
TBR=tedvessenes@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9597005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/9572036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79186
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9430030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=114258
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9359047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a harmless bug in this code -- the signedness of the final
char is unspecified. On x86 it's signed by default, but on most ARM
compilers it's unsigned. The signed version has been baked into the
unit test data, as well as user's disk caches, so this patch makes
it official.
This patch is needed to fix the disk cache unit tests on Android.
BUG=90659
TEST=DiskCacheBackendTest
Patch submitted by husky@chromium.org.
Original review: http://codereview.chromium.org/9375011/
Review URL: https://chromiumcodereview.appspot.com/9402036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not flaky anymore.
BUG=74387
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9392023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6
BUG=74387,112682,25045
Review URL: https://chromiumcodereview.appspot.com/9350047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9190027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=100673
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9290029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=102809
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9289026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sure that the number of entries on the file is not out of
sync.
* Check the counters on every session
* Make sure that num_entries is always >= number of used bits
(create/delete order)
* Make sure that the updating flag works for gcc & co.
* Fail initialization if we cannot fix the file.
BUG=108375
TEST=net_unittests
Review URL: http://codereview.chromium.org/9016033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/9035012"
The hanging test is unrelated to this change (it's merely tickled by a
potential timing change).
BUG=50346
TEST=none
TBR=awong
Review URL: http://codereview.chromium.org/9088002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=groby,awong,csilv
Review URL: http://codereview.chromium.org/9028009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The net unit tests have been red under windows tsan continuously since this landed.
BUG=50346
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/9028008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=groby,csilv,ajwong
Review URL: http://codereview.chromium.org/9035012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115737 0039d316-1c4b-4281-b951-d872f2087c98
|