summaryrefslogtreecommitdiffstats
path: root/net/disk_cache
Commit message (Collapse)AuthorAgeFilesLines
* Revert 152360 - Disk cache: Disable checking the lists on start-up.rvargas@google.com2012-08-201-0/+3
| | | | | | | | | | | | | | This cl is intended for the beta channel. BUG=143743 TEST=none TBR=gavinp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10837341 TBR=rvargas@google.com Review URL: https://chromiumcodereview.appspot.com/10854230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152364 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Disable checking the lists on start-up.rvargas@google.com2012-08-201-3/+0
| | | | | | | | | | | This cl is intended for the beta channel. BUG=143743 TEST=none TBR=gavinp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10837341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152360 0039d316-1c4b-4281-b951-d872f2087c98
* net: Fix more clang warnings about missing virtual and OVERRIDE annotations.tfarina@chromium.org2012-08-193-7/+7
| | | | | | | | | | BUG=115047 R=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152296 0039d316-1c4b-4281-b951-d872f2087c98
* Run the disk cache tests in scoped temporary directories instead of a fixed ↵jam@chromium.org2012-08-176-58/+12
| | | | | | | | | directory so that they can run in parallel. BUG=139272 Review URL: https://chromiumcodereview.appspot.com/10824336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151999 0039d316-1c4b-4281-b951-d872f2087c98
* Change the type of file_type parameter to int, as the parameter actually ↵haruki@chromium.org2012-08-121-6/+3
| | | | | | | | | | | | | takes or-ed bitmasks, to remove static_cast<> in the callers. BUG=139130 TEST=try bots Review URL: https://chromiumcodereview.appspot.com/10855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151192 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up inline members of nested classes (net/)hans@chromium.org2012-08-092-4/+12
| | | | | | | | | | | | | | | | Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Review URL: https://chromiumcodereview.appspot.com/10854063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150917 0039d316-1c4b-4281-b951-d872f2087c98
* Add HttpCache histograms focussed on blocking and transaction type.gavinp@chromium.org2012-08-095-0/+13
| | | | | | | | | | | | | Most of our existing disk cache histograms focus on the speed of operations on the cache itself. This CL adds a bunch that break down http transactions by type, and track both time spent reading (either from disk cache or network), and time spent waiting for the disk cache to allow us to send the network request. Note that these patches are based on http://codereview.chromium.org/10797042/ , which must land first. R=rvargas@chromium.org, tburkhard@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/10808047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150902 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: Fix the value reported for QuickListCheck histogram.rvargas@google.com2012-08-031-1/+1
| | | | | | | | | BUG=none TEST=none TBR=gavinp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10850035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149762 0039d316-1c4b-4281-b951-d872f2087c98
* This is a major refactor of Histogram related code:kaiwang@chromium.org2012-08-012-16/+7
| | | | | | | | | | | 1. Remove duplicated code from histogram.h/.cc, including validating related code and BucketRanges related. 2. Constness of BucketRanges from Histograms, to prevent accidentally modification and provide a simpler interface. 3. Add/move tests. Review URL: https://chromiumcodereview.appspot.com/10834011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149495 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unnecessary DCHECK on entryorenb@chromium.org2012-07-261-1/+0
| | | | | | | | | | | | | Addresses discussion in code review iossue 10828025. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10821039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148598 0039d316-1c4b-4281-b951-d872f2087c98
* Added sanity check for entry in ReadyToUseorenb@chromium.org2012-07-261-1/+2
| | | | | | | | | | | | | CID_COUNT=1 CID=103693 BUG= TEST= TBR=rvargas Review URL: https://chromiumcodereview.appspot.com/10828025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148457 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2012-07-251-1/+12
| | | | | | | | | | | | | CID_COUNT=6 CID=102321,102647,102678,102810,103294,103381 BUG=none TEST=none R=tbreisacher@chromium.org TBR=mirandac@chromium.org, jam@chromium.org,dcheng@chromium.org Review URL: https://chromiumcodereview.appspot.com/10833013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148433 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Always look for open entries when loadingrvargas@google.com2012-07-204-8/+56
| | | | | | | | | | a rankings node for a read only cache (AppCache) BUG=137959 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10795040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147672 0039d316-1c4b-4281-b951-d872f2087c98
* Change the FindHistogram interface of StatisticsRecorderkaiwang@chromium.org2012-07-181-5/+2
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10802002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147269 0039d316-1c4b-4281-b951-d872f2087c98
* Move StatisticsRecorder out of histogram.cc/h for further refactoring.kaiwang@chromium.org2012-07-131-1/+2
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10703037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146659 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-1133-33/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144947 - Disk cache: don't check the list of entries at startup.rvargas@google.com2012-06-291-0/+3
| | | | | | | | | | | | | | This is meant for M21 Satble BUG=135233 TEST=none TBR=gavinp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10690049 TBR=rvargas@google.com Review URL: https://chromiumcodereview.appspot.com/10701044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144949 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: don't check the list of entries at startup.rvargas@google.com2012-06-291-3/+0
| | | | | | | | | | | This is meant for M21 Satble BUG=135233 TEST=none TBR=gavinp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10690049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144947 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Wait until time actually moves forward, torvargas@google.com2012-06-294-15/+22
| | | | | | | | | | | avoid a possible issue with the high resolution timer going back due to clock skew. BUG=133052 TEST=none Review URL: https://chromiumcodereview.appspot.com/10684007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144944 0039d316-1c4b-4281-b951-d872f2087c98
* Optionally disable mmap() in the disk cache.husky@chromium.org2012-06-269-6/+143
| | | | | | | | | | | | | | | | | | | | | The disk cache mmaps the headers of certain important files (the main index file, plus block files). Unfortunately on some Android devices mmap performs badly on flash storage, and it's actually better to write the data manually. This patch adds the macro USE_MMAP_FOR_DISK_CACHE macro and the method disk_cache::MappedFile::FlushHeader(). By default, the macro is defined, the new method is a no-op, and there's no change in behavior. TEST=DiskCacheTest BUG= Review URL: https://chromiumcodereview.appspot.com/10573032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144166 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Continue looking for list errors after the first one.rvargas@chromium.org2012-06-261-4/+6
| | | | | | | | | | BUG=none TEST=none TBR=gavinp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10659025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144102 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: Add a histogram to track list head corruption.rvargas@google.com2012-06-192-1/+49
| | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10561012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142996 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Make sure that references to IO buffers arervargas@chromium.org2012-06-143-12/+55
| | | | | | | | | | | released before invoking the callbacks. BUG=131272 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10542068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142039 0039d316-1c4b-4281-b951-d872f2087c98
* NetLogEventParameter to Callback refactoring 2.mmenke@chromium.org2012-06-125-236/+186
| | | | | | | | | | | Get rid of all uses of NetLogEventParameters in net/disk_cache. R=eroman@chromium.org BUG=126243 Review URL: https://chromiumcodereview.appspot.com/10543114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141697 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Pre-read file headers when opening files (posix).rvargas@google.com2012-06-081-2/+8
| | | | | | | | BUG=128140 TEST=none Review URL: https://chromiumcodereview.appspot.com/10454093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141245 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 139886 - Disk cache: Don't check the list of entries at startup.rvargas@google.com2012-05-311-0/+3
| | | | | | | | | | | | | This is intended for the beta channel. BUG=130443 TEST=none Review URL: https://chromiumcodereview.appspot.com/10446092 TBR=rvargas@google.com Review URL: https://chromiumcodereview.appspot.com/10442120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139904 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Don't check the list of entries at startup.rvargas@google.com2012-05-311-3/+0
| | | | | | | | | | This is intended for the beta channel. BUG=130443 TEST=none Review URL: https://chromiumcodereview.appspot.com/10446092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139886 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, net/ editionrsleevi@chromium.org2012-05-291-2/+3
| | | | | | | | | | BUG=123295 TEST=existing Review URL: https://chromiumcodereview.appspot.com/10417002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139272 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded scoped_ptr.h includes from net.thestig@chromium.org2012-05-171-2/+1
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10383229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137636 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Measure the time spent verifying the lists.rvargas@google.com2012-05-081-0/+2
| | | | | | | | | BUG=none TEST=none TBR=gavinp Review URL: https://chromiumcodereview.appspot.com/10332050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135782 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Modify when we report empty cache files.rvargas@google.com2012-05-051-7/+9
| | | | | | | | | BUG=none TEST=none TBR=gavinp Review URL: https://chromiumcodereview.appspot.com/10317023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135503 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: Add more corruption tracking histograms.rvargas@chromium.org2012-05-017-53/+154
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/10148001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134678 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, net/rsleevi@chromium.org2012-04-282-12/+55
| | | | | | | | | | BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10066045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134460 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Make sure that we don't leak file handles (even on leaky tests)rvargas@google.com2012-04-261-12/+14
| | | | | | | | | | because that may cause failures with other tests. BUG=122005 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10140031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134160 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow UI/IO thread blocking on any other thread.jam@chromium.org2012-04-262-1/+8
| | | | | | | By design, there's no ScopedAllowWait that is reachable by all code. From experience with ScopedAllowIO, it will be abused. So instead the existing callers (which should all be fixed other than two) are friends with ThreadRestrictions. Review URL: https://chromiumcodereview.appspot.com/10151009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134114 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Add more logging to track disk errors.rvargas@google.com2012-04-231-1/+3
| | | | | | | | | BUG=122005 TEST=none TBR=gavinp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10204005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133564 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: print out the name of the folders when there's an errorrvargas@google.com2012-04-201-1/+2
| | | | | | | | | | renaming the cache folder. BUG=122005 TEST=none Review URL: https://chromiumcodereview.appspot.com/10152002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133094 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Remove per-size-group histograms and a few stale ones.rvargas@google.com2012-04-183-29/+12
| | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10116006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132879 0039d316-1c4b-4281-b951-d872f2087c98
* Make FileStream::Seek async and add FileStream::SeekSync for sync operationkinuko@chromium.org2012-04-111-1/+1
| | | | | | | | | BUG=75548,113300 TEST=existing tests should pass Review URL: https://chromiumcodereview.appspot.com/9949011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131732 0039d316-1c4b-4281-b951-d872f2087c98
* initialize all fields in ctortbreisacher@chromium.org2012-03-301-0/+5
| | | | | | | | | | CID=102809 BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9864047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129959 0039d316-1c4b-4281-b951-d872f2087c98
* Checked that |entry| and |entry->backend_| are non-NULL.khorimoto@chromium.org2012-03-281-0/+1
| | | | | | | | | | | CID=103629 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/9864055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129334 0039d316-1c4b-4281-b951-d872f2087c98
* Return false if CreateDirectory failstbreisacher@chromium.org2012-03-281-1/+2
| | | | | | | | | | | CID=15982 BUG=none TEST=none Review URL: http://codereview.chromium.org/9860046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129325 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 129018 - Revert 128993 - Refactor BaseTimer to avoid spamming the ↵jbates@chromium.org2012-03-272-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | MessageLoop with orphaned tasks. This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time. * The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL. A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer). As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states. BUG=117451,103667,119714,119750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506 Review URL: https://chromiumcodereview.appspot.com/9655006 TBR=jbates@chromium.org Review URL: https://chromiumcodereview.appspot.com/9791009 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/9860014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129062 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 128993 - Refactor BaseTimer to avoid spamming the MessageLoop with ↵aa@chromium.org2012-03-262-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | orphaned tasks. This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time. * The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL. A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer). As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states. BUG=117451,103667,119714,119750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506 Review URL: https://chromiumcodereview.appspot.com/9655006 TBR=jbates@chromium.org Review URL: https://chromiumcodereview.appspot.com/9791009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129018 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BaseTimer to avoid spamming the MessageLoop with orphaned tasks.jbates@chromium.org2012-03-262-4/+5
| | | | | | | | | | | | | | | | | | | | This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time. * The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL. A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer). As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states. BUG=117451,103667,119714,119750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506 Review URL: https://chromiumcodereview.appspot.com/9655006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128993 0039d316-1c4b-4281-b951-d872f2087c98
* Additional DCHECK for InFlightIO::InvokeCallback.gavinp@chromium.org2012-03-231-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | I'm interested in InFlightIO::io_list_, which is of type std::set<scoped_refptr<BackgroundIO> >, so it holds refs to the underlying objects. On the primary/callback thread, the erase call in InFlightIO::InvokeCallback can delete the operation if the list holds the last reference. This typically can't happen because the pending tasks hold a reference to the operation; this is good: it means that operations are deleted/newed on the background thread, I believe. This DCHECK() is useful for when you make changes that can delete an operation in the primary thread, like we found with some of the posix races in http://codereview.chromium.org/9702059/ Question: for debugging I like the use of scoped_refptr<BackgroundIO>; but since we never want to delete here, wouldn't a set<BackgroundIO*> on non-debug builds be more in line with our use? BUG=None Review URL: http://codereview.chromium.org/9758002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128593 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache. Fix style on some missing files.rvargas@google.com2012-03-232-22/+20
| | | | | | | | | | No real code change. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9839040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128540 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor BaseTimer to avoid spamming the MessageLoop with orphaned ↵rnk@chromium.org2012-03-232-5/+4
| | | | | | | | | | | | | | tasks." This reverts commit r128412, which is causing DCHECKs in thread destruction in media unittests. BUG=119714,119750 TBR=sky@chromium.org,petermayo@chromium.org Review URL: https://chromiumcodereview.appspot.com/9839059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128506 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BaseTimer to avoid spamming the MessageLoop with orphaned tasks.jbates@chromium.org2012-03-232-4/+5
| | | | | | | | | | | | | | | | This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time. * The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL. A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer). As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states. BUG=117451,103667 Review URL: http://codereview.chromium.org/9655006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128412 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Fix style and extra net:: specification.rvargas@google.com2012-03-239-180/+168
| | | | | | | | | | No real code change. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9812031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128364 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 13:34:16 +0000