| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/102873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.
To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.
base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:
sed -E -i '' \
-e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
-e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
-e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
$(git grep -El 'HANDLE_EINTR.*close')
sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
$(grep -EL '(HANDLE|IGNORE)_EINTR' \
$(git grep -El '#include.*eintr_wrapper\.h"'))
BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS
Review URL: https://codereview.chromium.org/100253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
MDnsClinet will just listen and send packet to those sockets without knowing address family or interface.
BUG=297690
TBR=thestig, for c/tools/
Review URL: https://codereview.chromium.org/87693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If GetLocalAddress fails, |src| is empty so ToStringWithoutPort will
CHECK. The actual intent is to log |dest|.
BUG=321438
Review URL: https://codereview.chromium.org/76913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use VLOG(1) instead of LOG(WARNING) for the following
messages:
[1100:1268:1009/125256:WARNING:dns_socket_pool.cc(85)]
Failed to connect socket: -109
[15162:16935:1031/172646:WARNING:address_sorter_posix.cc(305)]
Could not connect to <address> reason -109
BUG=305883
Review URL: https://codereview.chromium.org/76073004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All we have to do is forward the relevant methods to the wrapped impl_.
BUG=313455
R=mmenke@chromium.org
Review URL: https://codereview.chromium.org/53633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Services Code Point for each package. Will be used by webrtc to hopefully improve performance. (See bug for how we will test this.)
BUG=277022
Review URL: https://codereview.chromium.org/22381012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is to avoid confusion with whether higher numbers are higher priority.
BUG=307757
R=rch@chromium.org
Review URL: https://codereview.chromium.org/26297006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/25687006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 225155 "Keep running mdns client even if either IPv4 or I..."
>
> BUG=298768
>
> > Keep running mdns client even if either IPv4 or IPv6 bind failed.
> >
> > BUG=297212
> > NOTRY=true
> >
> > Review URL: https://chromiumcodereview.appspot.com/23498056
>
> TBR=vitalybuka@chromium.org
>
> Review URL: https://codereview.chromium.org/24486005
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/24813006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=298768
> Keep running mdns client even if either IPv4 or IPv6 bind failed.
>
> BUG=297212
> NOTRY=true
>
> Review URL: https://chromiumcodereview.appspot.com/23498056
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/24486005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=295997
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225303
R=szym@chromium.org
Review URL: https://codereview.chromium.org/23726043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Added NetworkInterface::network_prefix.
>
> BUG=295997
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/23726043
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/24530007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=295997
NOTRY=true
Review URL: https://codereview.chromium.org/23726043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, brettw@chromium.org, sergeyu@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/24616002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297212
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/23498056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Simple PrivetTrafficDetector listens mDns port for specific sub-string and starts notification only if privet-like traffic detected. This allows to avoid ruining additional process for users without such devices on network.
BUG=292754
TBR=jln,jschuh
Review URL: https://chromiumcodereview.appspot.com/23702043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, if there's no WPAD host on the local network, we have to wait up to
two seconds for ProxyScriptDecider to time out, during which all requests are
stalled waiting to find out what proxy to use. This is a pretty crappy
experience when you have proxy autodetection turned on and no WPAD host.
Therefore, add a new state to ProxyScriptDecider's state machine: "QuickCheck".
When we're in this state, we are doing a DNS query only for WPAD, with a timeout
of 1 second; if this query doesn't succeed, we abort the entire WPAD process. We
also upload an UMA report saying how long the WPAD resolution took to succeed.
In future, once we have a good idea how long WPAD requests usually actually
take, we'll turn this timeout down, probably to something extremely low (from
experiments, IE appears to use a timeout of 50ms).
TEST=unit,trybot,manual
BUG=chromium:161826
Review URL: https://chromiumcodereview.appspot.com/23181010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, conservatively assume that non-empty NRPT or unknown DnsConfig could mean
DirectAccess is used, and disable IPv6 probing in that case.
BUG=259792
Review URL: https://chromiumcodereview.appspot.com/23522036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
responses with no addresses.
> [net/dns] Perform A/AAAA queries for AF_UNSPEC resolutions in parallel.
>
> The second DnsTransaction is scheduled as a second job on the resolver's
> PrioritizedDispatcher, at the beginning of its priority queue. The two
> DnsTransactions run independently of each other, although if one of them
> finishes with an error, the other one will be scrapped immediately, and
> the Job will fall back to ProcTask.
>
> BUG=174992
>
> Original Review URL: https://chromiumcodereview.appspot.com/19498003
Revert URL: https://codereview.chromium.org/23102009
BUG=174992,277625
Review URL: https://chromiumcodereview.appspot.com/22909037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Local discovery listens for mDns traffic inside Utility process with enabled setuid sandbox (seccomp-BPF is not enabled). Setuid sandbox fails ::socket calls. To overcome this we use LocalDiscoveryMsg_SetSockets IPC message to pass two new UDP sockets created in browser process. These sockets will be provided for net::MDnsClient using net::PlatformSocketFactory.
Added check to make sure that only Local Discovery Utility process handles LocalDiscovery* IPC messages.
This code, as well as Windows version, is not executed without --enable-device-discovery switch.
BUG=277654
Review URL: https://chromiumcodereview.appspot.com/23482003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/19579005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for making ObserverList::size() protected (see bug for details).
BUG=278526
TEST=no change
TBR=darin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23190045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the priority from the socket param classes to their respective
ConnectJob implementations. This prevents the possibility of
mismatching priorities when socket params have member variables of
other socket param types.
Add tests for priority propagation.
BUG=166689
R=mmenke@chromium.org
Review URL: https://codereview.chromium.org/22818010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was causing crashes in the case of DNS responses with no addresses.
> [net/dns] Perform A/AAAA queries for AF_UNSPEC resolutions in parallel.
>
> The second DnsTransaction is scheduled as a second job on the resolver's
> PrioritizedDispatcher, at the beginning of its priority queue. The two
> DnsTransactions run independently of each other, although if one of them
> finishes with an error, the other one will be scrapped immediately, and
> the Job will fall back to ProcTask.
>
> BUG=174992
>
> Review URL: https://chromiumcodereview.appspot.com/19498003
TBR=mmenke@chromium.org
BUG=277625
Review URL: https://codereview.chromium.org/23102009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also changes the handling of DNS configuration options not
yet fully implemented by DnsClient. Rather than DnsConfigService
failing to provide DnsConfig, the new field DnsConfig.unhandled_options
indicates to DnsClient that it should disable itself.
BUG=265970
Review URL: https://chromiumcodereview.appspot.com/21368005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The second DnsTransaction is scheduled as a second job on the resolver's
PrioritizedDispatcher, at the beginning of its priority queue. The two
DnsTransactions run independently of each other, although if one of them
finishes with an error, the other one will be scrapped immediately, and
the Job will fall back to ProcTask.
BUG=174992
Review URL: https://chromiumcodereview.appspot.com/19498003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it part of the HostResolver::Resolve() call instead.
This makes it possible for RequestInfo to remain constant for the
lifetime of a request.
This also has the nice side effect for not needing to pass a priority
for ResolveFromCache() calls.
BUG=166689
TBR=asargent@chromium.org, mmenke@chromium.org, sergeyu@chromium.org
Review URL: https://codereview.chromium.org/22824022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use DEFAULT_PRIORITY when there isn't already a priority
available.
This has the net effect of changing the priority of
host resolver requests that didn't specify one from
MEDIUM to DEFAULT_PRIORITY (= LOWEST). This is okay,
as those requests apparently didn't care what priority
they wanted.
BUG=166689
TBR=mmenke@chromium.org
Review URL: https://codereview.chromium.org/23146004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make it easier to modify ClientSocketFactory et al. to support
reprioritization. This also fixes a few latent memory leaks in tests.
Make SocketStream use a ClientSocketHandle instead of
just a StreamSocket.
Rename {set,release}_socket() to {Set,Pass}Socket().
BUG=166689
TBR=eroman@chromium.org, rsleevi@chromium.org, sergeyu@chromium.org
Review URL: https://codereview.chromium.org/22995002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In MDns cache lookups with multiple results return the first result over and
over again. This is the result of a simple oversight. Fix this and add
regression test.
BUG=
Review URL: https://chromiumcodereview.appspot.com/22472002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=268089
Review URL: https://chromiumcodereview.appspot.com/22068002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/21534003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++11 now warns when initializing array of uint8 using char literals with value larger than 127. So it's preferred to use numeric (either 0x or decimal) directly instead of char when possible.
I opted to use decimal literals for IPs and numbers, and kept the hexadecimal representation for "codes" (like the identifying code for Type A).
This patch fixes compilation for G++ 4.8.1.
TEST=net_unittests --gtest_filter="MDnsCacheTest*"
Review URL: https://chromiumcodereview.appspot.com/21082002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Honor DnsConfig timeout if it exceeds 5s.
BUG=110197
TEST=net_unittests --gtest_filter=DnsSessionTest.HistogramTimeout*
Review URL: https://chromiumcodereview.appspot.com/20482002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Avira's anti-DDoS mechanims are sensitive to any UDP activity on port 80.
BUG=258548
Review URL: https://chromiumcodereview.appspot.com/19743006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds UDP_LOCAL_ADDRESS NetLog event, and logs the UDP sockets used to
determine IPv6 support.
BUG=259792
Review URL: https://chromiumcodereview.appspot.com/19492013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes MessagePump a non-thread safe class to make sure thread-bound resources (such as the UI window used for pumping messages on Windows) are freed on the correct thread.
Handling of incoming tasks and synchronization between different threads was moved out to a separate class - IncomingTaskQueue reducing the number of locks to be taken while posting a task to one. Posting tasks via both MessageLoop and MessageLoopProxyImpl is now routed via IncomingTaskQueue.
TBR all reviewers from https://chromiumcodereview.appspot.com/17567007/ because this is a re-land of it with a mechanical fix (adding a missing header).
TBR=rsesek@chromium.org,darin@chromium.org,thakis@chromium.org,rvargas@chromium.org,dalecurtis@chromium.org
BUG=241939
Review URL: https://codereview.chromium.org/19661004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r212948 broke Mac Builder: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Builder/builds/25623
> Made MessagePump a non-thread safe class.
>
> This CL makes MessagePump a non-thread safe class to make sure thread-bound resources (such as the UI window used for pumping messages on Windows) are freed on the correct thread.
>
> Handling of incoming tasks and synchronization between different threads was moved out to a separate class - IncomingTaskQueue reducing the number of locks to be taken while posting a task to one. Posting tasks via both MessageLoop and MessageLoopProxyImpl is now routed via IncomingTaskQueue.
>
> BUG=241939
>
> Review URL: https://chromiumcodereview.appspot.com/17567007
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/19737005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes MessagePump a non-thread safe class to make sure thread-bound resources (such as the UI window used for pumping messages on Windows) are freed on the correct thread.
Handling of incoming tasks and synchronization between different threads was moved out to a separate class - IncomingTaskQueue reducing the number of locks to be taken while posting a task to one. Posting tasks via both MessageLoop and MessageLoopProxyImpl is now routed via IncomingTaskQueue.
BUG=241939
Review URL: https://chromiumcodereview.appspot.com/17567007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Use Histogram algorithm to calculate DNS timeout.
>
> BUG=110197
>
> Review URL: https://chromiumcodereview.appspot.com/19770014
TBR=szym@chromium.org
Review URL: https://codereview.chromium.org/19886002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
or with failure.
BUG=110197
Review URL: https://chromiumcodereview.appspot.com/19849002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There's no benefit in supporting loopback-only networking on OS_ANDROID.
BUG=260814
Review URL: https://chromiumcodereview.appspot.com/19692002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an uncommon case, currently only done on certain
errors, and complicates logic elsewhere. Since
HostResolverImpl::Jobs have to complete asynchronously
anyways, even in those rare cases, there was no performance
gain.
This is a prerequsite for at least one potential
implementation of simultaneous A/AAAA queries.
BUG=174992
Review URL: https://chromiumcodereview.appspot.com/19776005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=110197
Review URL: https://chromiumcodereview.appspot.com/19814002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=110197
Review URL: https://chromiumcodereview.appspot.com/19770014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since r195406 the probe is not used. It is now safe to remove this code completely.
BUG=260750
Review URL: https://chromiumcodereview.appspot.com/19286002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19614003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=259909
Review URL: https://chromiumcodereview.appspot.com/18796005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I wasn't checking for npos after SkipWhitespace, so any hosts file
ending in whitespace would run the parser into the weeds.
BUG=259909
TEST=added a test case to dns_hosts_unittest.cc
Review URL: https://chromiumcodereview.appspot.com/18734004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211482 0039d316-1c4b-4281-b951-d872f2087c98
|