| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If there is no domain or search in /etc/resolv.conf
res_ninit() will return 0 ("no error") and set RES_INIT but it will
not reset res.dnsearch. Adding a memset to prevent non-UTF8 garbled
domain suffixes from crashing the NetLog.
BUG=115506
TEST=chrome --enable-async-dns # on Linux, and restart network
Review URL: http://codereview.chromium.org/9663048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Go to chrome://net-internals/#events and see HOST_RESOLVER_IMPL_JOB properly nested
R=mmenke@chromium.org
Review URL: http://codereview.chromium.org/9456018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of a bool async.
Review URL: http://codereview.chromium.org/9425016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If started with --enable-async-dns, HostResolverImpl will use
DnsConfigService to determine system DNS configuration and
DnsTransaction to resolve host names. It will fallback to
HostResolverProc on failure.
BUG=90881, 107880, 113829
TEST=./net_unittests --gtest_filter=HostResolverImpl*:Dns*
Review URL: http://codereview.chromium.org/9369045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reject empty string16 early to avoid exception when converting to string.
Default to 53, if port is not set.
Fix CreateAdapterAddresses for the case there is more than one address.
BUG=113692, 113693
TEST=./net_unittest --gtest_filter=DnsConfigService*
Review URL: http://codereview.chromium.org/9384009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implements domain name devolution, search list policy and AppendToMultiLabelName. Also fixes behavior for single-label names with empty search list.
BUG=99510,109902,109949
TEST=./net_unittests --gtest_filter=DnsConfigServiceWin*
Review URL: http://codereview.chromium.org/9232059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found another batch of unit tests that needed their Sleep() and
PostDelayedTask() interfaces updated. As far as I know, this is
the last batch of changes required before the deprecated integer
interfaces to these functions can be removed.
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9316036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9190027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9288034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsClient::Request ==> DnsTransaction
DnsTransaction ==> DnsTransactionImpl
DnsClient ==> DnsTransactionFactory
BUG=109949
TEST=net_unittests --gtest_filter=Dns*
Review URL: http://codereview.chromium.org/9190031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes ref-counting from DelayedSocketData and OrderedSocketData.
- Calls CompleteRead (which reads from underlying data) only if
a Socket::Read call is "blocked" (previously returned with ERR_IO_PENDING).
- Removes unsafe pointers to the handed out sockets (the factory does not own them and cannot guarantee their lifetime).
BUG=110626
TEST=./net_unittests --gtest_filter=Spdy*:Http*:Socket*:WebSocket*:Ftp*
Review URL: http://codereview.chromium.org/9251019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-lands r118489 but with static initializers removed.
BUG=25472, 107880
TEST=net_unittests
R=mmenke
Review URL: http://codereview.chromium.org/9226035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"""
Adds custom ttl argument to HostCache::Set.
BUG=25472,107880
TEST=net_unittests
Review URL: http://codereview.chromium.org/9197009
TBR=szym@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9138039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25472,107880
TEST=net_unittests
Review URL: http://codereview.chromium.org/9197009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110651
TEST=
Review URL: https://chromiumcodereview.appspot.com/9159005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two motivations:
(1) There are currently clients in src/crypto that need the same logic.
(2) There is soon to be a client in src/chrome/common that needs the 64-bit version of this logic, which is currently inlined in a src/crypto implementation file.
BUG=103480
TEST=compiles
Review URL: http://codereview.chromium.org/8949026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They are needed because StringPiece is going to become a template instatiation, and according to the Chromium style-checking Clang plugins, that makes any class with a member StringPiece 'complex'.
See http://codereview.chromium.org/8659047/ for the changes to StringPiece.
R=mmenke@chromium.org
BUG=87634
TEST=
Review URL: http://codereview.chromium.org/9018003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.
BUG=87634
R=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/8929002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=AsyncHostResolver.*
Review URL: http://codereview.chromium.org/8918029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users.
BUG=none
TEST=existing.
Review URL: http://codereview.chromium.org/8824006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsClient provides a generic DNS client that allows fetching resource records.
DnsClient is very lightweight and does not support aggregation, queuing or
prioritization of requests.
This is the first CL in a series to merge AsyncHostResolver into
HostResolverImpl.
Also introduces general-purpose BigEndianReader/Writer.
Removes DnsTransactionTest-related suppressions.
BUG=90881,80225,106688
TEST=./net_unittests
Review URL: http://codereview.chromium.org/8852009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were a few memory issues including access of unadressable memory.
DnsClient provides a generic DNS client that allows fetching resource records.
DnsClient is very lightweight and does not support aggregation, queuing or
prioritization of requests.
This is the first CL in a series to merge AsyncHostResolver into
HostResolverImpl.
Also introduces general-purpose BigEndianReader/Writer.
BUG=90881
TEST=./net_unittests
Review URL: http://codereview.chromium.org/8762001
TBR=szym@chromium.org
Review URL: http://codereview.chromium.org/8835011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsClient provides a generic DNS client that allows fetching resource records.
DnsClient is very lightweight and does not support aggregation, queuing or
prioritization of requests.
This is the first CL in a series to merge AsyncHostResolver into
HostResolverImpl.
Also introduces general-purpose BigEndianReader/Writer.
BUG=90881
TEST=./net_unittests
Review URL: http://codereview.chromium.org/8762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8735014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8429034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8549004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=compiles, ./net_unittests
Review URL: http://codereview.chromium.org/8533011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8525020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net/base/host_resolver_proc.cc:
- define AI_ADDRCONFIG as 0
net/base/listen_socket.cc:
- Shuffle and add missing headers since the order
of including these matters.
net/base/net_util.h:
- Missing header for all POSIX platforms. Needed on
OpenBSD and it won't hurt others.
net/dns/dns_config_service_posix.h:
- Missing header for OpenBSD. The order matters here too
net/dns/dns_config_service_posix.cc:
- Use res_init() on OpenBSD and disable RES_ROTATE
if it is not defined
net/net.gyp:
- Do not use libresolv on OpenBSD since it's not there,
the resolver is in libc.
- Include base/platform_mime_util_linux.cc in the OpenBSD builds.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8336024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new method to hook up AsyncHostResolver to
about:net-internals#dns and to clear DNS cache hooks.
Also fix up DNSTransaction's NetLog logging a little.
R=eroman,cbentzel,szym
BUG=99847
TEST=manual
Review URL: http://codereview.chromium.org/8233013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsConfigServiceWin watches Windows registry for changes and asks IPHelper for effective DNS server addresses. To support group policy, suffix search list is read directly from registry. (Alternative to use WMI is too cumbersome.)
BUG=90881
TEST=./net_unittests --gtest_filter=DnsConfigService*
Review URL: http://codereview.chromium.org/8142013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback.
Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g.
BUG=98719
TEST=none
Review URL: http://codereview.chromium.org/8070013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure.
Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/7879006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix remaining users to use base/memory/scoped_ptr.h.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7930009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cancel()
This addresses flakiness in the unittest.
BUG=96042
TEST=./net_unittests --gtest_filter=WatchingFileReaderTest.FilePathWatcherFailures
Review URL: http://codereview.chromium.org/7867032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=95497
TEST=none
Review URL: http://codereview.chromium.org/7839018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Isolate WatchingFileReader for reusability and testability
- DnsHosts and ParseHosts to parse /etc/hosts
BUG=90881
TEST=./net_unittests --gtest_filter='DnsConfig*:DnsHosts*:WatchingFileReader*'
Review URL: http://codereview.chromium.org/7826010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
original CL w/LGTMs: http://codereview.chromium.org/7812036/
Review URL: http://codereview.chromium.org/7824041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so the original code that created the delayed callback is lost."
This reverts commit 4cf5cf73d319b69c32ad30af8954235755856455. (r99284)
TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/7825026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the original code that created the delayed callback is lost.
This change adds a tracked_objects::Location parameter to the APIs in base/timer.h so we can trace the PostTask callbacks. The other files are touched to add the FROM_HERE Location parameter.
Review URL: http://codereview.chromium.org/7812036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Isolate WatchingFileReader for reusability and testability
- ParseHosts to parse /etc/hosts
- tests
BUG=90881
TEST=./net_unittests --gtest_filter='DnsConfig*:DnsHosts*:WatchingFileReader*'
Review URL: http://codereview.chromium.org/7753027
TBR=szym@chromium.org
Review URL: http://codereview.chromium.org/7829001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Isolate WatchingFileReader for reusability and testability
- ParseHosts to parse /etc/hosts
- tests
BUG=90881
TEST=./net_unittests --gtest_filter='DnsConfig*:DnsHosts*:WatchingFileReader*'
Review URL: http://codereview.chromium.org/7753027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7631042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7677016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7670016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by: Szymon Jakubczak <szym@chromium.org>
BUG=90881
TEST=./net_unittests --gtest_filter="DnsConfigServiceTest*"
Review URL: http://codereview.chromium.org/7518028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7529043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
synchronous resolution.
BUG=90547,60149
TEST=net_unittests
Review URL: http://codereview.chromium.org/7492059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change gets rid of the asymmetry between Resolve() calls that complete synchronously and those that complete asynchronously. Makes code more readable/understandable, allows to embed OnStart/OnFinish/OnCancel calls within the Request::Request()/Request::On{Sync,Async}Complete/Request::~Request() so that we do not miss these inadvertently. As a result of this, I found out that code logic as well as the unit test was not notifying the observer of the cancellation due to object destruction.
BUG=60149
TEST=net_unittests --gtest_filter="AsyncHostResolverTest*"
Review URL: http://codereview.chromium.org/7492028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=60149
TEST=net_unittest --gtest_filter="AsyncHostResolver*"
Review URL: http://codereview.chromium.org/7484012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93644 0039d316-1c4b-4281-b951-d872f2087c98
|