summaryrefslogtreecommitdiffstats
path: root/net/ftp
Commit message (Collapse)AuthorAgeFilesLines
* FTP: work around server bugs resulting in negative file size being sent.phajdan.jr@chromium.org2011-12-202-4/+10
| | | | | | | | BUG=106841 Review URL: http://codereview.chromium.org/8970023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115115 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-192-16/+21
| | | | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944 Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114944 - Standardize StringToInt{,64} interface.battre@chromium.org2011-12-182-21/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | Revert due to compile breakage on ChromeOS. These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/8990002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114945 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-182-16/+21
| | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114944 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114929 - Standardize StringToInt{,64} interface.rsleevi@chromium.org2011-12-172-21/+16
| | | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/8984007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-172-16/+21
| | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114929 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind().ajwong@chromium.org2011-12-094-43/+46
| | | | | | | | | | | This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users. BUG=none TEST=existing. Review URL: http://codereview.chromium.org/8824006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113825 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert HostResolver::Resolve.jhawkins@chromium.org2011-11-161-1/+6
| | | | | | | | | | | BUG=none TEST=none R=willchan@chromium.org Review URL: http://codereview.chromium.org/8549004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110333 0039d316-1c4b-4281-b951-d872f2087c98
* Use AuthCredentials throughout the network stack instead of username/password.cbentzel@chromium.org2011-10-287-75/+71
| | | | | | | | This is a refactor only - no behavior change should happen. Review URL: http://codereview.chromium.org/8340026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107766 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move UnescapeURLComponent() functions into net namespace.tfarina@chromium.org2011-10-021-2/+2
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8109004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103677 0039d316-1c4b-4281-b951-d872f2087c98
* Begin CompletionCallback switchover.willchan@chromium.org2011-10-014-18/+18
| | | | | | | | | | | | | Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback. Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g. BUG=98719 TEST=none Review URL: http://codereview.chromium.org/8070013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix compatibility problem with ftp.comconlink.co.zaphajdan.jr@chromium.org2011-09-281-2/+0
| | | | | | | | | | | | We should also treat transient errors for USER and PASS as requiring auth. Also note very similar issue 25023. BUG=98212 Review URL: http://codereview.chromium.org/8059028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103129 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix compatibility with servers which send 451 responsephajdan.jr@chromium.org2011-09-143-15/+53
| | | | | | | | | | | | | | for CWD command. According to RFC 959 451 is not a valid response code for CWD command, but it is reasonable to handle it in the same way as the 550 response. BUG=96401 Review URL: http://codereview.chromium.org/7889010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101106 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: Cleanup - replace sscanf with more high-level routines.phajdan.jr@chromium.org2011-09-142-24/+46
| | | | | | | | | | | | This allows the error handling to be more precise. Also note https://www.securecoding.cert.org/confluence/display/seccode/INT05-C.+Do+not+use+input+functions+to+convert+character+data+if+they+cannot+handle+all+possible+inputs BUG=none Review URL: http://codereview.chromium.org/7891017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101103 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix navigation to ftp://ftp.emea.ibm.com/toibm/tivoliphajdan.jr@chromium.org2011-09-062-1/+2
| | | | | | | | | | | Recognize a slightly different format of a "Permission denied" error. BUG=95443 TEST=Navigate to ftp://ftp.emea.ibm.com/toibm/tivoli; no error message should appear. Review URL: http://codereview.chromium.org/7795024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99788 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NET_API to NET_EXPORT, and rename NET_TEST to NET_EXPORT_PRIVATE.darin@chromium.org2011-08-1214-28/+29
| | | | | | Review URL: http://codereview.chromium.org/7529043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96560 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: add directory listing parser for OS/2 format.phajdan.jr@chromium.org2011-08-1111-62/+342
| | | | | | | | | BUG=92154 TEST=navigate to ftp://ftp.os4.su/ - no errors should appear Review URL: http://codereview.chromium.org/7590011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96275 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix directory listing parsing for Hylafaxphajdan.jr@chromium.org2011-08-093-5/+12
| | | | | | | | BUG=90807 Review URL: http://codereview.chromium.org/7584018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96073 0039d316-1c4b-4281-b951-d872f2087c98
* Removed wchat_t from Time::FromString.shinyak@google.com2011-08-031-1/+1
| | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unittests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7492063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 94426 - Removed wchat_t from Time::FromString.morrita@chromium.org2011-07-281-1/+1
| | | | | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unitests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7470038 TBR=shinyak@google.com Review URL: http://codereview.chromium.org/7520021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94427 0039d316-1c4b-4281-b951-d872f2087c98
* Removed wchat_t from Time::FromString.shinyak@google.com2011-07-281-1/+1
| | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unitests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7470038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94426 0039d316-1c4b-4281-b951-d872f2087c98
* Remove explicit keyword from multi-argument (w/o default values) constructorsdilmah@chromium.org2011-07-261-2/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7477008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE throughout net/ftp/*eroman@chromium.org2011-07-223-30/+34
| | | | | | Review URL: http://codereview.chromium.org/7483012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93663 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Uninitialized struct members in FtpDirectoryListingEntry.finnur@chromium.org2011-06-122-1/+4
| | | | | | | | | BUG=None TEST=None CID=15968 Review URL: http://codereview.chromium.org/7003118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88787 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit-tests for SingleRequestHostResolver.eroman@chromium.org2011-06-061-0/+1
| | | | | | | | | To facilitate this, moved it out of host_resolver.cc to its own set of files. BUG=84261 Review URL: http://codereview.chromium.org/6993015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88006 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructors should have virtual keyword.hans@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | | | | | Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
* Ftp: Add NET_API for net.dllrvargas@google.com2011-05-1813-22/+37
| | | | | | | | BUG=76997 TEST=NONE Review URL: http://codereview.chromium.org/7013067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85818 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 3.jhawkins@chromium.org2011-05-121-1/+1
| | | | | | | | | | | BUG=82098 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/7016011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: split the directory listing parser test and re-enable it on TSan botsphajdan.jr@chromium.org2011-05-062-142/+185
| | | | | | | | | | | | | | The test was disabled on TSan bots becuase it was taking too much time. This change converts one huge test which parses ~30 directory listings to ~30 separate test cases. This change also moves ToLower/ToUpper from ui/base/l10n_util to base/i18n/case_conversion so that they can be used in net/ftp. BUG=79022 Review URL: http://codereview.chromium.org/6905027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84413 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ClientSocket to StreamSocket.sergeyu@chromium.org2011-05-052-4/+4
| | | | | | | | | BUG=80895 TEST=Compiles Review URL: http://codereview.chromium.org/6930014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84167 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: Fix a compatibility issue with Plan9phajdan.jr@chromium.org2011-05-032-7/+11
| | | | | | | | BUG=80970 TEST=Visit ftp://plan9.bell-labs.com/, the directory listing should be displayed. Review URL: http://codereview.chromium.org/6903166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83869 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r83048 "Removed wchar_t from Time::FromString."maruel@chromium.org2011-04-261-1/+1
| | | | | | | | | | | | This causes regression on KeywordProviderTest.Edit on clang produced executable. TBR=shinyak BUG= TEST= Review URL: http://codereview.chromium.org/6893031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83055 0039d316-1c4b-4281-b951-d872f2087c98
* Removed wchar_t from Time::FromString.shinyak@google.com2011-04-261-1/+1
| | | | | | | | | | | | | Also, some of the test case are moved from pr_time_unittests to time_unittests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/6903022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83048 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: Multiple fixes for localized directory listings:phajdan.jr@chromium.org2011-04-116-55/+121
| | | | | | | | | | | | | | | | | | | | | - fix detection of KOI8-R and possibly other encodings - fix parsing Russian month names When detecting the listing encoding, we need to not only check whether the data can be converted using given encoding, but also whether the result can be parsed as a valid directory listing. Also, we only need to compare the first three characters of the abbreviated month name, because that's how they're abbreviated in FTP directory listings. Finally, the Russian directory listings have swapped the "month" and "day of month" columns. BUG=65917 Review URL: http://codereview.chromium.org/6718043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81081 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix a misuse of isspace (it can only operate on char,phajdan.jr@chromium.org2011-04-091-6/+9
| | | | | | | | | | | | | | | | | | | not char16; this triggers an assertion on Windows, see http://codereview.chromium.org/6802006/ and http://msdn.microsoft.com/en-us/library/y13z34da(v=vs.71).aspx) This change replaces isspace with ICU's u_isspace. The original problem was introduced by http://codereview.chromium.org/449011/ The problem was detected while landing http://codereview.chromium.org/6718043, which adds more tests with non-ASCII characters. BUG=none Review URL: http://codereview.chromium.org/6802012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81037 0039d316-1c4b-4281-b951-d872f2087c98
* Rename a number of classes previously labeled "TCP" to "Transport" inmbelshe@chromium.org2011-04-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | preparation for non-TCP transports. This helps because the alternative is to either use non-TCP protocols (like SCTP) in classes which are called "TCPClientSocketPool", or to clone the code as "SCTPClientSocketPool", both of which are less than ideal. For now, we're just testing transports, so the TransportSocketPool classes will determine a single type of transport and just use them. In the future we'll likely need to figure out how to deal with runtime selection of transports, and probably support use of multiple transports either within the same pools or within subpools. But that is for the future. Note that the histograms have some "tcp" references to them. I didn't change these to "transport" yet, because it will effect existing histograms. Renames include: classes: TCPClientSocketPool -> TransportClientSocketPool MockTCPClientSocketPool -> MockTransportClientSocketPool TCPSocketParams -> TransportSocketParams methods (not the exhaustive list): CreateTCPClientSocket() -> CreateTransportClientSocket() DoTCPConnect() -> DoTransportConnect() BUG=none TEST=none Review URL: http://codereview.chromium.org/6804028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80781 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80587 - FTP: Multiple fixes for localized directory listings:- fix ↵phajdan.jr@chromium.org2011-04-066-121/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | detection of KOI8-R and possibly other encodings- fix parsing Russian month namesWhen detecting the listing encoding, we need to not onlycheck whether the data can be converted using given encoding,but also whether the result can be parsed as a valid directory listing.Also, we only need to compare the first three characters of theabbreviated month name, because that's how they're abbreviatedin FTP directory listings.Finally, the Russian directory listings have swapped the "month" and "day of month" columns.BUG=65917Review URL: http://codereview.chromium.org/6718043 TBR=phajdan.jr@chromium.org Failures (Windows only, both Vista and XP): FtpDirectoryListingBufferTest.Parse: .\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name Actual: L"" Expected: UTF8ToUTF16(name) Which is: L".." Google Test trace: .\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .. .\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[25]: dir-listing-ls-25 .\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name Actual: L"" Expected: UTF8ToUTF16(name) Which is: L".message" Google Test trace: .\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message .\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[25]: dir-listing-ls-25 .\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name Actual: L"" Expected: UTF8ToUTF16(name) Which is: L".." Google Test trace: .\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .. .\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[26]: dir-listing-ls-26 .\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name Actual: L"" Expected: UTF8ToUTF16(name) Which is: L".message" Google Test trace: .\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message .\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[26]: dir-listing-ls-26 .\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name Actual: L"" Expected: UTF8ToUTF16(name) Which is: L".." Google Test trace: .\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .. .\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[27]: dir-listing-ls-27 .\ftp\ftp_directory_listing_parser_unittest.cc(133): error: Value of: entry.name Actual: L"" Expected: UTF8ToUTF16(name) Which is: L".message" Google Test trace: .\ftp\ftp_directory_listing_parser_unittest.cc(112): Filename: .message .\ftp\ftp_directory_listing_parser_unittest.cc(83): Test[27]: dir-listing-ls-27 FtpDirectoryListingParserLsTest.Good: c:\b\build\slave\cr-win-rel\build\src\net/ftp/ftp_directory_listing_parser_unittest.h(47): error: Value of: entry.name Actual: L"" Expected: UTF8ToUTF16(test_case.filename) Which is: L"test" Google Test trace: .\ftp\ftp_directory_listing_parser_ls_unittest.cc(109): Test[21]: -rwxrwxr-x 1 ftp ftp 123 23 май 2011 test c:\b\build\slave\cr-win-rel\build\src\net/ftp/ftp_directory_listing_parser_unittest.h(47): error: Value of: entry.name Actual: L"" Expected: UTF8ToUTF16(test_case.filename) Which is: L"dir" Google Test trace: .\ftp\ftp_directory_listing_parser_ls_unittest.cc(109): Test[22]: drwxrwxr-x 1 ftp ftp 4096 19 окт 2011 dir Review URL: http://codereview.chromium.org/6802006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80590 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: Multiple fixes for localized directory listings:phajdan.jr@chromium.org2011-04-066-55/+121
| | | | | | | | | | | | | | | | | | | | | - fix detection of KOI8-R and possibly other encodings - fix parsing Russian month names When detecting the listing encoding, we need to not only check whether the data can be converted using given encoding, but also whether the result can be parsed as a valid directory listing. Also, we only need to compare the first three characters of the abbreviated month name, because that's how they're abbreviated in FTP directory listings. Finally, the Russian directory listings have swapped the "month" and "day of month" columns. BUG=65917 Review URL: http://codereview.chromium.org/6718043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80587 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: more flexible detection of column offsetphajdan.jr@chromium.org2011-03-292-65/+51
| | | | | | | | | | | | Some "columns" were assumed not to contain spaces. R=wtc@chromium.org,gavinp@chromium.org BUG=76295 Review URL: http://codereview.chromium.org/6725023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79661 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-284-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Clang build after landing http://codereview.chromium.org/6670085/phajdan.jr@chromium.org2011-03-262-0/+5
| | | | | | | | | | TBR=eroman BUG=76171 Review URL: http://codereview.chromium.org/6747024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79491 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: Detect the character encoding only after the entire listing is received.phajdan.jr@chromium.org2011-03-2618-976/+690
| | | | | | | | | | | | | | | | | | | Otherwise the parser could be confused extremely easily. Imagine a listing which has only ASCII characters at the beginning, but after we detect it as ASCII-encoded, some UTF-8 bytes appear. It can be made more complex though, for example the beginning might look like UTF-8, but the entire listing may use a different encoding incompatible with UTF-8 (that was the case here, see bug). This change also simplifies the directory listing parser. When we always have the entire listing when parsing, some complex code can be removed. BUG=76171 TEST=see bug Review URL: http://codereview.chromium.org/6670085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79490 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: use ICU to parse month abbreviations.phajdan.jr@chromium.org2011-03-193-47/+49
| | | | | | | | | | | | | | | In theory we should be able to parse localized listings in more languages now. This also allows us to get rid of hardcoded special cases for German. BUG=65917 TEST=net_unittests Review URL: http://codereview.chromium.org/6697021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78826 0039d316-1c4b-4281-b951-d872f2087c98
* More OOLing on Mac.erg@google.com2011-02-232-5/+19
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6546073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75788 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate the remote socket address to URLRequest and to ↵bryner@chromium.org2011-02-223-2/+21
| | | | | | | | | | | | | | | | ViewHostMsg_FrameNavigate. This will be used to run pre-classification checks for client-side phishing detection, and will also enable the socket address to be exposed via the webRequest extension API. This is adapted from the original patch by pmarks on http://codereview.chromium.org/6369003/ . BUG=51663 TEST=added socket address checks to various unittests Review URL: http://codereview.chromium.org/6488010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75620 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: Compatibility fix for "ls -l" style directory listing parser.phajdan.jr@chromium.org2011-02-163-10/+3
| | | | | | | | | | | | | | | Some servers, for example smallftpd, add an empty line at the end of the listing. We should not fail on those. I think this bug was introduced in 2009 by http://codereview.chromium.org/449011 Now we have more test cases, and this change shouldn't introduce new compatibility problems. BUG=72060 TEST=net_unittests Review URL: http://codereview.chromium.org/6515009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75079 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix directory listing parser when server fails to separate the first ↵phajdan.jr@chromium.org2011-02-012-4/+11
| | | | | | | | | | | two columns. BUG=70394 TEST=net_unittests Review URL: http://codereview.chromium.org/6396005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73261 0039d316-1c4b-4281-b951-d872f2087c98
* More net/ method ordering.erg@google.com2011-01-263-153/+157
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6339012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72710 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS file for net/ftpphajdan.jr@chromium.org2011-01-201-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6265012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71975 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 06:17:09 +0000