summaryrefslogtreecommitdiffstats
path: root/net/ftp
Commit message (Collapse)AuthorAgeFilesLines
* Update code that previously constructed strings from string iterators only ↵erikwright@chromium.org2010-10-223-10/+26
| | | | | | | | | | to use StringToInt. These usages now pass the iterators directly to the new StringToInt overloads. BUG=None TEST=All Review URL: http://codereview.chromium.org/3968001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63515 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Monster ctor patch after changing heuristics in clang plugin.erg@google.com2010-10-1816-20/+64
| | | | | | | | | | | (Only 916k this time off Debug Linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3814013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62967 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: make file downloads work when directory listing is restrictedphajdan.jr@chromium.org2010-10-152-34/+65
| | | | | | | | | BUG=56734 TEST=see bug Review URL: http://codereview.chromium.org/3775005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62714 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FTP directory listing for ftp.cisco.com.phajdan.jr@chromium.org2010-10-143-2/+16
| | | | | | | | | BUG=58963 TEST=net_unittests Review URL: http://codereview.chromium.org/3774002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62515 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-142-2/+2
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-146-17/+17
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* Stop refcounting HostResolver.willchan@chromium.org2010-10-012-3/+3
| | | | | | | | | BUG=46049 TEST=none Review URL: http://codereview.chromium.org/3601002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61256 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to ↵erg@google.com2010-09-302-7/+18
| | | | | | | | | | | | | | non-POD structs. Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on a whole bunch of virtual dtors that were missing it. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3522004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix directory listing parser for ftp.usa.hp.comphajdan.jr@chromium.org2010-09-3011-36/+185
| | | | | | | | | BUG=56547 TEST=net_unittests Review URL: http://codereview.chromium.org/3448029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61052 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61034 - Refactor FTP unit tests.phajdan.jr@chromium.org2010-09-301-530/+741
| | | | | | | | | | | | | | This is needed to write a fix for the bug below. BUG=56734 TEST=changing tests, and only tests (net_unittests) Review URL: http://codereview.chromium.org/3412039 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3537007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61040 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FTP unit tests.phajdan.jr@chromium.org2010-09-301-741/+530
| | | | | | | | | | | This is needed to write a fix for the bug below. BUG=56734 TEST=changing tests, and only tests (net_unittests) Review URL: http://codereview.chromium.org/3412039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61034 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60765 - FTP: fix directory listing parser for ftp.usa.hp.comphajdan.jr@chromium.org2010-09-2810-172/+8
| | | | | | | | | | | BUG=56547 TEST=net_unittests Review URL: http://codereview.chromium.org/3448029 TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60766 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix directory listing parser for ftp.usa.hp.comphajdan.jr@chromium.org2010-09-2810-8/+172
| | | | | | | | | BUG=56547 TEST=net_unittests Review URL: http://codereview.chromium.org/3448029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60765 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix directory listing parser for ftp.symantec.com.phajdan.jr@chromium.org2010-09-282-3/+8
| | | | | | | | | | | | Some servers do not send the symlink target that we were expecting, possibly for security reasons. BUG=56972 TEST=net_unittests Review URL: http://codereview.chromium.org/3416028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60763 0039d316-1c4b-4281-b951-d872f2087c98
* net: Append base:: in the StringPrintf calls.tfarina@chromium.org2010-09-257-19/+30
| | | | | | | | | | | (Note: This is a TODO in string_util.h) BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3390026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60555 0039d316-1c4b-4281-b951-d872f2087c98
* base: Finish moving the SplitString functions from string_util.h to ↵tfarina@chromium.org2010-09-246-8/+14
| | | | | | | | | | | string_split.h BUG=None TEST=trybos Review URL: http://codereview.chromium.org/3447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
* Change HostResolver::RequestInfo to take a HostPortPair rather than naked ↵eroman@chromium.org2010-09-151-7/+1
| | | | | | | | host string + port. Review URL: http://codereview.chromium.org/3420001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59577 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix parsing error on ftp.dell.comphajdan.jr@chromium.org2010-09-142-8/+20
| | | | | | | | | | | | | The problem was the date parser not recognizing time strings like H:MM as valid. Additionally, make sure the message about the error is visible. BUG=54395 TEST=visit ftp.dell.com, you should see a non-empty directory listing Review URL: http://codereview.chromium.org/3327025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59404 0039d316-1c4b-4281-b951-d872f2087c98
* In about:net-internals, each SOCKET created by a CONNECT_JOB holds a ↵mmenke@chromium.org2010-08-251-2/+2
| | | | | | | | | | | reference to the CONNECT_JOB that spawned it. BUG=47082 TEST=manual Review URL: http://codereview.chromium.org/3164005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57339 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obviously unneeded forward declarations from headers under ↵viettrungluu@chromium.org2010-08-211-1/+0
| | | | | | | | | | | src/{app,base,net}. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3136025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56995 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unnecessary STL #includes from src/net.viettrungluu@chromium.org2010-08-191-2/+0
| | | | | | | | | | | | This removes obviously unneeded inclusions of <map>, <set>, <string>, <vector>, etc. from src/net. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3132022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56654 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-034-1/+4
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad license header in app/ and net/ directories.tfarina@chromium.org2010-07-3114-46/+45
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3013049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54482 0039d316-1c4b-4281-b951-d872f2087c98
* Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found itbrettw@chromium.org2010-07-312-6/+8
| | | | | | | | | | | | | | | | | | | | | | | weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in string_util.h. This should help some dependencies since string_util changes much more frequently than utf_string_conversions and fewer files will now need string_utils. Since this requires a lot of changes, this keeps a forward-declaration in string_util so I can update the entire project incrementally. This change updates base and net only. I removed some includes of string_util from header files in net. In particular, url_request_context which involved creating a new .cc file to implement a function (already virtual so there's no speed penalty). It turns out a lot of files were getting string_util from this include, so I had to update a bunch of random files to now explicitly include string_util.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3076013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54456 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-319-38/+49
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-4/+7
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Net: Convert username and password to string16.thestig@chromium.org2010-07-297-67/+86
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3040016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54101 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit r53882 "FTP: fix navigation to systems with broken EPSV support."i"jeremy@chromium.org2010-07-281-0/+15
| | | | | | | | Original revert was an attempt to diagnose a build bustage, but this wasn't the cause. Review URL: http://codereview.chromium.org/3012028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53931 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "FTP: fix navigation to systems with broken EPSV support."ijeremy@chromium.org2010-07-281-15/+0
| | | | | | | | | | XP Perf test regression diagnostic - http://build.chromium.org/buildbot/waterfall/builders/XP%20Perf%20(1)/builds/9081 This reverts commit r53882. Review URL: http://codereview.chromium.org/2884043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53925 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix navigation to systems with broken EPSV support.phajdan.jr@chromium.org2010-07-281-0/+15
| | | | | | | | | | | | | Added error code check in DoDataConnectComplete, which falls back to PASV if the connection with EPSV has timed out, and stops the transaction in case of any other error. BUG=48285 TEST=navigate to ftp.apc.com, it should succeed and display a directory listing Review URL: http://codereview.chromium.org/3033028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53882 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: minor cleanups to the unit tests:phajdan.jr@chromium.org2010-07-271-6/+33
| | | | | | | | | | | | | | - remove obsolete workaround for us opening two data connections, we no longer do this - add comments explaining the 599 FTP error code BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3057012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53806 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug with parsing ftp directory listing lines.michaeln@chromium.org2010-07-272-3/+21
| | | | | | | | | BUG=49997 TEST=ftp_directory_listing_parser_windows_unittest.cc Review URL: http://codereview.chromium.org/3013029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53747 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2619-0/+19
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: add more detailed error codes based on RFC 959.phajdan.jr@chromium.org2010-07-153-104/+122
| | | | | | | | | | | This does not handle all cases yet, for simplicity. TEST=net_unittests BUG=none Review URL: http://codereview.chromium.org/2985012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52495 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up FTP code a bit:phajdan.jr@chromium.org2010-07-143-78/+12
| | | | | | | | | | | | | | - remove unneeded states - minor style and error handling improvements This change removes ACCT command support. It was really untested, and I think it wouldn't work in case it was needed. We may add it back when we get a good test case. However, people are unlikely to use a web browser to access servers that require usage of ACCT command. TEST=net_unittests BUG=none Review URL: http://codereview.chromium.org/2985004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52266 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: change order of commands to improve compatibilityphajdan.jr@chromium.org2010-07-083-199/+51
| | | | | | | | | | | | | | | | It turns out some FTP servers react strangely to a RETR for an unexistent file. They send a success reponse followed by a failure response. The solution is to move the file/directory sniffing logic from RETR earlier, to SIZE. BUG=44582 TEST=net_unittests Review URL: http://codereview.chromium.org/2813044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51866 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a renderer crash while processing FTP directory listing.phajdan.jr@chromium.org2010-06-262-1/+2
| | | | | | | | | | | | | | | | | The problem was caused by a broken assumption about current_parser_. After adding OnEndOfInput to FtpDirectoryListingParser interface, it was possible that during processing of input we ended up with just one parser, which returned error when OnEndOfInput was called. In that case, we should just reset current_parser_ to NULL to avoid a use-after-free error. TEST=net_unittests BUG=47528 Review URL: http://codereview.chromium.org/2846037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50930 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: Fix an infinite loop in a rare condition.phajdan.jr@chromium.org2010-05-152-13/+15
| | | | | | | | | | | | | After issuing the PASS command, we should never issue earlier commands again. The code was sending USER when it received "503 Bad command sequence" error code. TEST=added to net_unittests BUG=38707 Review URL: http://codereview.chromium.org/2094002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47364 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix navigating to files listed under non-ASCII charactersphajdan.jr@chromium.org2010-05-112-29/+7
| | | | | | | | | | | We need to convert the file name back to server encoding. BUG=38016 TEST=see bug Review URL: http://codereview.chromium.org/1857002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46900 0039d316-1c4b-4281-b951-d872f2087c98
* Pass nulls through test sockets.gavinp@chromium.org2010-05-101-9/+29
| | | | | | | | | | | | | Fixing 35050, one of the tests I wrote for EPSV required NULS go through the testing framework. That created issue 42432 which covers permitting NULs through our socket tests. I added an interface to SimulateRead which passes in an explicit length, and moved as much of that into ftp_network_transaction_unittest as possible. BUG=42432 TEST=see the modified Epsv test in ftp_network_transaction_unittest.cc Review URL: http://codereview.chromium.org/1949003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46813 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove the implicit constructor for BoundNetLog that allowed ↵eroman@chromium.org2010-04-281-5/+5
| | | | | | | | | passing NULL in place of a const BoundNetLog&. BUG=37421 Review URL: http://codereview.chromium.org/1783008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45851 0039d316-1c4b-4281-b951-d872f2087c98
* Add net log entries that summarize transmit and receive byte counts.vandebo@chromium.org2010-04-231-4/+6
| | | | | | | | | | | | | | | | | | | | | Tx/Rx summaries are integrated into the net log at the last point that bytes were transmitted or received. Hopefully this will help resolve http://crbug.com/37729 by showing if we've received bytes over the network when we hit the "Waiting for cache" bug. This change also modernizes the use of NetLog: - ClientSocket now has a net_log() accessor - ClientSocket::Connect no longer takes a NetLog, instead the TCPClientSocket constructor takes one, others use their transport socket's NetLog - TCPClientSocket creates a new source id with source type SOCKET Also updates PassiveLogCollector infrastructure: - The LiveRequestsObserver lets a RequestTracker update a RequestInfo just before it is displayed. This allows ConnectJobs to be associated with URLRequests while connecting and then reassociated if they are late-bound to a different request. BUG=37729 TEST=tx/rx lines show up in chrome://net-internals/ Review URL: http://codereview.chromium.org/1696005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45449 0039d316-1c4b-4281-b951-d872f2087c98
* Modify FTP to implement EPSV per RFC 2428. EPSV is an extended versioncbentzel@chromium.org2010-04-123-64/+325
| | | | | | | | | | | | | | | of PASV, intended specifically to address IPv6 compatibility in FTP. With this change, we now always prefer EPSV over PASV, however our FTP client will fall back to PASV in the case that a remote host does not support EPSV. Contributed by: gavinp@google.com BUG=35050 TEST=ftp to an ipv6 site like ftp.netbsd.org and retrieve data Review URL: http://codereview.chromium.org/1600017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44262 0039d316-1c4b-4281-b951-d872f2087c98
* Fix out of array bounds access in VMSPathToUnix function.inferno@chromium.org2010-04-082-1/+2
| | | | | | | | | BUG=40801 TEST=FtpUtilTest.VMSPathToUnix Review URL: http://codereview.chromium.org/1566029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43961 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to strip the brackets around IPv6 literals when resolving the ↵eroman@chromium.org2010-04-072-1/+16
| | | | | | | | | | | hostname for FTP. BUG=39830 (comment #9) TEST=FtpNetworkTransactionTest.StripBracketsFromIPv6Literals Review URL: http://codereview.chromium.org/1585022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43888 0039d316-1c4b-4281-b951-d872f2087c98
* Respect typecode in the FTP network transaction.phajdan.jr@chromium.org2010-03-243-19/+145
| | | | | | | | | | | See RFC 1738. BUG=31819 TEST=net_unittests Review URL: http://codereview.chromium.org/1170003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the "ls -l" style date parser to correctly guess the year if it is not ↵phajdan.jr@chromium.org2010-03-2412-55/+106
| | | | | | | | | | | | | provided. Also provide an infrastructure to mock the current time in the tests. BUG=36293 TEST=net_unittests Review URL: http://codereview.chromium.org/1120012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42447 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test to check for zero length dir in FTP PWD response. inferno@chromium.org2010-03-221-0/+11
| | | | | | | | BUG=38845 TEST=FtpNetworkTransactionTest.ZeroLengthDirInPWD Review URL: http://codereview.chromium.org/1166001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42238 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the out-of-bounds array read in the ftp response.inferno@chromium.org2010-03-221-1/+1
| | | | | | | | BUG=38845 TEST=Pass a ftp server response having two double quotes with no character in between and verify no browser crash happens. Review URL: http://codereview.chromium.org/1082008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42204 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize the net module's LoadLog facility from a passive container, to an ↵eroman@chromium.org2010-03-163-11/+12
| | | | | | | | | | | | | | | | event stream (NetLog). This makes it possible to associate a single NetLog with a URLRequestContext, and then attach observers to that log to watch the stream of events. This changelist attempts to do the most direct translation, so there will be subsequent iterations to clean up. The user-visible behavior should remain unchanged. BUG=37421 Review URL: http://codereview.chromium.org/848006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41689 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 13:40:20 +0000