| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All other UAs don't treat the name value as a synonym. Drop support
from Chrome.
UMA metrics indicate 0.00% actually only contain the "name" attribute.
0.01% of requests had with a name attribute; but had higher preference
values as well. This feature isn't clearly used anymore.
BUG=162815
TEST=net_unittests
Review URL: https://codereview.chromium.org/1107913003
Cr-Commit-Position: refs/heads/master@{#327708}
|
|
|
|
|
|
|
|
| |
BUG=162815
Review URL: https://chromiumcodereview.appspot.com/11478034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Content-Disposition
Now that we have net::HttpContentDisposition to parse the Content-Disposition
header, BufferedResourceHandler::ShouldDownload shouldn't use its own ad-hoc
parser.
Review URL: http://codereview.chromium.org/9297039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We pass the vast majority of these tests. In a future CL, I will go through
and fix the ones where we disagree with tc2231 (as appropriate).
Review URL: https://chromiumcodereview.appspot.com/9121044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Previous, we were using GetHeaderParamValue to parse the Content-Disposition
header, which describes itself as a "quick and dirty implementation." After
this patch, we use more of our normal HTTP parsing machinery, making our
parsing much less quirky and better aligned with RFC 6266.
Some notes:
1) Many of the test cases for parsing the Content-Disposition header included
the string "Content-Disposition: " in the input. I've looked through all
of the callers of these functions, and that seems to be completely bogus.
The old parser wasn't careful enough to see that as a problem, but the new
one follows the spec more closely. I've updated the test cases to remove
this string.
2) After this patch, there's a bunch of code in net_util.cc that really should
be moved to http_content_disposition.cc. I didn't move that code in this
patch because I didn't want this path to be too large. I'll move it in a
future patch.
3) In a future patch, I'll audit the codebase for callers of
GetHeaderParamValue. With any luck, we'll be able to remove them all and
delete this less-than-amazing function.
BUG=65423
Review URL: http://codereview.chromium.org/9234055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119378 0039d316-1c4b-4281-b951-d872f2087c98
|