| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpResponseInfo contains a "network_accessed" flag that is currently
set when HttpNetworkTransaction finishes sending the request. This is
not entirely accurate; it ends up false for requests that don't send a
request but do touch the network in other ways (e.g. DNS resolution
fails, or TCP connection is terminated before we finish sending the
request).
This flag is used only by Domain Reliability for checking whether a
request touched the network, and by ServiceWorker for histograms.
horo says ServiceWorker won't be affected, and I would prefer these
semantics for Domain Reliability's use, so I'm changing it.
Note that this also changes several instances of GetResponseInfo
to stop returning NULL.
See also for context:
https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/Wtn65jGyot0
BUG=480565
Review URL: https://codereview.chromium.org/1072423005
Cr-Commit-Position: refs/heads/master@{#330011}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpNetworkTransaction.
Log connection attempts in {Transport,SSL}ConnectJob and copy them into the ClientSocketHandle. Form there, copy them up the stack through the HttpStreamRequest (on job completion) to the HttpNetworkTransaction (on stream creation or failure).
SPDY is covered by this change -- sockets for new SPDY sessions are connected on the same path as sockets for HTTP connections, and then passed off to the SPDY code.
QUIC is not covered by this change -- sockets for new QUIC sessions are created in the QUIC code, and Chrome's current QUIC behavior does not let us see those results easily. My current plan is to log those *in* the QUIC code and then grab them on the next request that would use that QUIC session. I still need to see if this is actually practical.
BUG=480565
Review URL: https://codereview.chromium.org/1006643002
Cr-Commit-Position: refs/heads/master@{#327298}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed because the higher layers, e.g., UrlRequestHttpJob
do not always have a pointer to the request headers that the
HttpNetworkTransaction will actually send. Note that the old code
could also pass the wrong headers if redirects resulted in no longer
going through the proxy.
BUG=345907
Review URL: https://codereview.chromium.org/360113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=345907, 367268
Review URL: https://codereview.chromium.org/333113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=wtc@chromium.org, rvargas@chromium.org
Review URL: https://codereview.chromium.org/143073006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disk_cache_based_quic_server_info.*.
Renamed ssl_host_info.* to quic_server_info.*.
Deleted all SSLConfig and CertVerifier related code.
Replaced them with QuicCryptoClientConfig::CachedState.
Will fill out the details in quic_server_info (persist/restore code) in the next CL.
R=wtc@chromium.org
Review URL: https://codereview.chromium.org/140823019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented DiskCacheBasedSSLHostInfo which fetches information about an SSL host from our standard disk cache. Since the information is defined to be non-sensitive, it's ok for us to keep it on disk.
SSLHostInfo persists/restores server's certificates. Certificates is a vector of DER encoded X.509 certificates, as the server returned them and in the same order.
These changes are the frame work. This code is not enabled to store any data to disk cache.
R=wtc@chromium.org
Review URL: https://codereview.chromium.org/135373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DoCreateStream time in the HttpNetworkTransaction. This hook allows
for experimentation with the ResourceScheduler so that it can defer
after first checking the cache, gathering the cookies, and starting
the WebRequest but before going to the network.
BUG=328741
Review URL: https://codereview.chromium.org/122453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111052
Review URL: https://codereview.chromium.org/99723004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base class so that
URLRequestHttpJob can pass through the WebSocketHandshakeStreamBase::Factory object.
Implement OnWebSocketHandshakeStreamReady().
BUG=315027
TEST=net_unittests
Review URL: https://codereview.chromium.org/23856018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a redirect is deferred in the warm cache case, the HTTP transaction
currently doesn't release the cache entry until after the redirect continues.
This prevents other requests from accessing the cache entry.
Reuse the DoneReading() signal for the URLRequestJob to notify the transaction
that the response body is to be discarded. This matches the redirect-specific
logic in HttpCache::Transaction which does not cache redirect bodies.
In addition, now that this signal exists at a higher level, remove that logic
in HttpCache::Transaction. It is now the caller's job to decide which response
bodies are and aren't truncated away.
Fixup and add new tests for this behavior.
BUG=292879
TEST=HttpCache.CachedRedirect,
HttpCache.DoneReading,
URLRequestJob.RedirectTransactionNotifiedWhenDone
Review URL: https://chromiumcodereview.appspot.com/23710059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dev Tools displays the raw request and response headers. Right now, it gets
them by snarfing them out of the NetLog, which is bad, as the NetLog is for
huamn consumption only. I'm trying to refactor the DevToolsNetLogObserver
away; providing an alternate, supported path to get the request headers is the
first step.
BUG=196304
TEST=added to URLRequest, HttpTransaction, and HttpNetworkTransaction unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199535
Review URL: https://chromiumcodereview.appspot.com/12621011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the request went over the wire before headers were returned,
return information about the last over the wire request. Otherwise,
set send times to be when the cache entry was opened, and
receive_header_start to be when the headers were read.
BUG=239842
Review URL: https://chromiumcodereview.appspot.com/14625012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add GetFullRequestHeaders, from URLRequestJob to HttpNetworkTransaction.
>
> Dev Tools displays the raw request and response headers. Right now, it gets
> them by snarfing them out of the NetLog, which is bad, as the NetLog is for
> huamn consumption only. I'm trying to refactor the DevToolsNetLogObserver
> away; providing an alternate, supported path to get the request headers is the
> first step.
>
> BUG=196304
> TEST=added to URLRequest, HttpTransaction, and HttpNetworkTransaction unittests
>
> Review URL: https://chromiumcodereview.appspot.com/12621011
TBR=ttuttle@chromium.org
Review URL: https://codereview.chromium.org/15054003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dev Tools displays the raw request and response headers. Right now, it gets
them by snarfing them out of the NetLog, which is bad, as the NetLog is for
huamn consumption only. I'm trying to refactor the DevToolsNetLogObserver
away; providing an alternate, supported path to get the request headers is the
first step.
BUG=196304
TEST=added to URLRequest, HttpTransaction, and HttpNetworkTransaction unittests
Review URL: https://chromiumcodereview.appspot.com/12621011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for propagating priority changes from
ResourceScheduler all the way to HostResolver and ClientSocketPool.
Add some NetLog events and parameters for priority.
BUG=166689
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189829
Review URL: https://codereview.chromium.org/12701011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See heapcheck failures:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/25563
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/25563/steps/heapcheck%20test%3A%20net/logs/stdio
Example (one of many):
Leak of 792 bytes in 1 objects allocated from:
@ 10d675b URLRequestFtpJobPriorityTest
@ 10d68e7 URLRequestFtpJobPriorityTest_SetPriorityBasic_Test
@ 10de383 CreateTest
Suppression (error hash=#0A68FF60C5D043B8#):
{
<insert_a_suppression_name_here>
Heapcheck:Leak
fun:URLRequestFtpJobPriorityTest
fun:URLRequestFtpJobPriorityTest_SetPriorityBasic_Test
fun:CreateTest
}
> [Net] Propagate priority changes from URLRequest to HttpTransaction
>
> This is in preparation for propagating priority changes from
> ResourceScheduler all the way to HostResolver and ClientSocketPool.
>
> Add some NetLog events and parameters for priority.
>
> BUG=166689
> TBR=simonjam@chromium.org,sky@chromium.org
>
> Review URL: https://codereview.chromium.org/12701011
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/12676022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for propagating priority changes from
ResourceScheduler all the way to HostResolver and ClientSocketPool.
Add some NetLog events and parameters for priority.
BUG=166689
TBR=simonjam@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/12701011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add send and receive times to HttpNetworkTransaction.
Add LoadTimingInfo accessors to Http*Transaction,
URLRequestJob, and URLRequest classes.
Proxy resolution times still need to be added.
BUG=77446
Review URL: https://chromiumcodereview.appspot.com/11929017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpTransaction::GetUploadProgress()
Add net::UploadProgress
Change return type of GetUploadSize() from uint64 to UploadProgress.
BUG=112607
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10834178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=105208
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8990001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is a refactor only - no behavior change should happen.
Review URL: http://codereview.chromium.org/8340026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback.
Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g.
BUG=98719
TEST=none
Review URL: http://codereview.chromium.org/8070013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
completing the request (returning 0 bytes from a read).
BUG=91898
TEST=net_unittests
Review URL: http://codereview.chromium.org/7569027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7529043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76997
TEST=NONE
Review URL: http://codereview.chromium.org/6969080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No effective code change.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/3728002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds --enable-snap-start to enable an experimental zero round
trip TLS handshake. Use of this option disables certificate checking.
TEST=it's complicated
BUG=none
Review URL: http://codereview.chromium.org/3557013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3040016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22588
Review URL: http://codereview.chromium.org/1604011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
event stream (NetLog).
This makes it possible to associate a single NetLog with a URLRequestContext, and then attach observers to that log to watch the stream of events.
This changelist attempts to do the most direct translation, so there will be subsequent iterations to clean up.
The user-visible behavior should remain unchanged.
BUG=37421
Review URL: http://codereview.chromium.org/848006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the ability to stop caching a given request.
BUG=32406, 22900
TEST=none
Review URL: http://codereview.chromium.org/600167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
towards redoing the Callback interfaces.
Added and removed includes as needed.
BUG=35223
TEST=trybots
Review URL: http://codereview.chromium.org/646061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and proyxservice.This dependency comes from the parent URLRequest, and is used as a container for per-request profiling data.This change is strictly a no-op refactor -- the parameter is unused, and LoadLog does nothing.BUG=http://crbug.com/14478TEST=none -- just needs to compile and pass existing tests.DESIGN=<http://docs.google.com/Doc?id=dfhcnb2v_21gbtrcpr3&hl=en>
Review URL: http://codereview.chromium.org/126303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See the changes to url_request.h and ssl_cert_request_info.h.
They are similar to the methods for handling SSL certificate
errors and HTTP authentication.
The handling of servers that request but don't require SSL
client authentication is reimplemented using the new methods.
R=rvargas,eroman
BUG=http://crbug.com/318
TEST=none
Review URL: http://codereview.chromium.org/118039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two parts to this change:
(1) rebuild the request cookies before each transaction restart for
authentication
(2) notify the URLRequestHttpJob of header completion before *each*
transaction restart for authentication
By "each transaction" I mean the automatic restarts that don't require
user input, such as:
- replying to the first step of NTLM
- selecting identity embedded in URL
- selecting identity in auth-cache
Needing to notify URLRequestHttpJob for these intermediate restarts is
a consequence of cookie store management being done outside of
HttpNetworkTransaction.
After updating the cookie store, URLRequestHttpJob now tests
|HttpTransaction::IsReadyToRestartForAuth()| to check whether the
notification was informational or an identity is actually needed.
R=wtc
BUG=6450
Review URL: http://codereview.chromium.org/51004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in net/. All files end in a single newline.
Review URL: http://codereview.chromium.org/43079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is cleanup from bug 5325.
Original code review: http://codereview.chromium.org/20134/show
Review URL: http://codereview.chromium.org/20251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is cleanup from bug 5325.
Review URL: http://codereview.chromium.org/20134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will re-land http://codereview.chromium.org/18390
BUG=5325
Review URL: http://codereview.chromium.org/19004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18576
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325
Review URL: http://codereview.chromium.org/18390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scoped_ptr<>.
Review URL: http://codereview.chromium.org/7532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1076 0039d316-1c4b-4281-b951-d872f2087c98
|