summaryrefslogtreecommitdiffstats
path: root/net/http/http_transaction_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Rename http_transaction_unittest to http_transaction_test_util.eustas@chromium.org2014-05-141-503/+0
| | | | | | | | | | | | And move it to test support target. Actually this file contains only utilities for tests, but not tests themselves. BUG=245436 Review URL: https://codereview.chromium.org/280763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270354 0039d316-1c4b-4281-b951-d872f2087c98
* net: Avoid recursion in URLRequestJob::ReadFilteredData.rvargas@chromium.org2014-05-031-0/+2
| | | | | | | | | | | | | | | | There's no need to use recursion when getting the data from a filter. This version uses a loop instead. The issue with recursion is that it opens the door to stack exhaustion if there is no way to limit its depth. In this case, that would be a hard thing to do given that it basically depends on interactions outside of our control. BUG=366149 Review URL: https://codereview.chromium.org/267793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268030 0039d316-1c4b-4281-b951-d872f2087c98
* Don't cache non-redirect HTTP responses when a redirect is forcedmmenke@chromium.org2014-03-241-1/+9
| | | | | | | | | | | | | | by a NetworkDelegate in OnHeadersReceived. This regressed in https://chromiumcodereview.appspot.com/23710059. Fortunately, no NetworkDelegate currently does this, but that is going to change. BUG=354508 Review URL: https://codereview.chromium.org/208683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258983 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup of SetQuicServerInfo.rtenneti@chromium.org2014-01-251-0/+3
| | | | | | | | R=wtc@chromium.org, rvargas@chromium.org Review URL: https://codereview.chromium.org/143073006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247095 0039d316-1c4b-4281-b951-d872f2087c98
* Allows deferral of a URLRequest just before talking to the network, atjkarlin@chromium.org2014-01-081-0/+9
| | | | | | | | | | | | | DoCreateStream time in the HttpNetworkTransaction. This hook allows for experimentation with the ResourceScheduler so that it can defer after first checking the cache, gathering the cookies, and starting the WebRequest but before going to the network. BUG=328741 Review URL: https://codereview.chromium.org/122453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243568 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Attempt to authenticate requests that originate in the cache.rvargas@chromium.org2014-01-041-49/+74
| | | | | | | | | | | | | | | | | | | The cache can decompose some requests and issue a variable number of network request for a single user-generated request. When network authentication is part of the picture, we may receive authentication failures after completing Start() processing for the "main" request, so doing regular auth is not an option (going to the caller to select credentials etc). This CL attempts automatic authentication for the extra requests, and improves error handling so that when everything else fails the partially cached content is removed from the cache. BUG=316602 R=wtc@chromium.org Review URL: https://codereview.chromium.org/102113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242972 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HttpTransactionDelegate and all users (LoadTimeStats).rvargas@chromium.org2013-12-271-3/+2
| | | | | | | | | | | | | These metrics are not used anymore. TEST=builds BUG= TBR=mkosiba@chromium.org (webview) Review URL: https://codereview.chromium.org/121453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242643 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GetTotalReceivedBytes for http transaction.eustas@chromium.org2013-12-241-0/+6
| | | | | | | | BUG=111052 Review URL: https://codereview.chromium.org/99723004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242433 0039d316-1c4b-4281-b951-d872f2087c98
* Add a SetWebSocketHandshakeStreamFactory() method to the HttpTransaction ↵ricea@chromium.org2013-11-141-0/+6
| | | | | | | | | | | | | | | base class so that URLRequestHttpJob can pass through the WebSocketHandshakeStreamBase::Factory object. Implement OnWebSocketHandshakeStreamReady(). BUG=315027 TEST=net_unittests Review URL: https://codereview.chromium.org/23856018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235016 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in net/, part 2.avi@chromium.org2013-07-181-1/+1
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19625002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212241 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in net/, part 2.avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18054010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209150 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetFullRequestHeaders, from URLRequestJob to HttpNetworkTransaction.ttuttle@chromium.org2013-06-201-0/+5
| | | | | | | | | | | | | | | | | Dev Tools displays the raw request and response headers. Right now, it gets them by snarfing them out of the NetLog, which is bad, as the NetLog is for huamn consumption only. I'm trying to refactor the DevToolsNetLogObserver away; providing an alternate, supported path to get the request headers is the first step. BUG=196304 TEST=added to URLRequest, HttpTransaction, and HttpNetworkTransaction unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199535 Review URL: https://chromiumcodereview.appspot.com/12621011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207341 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_ptr<T>(NULL) to use the default ctor in net/.dcheng@chromium.org2013-06-121-3/+1
| | | | | | | | | | | This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the net/ directory. BUG=173286 Review URL: https://chromiumcodereview.appspot.com/16434016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205961 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in net/http/.avi@chromium.org2013-06-111-2/+2
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15906017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205594 0039d316-1c4b-4281-b951-d872f2087c98
* Update net/ to use WeakPtr<T>::get() instead of implicit "operator T*"akalin@chromium.org2013-06-021-1/+1
| | | | | | | | BUG=245942 Review URL: https://chromiumcodereview.appspot.com/15881011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203633 0039d316-1c4b-4281-b951-d872f2087c98
* Update net/ to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-011-3/+4
| | | | | | | | | | | Linux fixes BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/15829004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203535 0039d316-1c4b-4281-b951-d872f2087c98
* net: Use base::MessageLoop.xhwang@chromium.org2013-05-231-2/+2
| | | | | | | | | BUG=236029 R=agl@chromium.org Review URL: https://chromiumcodereview.appspot.com/14021017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201882 0039d316-1c4b-4281-b951-d872f2087c98
* net: Return LoadTiming information in the case of a cache hit.mmenke@chromium.org2013-05-151-3/+26
| | | | | | | | | | | | | If the request went over the wire before headers were returned, return information about the last over the wire request. Otherwise, set send times to be when the cache entry was opened, and receive_header_start to be when the headers were read. BUG=239842 Review URL: https://chromiumcodereview.appspot.com/14625012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200356 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 199535 "Add GetFullRequestHeaders, from URLRequestJob to ..."ttuttle@chromium.org2013-05-101-5/+0
| | | | | | | | | | | | | | | | | | | | | > Add GetFullRequestHeaders, from URLRequestJob to HttpNetworkTransaction. > > Dev Tools displays the raw request and response headers. Right now, it gets > them by snarfing them out of the NetLog, which is bad, as the NetLog is for > huamn consumption only. I'm trying to refactor the DevToolsNetLogObserver > away; providing an alternate, supported path to get the request headers is the > first step. > > BUG=196304 > TEST=added to URLRequest, HttpTransaction, and HttpNetworkTransaction unittests > > Review URL: https://chromiumcodereview.appspot.com/12621011 TBR=ttuttle@chromium.org Review URL: https://codereview.chromium.org/15054003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199553 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetFullRequestHeaders, from URLRequestJob to HttpNetworkTransaction.ttuttle@chromium.org2013-05-101-0/+5
| | | | | | | | | | | | | | | Dev Tools displays the raw request and response headers. Right now, it gets them by snarfing them out of the NetLog, which is bad, as the NetLog is for huamn consumption only. I'm trying to refactor the DevToolsNetLogObserver away; providing an alternate, supported path to get the request headers is the first step. BUG=196304 TEST=added to URLRequest, HttpTransaction, and HttpNetworkTransaction unittests Review URL: https://chromiumcodereview.appspot.com/12621011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199535 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.scherkus@chromium.org2013-04-301-1/+1
| | | | | | | | | | | It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details. BUG=234765 R=rch@chromium.org Review URL: https://codereview.chromium.org/14113037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197200 0039d316-1c4b-4281-b951-d872f2087c98
* Implement offline mode behind a flag.rdsmith@chromium.org2013-04-201-0/+1
| | | | | | | | BUG=2204 Review URL: https://chromiumcodereview.appspot.com/12886022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195374 0039d316-1c4b-4281-b951-d872f2087c98
* Fix error in use-before-init of test member variable in MockNetworkTransaction.rdsmith@chromium.org2013-03-261-1/+2
| | | | | | | | | | BUG=223393 R=rvargas@chromium.org Review URL: https://chromiumcodereview.appspot.com/12925004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190626 0039d316-1c4b-4281-b951-d872f2087c98
* Cache failover to LOAD_PREFERRING_CACHE if network response suggests offline.rdsmith@chromium.org2013-03-231-5/+18
| | | | | | | | | | | | (Controlled by new load flag.) BUG=2204 R=rvargas@chromium.org Review URL: https://chromiumcodereview.appspot.com/12310075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190020 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Propagate priority changes from URLRequest to HttpTransactionakalin@chromium.org2013-03-221-2/+13
| | | | | | | | | | | | | | | This is in preparation for propagating priority changes from ResourceScheduler all the way to HostResolver and ClientSocketPool. Add some NetLog events and parameters for priority. BUG=166689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189829 Review URL: https://codereview.chromium.org/12701011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189894 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 189829 "[Net] Propagate priority changes from URLRequest ..."msw@chromium.org2013-03-221-13/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See heapcheck failures: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/25563 http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/25563/steps/heapcheck%20test%3A%20net/logs/stdio Example (one of many): Leak of 792 bytes in 1 objects allocated from: @ 10d675b URLRequestFtpJobPriorityTest @ 10d68e7 URLRequestFtpJobPriorityTest_SetPriorityBasic_Test @ 10de383 CreateTest Suppression (error hash=#0A68FF60C5D043B8#): { <insert_a_suppression_name_here> Heapcheck:Leak fun:URLRequestFtpJobPriorityTest fun:URLRequestFtpJobPriorityTest_SetPriorityBasic_Test fun:CreateTest } > [Net] Propagate priority changes from URLRequest to HttpTransaction > > This is in preparation for propagating priority changes from > ResourceScheduler all the way to HostResolver and ClientSocketPool. > > Add some NetLog events and parameters for priority. > > BUG=166689 > TBR=simonjam@chromium.org,sky@chromium.org > > Review URL: https://codereview.chromium.org/12701011 TBR=akalin@chromium.org Review URL: https://codereview.chromium.org/12676022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189872 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Propagate priority changes from URLRequest to HttpTransactionakalin@chromium.org2013-03-221-2/+13
| | | | | | | | | | | | | | This is in preparation for propagating priority changes from ResourceScheduler all the way to HostResolver and ClientSocketPool. Add some NetLog events and parameters for priority. BUG=166689 TBR=simonjam@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/12701011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189829 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Separate out priority field from HttpRequestInfoakalin@chromium.org2013-03-191-3/+7
| | | | | | | | | | | | | | This is in preparation for supporting reprioritization; HttpRequestInfo is assumed to be an unchanging struct, so priority can't live in it if it is something that can change. Also add DEFAULT_PRIORITY value and replace some uses of LOWEST with it. BUG=166689 Review URL: https://codereview.chromium.org/12833008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189099 0039d316-1c4b-4281-b951-d872f2087c98
* LoadTiming in net, part 3.mmenke@chromium.org2013-01-211-0/+5
| | | | | | | | | | | | | | | Add send and receive times to HttpNetworkTransaction. Add LoadTimingInfo accessors to Http*Transaction, URLRequestJob, and URLRequest classes. Proxy resolution times still need to be added. BUG=77446 Review URL: https://chromiumcodereview.appspot.com/11929017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177942 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Modify the Vary header behavior.rvargas@google.com2012-11-161-0/+1
| | | | | | | | | | | | Prioritize vary headers over LOAD_PREFERRING_CACHE. This means that back navigations would fail after reaching a vary header, and a new network request will be issued. BUG=94369 TEST=net_unittests Review URL: https://codereview.chromium.org/11358260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168311 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 153131 (Histograms showed it doesn't help much)mmenke@chromium.org2012-09-111-36/+25
| | | | | | | | | | | | | | | | | | Reland of http://codereview.chromium.org/10854204/, which I reverted because of a bug in its unit tests. Retry failed network requests. R=willchan@chomium.org BUG=143425 Review URL: https://chromiumcodereview.appspot.com/10872044 TBR=mmenke@chromium.org Review URL: https://chromiumcodereview.appspot.com/10933022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156041 0039d316-1c4b-4281-b951-d872f2087c98
* net: Return size of upload as well as position from ↵hashimoto@chromium.org2012-08-301-2/+2
| | | | | | | | | | | | | | HttpTransaction::GetUploadProgress() Add net::UploadProgress Change return type of GetUploadSize() from uint64 to UploadProgress. BUG=112607 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10834178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154063 0039d316-1c4b-4281-b951-d872f2087c98
* Reland of http://codereview.chromium.org/10854204/, whichmmenke@chromium.org2012-08-241-25/+36
| | | | | | | | | | | | | I reverted because of a bug in its unit tests. Retry failed network requests. R=willchan@chomium.org BUG=143425 Review URL: https://chromiumcodereview.appspot.com/10872044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153131 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 153025 - Automatically retry failed network requests.mmenke@chromium.org2012-08-231-32/+21
| | | | | | | | | | | | | | This is a temporary experiment to see if this behavior is worth implementing in a cleaner fashion. BUG=143425 Review URL: https://chromiumcodereview.appspot.com/10854204 TBR=mmenke@chromium.org Review URL: https://chromiumcodereview.appspot.com/10883011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153031 0039d316-1c4b-4281-b951-d872f2087c98
* Automatically retry failed network requests.mmenke@chromium.org2012-08-231-21/+32
| | | | | | | | | | | This is a temporary experiment to see if this behavior is worth implementing in a cleaner fashion. BUG=143425 Review URL: https://chromiumcodereview.appspot.com/10854204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153025 0039d316-1c4b-4281-b951-d872f2087c98
* Adding histograms showing fraction of page load times spent in the disk ↵tburkard@chromium.org2012-07-301-2/+3
| | | | | | | | | | cache, for full and partial page loads. R=mmenke@chromium.org, jam@chromium.org, willchan@chromium.org, brettw@chromium.org BUG=139210 Review URL: https://chromiumcodereview.appspot.com/10736066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149007 0039d316-1c4b-4281-b951-d872f2087c98
* Make disk cache tests ETags more HTTP standard conformant.gavinp@chromium.org2012-07-221-2/+2
| | | | | | | | | | | | | ETags shuld use quotes. For a special treat, do check out HttpCache.ConditionalizedGet_PreserveRequestHeaders, previously it asserted on the ETags as being "\"foopy\"" when the ETags were created they were just "foppy". So that test looked like a matching ETags unless you read the code very carefully. R=rvargas@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/10802053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147823 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate HttpCache adn HttpCacheTransaction to base::Bind().ajwong@chromium.org2011-12-231-6/+6
| | | | | | | | | BUG=none TEST=existing Review URL: http://codereview.chromium.org/9025033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115675 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert most of net/http.jhawkins@chromium.org2011-12-201-21/+23
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8990001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115220 0039d316-1c4b-4281-b951-d872f2087c98
* Use AuthCredentials throughout the network stack instead of username/password.cbentzel@chromium.org2011-10-281-3/+3
| | | | | | | | This is a refactor only - no behavior change should happen. Review URL: http://codereview.chromium.org/8340026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107766 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind conversion for net/http/...adamk@chromium.org2011-10-201-3/+5
| | | | | | | | | R=willchan@chromium.org Review URL: http://codereview.chromium.org/8344066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106428 0039d316-1c4b-4281-b951-d872f2087c98
* Begin CompletionCallback switchover.willchan@chromium.org2011-10-011-8/+8
| | | | | | | | | | | | | Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback. Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g. BUG=98719 TEST=none Review URL: http://codereview.chromium.org/8070013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
* net: Notify the http job and cache transaction about a filterrvargas@google.com2011-08-121-4/+16
| | | | | | | | | | completing the request (returning 0 bytes from a read). BUG=91898 TEST=net_unittests Review URL: http://codereview.chromium.org/7569027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96576 0039d316-1c4b-4281-b951-d872f2087c98
* Kill URLRequestJobTracker.willchan@chromium.org2011-05-221-2/+0
| | | | | | | | | | BUG=81160 TEST=none Review URL: http://codereview.chromium.org/7043007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86241 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 3.jhawkins@chromium.org2011-05-121-1/+1
| | | | | | | | | | | BUG=82098 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/7016011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-261-14/+218
| | | | | | | | | | | | | | | | | | | | (Reapply r72562 with willchan's nits + locally tested shlib fixes + removing duplicate code that was partially responsible for the failure.) - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles First Review URL: http://codereview.chromium.org/6264013 Review URL: http://codereview.chromium.org/6248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72682 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up net unit testing code." since it breaks the shlib builder.erg@google.com2011-01-251-218/+14
| | | | | | | | | | This reverts commit 006f377bbb65ece3490b7c76e58e0dc4cb330909 (r72562). BUG=68682 TEST=compiles TBR=thomasvl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72564 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-251-14/+218
| | | | | | | | | | | | | | | | | - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6264013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72562 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-011-1/+1
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Auto-format style pass over files.cbentzel@chromium.org2010-05-041-1/+1
| | | | | | | | | | | This is a refactor (actually reformat) only - no behavior change in place. BUG=NONE TEST=net_unittests.exe Review URL: http://codereview.chromium.org/1800003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46349 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 07:29:33 +0000