| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
R=agl
BUG=63357
TEST=none
Review URL: http://codereview.chromium.org/5386001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, DiskCacheBasedSSLHostInfo had a couple of problems:
* I had assumed that the disk cache was taking references to the
callback. It wasn't.
* Even if it were, I was passing pointers into
DiskCacheBasedSSLHostInfo which needed to be live for the duration
of the callback.
This change switches to a custom callback class which doesn't need
reference counting and which contains pointer members that remain live
for the duration of the callback.
BUG=63867
TEST=Navigate to an HTTPS page with Snap Start running and no network connection.
http://codereview.chromium.org/5826001/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=66702
TEST=none
Contributed by: asanka@google.com
Review URL: http://codereview.chromium.org/5716004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5741001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For each HTTP authentication scheme, record whether it was started for a proxy, a secure proxy, a server, or a secure server.
Also, use a new scheme-based enumerated value as an index rather than the score.
BUG=None
TEST=trybots, look at about:histograms after authenticating to different resources.
Review URL: http://codereview.chromium.org/5563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
goes away.
Will re-enable after a canary goes out with this off.
BUG=65948
TEST=none
Review URL: http://codereview.chromium.org/5592009
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5727001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for in the future.)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5574006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will re-enable after a canary goes out with this off.
BUG=65948
TEST=none
Review URL: http://codereview.chromium.org/5592009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=58323
TEST=current tests
Review URL: http://codereview.chromium.org/5522014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5648004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reports
BUG=64918
TEST=linux_valgrind trybot
Review URL: http://codereview.chromium.org/5599004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
created, it uses the NetLog from the SpdySession, not from the
ConnectJob, so that we avoid circular dependencies.
I attempted to verify the buggy behavior and the fix by adding a
DCHECK() to ConnectJob::set_socket (which is the source of the
cycle you detected), but unfortunately, it appears that our unit
tests seems to use the same NetLog everywhere. So to test this,
I added a very specific DCHECK in passive_log_collector.cc
which failed on every HTTPS request through a SPDY proxy when
using the old code, and which never failed using this new code.
BUG=65217
TEST=none
Review URL: http://codereview.chromium.org/5587005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
after we return the headers to the caller.
We used the response code as the only indicator to know if an entry
was sparse or not, but the response code is modified on the request
if a byte-range was not requested... so for subsequent sub-ranges we
could consider this a regular, non sparse resource.
BUG=62460
TEST=net_unittests
Review URL: http://codereview.chromium.org/5541004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DCHECK replaced by EXPECT for HttpAuthHandlerDigest unittests.
Also, changed RespondToChallenge to return a success boolean and LOG the failure reasons, rather than returning an error string.
BUG=None
TEST=net_unittests --gtest_filter="*HttpAuthHandlerDigest*"
Review URL: http://codereview.chromium.org/5205005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- implements basic client certificate support in ssl socket
- adds special-case IP address support to allow SSL connections to the test server (iff there is a trusted certificate in the store with 127.0.0.1 in its name)
- enables the test server for loading the temporary cert
- implements the DES encryptor (removed TODO about refactoring the file layout as it's already covered by a TODO in the .h file)
- disabled KeygenHandler tests, as this is not implemented for openssl
- disables the (firefox) importer unittests.
BUG=None
TEST=net_unittests now run green
Review URL: http://codereview.chromium.org/5195001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if an https:// URL was attempted to be fetched across it. Also fix a bug
where when two SSL connections are made, but only one is moved into a SPDY
session (because the second is redundant), close the redundant connection.
This had been leaking a un-verified SSL connection into the pool, which
could then get re-used as though it was verified.
BUG=64861
TEST=none
Review URL: http://codereview.chromium.org/5409004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ChromeNetLog is now owned by the browser process,
and passed to the IOThread on creation.
NetLog entries can be added from any thread.
Observers must be able to handle having log entries added
from any thread. Observers can add/remove themselves on any
thread.
BUG=63334
TEST=None, yet
Review URL: http://codereview.chromium.org/4118004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[reland CL 5271002... with CrOS / ARM interface update]
Connected up to the API for requesting more than
one preconnect at a time (that API also explicitly
tags requsets as preconnects, so that they can be
merged with actual navication requests).
BUG=64246
r=willchan,mbelshe
Review URL: http://codereview.chromium.org/5400002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Connected up to the API for requesting more than
one preconnect at a time (that API also explicitly
tags requsets as preconnects, so that they can be
merged with actual navication requests).
BUG=64246
r=willchan,mbelshe
Review URL: http://codereview.chromium.org/5271002
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/5397003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Connected up to the API for requesting more than
one preconnect at a time (that API also explicitly
tags requsets as preconnects, so that they can be
merged with actual navication requests).
BUG=64246
r=willchan,mbelshe
Review URL: http://codereview.chromium.org/5271002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(See r66623 for details.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r66970.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(Reland of r66623, reverted in r66687 due to Chrome Frame linking issues.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an SSL/TLS server requests a client certificate, the user may opt to not send any certificate. This will work if the server does not require a client certificate to be sent in order to load the resource - for example, to fall-back to forms-based authentication or when client certificates are configured as optional.
If the user declines to provide a client certificate, remember that choice in the SSLClientAuthCache so that they will not be repeatedly prompted to select a certificate (declining each time) for every sub-resource that loads, similar to how the SSLClientAuthCache remembers an explicit certificate selected by a user.
If the server requires a client certificate, it is expected that it will abort the TLS handshake with an appropriate TLS error code. When the server aborts and the error code is processed, the existing cached selection will be removed, and the user will be re-prompted to select a certificate on their next connection to that server.
If the server requires a client certificate to continue, but does not use the TLS stack to indicate that requirement - for example, to return a "friendlier" error page or an HTTP error code like 403, the selection will not be evicted from the cache, and the user must restart the browser before they will be prompted again for a certificate from that server. This is the same lifetime and behaviour as would happen if the user actively selected a certificate, rather than declined to provide one.
BUG=56177
TEST=SSLClientAuthCacheTest.LookupNullPreference . Also see the Apache configuration in http://crbug.com/56177. Access a site that requests, but does not require, client authentication, which will attempt to load multiple sub-resources, and which does not permit HTTP KeepAlives.
Review URL: http://codereview.chromium.org/4568002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These tests go through the normal lifecycle of the auth handler. They did not expose any broken code.
BUG=None
TEST=net_unittests --gtest_filter="*HttpAuthHandlerDigest*"
Review URL: http://codereview.chromium.org/5185003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r66623. Some how it causes libnspr4.dll to be linked in
Chrome Frame builds.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsCertProvenanceChecker is introduced to abstract away the action of
uploading reports. It's implemented by ChromeDnsCertProvenanceChecker
which lives in a scoped_ptr off of a URLRequestContext.
It's only active on the main context (i.e. not in incognito mode). This
might change in the future, but it's a nice, conservative choice for the
moment.
The DnsCertProvenanceChecker is plumbed all the way to SSLClientSocket
(via HttpCache) where it replaces the DnsRRResolver. Above
SSLClientSocket, it's plumbed in addition to the DnsRRResolver because
the later will end up going into SSLHostInfo in the future.
At the moment, ChromeDnsCertProvenanceCheckerContext is just a skeleton
to avoid putting too much real code in a plumbing job.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=56449
TEST=none
Review URL: http://codereview.chromium.org/5124001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Trying to simplify cleanup for more unit tests.
BUG=None
TEST=net_unittests
Review URL: http://codereview.chromium.org/5034001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, if the only qop is auth-int, use a different handler since this is not currently handled.
BUG=45194
TEST=net_unittests --gtest_filter="*HttpAuthHandlerDigest*"
Review URL: http://codereview.chromium.org/4825001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the callers to append base:: in the calls to StringAppendF.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4974001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to an HTTPS/SPDY proxy. Modify SSLClientSocket classes to correctly set the host_and_port field of the cert_request_info. Modify HttpNetworkTransaction to use this field when populating the SSL client auth cache.
BUG=59292
TEST=HttpProxyClientSocketPoolTest.SslClientAuth
Review URL: http://codereview.chromium.org/4339001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This preference can be set either via command-line or via group policy.
BUG=53625
TEST=unittests: ConfigurationPolicyPrefStore*; net_unittests: HttpAuthHandlerNegotiateTest.*:HttpAuthGSSAPIPOSIXTest.*; manually: start Chrome with command-line switch --gssapi-library-name=XYZ and see if this results in the Chrome process loading /usr/lib/whatever/XYZ as soon as an authenticated HTTP site is encountered.
Review URL: http://codereview.chromium.org/4560001
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
HTTP Basic Proxy Auth over SPDY.
BUG=none
TEST=HttpNetworkTransactionTest.HttpsProxySpdyGetWithProxyAuth
Review URL: http://codereview.chromium.org/4389001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
URLs only.
R=eroman,finnur
BUG=53366
TEST=net_unittests --gtest_filter=HTTPSRequestTest.HTTPS*Test
Review URL: http://codereview.chromium.org/4210004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restart an HTTP load when we mispredict the NPN protocol in a Snap Start connection.
Also, test the behaviour of the HTTP layer when SSL errors result
from the first Write() call. When we are doing Snap Start, we need to
merge the first application data record into the ClientHello. Thus the
SSL socket will report that it has connected immedately in order to get
a Write() call. This means that some errors, which would typically
result from the Connect(), are now returned on the first Write().
BUG=none
TEST=net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that the complete request is logged, not just the extra_headers.
Before I broke things, HttpNetworkTransaction was attempting to
do the logging, but after some refactors it no longer has access
to the final request. SpdySession already logs correctly in the
SPDY case, and I modified HttpBasicStream to log in the HTTP case.
Added unit tests is both HttpNetworkTransactionTest and
SpdyNetworkTransactionTest.
BUG=48962
TEST=net_unittests --gtest_filter=HttpNetworkTransactionTest.SimpleGET\*
Review URL: http://codereview.chromium.org/4644003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also remove the other using directives, most of which were already explicitly qualified at various places in the file anyway.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4660009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Now, HttpNetworkTransaction::HandleAuthChallenge returns ERR_INVALID_PROXY_AUTHENTICATE when this is detected.
BUG=61701
TEST=net_unittests --gtest_filter="*HttpsServerRequestsProxyAuthThroughProxy*"
Review URL: http://codereview.chromium.org/4575001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix conflicts like:
2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope
2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare'
Reported-by: Jeff Timanus <twiz@google.com>
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4366001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2826041
I then did quite a bit of manual editing to fix style issues.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4291001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56344,59077
TEST=new tests in HttpNetworkTransactionTest
Review URL: http://codereview.chromium.org/4192011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46620
TEST=net_unittests --gtest_filter="*SpdyBasicAuth*"
Review URL: http://codereview.chromium.org/4148009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=net_unittests
Review URL: http://codereview.chromium.org/4193007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in DoCreateStreamComplete instead of DoInitStreamComplete.
This solves the problem where Chrome repeately prompts for
ssl client certs.
BUG=56019
TEST=Visit a URL which requests SSL client authentication. Select a certificate. Navigate around the site without being re-prompted to select a certificate.
Review URL: http://codereview.chromium.org/4164004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor SSLClientSocketNSS::GetSSLInfo -- the code that sets
ssl_info->connection_status is moved to a new
UpdateConnectionStatus method, and CheckSecureRenegotiation
is subsumed by UpdateConnectionStatus.
R=agl,finnur
BUG=53659
TEST=none
Review URL: http://codereview.chromium.org/4198003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Modify HttpStream::SendRequest to take the HttpRequestHeaders instead of a string so that HttpNetworkTransaction can handle both HTTP and SPDY requests the same way.
BUG=
TEST=
Review URL: http://codereview.chromium.org/4061005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix indentation.
R=rch
BUG=none
TEST=no compilation errors.
Review URL: http://codereview.chromium.org/4119008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use chrome.exe --enable-tcp-fastopen
BUG=none
TEST=none yet
Review URL: http://codereview.chromium.org/4039003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63913 0039d316-1c4b-4281-b951-d872f2087c98
|