summaryrefslogtreecommitdiffstats
path: root/net/http
Commit message (Collapse)AuthorAgeFilesLines
* The SPDY Exclusions were broken; the intent of the exclusion is so that ourmbelshe@chromium.org2011-03-164-19/+20
| | | | | | | | | | | | | benchmark harness can force SPDY, but still report to the benchmark harness itself in non-spdy mode. BUG=none TEST=none Review URL: http://codereview.chromium.org/6674031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78400 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78061 - Revert 78034 - Removing a TODO and cleaning up code.kristianm@google.com2011-03-151-2/+2
| | | | | | | | | | | | | | | | | | | This is done in preparation of a patch to let some request ignore the max sockets and max sockets to group limits. BUG=none TEST=none Review URL: http://codereview.chromium.org/6679001 TBR=kristianm@google.com Review URL: http://codereview.chromium.org/6685057 TBR=kristianm@google.com Review URL: http://codereview.chromium.org/6696017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78189 0039d316-1c4b-4281-b951-d872f2087c98
* Code cleanup related to allowed_bad_certs.wtc@chromium.org2011-03-141-1/+1
| | | | | | | | | | | | | | | | cert_status is a bitwise-OR of CERT_STATUS_xxx, not ERR_CERT_xxx. Initialize a CertAndStatus structure after checking it is needed. Fix a typo in comments. R=hclam BUG=none TEST=none Review URL: http://codereview.chromium.org/6677022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78123 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78034 - Removing a TODO and cleaning up code.kristianm@google.com2011-03-141-2/+2
| | | | | | | | | | | | | | | | This is done in preparation of a patch to let some request ignore the max sockets and max sockets to group limits. BUG=none TEST=none Review URL: http://codereview.chromium.org/6679001 TBR=kristianm@google.com Review URL: http://codereview.chromium.org/6685057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78061 0039d316-1c4b-4281-b951-d872f2087c98
* Removing a TODO and cleaning up code.kristianm@google.com2011-03-141-2/+2
| | | | | | | | | | | | | This is done in preparation of a patch to let some request ignore the max sockets and max sockets to group limits. BUG=none TEST=none Review URL: http://codereview.chromium.org/6679001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78034 0039d316-1c4b-4281-b951-d872f2087c98
* Reland rest of r77399.willchan@chromium.org2011-03-1211-360/+595
| | | | | | | | | | | I had temporarily reverted it so I could break it up into 2 commits, so the first could be merged to 696. This is part 2. BUG=none TEST=none Review URL: http://codereview.chromium.org/6684019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77908 0039d316-1c4b-4281-b951-d872f2087c98
* Don't drain response bodies for SpdyHttpStreams.willchan@chromium.org2011-03-115-0/+15
| | | | | | | | | | | | | This should fix the specific instance of crbug.com/75657, although I can't reproduce the bug, so it's possible it may instead push the bug later down the pipeline rather than completely fixing it. I believe it should completely fix it though. This is a partial reland of r77399, which was reverted in order to faciliate this partial reland so I can merge a smaller change into branch 696. BUG=75657 TEST=none Review URL: http://codereview.chromium.org/6680009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77893 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r77399 in preparation for merging a small portion of it to 696.willchan@chromium.org2011-03-1115-610/+360
| | | | | | | | | | | | | | | | | | Reland r77075,r77077. They were reverted due to flaky tests, especially on valgrind. Basically, we kept hitting the backup socket timer (500ms) which would create another socket, which the tests don't expect, so they crash. I disabled the backup socket timer completely for the SPDY tests, because they make it too hard to handle the parallel alternate protocol jobs. I also deleted the HTTP fallback test from SpdyNetworkTransactionTest, because it had a similar problem. Also, it was already being tested in HttpNetworkTransactionTest. BUG=69688,75000 TEST=Try connecting to belshe.com with various proxy configurations. Should work still. Review URL: http://codereview.chromium.org/6635047 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6681012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77864 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r77075,r77077.willchan@chromium.org2011-03-0915-360/+610
| | | | | | | | | | | | | They were reverted due to flaky tests, especially on valgrind. Basically, we kept hitting the backup socket timer (500ms) which would create another socket, which the tests don't expect, so they crash. I disabled the backup socket timer completely for the SPDY tests, because they make it too hard to handle the parallel alternate protocol jobs. I also deleted the HTTP fallback test from SpdyNetworkTransactionTest, because it had a similar problem. Also, it was already being tested in HttpNetworkTransactionTest. BUG=69688,75000 TEST=Try connecting to belshe.com with various proxy configurations. Should work still. Review URL: http://codereview.chromium.org/6635047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77399 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77075 - Don't block on stream requests on Alternate-Protocol.jochen@chromium.org2011-03-0715-610/+360
| | | | | | | | | | | | | | Basically, after we get an HTTP header giving an Alternate-Protocol, we'll end up in a state where we're probably going to issue more HTTP requests. We have the already warm single HTTP connection. We probably don't have a SPDY session open. Previously, once we notice Alternate-Protocol, we'd block on trying to set up the new SPDY session, even though we still have the HTTP connection. Change this so we keep using HTTP until the SPDY session on the Alternate-Protocol becomes available, then we switch over to it. BUG=69688,75000 TEST=Browse to belshe.com. Examine net-internals to make sure it works. Test over a variety of connections (direct / various proxy types). Review URL: http://codereview.chromium.org/6610034 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6621040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77117 0039d316-1c4b-4281-b951-d872f2087c98
* Don't block on stream requests on Alternate-Protocol.willchan@chromium.org2011-03-0615-360/+610
| | | | | | | | | | | Basically, after we get an HTTP header giving an Alternate-Protocol, we'll end up in a state where we're probably going to issue more HTTP requests. We have the already warm single HTTP connection. We probably don't have a SPDY session open. Previously, once we notice Alternate-Protocol, we'd block on trying to set up the new SPDY session, even though we still have the HTTP connection. Change this so we keep using HTTP until the SPDY session on the Alternate-Protocol becomes available, then we switch over to it. BUG=69688,75000 TEST=Browse to belshe.com. Examine net-internals to make sure it works. Test over a variety of connections (direct / various proxy types). Review URL: http://codereview.chromium.org/6610034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77075 0039d316-1c4b-4281-b951-d872f2087c98
* Change other usages of .size() to .empty() when applicable.erg@google.com2011-03-041-1/+1
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6609008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
* Add chunked uploads support to SPDYsatish@chromium.org2011-03-042-9/+63
| | | | | | | | | | | | | | | As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData needs to serve both. BUG=none TEST=net_unittests (2 new tests added) Committed and rolled back: http://src.chromium.org/viewvc/chrome?view=rev&revision=76892 Review URL: http://codereview.chromium.org/6292013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76930 0039d316-1c4b-4281-b951-d872f2087c98
* Mention that HttpAuthCache::Entry::HasEnclosingPath() can return 0 as a path ↵asanka@chromium.org2011-03-041-1/+5
| | | | | | | | | | | | | len and fix typo. (Comment only change. Cleanup for 76539) BUG=none TEST=none Review URL: http://codereview.chromium.org/6612026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76911 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add chunked uploads support to SPDY"satish@chromium.org2011-03-042-63/+9
| | | | | | | | This reverts commit 8431a6e7be70b1b50b0d5b851bbe728b7fef220f. TBR=satish git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76896 0039d316-1c4b-4281-b951-d872f2087c98
* Add chunked uploads support to SPDYsatish@chromium.org2011-03-042-9/+63
| | | | | | | | | | | | | As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData needs to serve both. BUG=none TEST=net_unittests (2 new tests added) Review URL: http://codereview.chromium.org/6292013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76892 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Fix handling of truncated entries.rvargas@google.com2011-03-024-120/+194
| | | | | | | | | | | | | | | | | | | | | | | | - Always validate a truncated entry. Furthermore, given that a server can say not-modified (304), followed by 200 when actually asked for the final range, now we validate truncated entries by asking for the next byte that we need. - If a server refuses to serve a byte range and instead sends the whole resource, we just cache the response as if nothing was stored before. - If we receive a network error while reading from the net, we don't discard the cached entry right away. Now we wait until the transaction is closed, and attempt to mark the entry as truncated. BUG=48468 TEST=net_unittests Review URL: http://codereview.chromium.org/6588105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76560 0039d316-1c4b-4281-b951-d872f2087c98
* Pick the closest enclosing path match when looking up HTTP auth cache ↵asanka@chromium.org2011-03-023-17/+50
| | | | | | | | | | | | | | | | | | entries by path If we have two cache entries : < 'example.com', userA, realmA, paths=[ '/' ] > and < 'example.com', userB, realmB, paths=[ '/foo/' ] > Then a LookupByPath() for '/foo/bar/baz' should return the cache entry for userB rather than userA. BUG=73294 TEST=net_unittests --gtest_filter=HttpAuthCacheTest.Basic Review URL: http://codereview.chromium.org/6596076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76539 0039d316-1c4b-4281-b951-d872f2087c98
* Add HttpStreamFactory Job orphaning semantics.willchan@chromium.org2011-03-016-62/+295
| | | | | | | | | BUG=54371,69688 TEST=none Review URL: http://codereview.chromium.org/6591030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76389 0039d316-1c4b-4281-b951-d872f2087c98
* Update NetLog in preparation for late binding of HttpStream jobs to requests.willchan@chromium.org2011-02-285-8/+37
| | | | | | | | | BUG=54371,42669 TEST=Open up about:net-internals#Events and make sure HTTP_STREAM_JOBs appear and are tied together to URL_REQUESTs. Review URL: http://codereview.chromium.org/6592027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76287 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare for late binding of SpdyHttpStreams.willchan@chromium.org2011-02-256-296/+407
| | | | | | | | | | | | | | | | | | * Move HostPortProxyPair to net/proxy/proxy_server.h. * Have the Job assign the spdy_session_key to the Request when it's determined. * Have the Job notify the HttpStreamFactoryImpl when a SpdySession becomes available. Next steps: * When HttpStreamFactoryImpl sees a SpdySession becomes available, service all applicable requests by examining their spdy_session_key. * Introduce a new NetLog::Source for the late bound jobs. * Have HttpStreamFactoryImpl create two Jobs instead of just 1 per Request if Alternate-Protocol is available. BUG=54371,42669 TEST=existing Review URL: http://codereview.chromium.org/6577035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix realm selection when handling Basic authentication.asanka@chromium.org2011-02-244-20/+61
| | | | | | | | | | | | | | | Clarify comments and fix realm selection in HttpAuthHandlerBasic::HandleAnotherChallenge() to match the selection in HttpAuthHandlerBasic::ParseChallenge(). This is cleanup for r75390. BUG=none TEST=net_unittests --gtest_filter=HttpAuthHandlerBasicTest.* Review URL: http://codereview.chromium.org/6574003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75889 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor of NetworkDelegate.willchan@chromium.org2011-02-246-45/+11
| | | | | | | | | | | | | | * Renames HttpNetworkDelegate to NetworkDelegate, moves to net/base/network_delegate.h. NOTE: this is a layering violation. wtc/eroman/willchan have agreed to this exception because the other solutions are less palatable. * Move the virtuals in NetworkDelegate to the private section. Use non-virtual public interface as the network stack's interface for notifying the delegate. Add sanity checking to the implmentation in NetworkDelegate. The private virtual interface is for consumers to receive notifications. * Remove ExtensionIOEventRouter from ChromeURLRequestContext, it is only used by the ChromeNetworkDelegate. Pass it directly to the ChromeNetworkDelegate's constructor. * Introduce a SystemNetworkDelegate. It does nothing right now. BUG=67232 TEST=none Review URL: http://codereview.chromium.org/6580002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75822 0039d316-1c4b-4281-b951-d872f2087c98
* Create a URLRequestContextStorage object to provide storage for ↵willchan@chromium.org2011-02-231-3/+2
| | | | | | | | | | | URLRequestContext objects. BUG=none TEST=none Review URL: http://codereview.chromium.org/6560001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75756 0039d316-1c4b-4281-b951-d872f2087c98
* Send fatal proxy errors to the network delegate.jochen@chromium.org2011-02-231-1/+7
| | | | | | | | | BUG=60099 TEST=browser test Review URL: http://codereview.chromium.org/6541021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75726 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpStreamFactory.willchan@chromium.org2011-02-2321-634/+942
| | | | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75668 Review URL: http://codereview.chromium.org/6543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75688 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75668 for breaking ChromeOS build - Refactor HttpStreamFactory.willchan@chromium.org2011-02-2321-942/+634
| | | | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Review URL: http://codereview.chromium.org/6543004 TBR=willchan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75670 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpStreamFactory.willchan@chromium.org2011-02-2221-634/+942
| | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Review URL: http://codereview.chromium.org/6543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75668 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate the remote socket address to URLRequest and to ↵bryner@chromium.org2011-02-225-1/+66
| | | | | | | | | | | | | | | | ViewHostMsg_FrameNavigate. This will be used to run pre-classification checks for client-side phishing detection, and will also enable the socket address to be exposed via the webRequest extension API. This is adapted from the original patch by pmarks on http://codereview.chromium.org/6369003/ . BUG=51663 TEST=added socket address checks to various unittests Review URL: http://codereview.chromium.org/6488010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75620 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for testing SPDY with a forced-single-domain mode. This ismbelshe@chromium.org2011-02-222-1/+6
| | | | | | | | | | | | for benchmarking only. BUG=none TEST=none Review URL: http://codereview.chromium.org/6532086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75597 0039d316-1c4b-4281-b951-d872f2087c98
* Check and invalidate cached credentials if they were used for preemptive ↵asanka@chromium.org2011-02-187-25/+84
| | | | | | | | | | | authentication and were rejected by the server. BUG=72589 TEST=net_unittests --gtest_filter=HttpAuthHandler*.HandleAnotherChallenge Review URL: http://codereview.chromium.org/6525035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75390 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity UNINIT_CTOR defect in the HttpAuthCache::Entrywtc@chromium.org2011-02-111-1/+2
| | | | | | | | | | | | constructor. R=cbentzel CID=8793 BUG=none TEST=none Review URL: http://codereview.chromium.org/6492001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74672 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing with the out-of-lining of test code.erg@google.com2011-02-116-78/+165
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6485015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74660 0039d316-1c4b-4281-b951-d872f2087c98
* clang: Fix several -Woverloaded-virtual warnings.thakis@chromium.org2011-02-112-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Real bugs: net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:310:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>' requested here CaptureGroupNameHttpProxySocketPool::CaptureGroupNameSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:10: ./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:316:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>' requested here CaptureGroupNameSSLSocketPool::CaptureGroupNameSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:12: ./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:5511:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>' requested here new CaptureGroupNameTCPSocketPool(NULL, NULL); ^ In file included from ./net/socket/socket_test_util.h:34: ./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:5630:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>' requested here new CaptureGroupNameSOCKSSocketPool(NULL, NULL); ^ In file included from ./net/http/http_network_session_peer.h:11: ./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ CXX(target) out/Debug/obj.target/net_unittests/net/http/http_response_body_drainer_unittest.o 4 errors generated. net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:170:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>' requested here CapturePreconnectsHttpProxySocketPool::CapturePreconnectsSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:10: ./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:176:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>' requested here CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:12: ./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:188:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>' requested here new CapturePreconnectsTCPSocketPool( ^ In file included from ./net/socket/socket_test_util.h:34: ./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:237:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>' requested here new CapturePreconnectsSOCKSSocketPool( ^ In file included from net/http/http_stream_factory_unittest.cc:17: In file included from ./net/http/http_network_session_peer.h:11: ./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ CXX(target) out/Debug/obj.target/net_unittests/net/http/http_vary_data_unittest.o 4 errors generated. make: *** [out/Debug/obj.target/net_unittests/net/http/http_stream_factory_unittest.o] Error 1 media/audio/linux/alsa_output_unittest.cc:83:3:error: 'MockAudioManagerLinux::MakeAudioInputStream' hides overloaded virtual function [-Woverloaded-virtual] MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ In file included from media/audio/linux/alsa_output_unittest.cc:12: In file included from ./testing/gmock/include/gmock/gmock.h:61: testing/gmock/include/gmock/gmock-generated-function-mockers.h:632:28: note: instantiated from: ^ media/audio/linux/alsa_output_unittest.cc:83:3: note: instantiated from: MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ media/audio/linux/alsa_output_unittest.cc:83:16: note: instantiated from: MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ In file included from media/audio/linux/alsa_output_unittest.cc:9: ./media/audio/linux/audio_manager_linux.h:30:29: note: hidden overloaded virtual function 'AudioManagerLinux::MakeAudioInputStream' declared here virtual AudioInputStream* MakeAudioInputStream(AudioParameters params); ^ CXX(target) out/Debug/obj.target/media_unittests/media/base/data_buffer_unittest.o CXX(target) out/Debug/obj.target/media_unittests/media/base/djb2_unittest.o 1 error generated. No bug, just confusing: In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5: ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual] void HandleEvent(int event_index); ^ In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5: In file included from ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:9: ./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here virtual int16 HandleEvent(void* event); ^ 1 error generated. make: *** [out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_schedule_timer_test.o] Error 1 CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_private_test.o CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_test_factory.o In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:17: ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual] void HandleEvent(int event_index); ^ In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:7: In file included from ./webkit/plugins/npapi/test/plugin_arguments_test.h:8: ./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here virtual int16 HandleEvent(void* event); ^ 1 error generated. BUG=72205 TEST=none Review URL: http://codereview.chromium.org/6503001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74642 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused HttpResponseHeaders::GetRawHeaders method.adamk@chromium.org2011-02-112-27/+0
| | | | | | Review URL: http://codereview.chromium.org/6469003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74530 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity UNINIT_CTOR defects in constructors.wtc@chromium.org2011-02-112-2/+3
| | | | | | | | | | | R=eroman CID=14767,1304,8594 BUG=none TEST=none Review URL: http://codereview.chromium.org/6493003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74528 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity UNINIT_CTOR defect in thewtc@chromium.org2011-02-112-8/+10
| | | | | | | | | | | | | | DiskCacheBasedSSLHostInfo::CallbackImpl constructor. Fix cpplint nits. R=agl CID=14184 BUG=none TEST=No compilation errors. Review URL: http://codereview.chromium.org/6474009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74527 0039d316-1c4b-4281-b951-d872f2087c98
* Display more information at chrome://net-internals/#spdyrch@chromium.org2011-02-092-2/+31
| | | | | | | | | | | | In particular, list the mapping from host:port to port:alternate-protocol and the global spdy configuration state. BUG=none TEST=chrome://net-internals/#spdy Review URL: http://codereview.chromium.org/6465001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74355 0039d316-1c4b-4281-b951-d872f2087c98
* NetLog: Log net error codes on a lot of EndEvents.mmenke@chromium.org2011-02-083-14/+18
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6349083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74143 0039d316-1c4b-4281-b951-d872f2087c98
* Add logging for ERR_UNEXPECTED_SECURITY_LIBRARY_STATUS on ↵cbentzel@chromium.org2011-02-081-1/+4
| | | | | | | | | | | | | AcquireCredentialsHandle. This was being done for InitSecurityContext, but duplicated here. BUG=72126 TEST=None Review URL: http://codereview.chromium.org/6449004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74142 0039d316-1c4b-4281-b951-d872f2087c98
* Test that the same socket is used for each round of connection-based auth.cbentzel@chromium.org2011-02-061-5/+69
| | | | | | | | | | | NTLM and Negotiate were broken in beta builds around M6/M7 since the socket was released back to the general socket pool. A competing request would then grab it, but the server would expect another round of authentication on the same socket and authentication would break. BUG=58770 TEST=net_unittests --gtest_filter="*MultiRoundAuth" Review URL: http://codereview.chromium.org/6349108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73953 0039d316-1c4b-4281-b951-d872f2087c98
* Return more specific error messages when performing a SSL client auth ↵rsleevi@chromium.org2011-02-051-2/+14
| | | | | | | | | | | handshake and an error signing with the certificate private key is encountered, rather than using ERR_FAILED/ERR_SSL_PROTOCOL_ERROR. BUG=69609 TEST=none Review URL: http://codereview.chromium.org/6371014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73891 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpNetworkSession construction.willchan@chromium.org2011-02-0314-284/+253
| | | | | | | | | | | Introduce HttpNetworkSession::Params. This should make it easy to add new optionally NULL parameters. I also took this opportunity to eliminate some copy/pastes of TestURLRequestContext and make them use the original. I was also able to remove the need for ClientSocketFactory::GetDefaultFactory() calls and new SpdySessionPool() calls in most places. BUG=none TEST=none Review URL: http://codereview.chromium.org/6349028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73669 0039d316-1c4b-4281-b951-d872f2087c98
* Unreverting: First steps towards webRequest extension API.mpcomplete@chromium.org2011-02-011-0/+4
| | | | | | | | | | | | | | Only an asynchronous version of onBeforeRequest is implement, with limited data being passed. Original CL: http://src.chromium.org/viewvc/chrome?view=rev&revision=73196 BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73344 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "First steps towards webRequest extension API."mpcomplete@chromium.org2011-01-311-4/+0
| | | | | | | | | | | | | | | Seems to have broken the sync_integration_tests. This reverts commit d6f8d16cd6a5ebdf019c4755e7d42aee8136abf1. TBR=aa BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6287029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73219 0039d316-1c4b-4281-b951-d872f2087c98
* First steps towards webRequest extension API.mpcomplete@chromium.org2011-01-311-0/+4
| | | | | | | | | | | | Only an asynchronous version of onBeforeRequest is implement, with limited data being passed. BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6288014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73196 0039d316-1c4b-4281-b951-d872f2087c98
* Require NTLM identity earlyasanka@chromium.org2011-01-312-26/+42
| | | | | | | | | | | Don't wait until we receive an NTLM challenge to request username/password BUG=22845 TEST=net_unittests --gtest_filter=HttpNetworkTransactionTest.NTLMAuth* Review URL: http://codereview.chromium.org/6326016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73150 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes eol on http_stream_parser.ccmaruel@chromium.org2011-01-291-1/+1
| | | | | | | NO CODE CHANGE. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73095 0039d316-1c4b-4281-b951-d872f2087c98
* The HttpRequestInfo object must outlive the HttpNetworkTransaction object ↵satish@chromium.org2011-01-281-309/+309
| | | | | | | | | | | | | | because HttpRequestInfo is passed to HttpNetworkTransaction::Start() and HttpNetworkTransaction access the request info object in many places. With the current code UploadData gets deleted before HttpStreamParser and that causes read-after-free cases as shown in the below bug. BUG=70825 TEST=verify that the valgrind issue mentioned in the bug gets fixed Review URL: http://codereview.chromium.org/6327020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72954 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify HttpCache/HttpNetworkLayer/HttpNetworkSession interaction.willchan@chromium.org2011-01-285-263/+102
| | | | | | | | | | | | | Eliminate lazy initialization of HttpNetworkSession in HttpNetworkLayer. * This eliminates the need to update parameters for HttpNetworkLayer, it just takes a HttpNetworkSession. * It is OK to eliminate lazy initialization since these variables are cheap. BUG=none TEST=none Review URL: http://codereview.chromium.org/6402002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72931 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 05:54:08 +0000