summaryrefslogtreecommitdiffstats
path: root/net/http
Commit message (Collapse)AuthorAgeFilesLines
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-1157-57/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* fix clang warnings for chrome on androidqinmin@chromium.org2012-07-102-5/+0
| | | | | | | | | | | | variable begin_ and end_ is never being used, and it is generating clang errors BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10704134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145970 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race in HttpNetworkTransactionSpdy2Test.BasicAuthSpdyProxy andmmenke@chromium.org2012-07-102-18/+18
| | | | | | | | | | | | | | | re-enable it on TSAN/Dr. Memory. Apply same fix to the corresponding Spdy 3 test. Issue was that the tests relied on never reading MockReadData could not be safely read not being read. The memory bots slow things down enough that it was being read, and causing a crash. Fixed the bad data, and corrected the ordering of events. BUG=130874 Review URL: https://chromiumcodereview.appspot.com/10704042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix permissions bit that accidentally got +x.ericu@google.com2012-07-101-0/+0
| | | | | | | | | BUG=none TEST=check_perms Review URL: https://chromiumcodereview.appspot.com/10700147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145945 0039d316-1c4b-4281-b951-d872f2087c98
* [MIPS] Set endianness for MIPS architecture in http_auth_handler_ntlm_portable.petarj@mips.com2012-07-101-2/+6
| | | | | | | | | | | Small patch to set correctly endianness for MIPS arch. BUG=https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Review URL: https://chromiumcodereview.appspot.com/10752020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145928 0039d316-1c4b-4281-b951-d872f2087c98
* DeterministicSocketDataProvider should not be RefCountedrsleevi@chromium.org2012-07-107-37/+41
| | | | | | | | | | BUG=123295 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10690104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145845 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent requests for http://host:port/ from being sent over an existing spdy ↵rch@chromium.org2012-07-024-6/+523
| | | | | | | | | | | | session to https://host:port/. BUG=133176 TEST=HttpNetworkTransactionSpdy\*Test.\*UseSpdySessionForHttp\* Review URL: https://chromiumcodereview.appspot.com/10581020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145172 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144649 - Instead of enqueueing SPDY frames, instead enqueue SPDY ↵mattm@chromium.org2012-06-282-4/+4
| | | | | | | | | | | | | streams that are ready to produce data. This allows us to lazily allocate a stream id. BUG=111708 Review URL: https://chromiumcodereview.appspot.com/10448083 TBR=rch@chromium.org Review URL: https://chromiumcodereview.appspot.com/10710008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144655 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of enqueueing SPDY frames, instead enqueue SPDY streams that are ↵rch@chromium.org2012-06-282-4/+4
| | | | | | | | | | ready to produce data. This allows us to lazily allocate a stream id. BUG=111708 Review URL: https://chromiumcodereview.appspot.com/10448083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144649 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SSLHostInfo.agl@chromium.org2012-06-2714-558/+5
| | | | | | | BUG=105208 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144468 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix a pass-by-value.jhawkins@chromium.org2012-06-202-2/+2
| | | | | | | | | | | | | | CID_COUNT=1 CID=104201 BUG=none TEST=none R=groby TBR=willchan Review URL: https://chromiumcodereview.appspot.com/10579045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143231 0039d316-1c4b-4281-b951-d872f2087c98
* (Finally) Remove NetLog::EventParameters.mmenke@chromium.org2012-06-192-0/+2
| | | | | | | | | R=eroman@chromium.org BUG=126243 Review URL: https://chromiumcodereview.appspot.com/10565009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142953 0039d316-1c4b-4281-b951-d872f2087c98
* Do not enqueue multiple socket writes performing an HTTP chunked requestrsleevi@chromium.org2012-06-153-4/+176
| | | | | | | | | | | | | | | | When performing an HTTP request that uses a chunked transfer encoding, and both the underlying socket and the UploadDataStream provide data asynchronously, ensure that writes to the underlying socket maintain a strict ordering and that only one callback (socket write, chunked data available) is pending at a time. BUG=132243 TEST=HttpStreamParser.AsyncChunkAndAsyncSocket Review URL: https://chromiumcodereview.appspot.com/10536138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142470 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - Added SETTINGS_MAX_CONCURRENT_STREAMS:1000 in the initial SETTINGS frame,rtenneti@google.com2012-06-144-4/+22
| | | | | | | | | | | | | | so the server can push effectively as many streams as it wants to. - Send along SETTINGS_MAX_CONCURRENT_STREAMS for SPDY versions 2 and higher. - Avoid sending the Settings frame for every unit tests. R=willchan BUG=132341 TEST=netowrk unit tests Review URL: https://chromiumcodereview.appspot.com/10536136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142265 0039d316-1c4b-4281-b951-d872f2087c98
* Make HttpStream take a scoped_ptr<UploadDataStream>, to clearly communicate ↵rsleevi@chromium.org2012-06-1413-170/+247
| | | | | | | | | | | | | | | | | | | transfer of ownership HttpStream assumes ownership of the passed in UploadDataStream when SendRequest is called. However, there existed a few call sites where the passed in UploadDataStream may have been leaked, primarily during error handling. Using scoped_ptr<> & Pass() provide clear API-level contracts as to the ownership of pointers. BUG=none TEST=existing R=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10539137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142211 0039d316-1c4b-4281-b951-d872f2087c98
* NetLogEventParameter to Callback refactoring 5.mmenke@chromium.org2012-06-138-187/+103
| | | | | | | | | | | Get rid of all uses of NetLogEventParameters in net/http. R=eroman@chromium.org BUG=126243 Review URL: https://chromiumcodereview.appspot.com/10534129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142009 0039d316-1c4b-4281-b951-d872f2087c98
* Make NetLog take in callbacks that return Values rathermmenke@chromium.org2012-06-1013-162/+199
| | | | | | | | | | | | than refcounted objects. Avoids the need to create classes and copy data. Also no longer get time whenever an event is logged. BUG=126243 Review URL: https://chromiumcodereview.appspot.com/10399083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141377 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new OnHostResolutionCallback to TransportSocketParamsrch@chromium.org2012-06-086-112/+288
| | | | | | | | | | | | Correctly implement OnHostResolution in HttpStreamFactoryImpl::Job BUG=106235 TEST=HttpNetworkTransactionSpdy\*Test.UseIPConnectionPoolingAfterResolution Review URL: https://chromiumcodereview.appspot.com/10238010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141328 0039d316-1c4b-4281-b951-d872f2087c98
* CapturingNetLog - remove maximum entries constructor argument.mmenke@chromium.org2012-06-084-50/+50
| | | | | | | | | | | | Also replace with a NULL NetLog in a couple callsites where it wasn't being used. R=eroman@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10546071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141315 0039d316-1c4b-4281-b951-d872f2087c98
* fixed issue 128383 - replace GetPeerAddress(AddressList* address) with ↵zhaoqin@chromium.org2012-06-083-5/+5
| | | | | | | | | | | | | GetPeerAddress(IPEndPoint* address) R=szym@chromium.org BUG=128383 TEST=try bot Review URL: https://chromiumcodereview.appspot.com/10491007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141125 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pass GSS_C_NO_CONTEXT into gss_inquire_context()asanka@chromium.org2012-06-051-1/+3
| | | | | | | | | | | | If the call to gss_init_sec_context() failed, the returned context handle could be NULL. Attempting to describe the context by calling gss_inquire_context() using the NULL handle can cause a crash in the Kerberos library. BUG=73145 TEST=none Review URL: https://chromiumcodereview.appspot.com/10535018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140603 0039d316-1c4b-4281-b951-d872f2087c98
* Prefer 'filename' parameters if both 'name' and 'filename' parameters are ↵asanka@chromium.org2012-06-042-5/+16
| | | | | | | | | | | | specified in a Content-Disposition header. BUG=129366 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10447019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140289 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CapturingNetLog::Entry to CapturingNetLog::CaptureEntry,mmenke@chromium.org2012-06-024-32/+66
| | | | | | | | | | | | | | | | | | and have it keep its own copy of a NetLog Entry's parameters. This is in preparation for a NetLog refactoring that will result in NetLog parameters lasting no longer than the function call, to avoid always having to copy all parameters. This does make CapturingNetLogs much less efficient themselves, but they should not be used in production code, anyways. TEST=NONE BUG=126243 Review URL: https://chromiumcodereview.appspot.com/10442085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140146 0039d316-1c4b-4281-b951-d872f2087c98
* Always enqueue SYN_STREAM frames to the output queue at HIGHEST priorityrch@chromium.org2012-05-312-5/+5
| | | | | | | | | | | | to ensure that they are writte to the wire in the order they were created. BUG=111708 TEST=\*OutOfOrder\* Review URL: https://chromiumcodereview.appspot.com/10456057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139852 0039d316-1c4b-4281-b951-d872f2087c98
* Add the SSL_VERSION_FALLBACK event type for NetLog.wtc@chromium.org2012-05-311-6/+44
| | | | | | | | | | | | | | | Remove the obsolete SSL_SNAP_START event type. Replace the warning log messages with NetLog events. R=eroman@chromium.org,rsleevi@chromium.org BUG=126340 TEST=visit https://www-927.ibm.com/ibm/cas/cascon/ and verify that about:net-internals has two SSL_VERSION_FALLBACK events under the URL_REQUEST event for https://www-927.ibm.com/ibm/cas/cascon/. Review URL: https://chromiumcodereview.appspot.com/10456049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139841 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Test deleting an entry with a pending_entry whenrvargas@google.com2012-05-291-5/+13
| | | | | | | | | | adding the truncated flag. BUG=125159 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10356113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139331 0039d316-1c4b-4281-b951-d872f2087c98
* Use TLS 1.1.wtc@chromium.org2012-05-264-30/+124
| | | | | | | | | | | | | | | | | | | | | | | | | Enable SSL 3.0 ~ TLS 1.1 by default. If the SSLClientSocket class does not support TLS 1.1, enable SSL 3.0 ~ TLS 1.0 by default. TLS intolerant servers are handled by falling back to the next lower protocol version at a time, rather than falling back to SSL 3.0 directly. In the SSLConfig structure, replace the ssl3_enabled and tls1_enabled members by version_min and version_max to allow multiple, contiguous protocol versions to be enabled, and rename the ssl3_fallback member to version_fallback. The preferences prefs::kSSL3Enabled and prefs::kTLS1Enabled are not yet removed. Generalize prefs::kTLS1Enabled to mean enabling or disabling all TLS versions. R=agl@chromium.org,rsleevi@chromium.org BUG=126340 TEST=net_unittests --gtest_filter=HTTPSRequestTest.TLSv1Fallback Review URL: https://chromiumcodereview.appspot.com/10377022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139204 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress pause-and-buffer behavior when the HTTP response won't satisfy ↵fischman@chromium.org2012-05-253-26/+49
| | | | | | | | | | | future requests via cache. BUG=123074 Review URL: https://chromiumcodereview.appspot.com/10387200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138972 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable embedded identities in URLs for HTTP authentication.asanka@chromium.org2012-05-223-11/+301
| | | | | | | | | | | This effectively reverts r121506. BUG=123150 TEST=net_unittests. Username/passwords specified in URLs work. XmlHttpRequests() with credentials passed as arguments work. Review URL: https://chromiumcodereview.appspot.com/10412025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138264 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 137445 - CHECK for that we are not seeing user-visible ↵rch@chromium.org2012-05-171-2/+0
| | | | | | | | | | | | | | SPDY_PING_FAILED errors. BUG=107048 Review URL: https://chromiumcodereview.appspot.com/10243016 TBR=rch@chromium.org Review URL: https://chromiumcodereview.appspot.com/10408010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137683 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded scoped_ptr.h includes from net.thestig@chromium.org2012-05-172-3/+2
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10383229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137636 0039d316-1c4b-4281-b951-d872f2087c98
* CHECK for that we are not seeing user-visible SPDY_PING_FAILED errors.rch@chromium.org2012-05-161-0/+2
| | | | | | | | | BUG=107048 Review URL: https://chromiumcodereview.appspot.com/10243016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137445 0039d316-1c4b-4281-b951-d872f2087c98
* Update net::HttpUtil::IsSafeHeader() with two new headersbenjhayden@chromium.org2012-05-142-0/+9
| | | | | | | | | | | Looks like W3C added Access-Control-Request-Headers and Access-Control-Request-Method to the list of unsafe headers. http://www.w3.org/TR/XMLHttpRequest/#the-setrequestheader-method BUG=126264 Review URL: https://chromiumcodereview.appspot.com/10365012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136923 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Don't attempt to doom the same entry multiple timesrvargas@google.com2012-05-094-3/+108
| | | | | | | | | | | and make sure that side effects of adding the truncation flag are considered by the cache. BUG=125159 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10382089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136172 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplements net::AddressList without struct addrinfo.szym@chromium.org2012-05-074-8/+6
| | | | | | | | | | | | | | | | net::AddressList extends std::vector<std::IPEndPoint> by canonical name. (Canonical name is planned to be removed as well.) Removes dependency on sys_addrinfo.h throughout the codebase. Introduces net::SockaddrStorage for convenience. BUG=125696 TEST=green waterfall Review URL: http://codereview.chromium.org/10309002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135731 0039d316-1c4b-4281-b951-d872f2087c98
* Disable HttpNetworkTransactionSpdy2Test.UseIPConnectionPooling* tests on ↵cbentzel@chromium.org2012-05-041-2/+16
| | | | | | | | | | | | | Windows. These were timing out on the Win7 dbg(2) bots. BUG=124776 Review URL: http://codereview.chromium.org/10354010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135439 0039d316-1c4b-4281-b951-d872f2087c98
* Refuse to pipeline frames, prefetches, and downloads.simonjam@chromium.org2012-04-302-9/+67
| | | | | | | | | | BUG=119287 TEST=Follow steps in bug Review URL: http://codereview.chromium.org/10095024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134621 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, net/rsleevi@chromium.org2012-04-283-2/+17
| | | | | | | | | | BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10066045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134460 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed unsafe passing of command-line parameter to SpdySessionbengr@google.com2012-04-276-17/+32
| | | | | | | | | | | | | | | The value of --trusted-spdy-proxy (formerly --allow-spdy-proxy-push-across-origins) is now being passed to a SpdySession via HttpNetworkSession::Params. This fixes unsafe memory handling in which a stack-allocated value was being stored in a global char* in spdy_session.cc. BUG= TEST= Review URL: http://codereview.chromium.org/10169033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134305 0039d316-1c4b-4281-b951-d872f2087c98
* net: don't remember TLS intolerant servers.agl@chromium.org2012-04-265-25/+4
| | | | | | | | | | | | | | | | | | | | | I've seen a couple of reports recently where is was clear that an SNI-only hostname had ended up in the list of TLS-intolerant servers. The result is that the user sees the non-SNI certificate for that IP address, which doesn't match the requested hostname. The only way to clear this is to restart Chrome. This change partly reverts r45088 so that we will no longer remember TLS-intolerant servers. This means that we'll perform SSLv3 fallback for every connection, if needed. That's unfortunate for truly TLS-intolerant servers, but it also means that we'll get back to TLS much faster in the event of a transient network error trigger fallback. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/10218007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134129 0039d316-1c4b-4281-b951-d872f2087c98
* Move SpdyFramer::set_enable_compression_default to BufferedSpdyFramerrch@chromium.org2012-04-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/10209012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133806 0039d316-1c4b-4281-b951-d872f2087c98
* [net] Change order of RequestPriority to natural: higher > lowerszym@chromium.org2012-04-241-2/+2
| | | | | | | | | | BUG=124683 TEST=./net_unittests Review URL: http://codereview.chromium.org/10185007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133766 0039d316-1c4b-4281-b951-d872f2087c98
* Mark HttpNetworkTransactionSpdy2Test.UseIPConnectionPooling as flakyjeremy@chromium.org2012-04-241-1/+1
| | | | | | | | | | | | | Times out on Win7 Debug - see bug for details. BUG=124776 TEST=None TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/10207008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133658 0039d316-1c4b-4281-b951-d872f2087c98
* net: Use operator!= from scoped_ptr to check if |original_url_| is NULL.tfarina@chromium.org2012-04-221-1/+1
| | | | | | | | | | | The pattern get() ? true : false isn't widely used and has just more two occurrences. R=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10168023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133385 0039d316-1c4b-4281-b951-d872f2087c98
* Report cases where the connection appears to close too early while ↵cbentzel@chromium.org2012-04-203-8/+36
| | | | | | | | | | | | | | transferring an HTTP body. This should not change behavior at all, but will let us see how commonly these situations happen in the wild. BUG=52847 TEST=Existing tests. Review URL: http://codereview.chromium.org/9950023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133208 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - replaced SpdySettings (list) with SettingsMaprtenneti@chromium.org2012-04-182-2/+0
| | | | | | | | | | | | | | | | | | CreateSettings accepts SettingsMap which enforces that there are no duplicate settings. Deleted unused class SpdySettingsStorage. In net-internals, log setting's id, flags and value for SpdySettings. BUG=119752 R=rch@chromium.org,hkhalil@google.com TEST=network unit tests Review URL: http://codereview.chromium.org/10054034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132722 0039d316-1c4b-4281-b951-d872f2087c98
* Make string literal initialization more idiomatic.thakis@chromium.org2012-04-171-3/+3
| | | | | | | | | | | | No intended behavior change. BUG=none TEST=none Review URL: http://codereview.chromium.org/10095001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132656 0039d316-1c4b-4281-b951-d872f2087c98
* HTTP Cache: Add more POST unit tests.rvargas@google.com2012-04-131-20/+42
| | | | | | | | BUG=none TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/9784007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132097 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - Added the following flow control unitests.rtenneti@chromium.org2012-04-111-0/+4
| | | | | | | | | | | | | | | | | | | | | | | * We update the send window size for all streams, current and future, on receipt of SETTINGS * We correctly handle the case where the SETTINGS frame results in a negative send window size * We correctly handle the case where the SETTINGS frame results in unstalling the send window - In SETTINGS frame if SETTINGS_INITIAL_WINDOW_SIZE is less than zero, then NetLog the value and ignore it because it is a server bug. - Adding a NetLog event that we're updating streams send window sizes by |delta_window_size| when we receive SETTINGS_INITIAL_WINDOW_SIZE. - Added code to unstall the stream if it is stalled and when |delta_window_size| makes send_window_size positive when we receive a SETTINGS frame. BUG=113091 R=willchan TEST=network unit tests Review URL: http://codereview.chromium.org/9549010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131811 0039d316-1c4b-4281-b951-d872f2087c98
* Make FileStream::Seek async and add FileStream::SeekSync for sync operationkinuko@chromium.org2012-04-111-1/+1
| | | | | | | | | BUG=75548,113300 TEST=existing tests should pass Review URL: https://chromiumcodereview.appspot.com/9949011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131732 0039d316-1c4b-4281-b951-d872f2087c98