| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=mmenke@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8949065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of calling DisableOCSP() all SSL socket used in sandbox should be created with reb_checking_enabled flag set to false.
BUG=93273
TEST=None
Review URL: http://codereview.chromium.org/7685040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=93273
TEST=SSLClientSocketNSS can be used on any thread in renderer.
Review URL: http://codereview.chromium.org/7648057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7529043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed unused/irrelevant functions
removed irrelevant comments
Moved stl_util-inl.h => stl_util.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7342047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a shared net library on Linux, and update base and
crypto API definitions.
BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7240021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This gets rid of all the ugly "is_main" logic for URLRequestContext.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7013071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without parsing, we can't detect OCSP responses that actually mean "I don't
know about this cert", or "This server has failed". But we can detect
timeouts, HTTP errors etc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6880123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch by vipul.bhasin@gmail.com.
BUG=3333
TEST=None
Review URL: http://codereview.chromium.org/6625076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the base namespace. Fix several files including lock.h unnecessarily.
BUG=none
TEST=none
Original review=http://codereview.chromium.org/6142009/
Patch by leviw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/6338002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It just adds the 'namespace net' to these files and a typedef for them, because there are many
entries to fix in one pass. They will be fixed later.
BUG=64263
TEST=trybots
Review URL: http://codereview.chromium.org/6056007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I kept a base/lock.h in place with a using statement to avoid updating
all callers in one CL.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6018013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stub and "using" declarations in the old location to avoid having to change the
entire project at once.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6001010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CRLs/OCSP responses to prevent redirects to non-HTTP URLs. This matches the initial check when first called from NSS to create the URLRequest.
In particular, fetching a CRL/OCSP response over HTTPS is troublesome, as the certificate sent by the responder may also need revocation checking, potentially causing revocation checking loops.
The existing check only considered the initial URL scheme supplied by NSS. However, if the server issues a redirect, the new URL scheme scheme was not filtered.
BUG=64521
TEST=none
Review URL: http://codereview.chromium.org/5372002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/5384002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread.
Test breakages caused by this change have been fixed here or in other changelists.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/5024003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5206005
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5242002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test breakages caused by this change have been fixed here or in other changelists.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/5024003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5206005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Test breakages caused by this change have been fixed here or in other changelists.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/5024003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59630
TEST=none
Review URL: http://codereview.chromium.org/4119020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread shutdown.
We register all ChromeURLRequestContextGetters that have a reference to a ChromeURLRequestContext with the IOThread. We unregister them when they go away. In IOThread::CleanUp(), we tell the known ChromeURLRequestContextGetters to release their references to ChromeURLRequestContexts.
BUG=58859
TEST=none
Review URL: http://codereview.chromium.org/3686003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/4014010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We register all ChromeURLRequestContextGetters that have a reference to a ChromeURLRequestContext with the IOThread. We unregister them when they go away. In IOThread::CleanUp(), we tell the known ChromeURLRequestContextGetters to release their references to ChromeURLRequestContexts.
BUG=58859
TEST=none
Review URL: http://codereview.chromium.org/3686003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59630
TEST=existing
Review URL: http://codereview.chromium.org/3822011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a revert of r62107 which is a revert of r62105 which is a revert of r60753 which is a revert of r60739 which is a revert of r60025 which is a revert of r59972 which is a revert of r59570 which is a revert of r59511 which is a revert of r59299 which is a revert of r59289.
The most recent reverts have all been due to ChromiumOS leaks which I believe to be fixed after fixing bug 58572, since I tested the combined fix in r62105 which was green on all ChromiumOS valgrind bots.
BUG=55940
TEST=Run a debug build on Linux. 10% or so of startups used to crash on startup. Shouldn't happen anymore.
Review URL: http://codereview.chromium.org/3660010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
run on ChromiumOS valgrind bots.
Revert "Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the IO loop used for OCSP."
Review URL: http://codereview.chromium.org/3681003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3669003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
valgrind bots.
Revert "Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the IO loop used for OCSP."
Review URL: http://codereview.chromium.org/3681003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Reduces console spam.
Review URL: http://codereview.chromium.org/3544011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IO loop used for OCSP.
ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP.
The only change from r59972 is the location that I set_is_main(). I set it when we set the default request context. This is because, by the time I had called set_is_main() in BrowserMain, the ChromeURLRequestContextGetter was already created (it gets created during the CreateProfile() function). So I was too late.
BUG=55940
TEST=Manual
Review URL: http://codereview.chromium.org/3391028
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3421039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP.
The only change from r59972 is the location that I set_is_main(). I set it when we set the default request context. This is because, by the time I had called set_is_main() in BrowserMain, the ChromeURLRequestContextGetter was already created (it gets created during the CreateProfile() function). So I was too late.
BUG=55940
TEST=Manual
Review URL: http://codereview.chromium.org/3391028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix the revision r60555 that broke the tree.
TBR=eroman@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3400025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This is a TODO in string_util.h)
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3390026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used for OCSP.
ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP.
Other than minor plumbing of "is_main_", this changelist is identical to r59511.
BUG=55940
TEST=Startup ChromeOS's Chrome. Should not crash on startup.
Review URL: http://codereview.chromium.org/3470001
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3468005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP.
Other than minor plumbing of "is_main_", this changelist is identical to r59511.
BUG=55940
TEST=Startup ChromeOS's Chrome. Should not crash on startup.
Review URL: http://codereview.chromium.org/3470001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IO loop used for OCSP.
Refactor nss_ocsp.cc code even more. Split up OCSP initialization into two LazyInstances. One is for the IO loop. One is for registration of OCSP callbacks in NSS, which will load NSS into memory. Sync and the normal network stack race to set their loop at the IO loop used by OCSP. We fix that by providing a SetMessageLoopForOCSP() function which will be called in the IOThread initialization code which runs before the sync thread starts up. Since we split this up from the registration of the OCSP callbacks, it won't also eagerly load NSS, which previously regressed startup time. Note that the URLRequestContext pointer is still a global, not associated with either of the LazyInstances, because it's used by worker threads which can run past the lifetime of the LazyInstances.
BUG=36740
TEST=none
Review URL: http://codereview.chromium.org/3446001
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3424010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor nss_ocsp.cc code even more. Split up OCSP initialization into two LazyInstances. One is for the IO loop. One is for registration of OCSP callbacks in NSS, which will load NSS into memory. Sync and the normal network stack race to set their loop at the IO loop used by OCSP. We fix that by providing a SetMessageLoopForOCSP() function which will be called in the IOThread initialization code which runs before the sync thread starts up. Since we split this up from the registration of the OCSP callbacks, it won't also eagerly load NSS, which previously regressed startup time. Note that the URLRequestContext pointer is still a global, not associated with either of the LazyInstances, because it's used by worker threads which can run past the lifetime of the LazyInstances.
BUG=36740
TEST=none
Review URL: http://codereview.chromium.org/3446001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
eroman caught a race in it.
BUG=36740
TEST=none
Review URL: http://codereview.chromium.org/3376005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents the IO loop being set to sync's thread instead of the IO thread.
BUG=36740
TEST=none
Review URL: http://codereview.chromium.org/3377002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in
string_util.h. This should help some dependencies since string_util changes
much more frequently than utf_string_conversions and fewer files will now need
string_utils.
Since this requires a lot of changes, this keeps a forward-declaration in
string_util so I can update the entire project incrementally. This change
updates base and net only.
I removed some includes of string_util from header files in net. In particular,
url_request_context which involved creating a new .cc file to implement a
function (already virtual so there's no speed penalty). It turns out a lot of
files were getting string_util from this include, so I had to update a bunch of
random files to now explicitly include string_util.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3076013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=11514
TEST=builds
BUG=none
Review URL: http://codereview.chromium.org/2941002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Addresses wtc's comments in http://codereview.chromium.org/2834030/show)
http://codereview.chromium.org/2827042/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(Builder compilers are dumb.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Addresses wtc's comments in http://codereview.chromium.org/2834030/show)
http://codereview.chromium.org/2827042/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IM context when it has focus.
BUG=http://crosbug.com/4449
TEST=See bug report.
Review URL: http://codereview.chromium.org/2856028
TBR=suzhe@chromium.org
Review URL: http://codereview.chromium.org/2848036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it has focus.
BUG=http://crosbug.com/4449
TEST=See bug report.
Review URL: http://codereview.chromium.org/2856028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Addresses wtc's comments in http://codereview.chromium.org/2834030/show)
http://codereview.chromium.org/2827042/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NSS (which is the default SSL library on all platforms now) has a set
of callbacks via which it fetches OCSP responsese and CRLs. This patch
adds histograms so that we can measure the amount of time spent in
these operations. (Note that these operations block SSL handshakes).
http://codereview.chromium.org/2834030/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51271 0039d316-1c4b-4281-b951-d872f2087c98
|