summaryrefslogtreecommitdiffstats
path: root/net/ocsp
Commit message (Collapse)AuthorAgeFilesLines
* [Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITYakalin@chromium.org2013-11-141-2/+2
| | | | | | | | | | | | | | | | Also remove the priority juggling in ClientSocketPoolBaseHelper, and instead assert that any requests with ignore_limits = true also has priority = MAXIMUM_PRIORITY. BUG=166689 R=asanka@chromium.org, gene@chromium.org, jamesr@chromium.org, joaodasilva@chromium.org, mmenke@chromium.org, simonjam@chromium.org TBR=benm@chromium.org, jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232802 Review URL: https://codereview.chromium.org/51683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234964 0039d316-1c4b-4281-b951-d872f2087c98
* net_ocsp: Explicitly ignore result of CalledOnValidThread().thakis@chromium.org2013-11-061-1/+4
| | | | | | | | | | BUG=314505 R=blundell@chromium.org TBR=rsleevi Review URL: https://codereview.chromium.org/58833006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233169 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 232802 "[Net] Assert that URLRequests with LOAD_IGNORE_LI..."scherkus@chromium.org2013-11-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | > [Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITY > > Also remove the priority juggling in ClientSocketPoolBaseHelper, and instead > assert that any requests with ignore_limits = true also has priority = > MAXIMUM_PRIORITY. > > BUG=166689 > R=asanka@chromium.org, gene@chromium.org, joaodasilva@chromium.org, mmenke@chromium.org, simonjam@chromium.org > TBR=benm@chromium.org, jamesr@chromium.org > > Review URL: https://codereview.chromium.org/51683002 Broke PrerenderBrowserTest.PrerenderDeferredSynchronousXHR. Running locally I was hitting a check on url_request.cc:979. TBR=akalin@chromium.org Review URL: https://codereview.chromium.org/47563006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232832 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITYakalin@chromium.org2013-11-041-2/+2
| | | | | | | | | | | | | | Also remove the priority juggling in ClientSocketPoolBaseHelper, and instead assert that any requests with ignore_limits = true also has priority = MAXIMUM_PRIORITY. BUG=166689 R=asanka@chromium.org, gene@chromium.org, joaodasilva@chromium.org, mmenke@chromium.org, simonjam@chromium.org TBR=benm@chromium.org, jamesr@chromium.org Review URL: https://codereview.chromium.org/51683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232802 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Add a priority parameter to URLRequest's constructorakalin@chromium.org2013-10-311-1/+3
| | | | | | | | | | | | | | | | | | | This is so that it is clearer what the intended initial priority of a URLRequest is. It is also needed so that we can later enforce that if a URLRequest is set to ignore limits, it has MAXIMUM_PRIORITY; otherwise, we'd have to mandate that SetPriority() is called before set_load_flags(), which is fiddly. Also standardize on a single URLRequest constructor. BUG=166689 R=jam@chromium.org, jamesr@chromium.org, joth@chromium.org, mmenke@chromium.org, scottbyer@chromium.org, sky@chromium.org, tommi@chromium.org Review URL: https://codereview.chromium.org/51953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232219 0039d316-1c4b-4281-b951-d872f2087c98
* Move ReadFileToString to the base namespace.brettw@chromium.org2013-08-301-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/19579005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220612 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in net/, part 2.avi@chromium.org2013-07-181-1/+1
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19625002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212241 0039d316-1c4b-4281-b951-d872f2087c98
* net: Migrate from googleurl/ includes to url/ ones.tfarina@chromium.org2013-07-121-1/+1
| | | | | | | | | | BUG=229660 R=eroman@chromium.org TBR=eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/6362186595172352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211347 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in net/, part 2.avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18054010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209150 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in net/ocsp/, net/proxy/, net/quic/, ↵avi@chromium.org2013-06-111-2/+2
| | | | | | | | | | | | net/server/, net/socket/, net/spdy/, net/ssl/. BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16017010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205487 0039d316-1c4b-4281-b951-d872f2087c98
* Update net/ to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-012-8/+12
| | | | | | | | | | | Linux fixes BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/15829004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203535 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce unit test for NSS OCSP/AIA fetchingrsleevi@chromium.org2013-05-241-0/+159
| | | | | | | | | BUG=176541 R=erikwright, wtc Review URL: https://chromiumcodereview.appspot.com/15080007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201984 0039d316-1c4b-4281-b951-d872f2087c98
* net: Use base::MessageLoop.xhwang@chromium.org2013-05-231-11/+11
| | | | | | | | | BUG=236029 R=agl@chromium.org Review URL: https://chromiumcodereview.appspot.com/14021017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201882 0039d316-1c4b-4281-b951-d872f2087c98
* net: Change argument of URLRequest::set_upload from UploadData to ↵hashimoto@chromium.org2012-12-151-5/+11
| | | | | | | | | | | | | | | UploadDataStream Users of URLRequest are now responsible to create UploadDataStream. UploadOwnedBytesElementReader is moved from upload_data_stream.cc to upload_bytes_element_reader.h. BUG=156574 TEST=net_unittests and git try TBR=abodenha@chromium.org for cloud_print/service/service_state.cc Review URL: https://chromiumcodereview.appspot.com/11439008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173318 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move ownership of UploadDataStream from URLRequestHttpJob to URLRequesthashimoto@chromium.org2012-11-281-2/+5
| | | | | | | | | | | | | | | | URLRequest creates and owns UploadDataStream. URLRequest::get_upload_mutable and URLRequest::AppendBytesToUpload are removed because they can modify UploadData after UploadDataStream is created. Return type of URLRequest::get_upload is changed from UploadData to UploadDataStream. A number of methods are added to UploadElementReader and its subclasses to support URLRequestAutomationJob and some other users. BUG=156574 TEST=git try TBR=jam@chromium.org (for chrome/browser/automation, already reviewed by ananta@chromium.org) Review URL: https://chromiumcodereview.appspot.com/11419034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170028 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that OCSPIOLoop is associated with right thread if restarted.blundell@chromium.org2012-11-092-0/+22
| | | | | | | | | | | | | | In tests, g_ocsp_io_loop can be shut down and restarted. Ensure that if it is restarted it is associated with the current IO thread to avoid DCHECK's potentially going off when it is subsequently (re-)shut down. BUG= Review URL: https://chromiumcodereview.appspot.com/11347039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166869 0039d316-1c4b-4281-b951-d872f2087c98
* Fix places where "request" is misspelled "requst". Surprisingly, there are ↵pkasting@chromium.org2012-10-251-1/+1
| | | | | | | | | | several. BUG=none TEST=none Review URL: https://codereview.chromium.org/11268002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164164 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Removed redundant conditiongroby@chromium.org2012-10-041-6/+6
| | | | | | | | | | | | CID=105918 R=wtc@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/11052005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160075 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the network timeout for NSS from 60 seconds to 15 secondsrsleevi@chromium.org2012-08-301-2/+12
| | | | | | | | | | | | | | BUG=143747 TEST=On Linux, Enable revocation checking via preferences. Run chrome with --v=1 from behind a captive portal/firewall that allows SSL access to a particular host, but does not allow OCSP or CRL fetches, and instead blackholes them (holds the TCP connection open). You should see "OCSP Timed out" after 15 seconds from when the OCSP connection started. Review URL: https://chromiumcodereview.appspot.com/10875059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154105 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup of NSS OCSP functionalityrsleevi@chromium.org2012-08-261-32/+29
| | | | | | | | | | | | | - Properly handle IPv6 responder URLs - Remove unnecessary net:: namespace qualifiers by moving the unnnamed namespace into net:: BUG=none Review URL: https://chromiumcodereview.appspot.com/10868086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153411 0039d316-1c4b-4281-b951-d872f2087c98
* net: Fix more clang warnings about missing virtual and OVERRIDE annotations.tfarina@chromium.org2012-08-191-3/+4
| | | | | | | | | | BUG=115047 R=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152296 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Use begin() to iterate over requests_ (a std::set) while deleting items.wtc@chromium.org2012-06-221-10/+9
| | | | | | | | | | R=willchan@chromium.org BUG=131549 TEST=to-do Review URL: https://chromiumcodereview.appspot.com/10640014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143747 0039d316-1c4b-4281-b951-d872f2087c98
* Added URLRequestContext to constructor for URLRequest.erikwright@chromium.org2012-06-221-2/+1
| | | | | | | | | | | | | Previously, the context was set using the member function set_context. Note that the context for a URLRequest is not allowed to be null. BUG=81979 TEST=None TBR=ajwong,brettw,vitalybuka,sky Review URL: https://chromiumcodereview.appspot.com/10559036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143595 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Revert "Revert "net: add OCSP tests.""""agl@chromium.org2012-03-201-9/+3
| | | | | | | | | | | | | | | | | | | | | (First landed in r127486, reverted in r127493 because it broke on Windows XP, relanded in r127518 and reverted in r127520 because Android got upset about an unused function.) I was getting increasingly unhappy altering EV and revocation checking semantics without any tests. We historically haven't had tests because online revocation checking is inherently flaky so I amended testserver with the minimum code to be able to sign and vend OCSP responses. These tests do not test the final EV/CRLSet/revocation checking semantics. They are intended to be altered in future CLs. BUG=none TEST=net_unittests https://chromiumcodereview.appspot.com/9663017/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127680 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Revert "net: add OCSP tests."""agl@chromium.org2012-03-191-3/+9
| | | | | | This reverts commit r127518. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127520 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "net: add OCSP tests.""agl@chromium.org2012-03-191-9/+3
| | | | | | | | | | | | | | | | | | | | (First landed in r127486, reverted in r127493 because it broke on Windows XP.) I was getting increasingly unhappy altering EV and revocation checking semantics without any tests. We historically haven't had tests because online revocation checking is inherently flaky so I amended testserver with the minimum code to be able to sign and vend OCSP responses. These tests do not test the final EV/CRLSet/revocation checking semantics. They are intended to be altered in future CLs. BUG=none TEST=net_unittests https://chromiumcodereview.appspot.com/9663017/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127518 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: add OCSP tests."agl@chromium.org2012-03-191-3/+9
| | | | | | This reverts commit r127486. Looks like it's broken on Windows XP only. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127493 0039d316-1c4b-4281-b951-d872f2087c98
* net: add OCSP tests.agl@chromium.org2012-03-191-9/+3
| | | | | | | | | | | | | | | | | I was getting increasingly unhappy altering EV and revocation checking semantics without any tests. We historically haven't had tests because online revocation checking is inherently flaky so I amended testserver with the minimum code to be able to sign and vend OCSP responses. These tests do not test the final EV/CRLSet/revocation checking semantics. They are intended to be altered in future CLs. BUG=none TEST=net_unittests https://chromiumcodereview.appspot.com/9663017/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127486 0039d316-1c4b-4281-b951-d872f2087c98
* net: always enable NSS's HTTP fetchesagl@chromium.org2012-03-142-18/+20
| | | | | | | | | | | | | | | By tying them to revocation checking and disabling revocation checking by default, I broke AIA chasing on Linux. This change also renames the public functions in nss_ocsp.cc to better reflect that HTTP fetching is used for more than just OCSP. BUG=117832 TEST=none (yet) Review URL: https://chromiumcodereview.appspot.com/9693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126637 0039d316-1c4b-4281-b951-d872f2087c98
* Add a convenience typedef LazyInstance<T>::Leaky to avoid repeating T.fischman@chromium.org2012-01-231-1/+1
| | | | | | | | | | | | | Converted the first 20 or so hits for LeakyLazyInstanceTraits on codesearch to demonstrate the benefit at callsites. The real change is base/lazy_instance.h; everything else is example. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9192024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118754 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up uses of static data around singletons.rsesek@chromium.org2012-01-191-2/+7
| | | | | | | | | | | | This is in preparation for destroying singletons between each test. BUG=110594 TEST=Test suites. Review URL: http://codereview.chromium.org/9255020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118320 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind fixesgroby@chromium.org2011-12-231-4/+6
| | | | | | | | | | TBR=mmenke@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/8949065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115730 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-3/+3
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DisableOCSP().sergeyu@chromium.org2011-08-232-25/+3
| | | | | | | | | | | Instead of calling DisableOCSP() all SSL socket used in sandbox should be created with reb_checking_enabled flag set to false. BUG=93273 TEST=None Review URL: http://codereview.chromium.org/7685040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97918 0039d316-1c4b-4281-b951-d872f2087c98
* Disable OCSP initialization when running in sandbox.sergeyu@chromium.org2011-08-182-3/+25
| | | | | | | | | BUG=93273 TEST=SSLClientSocketNSS can be used on any thread in renderer. Review URL: http://codereview.chromium.org/7648057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97253 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NET_API to NET_EXPORT, and rename NET_TEST to NET_EXPORT_PRIVATE.darin@chromium.org2011-08-121-5/+5
| | | | | | Review URL: http://codereview.chromium.org/7529043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96560 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add NET_API to more code to enable buildingrvargas@google.com2011-06-301-4/+6
| | | | | | | | | | | a shared net library on Linux, and update base and crypto API definitions. BUG=76997 TEST=none Review URL: http://codereview.chromium.org/7240021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91234 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using the system request context for OCSP.willchan@chromium.org2011-05-162-10/+0
| | | | | | | | | | | | This gets rid of all the ugly "is_main" logic for URLRequestContext. BUG=none TEST=none Review URL: http://codereview.chromium.org/7013071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85555 0039d316-1c4b-4281-b951-d872f2087c98
* net: add histograms for OCSP and CRL fetch failures.agl@chromium.org2011-04-221-30/+61
| | | | | | | | | | | | | Without parsing, we can't detect OCSP responses that actually mean "I don't know about this cert", or "This server has failed". But we can detect timeouts, HTTP errors etc. BUG=none TEST=none Review URL: http://codereview.chromium.org/6880123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82640 0039d316-1c4b-4281-b951-d872f2087c98
* Removing references to off the record in comments and log messages.akalin@chromium.org2011-03-081-1/+1
| | | | | | | | | | | Original patch by vipul.bhasin@gmail.com. BUG=3333 TEST=None Review URL: http://codereview.chromium.org/6625076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-211-1/+1
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestContext URLRequestContext;tfarina@chromium.org2011-01-151-4/+4
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to the remaining files under url_request directory.tfarina@chromium.org2011-01-061-3/+3
| | | | | | | | | | | | It just adds the 'namespace net' to these files and a typedef for them, because there are many entries to fix in one pass. They will be fixed later. BUG=64263 TEST=trybots Review URL: http://codereview.chromium.org/6056007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70592 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/lock and base/condition_variable to base/synchronization/brettw@chromium.org2011-01-011-18/+18
| | | | | | | | | | | I kept a base/lock.h in place with a using statement to avoid updating all callers in one CL. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6018013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70363 0039d316-1c4b-4281-b951-d872f2087c98
* Move platform_thread to base/threading and put in the base namespace. I left abrettw@chromium.org2010-12-311-2/+2
| | | | | | | | | | | stub and "using" declarations in the old location to avoid having to change the entire project at once. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6001010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70342 0039d316-1c4b-4281-b951-d872f2087c98
* When using NSS for certificate verification, add a check when fetching ↵rsleevi@chromium.org2010-12-061-0/+13
| | | | | | | | | | | | | | | CRLs/OCSP responses to prevent redirects to non-HTTP URLs. This matches the initial check when first called from NSS to create the URLRequest. In particular, fetching a CRL/OCSP response over HTTPS is troublesome, as the certificate sent by the responder may also need revocation checking, potentially causing revocation checking loops. The existing check only considered the initial URL scheme supplied by NSS. However, if the server issues a redirect, the new URL scheme scheme was not filtered. BUG=64521 TEST=none Review URL: http://codereview.chromium.org/5372002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68329 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequest URLRequest;tfarina@chromium.org2010-11-301-9/+9
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 66791 (change was innocent)willchan@chromium.org2010-11-191-9/+2
| | | | | | | | | | | | | | | | | | | Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread. Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5206005 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5242002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66808 0039d316-1c4b-4281-b951-d872f2087c98