summaryrefslogtreecommitdiffstats
path: root/net/ocsp
Commit message (Collapse)AuthorAgeFilesLines
* Remove destruction observer in CancelURLRequestukai@chromium.org2010-01-141-0/+4
| | | | | | | | | BUG=30410 TEST=none Review URL: http://codereview.chromium.org/541060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36228 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't send cookies with an OCSP request.agl@chromium.org2009-12-221-1/+2
| | | | | | | | | http://codereview.chromium.org/507066 BUG=30895 TEST=Watch an OCSP request in Wireshark (i.e. https://paypal.com). Check that cookies aren't sent. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35161 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor OCSPInitSingleton.ukai@chromium.org2009-12-171-23/+50
| | | | | | | | | | | Move OCSPInitSingleton constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/506028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34805 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call RemoveDestructionObserver on non-IO thread.ukai@chromium.org2009-12-161-24/+55
| | | | | | | | | | | | | RemoveDestructionObserver is expected to be called on the IO thread. Instead, just checking io_loop_ is NULL in destructor. IO thread should be deleted and call WillDestroyCurrentMessageLoop() before deleting singletons in AtExitManager. BUG=28526,28769 TEST=none Review URL: http://codereview.chromium.org/460067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34655 0039d316-1c4b-4281-b951-d872f2087c98
* AddRef() / Release() while URLRequest is alive in OCSPRequestSessionukai@chromium.org2009-12-071-11/+20
| | | | | | | | | | | | To make sure OCSPRequestSession is avlie while URLRequest is running, AddRef() in StartURLRequest() and Release() in OnReadCompleted(). BUG=28526,28769 TEST=none Review URL: http://codereview.chromium.org/449009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33950 0039d316-1c4b-4281-b951-d872f2087c98
* Do not set io_loop_ to NULL until we have deleted request_ and setwtc@chromium.org2009-12-031-4/+3
| | | | | | | | | | | | | | request_ to NULL, otherwise Cancel() may fail to post a CancelURLRequest task because io_loop_ is NULL but request_ is not NULL. (That task adds a reference to the OCSPRequestSession object to ensure that it lives longer than the URLRequest object.) R=ukai BUG=28526 TEST=none Review URL: http://codereview.chromium.org/460040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33698 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Apply test isolation goodness to net_unittests.phajdan.jr@chromium.org2009-12-021-0/+2
| | | | | | | | | TEST=Covered by net_unittests and test_shell_tests. BUG=12710 Review URL: http://codereview.chromium.org/460014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unnecessary workaround for NSS bug 455424, now that we requirewtc@chromium.org2009-12-011-4/+0
| | | | | | | | | | | NSS 3.12.3 or later. R=ukai BUG=none TEST=No compilation errors. Review URL: http://codereview.chromium.org/452014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33464 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Apply test isolation goodness to net_unittests."phajdan.jr@chromium.org2009-11-261-2/+0
| | | | | | | | | | | | | Revert "Fix a memory leak in DnsReloadTimer" Valgrind test_shell_tests still fails, will investigate offline. :( TBR=wtc BUG=12710 Review URL: http://codereview.chromium.org/434115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33205 0039d316-1c4b-4281-b951-d872f2087c98
* Apply test isolation goodness to net_unittests.phajdan.jr@chromium.org2009-11-261-0/+2
| | | | | | | | | | | | We're going to have it enabled for all tests, but I'm enabling it one-by-one to limit damage from possible problems. TEST=none BUG=12710 Review URL: http://codereview.chromium.org/439007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race condition in OCSPRequestSession.ukai@chromium.org2009-11-201-9/+17
| | | | | | | | | BUG=23437 TEST=none Review URL: http://codereview.chromium.org/404044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32580 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call CancelURLRequest if request_is already NULL.ukai@chromium.org2009-11-181-8/+8
| | | | | | | | | | | | | | | | Fix DCHECK when io_loop_ is NULL http://code.google.com/p/chromium/issues/detail?id=23437#c8 hits DCHECK at nss_ocsp.cc:281 in CancelURLRequest(). CancelURLRequest() is called from Cancel() if io_loop_ is not NULL. Maybe, we don't need to call CancelURLRequest if request_ is already NULL, which happens when request is completed in OnReadCompleted(). BUG=23437 TEST=none Review URL: http://codereview.chromium.org/405013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32306 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix valgrind error in nss_ocsp.ccukai@chromium.org2009-11-171-11/+36
| | | | | | | | | | | | | | I think valgrind error would happen when IO thread was terminated before cert verification timed out. So, observe IO thread destruction and once IO thread destructed, don't post task to cancel the cert verication. BUG=23437 TEST=none Review URL: http://codereview.chromium.org/390011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32150 0039d316-1c4b-4281-b951-d872f2087c98
* Move NULLing of OCSP context from UI thread to IO thread, to avoid possible ↵eroman@chromium.org2009-11-162-4/+9
| | | | | | | | races. Review URL: http://codereview.chromium.org/391062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32104 0039d316-1c4b-4281-b951-d872f2087c98
* OCSPTrySendAndReceive should always set *http_response_data_len, even onwtc@chromium.org2009-11-061-5/+13
| | | | | | | | | | | | | failure. If the response data is larger than the acceptable size, we should set *http_response_data_len to the actual size because we have downloaded the entire response. R=ukai BUG=18559 TEST=none Review URL: http://codereview.chromium.org/378003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux build break.jam@chromium.org2009-11-061-3/+0
| | | | | | | TBR=eroman Review URL: http://codereview.chromium.org/371009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31172 0039d316-1c4b-4281-b951-d872f2087c98
* Second patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-0/+6
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/368001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31165 0039d316-1c4b-4281-b951-d872f2087c98
* If the HTTP response code is -1, don't call OCSPSetResponse because thewtc@chromium.org2009-08-211-1/+6
| | | | | | | | | | | | request failed and there is no response. This fixes the crashes in OCSPTrySendAndReceive. R=willchan BUG=http://crbug.com/19915 TEST=See issue 19915 for steps to reproduce the crash. Review URL: http://codereview.chromium.org/174248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24040 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor OCSP handler.ukai@chromium.org2009-08-201-141/+48
| | | | | | | | | | | | | | Get rid of the Core class and merge into OCSPRequestSession. OCSPCreate adds ref to the OCSPRequestSession and OCSPFree calls OCSPRequestSession::Cancel and releases a reference to it. BUG=none TEST=none Review URL: http://codereview.chromium.org/173051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23806 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix crash in OCSP handlers.ukai@chromium.org2009-08-191-8/+18
| | | | | | | | | | | | | | | Make sure OCSPRequestSession::Core is cancelled when OCSPRequestSession is deleted as URLFetcher does. Revert http://src.chromium.org/viewvc/chrome?view=rev&revision=23575 BUG=18907,10911 TEST=none Review URL: http://codereview.chromium.org/165362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23696 0039d316-1c4b-4281-b951-d872f2087c98
* Implement OCSP handler for NSS.ukai@chromium.org2009-07-242-0/+622
BUG=none TEST=none Review URL: http://codereview.chromium.org/126046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21508 0039d316-1c4b-4281-b951-d872f2087c98