summaryrefslogtreecommitdiffstats
path: root/net/ocsp
Commit message (Collapse)AuthorAgeFilesLines
* Stop using DestructionObserver in OCSP code. Explicilty cancel all URLRequests.willchan@chromium.org2010-11-091-127/+154
| | | | | | | | | BUG=59630 TEST=none Review URL: http://codereview.chromium.org/4119020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65479 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63578 - Release ChromeURLRequestContextGetters' references on IO ↵willchan@chromium.org2010-10-251-1/+1
| | | | | | | | | | | | | | | | thread shutdown. We register all ChromeURLRequestContextGetters that have a reference to a ChromeURLRequestContext with the IOThread. We unregister them when they go away. In IOThread::CleanUp(), we tell the known ChromeURLRequestContextGetters to release their references to ChromeURLRequestContexts. BUG=58859 TEST=none Review URL: http://codereview.chromium.org/3686003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/4014010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63759 0039d316-1c4b-4281-b951-d872f2087c98
* Release ChromeURLRequestContextGetters' references on IO thread shutdown.willchan@chromium.org2010-10-221-1/+1
| | | | | | | | | | | We register all ChromeURLRequestContextGetters that have a reference to a ChromeURLRequestContext with the IOThread. We unregister them when they go away. In IOThread::CleanUp(), we tell the known ChromeURLRequestContextGetters to release their references to ChromeURLRequestContexts. BUG=58859 TEST=none Review URL: http://codereview.chromium.org/3686003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63578 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly shutdown OCSP.willchan@chromium.org2010-10-212-5/+15
| | | | | | | | | BUG=59630 TEST=existing Review URL: http://codereview.chromium.org/3822011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63428 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-141-1/+1
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* Reland fix for OCSP startup race.willchan@chromium.org2010-10-122-92/+177
| | | | | | | | | | | | | This is a revert of r62107 which is a revert of r62105 which is a revert of r60753 which is a revert of r60739 which is a revert of r60025 which is a revert of r59972 which is a revert of r59570 which is a revert of r59511 which is a revert of r59299 which is a revert of r59289. The most recent reverts have all been due to ChromiumOS leaks which I believe to be fixed after fixing bug 58572, since I tested the combined fix in r62105 which was green on all ChromiumOS valgrind bots. BUG=55940 TEST=Run a debug build on Linux. 10% or so of startups used to crash on startup. Shouldn't happen anymore. Review URL: http://codereview.chromium.org/3660010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62256 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62105 - Test change to fix a leak. Will revert after getting in a ↵willchan@chromium.org2010-10-102-177/+92
| | | | | | | | | | | | | run on ChromiumOS valgrind bots. Revert "Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the IO loop used for OCSP." Review URL: http://codereview.chromium.org/3681003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3669003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62107 0039d316-1c4b-4281-b951-d872f2087c98
* Test change to fix a leak. Will revert after getting in a run on ChromiumOS ↵willchan@chromium.org2010-10-102-92/+177
| | | | | | | | | | valgrind bots. Revert "Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the IO loop used for OCSP." Review URL: http://codereview.chromium.org/3681003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62105 0039d316-1c4b-4281-b951-d872f2087c98
* nss_oscp: convert LOG(INFO) to VLOG(1)evan@chromium.org2010-10-051-19/+19
| | | | | | | | Reduces console spam. Review URL: http://codereview.chromium.org/3544011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61574 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the ↵willchan@chromium.org2010-09-282-177/+92
| | | | | | | | | | | | | | | | | | IO loop used for OCSP. ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. The only change from r59972 is the location that I set_is_main(). I set it when we set the default request context. This is because, by the time I had called set_is_main() in BrowserMain, the ChromeURLRequestContextGetter was already created (it gets created during the CreateProfile() function). So I was too late. BUG=55940 TEST=Manual Review URL: http://codereview.chromium.org/3391028 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3421039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60753 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r59972: Eagerly set the IO loop used for OCSP.willchan@chromium.org2010-09-282-92/+177
| | | | | | | | | | | | | ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. The only change from r59972 is the location that I set_is_main(). I set it when we set the default request context. This is because, by the time I had called set_is_main() in BrowserMain, the ChromeURLRequestContextGetter was already created (it gets created during the CreateProfile() function). So I was too late. BUG=55940 TEST=Manual Review URL: http://codereview.chromium.org/3391028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60739 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include order to fix linux perf bot.tfarina@chromium.org2010-09-251-2/+2
| | | | | | | | | | | | This should fix the revision r60555 that broke the tree. TBR=eroman@chromium.org BUG=None TEST=None Review URL: http://codereview.chromium.org/3400025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60557 0039d316-1c4b-4281-b951-d872f2087c98
* net: Append base:: in the StringPrintf calls.tfarina@chromium.org2010-09-251-7/+8
| | | | | | | | | | | (Note: This is a TODO in string_util.h) BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3390026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60555 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59972 (chromium os leaks) - Reland r59511: Eagerly set the IO loop ↵willchan@chromium.org2010-09-212-177/+92
| | | | | | | | | | | | | | | | | | used for OCSP. ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. Other than minor plumbing of "is_main_", this changelist is identical to r59511. BUG=55940 TEST=Startup ChromeOS's Chrome. Should not crash on startup. Review URL: http://codereview.chromium.org/3470001 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3468005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60025 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r59511: Eagerly set the IO loop used for OCSP.willchan@chromium.org2010-09-202-92/+177
| | | | | | | | | | | | | ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. Other than minor plumbing of "is_main_", this changelist is identical to r59511. BUG=55940 TEST=Startup ChromeOS's Chrome. Should not crash on startup. Review URL: http://codereview.chromium.org/3470001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59972 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59511 (potentially caused chromiumos leaks) - Take 2: Eagerly set the ↵willchan@chromium.org2010-09-152-174/+92
| | | | | | | | | | | | | | | | IO loop used for OCSP. Refactor nss_ocsp.cc code even more. Split up OCSP initialization into two LazyInstances. One is for the IO loop. One is for registration of OCSP callbacks in NSS, which will load NSS into memory. Sync and the normal network stack race to set their loop at the IO loop used by OCSP. We fix that by providing a SetMessageLoopForOCSP() function which will be called in the IOThread initialization code which runs before the sync thread starts up. Since we split this up from the registration of the OCSP callbacks, it won't also eagerly load NSS, which previously regressed startup time. Note that the URLRequestContext pointer is still a global, not associated with either of the LazyInstances, because it's used by worker threads which can run past the lifetime of the LazyInstances. BUG=36740 TEST=none Review URL: http://codereview.chromium.org/3446001 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3424010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59570 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2: Eagerly set the IO loop used for OCSP.willchan@chromium.org2010-09-152-92/+174
| | | | | | | | | | | Refactor nss_ocsp.cc code even more. Split up OCSP initialization into two LazyInstances. One is for the IO loop. One is for registration of OCSP callbacks in NSS, which will load NSS into memory. Sync and the normal network stack race to set their loop at the IO loop used by OCSP. We fix that by providing a SetMessageLoopForOCSP() function which will be called in the IOThread initialization code which runs before the sync thread starts up. Since we split this up from the registration of the OCSP callbacks, it won't also eagerly load NSS, which previously regressed startup time. Note that the URLRequestContext pointer is still a global, not associated with either of the LazyInstances, because it's used by worker threads which can run past the lifetime of the LazyInstances. BUG=36740 TEST=none Review URL: http://codereview.chromium.org/3446001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r59289: "Eagerly set the IO loop used for OCSP."willchan@chromium.org2010-09-132-47/+3
| | | | | | | | | | | eroman caught a race in it. BUG=36740 TEST=none Review URL: http://codereview.chromium.org/3376005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59299 0039d316-1c4b-4281-b951-d872f2087c98
* Eagerly set the IO loop used for OCSP.willchan@chromium.org2010-09-132-3/+47
| | | | | | | | | | | This prevents the IO loop being set to sync's thread instead of the IO thread. BUG=36740 TEST=none Review URL: http://codereview.chromium.org/3377002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59289 0039d316-1c4b-4281-b951-d872f2087c98
* Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found itbrettw@chromium.org2010-07-311-1/+2
| | | | | | | | | | | | | | | | | | | | | | | weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in string_util.h. This should help some dependencies since string_util changes much more frequently than utf_string_conversions and fewer files will now need string_utils. Since this requires a lot of changes, this keeps a forward-declaration in string_util so I can update the entire project incrementally. This change updates base and net only. I removed some includes of string_util from header files in net. In particular, url_request_context which involved creating a new .cc file to implement a function (already virtual so there's no speed penalty). It turns out a lot of files were getting string_util from this include, so I had to update a bunch of random files to now explicitly include string_util.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3076013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54456 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix using pointer to freed string in OCSPTrySendAndReceive.mattm@chromium.org2010-07-101-7/+7
| | | | | | | | | | CID=11514 TEST=builds BUG=none Review URL: http://codereview.chromium.org/2941002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52027 0039d316-1c4b-4281-b951-d872f2087c98
* net: Change how we detect OCSP vs CRL requests from NSS.agl@chromium.org2010-07-021-24/+58
| | | | | | | | (Addresses wtc's comments in http://codereview.chromium.org/2834030/show) http://codereview.chromium.org/2827042/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51543 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: Change how we detect OCSP vs CRL requests from NSS."agl@chromium.org2010-07-021-57/+24
| | | | | | (Builder compilers are dumb.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51538 0039d316-1c4b-4281-b951-d872f2087c98
* net: Change how we detect OCSP vs CRL requests from NSS.agl@chromium.org2010-07-021-24/+57
| | | | | | | | (Addresses wtc's comments in http://codereview.chromium.org/2834030/show) http://codereview.chromium.org/2827042/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51537 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51480 - [Linux]When cancelling a composition, only focus out/in the ↵kinuko@chromium.org2010-07-021-53/+24
| | | | | | | | | | | | | | IM context when it has focus. BUG=http://crosbug.com/4449 TEST=See bug report. Review URL: http://codereview.chromium.org/2856028 TBR=suzhe@chromium.org Review URL: http://codereview.chromium.org/2848036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51481 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux]When cancelling a composition, only focus out/in the IM context when ↵suzhe@chromium.org2010-07-021-24/+53
| | | | | | | | | | | it has focus. BUG=http://crosbug.com/4449 TEST=See bug report. Review URL: http://codereview.chromium.org/2856028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51480 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: Change how we detect OCSP vs CRL requests from NSS."agl@chromium.org2010-07-011-53/+24
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51410 0039d316-1c4b-4281-b951-d872f2087c98
* net: Change how we detect OCSP vs CRL requests from NSS.agl@chromium.org2010-07-011-24/+53
| | | | | | | | (Addresses wtc's comments in http://codereview.chromium.org/2834030/show) http://codereview.chromium.org/2827042/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51406 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms for the duration of OCSP and CRL fetches.agl@chromium.org2010-06-301-0/+12
| | | | | | | | | | | NSS (which is the default SSL library on all platforms now) has a set of callbacks via which it fetches OCSP responsese and CRLs. This patch adds histograms so that we can measure the amount of time spent in these operations. (Note that these operations block SSL handshakes). http://codereview.chromium.org/2834030/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51271 0039d316-1c4b-4281-b951-d872f2087c98
* Pass HttpRequestHeaders to URLRequest::SetExtraRequestHeaders().willchan@chromium.org2010-05-071-10/+7
| | | | | | | | BUG=22588 Review URL: http://codereview.chromium.org/1998008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46752 0039d316-1c4b-4281-b951-d872f2087c98
* Specify alternate OCSP AIA info for certificates issued bywtc@chromium.org2010-05-071-5/+29
| | | | | | | | | | | | | | the other "Network Solutions Certificate Authority" to work around NSS bug 564334. R=ukai BUG=41730 TEST=on a Linux distribution with NSS 3.12.6, visit https://blackboard.mines.edu and then https://www.networksolutions.com. We should not get the certificate revoked error page. Review URL: http://codereview.chromium.org/2011007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46684 0039d316-1c4b-4281-b951-d872f2087c98
* Specify alternate OCSP AIA info for certificates issued bywtc@chromium.org2010-04-231-0/+78
| | | | | | | | | | | | Network Solutions Certificate Authority to work around NSS bug 524013. R=ukai BUG=41730 TEST=Visit https://blackboard.mines.edu on a Linux distribution with NSS 3.12.6. We should not get the certificate revoked error page. Review URL: http://codereview.chromium.org/1752008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45452 0039d316-1c4b-4281-b951-d872f2087c98
* Our HTTP client callback functions for NSS must set an NSS/NSPR errorwtc@chromium.org2010-04-051-11/+24
| | | | | | | | | | | | | | | | | code on failure to prevent NSS from using a residual error code from an earlier, unrelated failure. When we retry CERT_PKIXVerifyCert with AIA certificate fetch enabled, handle two more error codes that may be set by the AIA certificate fetch code on failure. R=eroman,ukai BUG=33126,36371 TEST=Visit https://student-partners.com/default.aspx. We should get the certificate not trusted error page rather than net::ERR_FAILED. Review URL: http://codereview.chromium.org/1600009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43624 0039d316-1c4b-4281-b951-d872f2087c98
* Remove destruction observer in CancelURLRequestukai@chromium.org2010-01-141-0/+4
| | | | | | | | | BUG=30410 TEST=none Review URL: http://codereview.chromium.org/541060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36228 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't send cookies with an OCSP request.agl@chromium.org2009-12-221-1/+2
| | | | | | | | | http://codereview.chromium.org/507066 BUG=30895 TEST=Watch an OCSP request in Wireshark (i.e. https://paypal.com). Check that cookies aren't sent. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35161 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor OCSPInitSingleton.ukai@chromium.org2009-12-171-23/+50
| | | | | | | | | | | Move OCSPInitSingleton constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/506028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34805 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call RemoveDestructionObserver on non-IO thread.ukai@chromium.org2009-12-161-24/+55
| | | | | | | | | | | | | RemoveDestructionObserver is expected to be called on the IO thread. Instead, just checking io_loop_ is NULL in destructor. IO thread should be deleted and call WillDestroyCurrentMessageLoop() before deleting singletons in AtExitManager. BUG=28526,28769 TEST=none Review URL: http://codereview.chromium.org/460067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34655 0039d316-1c4b-4281-b951-d872f2087c98
* AddRef() / Release() while URLRequest is alive in OCSPRequestSessionukai@chromium.org2009-12-071-11/+20
| | | | | | | | | | | | To make sure OCSPRequestSession is avlie while URLRequest is running, AddRef() in StartURLRequest() and Release() in OnReadCompleted(). BUG=28526,28769 TEST=none Review URL: http://codereview.chromium.org/449009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33950 0039d316-1c4b-4281-b951-d872f2087c98
* Do not set io_loop_ to NULL until we have deleted request_ and setwtc@chromium.org2009-12-031-4/+3
| | | | | | | | | | | | | | request_ to NULL, otherwise Cancel() may fail to post a CancelURLRequest task because io_loop_ is NULL but request_ is not NULL. (That task adds a reference to the OCSPRequestSession object to ensure that it lives longer than the URLRequest object.) R=ukai BUG=28526 TEST=none Review URL: http://codereview.chromium.org/460040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33698 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Apply test isolation goodness to net_unittests.phajdan.jr@chromium.org2009-12-021-0/+2
| | | | | | | | | TEST=Covered by net_unittests and test_shell_tests. BUG=12710 Review URL: http://codereview.chromium.org/460014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unnecessary workaround for NSS bug 455424, now that we requirewtc@chromium.org2009-12-011-4/+0
| | | | | | | | | | | NSS 3.12.3 or later. R=ukai BUG=none TEST=No compilation errors. Review URL: http://codereview.chromium.org/452014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33464 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Apply test isolation goodness to net_unittests."phajdan.jr@chromium.org2009-11-261-2/+0
| | | | | | | | | | | | | Revert "Fix a memory leak in DnsReloadTimer" Valgrind test_shell_tests still fails, will investigate offline. :( TBR=wtc BUG=12710 Review URL: http://codereview.chromium.org/434115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33205 0039d316-1c4b-4281-b951-d872f2087c98
* Apply test isolation goodness to net_unittests.phajdan.jr@chromium.org2009-11-261-0/+2
| | | | | | | | | | | | We're going to have it enabled for all tests, but I'm enabling it one-by-one to limit damage from possible problems. TEST=none BUG=12710 Review URL: http://codereview.chromium.org/439007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race condition in OCSPRequestSession.ukai@chromium.org2009-11-201-9/+17
| | | | | | | | | BUG=23437 TEST=none Review URL: http://codereview.chromium.org/404044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32580 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call CancelURLRequest if request_is already NULL.ukai@chromium.org2009-11-181-8/+8
| | | | | | | | | | | | | | | | Fix DCHECK when io_loop_ is NULL http://code.google.com/p/chromium/issues/detail?id=23437#c8 hits DCHECK at nss_ocsp.cc:281 in CancelURLRequest(). CancelURLRequest() is called from Cancel() if io_loop_ is not NULL. Maybe, we don't need to call CancelURLRequest if request_ is already NULL, which happens when request is completed in OnReadCompleted(). BUG=23437 TEST=none Review URL: http://codereview.chromium.org/405013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32306 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix valgrind error in nss_ocsp.ccukai@chromium.org2009-11-171-11/+36
| | | | | | | | | | | | | | I think valgrind error would happen when IO thread was terminated before cert verification timed out. So, observe IO thread destruction and once IO thread destructed, don't post task to cancel the cert verication. BUG=23437 TEST=none Review URL: http://codereview.chromium.org/390011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32150 0039d316-1c4b-4281-b951-d872f2087c98
* Move NULLing of OCSP context from UI thread to IO thread, to avoid possible ↵eroman@chromium.org2009-11-162-4/+9
| | | | | | | | races. Review URL: http://codereview.chromium.org/391062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32104 0039d316-1c4b-4281-b951-d872f2087c98
* OCSPTrySendAndReceive should always set *http_response_data_len, even onwtc@chromium.org2009-11-061-5/+13
| | | | | | | | | | | | | failure. If the response data is larger than the acceptable size, we should set *http_response_data_len to the actual size because we have downloaded the entire response. R=ukai BUG=18559 TEST=none Review URL: http://codereview.chromium.org/378003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux build break.jam@chromium.org2009-11-061-3/+0
| | | | | | | TBR=eroman Review URL: http://codereview.chromium.org/371009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31172 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-24 20:50:36 +0000