summaryrefslogtreecommitdiffstats
path: root/net/proxy/proxy_script_fetcher_impl.cc
Commit message (Collapse)AuthorAgeFilesLines
* Add a bug annotation to a TODO.eroman@chromium.org2011-03-291-2/+2
| | | | | | | | BUG=77366 Review URL: http://codereview.chromium.org/6756011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79657 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of custom PAC scripts in Proxy Settings API.battre@chromium.org2011-02-161-0/+13
| | | | | | | | | BUG=50725 TEST= Review URL: http://codereview.chromium.org/6504004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75102 0039d316-1c4b-4281-b951-d872f2087c98
* More net/ header/implementation method reordering.erg@google.com2011-01-211-24/+24
| | | | | | | | | | | (Contains some minor de-inlining.) BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6263010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72232 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove prefix net:: from some places that already are in namespace net.tfarina@chromium.org2011-01-191-17/+17
| | | | | | | | | | | This should address the wtc review in http://codereview.chromium.org/6338002/ BUG=64263 TEST=trybots Review URL: http://codereview.chromium.org/6322003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71787 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestContext URLRequestContext;tfarina@chromium.org2011-01-151-6/+6
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequest URLRequest;tfarina@chromium.org2010-11-301-11/+11
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent re-entrancy into ProxyScriptFetcherImpl from ~URLRequestContext.willchan@chromium.org2010-11-231-0/+3
| | | | | | | | | | | | | | | The problem is that ProxyScriptFetcherImpl::OnFetchComplete() will delete the URLRequest, which may hold the last reference to the URLRequestContext, which will destroy the ProxyScriptFetcherImpl, which still thinks the URLRequest is alive, although we are in its destructor. Furthermore, even if we dodge that bullet, ProxyScriptFetcherImpl::OnFetchComplete() will invoke the user callback after deleting the URLRequest. This callback is to the InitProxyResolver object, which got deleted in ~URLRequestContext. So, we work around both of these problems by extending the lifetime of the URLRequestContext by acquiring a reference, which we release after deleting the URLRequest and invoking the user callback. The real solution is to stop refcounting URLRequestContext and do explicit destruction ordering. That's beyond the scope of this changelist. BUG=64253 TEST=none Review URL: http://codereview.chromium.org/5256002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67181 0039d316-1c4b-4281-b951-d872f2087c98
* Address a TODO about not using recursion to handle synchronous completions ↵eroman@chromium.org2010-11-201-23/+37
| | | | | | | | | of URLRequest::Read(). Also made some stylistic changes to DCHECKS. Review URL: http://codereview.chromium.org/5070002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66848 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Move the ProxyScriptFetcher registry from being a global in net, to ↵eroman@chromium.org2010-10-161-0/+286
living in IOThread. I had to make some other changes to make this fit well: moved ProxyScriptFetcherImpl to its own set of files, and added a IOThread::Get() accessor to avoid plumbing through several layers in connection_tester. I find the registry living in IOThread is preferable, as globals in net/ limit the ability to run on safely on multiple threads, and also leads to confusion on what needs to be called at shutdown. Review URL: http://codereview.chromium.org/3823001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62876 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-20 07:58:56 +0000