summaryrefslogtreecommitdiffstats
path: root/net/socket/ssl_client_socket_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* net: split the SSL session cache between incognito and normal.agl@chromium.org2011-12-121-0/+6
| | | | | | | | | | | | | This change causes incognito requests to effectively have a different SSL session cache from other requests. SSL session information will therefore not leak into or out of incognito mode. BUG=30877 TEST=net_unittests Review URL: http://codereview.chromium.org/8857002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114098 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind().ajwong@chromium.org2011-12-091-50/+54
| | | | | | | | | | | This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users. BUG=none TEST=existing. Review URL: http://codereview.chromium.org/8824006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113825 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SPDY IP pooling for SSL connections with client authentication.wtc@chromium.org2011-10-281-0/+7
| | | | | | | | | | | | | Add a "bool client_cert_sent" member to SSLInfo to extract this info from SSLClientSocket. R=rtenneti@chromium.org BUG=101778 TEST=new unit test Review URL: http://codereview.chromium.org/8401024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107671 0039d316-1c4b-4281-b951-d872f2087c98
* Begin CompletionCallback switchover.willchan@chromium.org2011-10-011-14/+14
| | | | | | | | | | | | | Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback. Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g. BUG=98719 TEST=none Review URL: http://codereview.chromium.org/8070013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
* Send only one byte of data in the first CBC encrypted aplication datawtc@chromium.org2011-08-181-1/+1
| | | | | | | | | | | | | | record. This randomizes the IV in a backward compatible manner. R=agl@chromium.org BUG=87159 TEST=HTTPS sites continue to work. Review URL: http://codereview.chromium.org/7621002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97269 0039d316-1c4b-4281-b951-d872f2087c98
* Implement PPB_Flash_TCPSocket.InitiateSSL.yzshen@chromium.org2011-08-161-0/+37
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7535007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97005 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: Precede each CBC encrypted application data record with an ↵agl@chromium.org2011-08-091-1/+1
| | | | | | | | | | | | | | empty one." This reverts commit r91768. BUG=91905 TEST=none Review URL: http://codereview.chromium.org/7583036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95932 0039d316-1c4b-4281-b951-d872f2087c98
* Added an OriginBoundCertStore field to the SSLClientSocketNSS class andrkn@chromium.org2011-07-211-3/+9
| | | | | | | | | | | | did the plumbing to pass this field through the layers. In addition, this CL groups several fields together into a single struct |SSLClientSocket::Context|. BUG=None TEST=None Review URL: http://codereview.chromium.org/7315009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93416 0039d316-1c4b-4281-b951-d872f2087c98
* net: Precede each CBC encrypted application data record with an empty one.agl@chromium.org2011-07-071-1/+1
| | | | | | | | | | | | | | | | Precede each CBC encrypted application data record with an empty application data record in order to randomize the IV in a backwards compatible manner. (This is a reland of r90632 which was reverted in r90643 because it tickled a bug in remoting unittests.) http://codereview.chromium.org/7239002 BUG=87159 TEST=HTTPS sites continue to work. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91768 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: Precede each CBC encrypted application data record with an ↵agl@chromium.org2011-06-271-1/+1
| | | | | | | | empty one." This reverts commit 71c84a00ba9eb06356176514c392043b585bf2d8. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90643 0039d316-1c4b-4281-b951-d872f2087c98
* net: Precede each CBC encrypted application data record with an empty one.agl@chromium.org2011-06-271-1/+1
| | | | | | | | | | | | | Precede each CBC encrypted application data record with an empty application data record in order to randomize the IV in a backwards compatible manner. BUG=87159 TEST=HTTPS sites continue to work. Review URL: http://codereview.chromium.org/7239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90632 0039d316-1c4b-4281-b951-d872f2087c98
* Include SSL plaintext traffic in addition to the ciphertext when logging raw ↵rsleevi@chromium.org2011-05-191-1/+65
| | | | | | | | | | | | | bytes to a NetLog R=eroman,mmenke BUG=82562 TEST=net_unittests SSLClientSocketTest.Read_FullLogging Review URL: http://codereview.chromium.org/7017007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85866 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ClientSocket to StreamSocket.sergeyu@chromium.org2011-05-051-12/+12
| | | | | | | | | BUG=80895 TEST=Compiles Review URL: http://codereview.chromium.org/6930014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84167 0039d316-1c4b-4281-b951-d872f2087c98
* Don't require the SSL_CONNECT end event to be last in client authdavidben@chromium.org2011-03-141-3/+19
| | | | | | | | | | | | | | Because the handshake is prematurely closed, there is a race condition in which the socket may receive data (or an EOF) after we log an SSL_CONNECT event. R=wtc BUG=54445 TEST=SSLClientSocketTest.ConnectClientAuthCertRequested Review URL: http://codereview.chromium.org/3348019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78000 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSLClientSocketTest.CipherSuiteDisables flakiness.rsleevi@chromium.org2011-01-091-5/+13
| | | | | | | | | | | Depending on timing, the test server may shutdown the socket before the unit test resumes, causing an extra read to appear in the NetLog. In testing, this only seemed to happen with TCPClientSocketWin. Make the final assertion check the last or second-to-last entry to accomodate the EOF. BUG=64843 TEST=SSLClientSocketTest.CipherSuiteDisables Review URL: http://codereview.chromium.org/6072011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70859 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SSLClientSocketTest.CipherSuiteDisables as flaky.phajdan.jr@chromium.org2011-01-031-1/+2
| | | | | | | | | | TBR=rsleevi BUG=64843 TEST=net_unittests Review URL: http://codereview.chromium.org/6040004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70385 0039d316-1c4b-4281-b951-d872f2087c98
* Cache certificate verification results in memory.wtc@google.com2010-12-161-21/+37
| | | | | | | | | R=agl BUG=63357 TEST=none Review URL: http://codereview.chromium.org/5386001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69414 0039d316-1c4b-4281-b951-d872f2087c98
* Implements disabled cipher support for OpenSSL. ↵joth@chromium.org2010-12-071-9/+2
| | | | | | | | | | | | | (ssl_config_.disabled_cipher_suites) Also adds a more complete error code mapping table. BUG=None TEST=SSLClientSocketTest.CipherSuiteDisables Review URL: http://codereview.chromium.org/5592003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68495 0039d316-1c4b-4281-b951-d872f2087c98
* Update NetLog to be threadsafe.mmenke@chromium.org2010-12-011-12/+35
| | | | | | | | | | | | | | | | | | The ChromeNetLog is now owned by the browser process, and passed to the IOThread on creation. NetLog entries can be added from any thread. Observers must be able to handle having log entries added from any thread. Observers can add/remove themselves on any thread. BUG=63334 TEST=None, yet Review URL: http://codereview.chromium.org/4118004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67851 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle SSL Client Authentication requests when connectingrch@chromium.org2010-11-121-22/+11
| | | | | | | | | | | to an HTTPS/SPDY proxy. Modify SSLClientSocket classes to correctly set the host_and_port field of the cert_request_info. Modify HttpNetworkTransaction to use this field when populating the SSL client auth cache. BUG=59292 TEST=HttpProxyClientSocketPoolTest.SslClientAuth Review URL: http://codereview.chromium.org/4339001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65976 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for restricting the cipher suites that SSLClientSocket(Mac,NSS) ↵rsleevi@chromium.org2010-11-111-0/+75
| | | | | | | | | | | | use. Restricting SSLClientSocketWin is handled by the existing Windows system policy (which deals in algorithms, not cipher suites). R=wtc BUG=58831 TEST=SSLClientSocketTest.CipherSuiteDisables Review URL: http://codereview.chromium.org/3845005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65773 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup style nits in SSLClientSocketTestrsleevi@chromium.org2010-11-101-101/+55
| | | | | | | | | | R=wtc BUG=none TEST=SSLClientSocketTest* Review URL: http://codereview.chromium.org/4130005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65626 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-011-12/+12
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to test_server.py to restrict the SSL/TLS bulk encryption ↵rsleevi@chromium.org2010-10-281-8/+12
| | | | | | | | | | | algorithms via the command-line argument --ssl-alg. BUG=58831 TEST=Run test_server.py as an HTTPS server with --ssl-alg=rc4. Connect via openssl s_client -connect 127.0.0.1:1337 -cipher DEFAULT:\!RC4. Observe a connection failure. Connect with openssl s_client -connect 127.0.0.1:1337, observe that a ciphersuite that uses RC4 is negotiated. Review URL: http://codereview.chromium.org/3812007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64233 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of missing bug references to FLAKY testsstuartmorgan@chromium.org2010-10-271-0/+1
| | | | | | | | | BUG=None TEST=N/A Review URL: http://codereview.chromium.org/4135007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revert 62918 - net: clean up SSLHostInfo construction."agl@chromium.org2010-10-191-10/+20
| | | | | | | Was reverted in r62922 due to a change landing between the try run and the commit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63046 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62918 - net: clean up SSLHostInfo construction.agl@chromium.org2010-10-181-20/+10
| | | | | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/3846005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62922 0039d316-1c4b-4281-b951-d872f2087c98
* net: clean up SSLHostInfo construction.agl@chromium.org2010-10-181-10/+20
| | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62918 0039d316-1c4b-4281-b951-d872f2087c98
* net: enable SSLClientSocketTest.(ConnectExpired|ConnectMismatched)agl@chromium.org2010-10-091-21/+5
| | | | | | | | | | r62085 made the tests pass on the Windows tsan bot. TBR=aboodman TEST=net_unittests BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62088 0039d316-1c4b-4281-b951-d872f2087c98
* net: alter detection of end of SSL connection in tests.agl@chromium.org2010-10-091-2/+2
| | | | | | | | | | | | | | This is a follow-up to r61991 that alters the logic for figuring out if an SSL connection completed in unittests. The tests which use this are currently disabled. I just want to see if they start passing on the Windows tsan bot so that I can re-enable them. TBR=aboodman TEST=net_unittests BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62085 0039d316-1c4b-4281-b951-d872f2087c98
* net: mark SSLClientSocketTest.(ConnectExpired|ConnectMismatched) as FAILS_agl@chromium.org2010-10-081-4/+21
| | | | | | | | | They are failing on the Windows tsan builder only. This change also adds logging to figure out why. TBR=aboodman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61991 0039d316-1c4b-4281-b951-d872f2087c98
* net: remove test flakyness caused by uncorking.agl@chromium.org2010-10-081-13/+18
| | | | | | | | | | | | | | | | r61546 (reverted r61546, landed r61638, reverted r61672; it was blameless for the first revert.) caused flakyness in the SSLClientSocket tests because the SSL_CONNECT event may be hidden by a SOCKET_SENT event in the case that the test takes over 200ms to run. This patch changes the test to match against either event. http://codereview.chromium.org/3531019 BUG=none TEST=net_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61956 0039d316-1c4b-4281-b951-d872f2087c98
* Stop refcounting HostResolver.willchan@chromium.org2010-10-011-11/+9
| | | | | | | | | BUG=46049 TEST=none Review URL: http://codereview.chromium.org/3601002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61256 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: add test for False Start corking."agl@chromium.org2010-09-211-32/+6
| | | | | | This reverts commit r60056. The test failed on Windows. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60059 0039d316-1c4b-4281-b951-d872f2087c98
* net: add test for False Start corking.agl@chromium.org2010-09-211-6/+32
| | | | | | | | | | | See r58838 for details of why we do False Start corking. BUG=none TEST=net_unittests http://codereview.chromium.org/3427014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60056 0039d316-1c4b-4281-b951-d872f2087c98
* Mark test flakinessgavinp@chromium.org2010-09-031-1/+1
| | | | | | | | | | | | This test flaking out closed the tree earlier today. TBR=phajdan.jr BUG=54445 TEST=net_unittests ... ConnectClientAuthCertRequested Review URL: http://codereview.chromium.org/3332005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58543 0039d316-1c4b-4281-b951-d872f2087c98
* In about:net-internals, each SOCKET created by a CONNECT_JOB holds a ↵mmenke@chromium.org2010-08-251-9/+18
| | | | | | | | | | | reference to the CONNECT_JOB that spawned it. BUG=47082 TEST=manual Review URL: http://codereview.chromium.org/3164005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57339 0039d316-1c4b-4281-b951-d872f2087c98
* Adds HostResolveImpl Requests and Jobs to log.mmenke@chromium.org2010-08-241-1/+2
| | | | | | | | | | | | | | | Differences over the reverted version (http://codereview.chromium.org/3080034/show - reverted http://codereview.chromium.org/3137022/show ): * Jobs never log anything in their destructor, as the HostResolverImpl randomly outlives the NetLog, at least in some unit tests. * Removed the extra log entries for when a DNS lookup starts/completes. Instead, the job's event is ended in OnLookupComplete(). * Slight modification of the CanceledAsynchronousLookup unit test, as the Job is now closed before posting any events to the Request. For actual lookups, this behavior means the Job's duration more accurately reflects the time the DNS lookup takes itself. BUG=46844 TEST=Look at the net-internals screen. Review URL: http://codereview.chromium.org/3119027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57189 0039d316-1c4b-4281-b951-d872f2087c98
* Reintegrate certificate selection in HttpNetworkTransaction DoLoopdavidben@chromium.org2010-08-211-2/+56
| | | | | | | | | | | | | | | | | | | | | The HttpNetworkTransaction refactor intercepts the client auth handling and moves it out of DoLoop. Because HandleCertificateRequest often switches states, this caused a DCHECK and crash in some circumstances. This reintegrates it and adds unit tests to catch the DCHECK. We really want to test sending a legitimate certificate, as well as more checking interesting errors, but we cannot import temporary keys yet. We also add a patch for tlslite to send a non-empty certificate_types. Apple's SSL implementation raises a protocol error otherwise. BUG=52744,51132,52778 TEST=SSLClientSocketTest.ConnectClientAuth*,URLRequestTest.ClientAuthTest Review URL: http://codereview.chromium.org/3141026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56983 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56539 - Added HostResolveImpl Requests and Jobs to log.mmenke@chromium.org2010-08-181-2/+1
| | | | | | | | | | | | | | | | | | ConnectJobs point to the requests, Requests point back to ConnectJobs and to the DNS lookup they were attached to, if any. Also CONNECT_JOBs are now identified by their host/port on the Requests list. BUG= 46844 TEST= Look at the net-internals screen. Review URL: http://codereview.chromium.org/3080034 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/3137022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56556 0039d316-1c4b-4281-b951-d872f2087c98
* Added HostResolveImpl Requests and Jobs to log.mmenke@chromium.org2010-08-181-1/+2
| | | | | | | | | | | | | | | ConnectJobs point to the requests, Requests point back to ConnectJobs and to the DNS lookup they were attached to, if any. Also CONNECT_JOBs are now identified by their host/port on the Requests list. BUG= 46844 TEST= Look at the net-internals screen. Review URL: http://codereview.chromium.org/3080034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56539 0039d316-1c4b-4281-b951-d872f2087c98
* Test server cleanup patch of death:phajdan.jr@chromium.org2010-08-171-98/+55
| | | | | | | | | | | | | | - reduce the number of different classes - clean up the internal code - modify the interface to expose less internal details (this will allow more flexibility with port numbers) TEST=many BUG=49680 Review URL: http://codereview.chromium.org/3080029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56384 - Don't resolve IP literals.vandebo@chromium.org2010-08-171-0/+6
| | | | | | | | | | | | | | For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache. BUG=39830 TEST=unit tests, new and old Review URL: http://codereview.chromium.org/3023048 TBR=vandebo@chromium.org Review URL: http://codereview.chromium.org/3115014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56385 0039d316-1c4b-4281-b951-d872f2087c98
* Don't resolve IP literals.vandebo@chromium.org2010-08-171-6/+0
| | | | | | | | | | | For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache. BUG=39830 TEST=unit tests, new and old Review URL: http://codereview.chromium.org/3023048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56384 0039d316-1c4b-4281-b951-d872f2087c98
* Add rudimentary support for client auth in testserver.py and unit testsdavidben@chromium.org2010-08-071-0/+50
| | | | | | | | | | | | | Nothing fancy for now. Just some tests that ERR_SSL_CLIENT_AUTH_CERT_NEEDED is returned from the socket layer, and that URLRequest requests a certificate. R=wtc BUG=51132,51127 TEST=SSLClientSocketTest.ConnectClientAuthNoCert,HTTPRequestTest.ClientAuthTest Review URL: http://codereview.chromium.org/3014055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55318 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move net/socket/ssl_test_util to net/test/test_serverphajdan.jr@chromium.org2010-07-211-1/+1
| | | | | | | | | | | This is a first step to make test server easier to use and more reliable. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3040011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53137 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line flag to change the default number of parallel DNS ↵eroman@chromium.org2010-07-171-1/+2
| | | | | | | | | | | | | requests issued by chrome. --host-resolver-parallelism=XXX This is a useful debugging tool, since for some users too many parallel DNS requests results in spurious DNS failures from their resolver. BUG=44489 Review URL: http://codereview.chromium.org/3019007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52802 0039d316-1c4b-4281-b951-d872f2087c98
* Massively simplify the NetworkChangeNotifier infrastructure:pkasting@chromium.org2010-06-251-1/+1
| | | | | | | | | | | | | | * Use a process-wide object (singleton pattern) * Create/destroy this object on the main thread, make it outlive all consumers * Make observer-related functions threadsafe As a result, the notifier can now be used by any thread (eliminating things like NetworkChangeObserverProxy and NetworkChangeNotifierProxy, and expanding its usefulness); its creation and inner workings are much simplified (eliminating implementation-specific classes); and it is simpler to access (eliminating things like NetworkChangeNotifierThread and a LOT of passing pointers around). BUG=none TEST=Unittests; network changes still trigger notifications Review URL: http://codereview.chromium.org/2802015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50895 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the logging for sockets/connectjobs.eroman@chromium.org2010-06-031-3/+3
| | | | | | | | | | | | | | | | | | In particular, make it work better when using backup jobs / late binding (the display was very confused before because of how these asynchronous events would nest). Also changed the paradigm for how PassiveLogCollector preserves these async associations -- this fixes how it replays the events to net-internals. (Before we would collapse the event streams into the SOURCE_URL_REQUEST which lost some hiearchy.. now I keep the separate streams). Some of the particular changes to the event streams: * ConnectJobs now create their own source stream internally. * Sockets are now bounded by +SOCKET_ALIVE / -SOCKET_ALIVE events (removed the one-off SOCKET_DONE event). * The socket log streams contains +SOCKET_IN_USE / -SOCKET_IN_USE event blocks to show which URLRequest was controlling it at various points in time (this makes it much easier to understand which read/writes belonged to a particular network transaction when a socket gets re-used). * ConnectJobs are bounded by +SOCKET_POOL_CONNECT_JOB / - SOCKET_POOL_CONNECT_JOB events. * ConnectJobs log the net error they failed with. * Removed the SOCKET_BACKUP_TIMER_EXTENDED event. Review URL: http://codereview.chromium.org/2363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48797 0039d316-1c4b-4281-b951-d872f2087c98
* net-internals: Log the addresses that were attempted during a TCP connect, ↵eroman@chromium.org2010-05-211-15/+6
| | | | | | | | | | | | and any OS errors that attempts failed with (windows implementation) Note that this change is the same as r47764, but for the windows implementation. BUG=44488 Review URL: http://codereview.chromium.org/2127011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47956 0039d316-1c4b-4281-b951-d872f2087c98