| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adds TLS false start support. This allows us to start sending encrypted
data before we have validated the server's Finished message. (This
behaviour is already enabled on Android.)
I've verified that this works using netem to add a 200ms delay on the
loopback adaptor. I've also checked that an incorrect Finished message from
the server causes an error by hacking the Go TLS server.
Beware when looking at packet traces that the time taken in NSS's SQLite
calls can exceed the RTT of the connection and make it appear that this
code isn't functioning.
* Adds DEBUG and TRACE defines to libssl when building Chromium in Debug
mode. This means that setting SSLTRACE in the environment now works for
debug builds.
http://codereview.chromium.org/518065
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Allow Netscape-style client certs.
Remember which identity the user chooses for a domain, and put it at the top of the list next time.
BUG=36316,36446
TEST=none
Review URL: http://codereview.chromium.org/651090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also create necessary infrastructure to know the address
a client socket is connected to.
TEST=Covered by net_unittests.
BUG=35670
Review URL: http://codereview.chromium.org/598071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's not often that you can make something both dynamic and static.
BUG=16831
TEST=none
Review URL: http://codereview.chromium.org/651055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Getting the name right is important if this code is to compile with both the
10.5 SDK (where we define the type) and the 10.6 SDK (where the system defines
it). The error was introduced in r39389.
BUG=16831
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/651044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
towards redoing the Callback interfaces.
Added and removed includes as needed.
BUG=35223
TEST=trybots
Review URL: http://codereview.chromium.org/646061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This includes sending an existing identity cert, and asking the user which cert to use. Doesn't yet handle SSL renegotiation, or key-gen.
BUG=16831
TEST=none
Review URL: http://codereview.chromium.org/604067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For benchmarking we would like to pretend that we're in a world with
OCSP stapling and OCSP disk caches etc. Since we currently don't check
certificates with SPDY anyway, it's no loss if we don't check OCSP
either.
This change needs to be reverted when we start checking certificates.
Hopefully by then we'll have a better OCSP world to live in.
BUG=32020
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=This is to reduce false positive "Unable to terminate process" log entries in unit tests.
BUG=none
Review URL: http://codereview.chromium.org/600108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27870
TEST=none
Review URL: http://codereview.chromium.org/604022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the SSLClientSocketNSSFactory function there.
Put the --use-nss-for-ssl command-line switch inside ifdefs
for the platforms that need it.
Call EnsureNSPRInit on the main thread so that PR_Cleanup
will be called on the main thread.
R=mark
BUG=28744
TEST=No build errors.
Review URL: http://codereview.chromium.org/573041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when they fail.
TEST=net_unittests
BUG=27567
Review URL: http://codereview.chromium.org/582020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It used to be the case that when a disconnected socket is released, it would pop the front of the queue, and since it was a disconnected socket, would kick off another ConnectJob and then append the request to the back to the queue.
While doing this, I cleaned up the TYPE_SOCKET_WAITING_IN_QUEUE since it doesn't make sense. You're always waiting in a queue, unless the request gets fulfilled immediately. I've added strings to the LoadLog to distinguish this situation and also identify when the socket has been reused.
Review URL: http://codereview.chromium.org/583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
While this doesn't entirely remove the hack, it limits the scope of it to HostResolverImpl.
Hopefully in the future HostResolver will not be refcounted so this can go away altogether.
BUG=18373
Review URL: http://codereview.chromium.org/569035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes HttpNetworkTransaction to fallback to the next proxy after a failure is encountered using a SOCKS proxy server.
Note that I decided against using finer granularity error codes, since it just adds a higher maintenance cost to ReconsiderProxyAfterError().
Power users can get better information on the cause of the failure by looking at the LoadLog anyway.
BUG=34386
Review URL: http://codereview.chromium.org/567030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires the following refactors:
(1) NetworkChangeNotifier moves out of HttpNetworkSession into IOThread.
(2) HostResolver gets initialized with NetworkChangeNotifier.
(3) NetworkChangeNotifier needs to get passed into HttpCache and HttpNetworkSession (required updating a lot of files).
(4) NetworkChangeNotifier is no longer reference counted. It is owned by IOThread.
(5) IOThread gains a new struct: Globals. It can only be used on the io thread.
(6) ChromeURLRequestContextFactory uses IOThread::Globals to initialize ChromeURLRequest objects with the host resolver and network change notifier.
BUG=26159
Review URL: http://codereview.chromium.org/552117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I added code in r36144 so that we wouldn't create extra ConnectJobs if we were still releasing sockets. This code did not handle the case where we had multiple disconnected releasing sockets. I've added a test and code to cover this case now.
BUG=34123
Review URL: http://codereview.chromium.org/557089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the --use-nss-for-ssl or --use-flip command-line switch
is specified.
R=mark,mbelshe
BUG=28744
TEST=Run chrome.exe with and without --use-nss-for-ssl.
SSL should work in both cases.
Review URL: http://codereview.chromium.org/555186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will help in diagnosing the "slow resolving host" bugs.
Users can now click an "Enable tracing" button on "chrome://net-internals/hostresolver".
This logs detailed information on the DNS requests flowing through the browser (when they were received, when they were posted to the thread pool, when they started running on the worker thread, etc...).
BUG=12754
Review URL: http://codereview.chromium.org/556094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidates all the callers to using the testing::AssertionResult() flavor, and renames them to have "Event" in the name. This rename is in anticipation of adding testers for other entry types.
BUG=NONE
TEST=existing
Review URL: http://codereview.chromium.org/551135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/556068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A follow-up to http://codereview.chromium.org/558008.
R=evan,pvalchev
BUG=none
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/558013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actually use it (controlled by a boolean flag in SSLConfig,
which is controlled by a command-line switch).
On Windows we still use CryptoAPI to verify and display
certificates. SSL client authentication isn't supported yet.
R=agl,mark
BUG=28744
TEST=No build errors.
Review URL: http://codereview.chromium.org/557027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix cpplint nits.
R=evan,pvalchev
BUG=none
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/558008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable socket late binding. The mac valgrind errors happened due to threading bugs in test_shell_tests. The ui thread would TearDown() the test object, which deleted the TestURLRequestContext, which eventually deletes the TCPClientSocketPool, which deletes its ConnectJobs. However, those ConnectJobs might be running simultaneously on the io thread. Therefore, we have a race condition. This change fixes that.
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets. Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly. It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways. A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.
Review URL: http://codereview.chromium.org/549093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initialization to SSLClientSocketNSS in src/net so that
src/base does not depend on the NSS SSL library. Call
PL_ArenaFinish in the NSPRInitSingleton destructor instead
of the NSSInitSingleton destructor because PLArena is part
of NSPR.
R=agl,ukai
BUG=28744
TEST=covered by existing tests.
Review URL: http://codereview.chromium.org/554096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* the error code that URLRequest Start() failed with.
* which peer the TCP connection is being made to [Only in full logging mode]
(for example, when using a proxy, this may differ from the host:port of the URL).
* the type of redirect that was received, and its URL [Only in full logging mode]
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/553043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is split off from http://codereview.chromium.org/518065 (see that CL for
the review).
TBR=wtc
http://codereview.chromium.org/548087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
future bugs like the one referenced are compile time and not runtime so they won't wide waiting to be found.
BUG=32595
TEST=everything builds and tests pass
Review URL: http://codereview.chromium.org/552048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=thomasvl@chromium.org
Review URL: http://codereview.chromium.org/548082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
improve.
BUG=none
TBR=thomasvl@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/551076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32595
TEST=using a SOCKS5 proxy and a debug build, you don't blow out in a NOTREACHED() any more
Review URL: http://codereview.chromium.org/551069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the SSL 2.0 cipher suites must be available if SSL 2.0 is enabled.
R=mark
BUG=30682
TEST=none
Review URL: http://codereview.chromium.org/552014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handshake errors. It should never return a certificate error
because we don't have the server's certificate when handshake
fails.
R=agl
BUG=24064
TEST=Visit the test URL in issue 24064 comment 8 on Linux. Chromium
should not crash.
Review URL: http://codereview.chromium.org/550026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable weak cipher suites (< 80 bits of security), anonymous cipher
suites, and FORTEZZA and IDEA cipher suites.
R=mark
BUG=30682,30160,31995
TEST=Visit https://sa.www4.irs.gov/modiein/individual/index.jsp. We
should be able to load the page rather than getting the ERR_UNEXPECTED
error.
Review URL: http://codereview.chromium.org/545036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename base/nss_init.{h,cc} to base/nss_util.{h,cc}, move PRTimeToBaseTime there.
BUG=18119
TEST=Load https://www.google.com, compare to firefox cert dialog.
Review URL: http://codereview.chromium.org/500141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke mac valgrind for test_shell_tests. Various errors. I also missed fixing a bug that eroman pointed out in review. Total brainfart.
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets. Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly. It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways. A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.
Review URL: http://codereview.chromium.org/543051
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/549047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets. Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly. It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways. A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.
Review URL: http://codereview.chromium.org/543051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
which is useful for tests.
When a socket has been released to ClientSocketPoolBase, it is not immediately released, but a DoReleaseSocket() task gets posted to the MessageLoop. In many of our tests, what can happen is right after ClientSocketHandle::Reset() gets called, which posts the aforementioned release task, another ClientSocketHandle requests a socket, which starts up a ConnectJob that will completely asynchronously, but AFTER the release task happens. Note that if the released socket is no longer connected, then when DoReleaseSocket() completes, it will try to process a pending request, thereby initiating an extra ConnectJob. So, even though ClientSocketHandle::Init() may only have been called twice, we can see 3 ConnectJobs, which is weird. It's mostly harmless since this race condition probably doesn't happen much in real use, and the only side effect is an extra ConnectJob which might even be faster, but this behavior introduces difficult to control behavior in tests.
The solution taken here is to keep track of the number of pending released sockets for a ClientSocketPool group. If there are any pending released sockets, then don't start up a new ConnectJob yet, wait for the sockets to get released. This can introduce some delays for starting up ConnectJobs, but the delay should be very small (one MessageLoop iteration through the IO thread should not take long) and it only happens in the edge case where a new ClientSocketPool request comes in for the same group where a DoReleaseSocket() task has been posted. In these cases, we may also prevent unnecessary ConnectJobs from getting started up, especially if the socket is released and able to be reused.
Existing unit tests (ClientSocketPoolBaseTest_LateBinding_RequestPendingJob*) cover this change in behavior.
Review URL: http://codereview.chromium.org/550024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31628
TEST=Goto https://www.txn.banking.pcfinancial.ca/a/authentication/preSignOn.ams?referid=loginBox_banking_go - you should not see an SSL error.
http://codereview.chromium.org/518074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SOCKSClientSocket::Disconnect().
BUG=25440
TEST=SOCKSClientSocketTest.DisconnectWhileHostResolveInProgress
Review URL: http://codereview.chromium.org/525084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Bernard Cafarelli <voyageur@gentoo.org>
TEST=none
BUG=22140
Review URL: http://codereview.chromium.org/524061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added net::ERR_UNEXPECTED <=> errSSLInternal mapping.
Added net::ERR_INVALID_ARGUMENT => paramErr mapping.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/515049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renegotiation was disabled when we switched to using our internal
version of NSS. The default in the new versions is to prohibit
renegotiation. However, since we are a client this is rather
pointless. An attacker can easily convince us to start a new TLS
connection to a host if they wish.
http://codereview.chromium.org/501178
BUG=none
TEST=Go to a site that uses renegotiation (generally because they want to request a client-side cert).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc
Review URL: http://codereview.chromium.org/521032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Net.TCP_Connection_Latency
Time to connect only
- Net.DNS_Resolution_And_TCP_Connection_Latency2
Time to do DNS and Connect
- Net.HttpConnectionLatency
Time for HTTP to connect (includes all delays, DNS, Queue, TCP, etc)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Previously, the "CONNECTION_ANY" was incorrectly recorded. It was recording
every Http *transaction*, not every Http connection.
* The histogram was vague about whether it was tracking successful or
unsuccessful connections. In fact, it was recording all SSL connections (fail
or success), and yet only successful HTTP connections. Modified to only apply
to successful connections.
* Added a Net.ConnectionTypeFailCount histogram which counts the number of
failed connections by type.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/519002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/515021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
headers."
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35240 0039d316-1c4b-4281-b951-d872f2087c98
|