summaryrefslogtreecommitdiffstats
path: root/net/socket
Commit message (Collapse)AuthorAgeFilesLines
* snap_start_tests: test NPN misprediction.agl@chromium.org2010-11-171-0/+45
| | | | | | | | | | | | | | | | | When snap startting, we can hit a case where we predicted that we would negotiation an NPN protocol with a server, but then found that we were wrong. r65837 deal with this from the HTTP stack's point of view. This change adds tests to make sure that we can recover from the misprediction and get it right next time. BUG=none TEST=snap_start_tests http://codereview.chromium.org/4854002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66458 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor EnsureOpenSSLInit and openssl_util into basejoth@chromium.org2010-11-171-6/+28
| | | | | | | | | | | | This allows the base/crypto methods to call EnsureOpenSSLInit. Also factors out the SSL_CTX and X509_STORE to be more closely associated with their consumers (ssl socket and X509Certificate resp.) rather than process wide globals. BUG=None TEST=None Review URL: http://codereview.chromium.org/4963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66413 0039d316-1c4b-4281-b951-d872f2087c98
* Fix openssl build: convert hostname_ and port_ to HostPortPairjoth@chromium.org2010-11-152-10/+6
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/5004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66115 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle SSL Client Authentication requests when connectingrch@chromium.org2010-11-1223-130/+136
| | | | | | | | | | | to an HTTPS/SPDY proxy. Modify SSLClientSocket classes to correctly set the host_and_port field of the cert_request_info. Modify HttpNetworkTransaction to use this field when populating the SSL client auth cache. BUG=59292 TEST=HttpProxyClientSocketPoolTest.SslClientAuth Review URL: http://codereview.chromium.org/4339001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65976 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extra logging when using client certificates on Windows via NSSrsleevi@chromium.org2010-11-111-0/+48
| | | | | | | | | BUG=62027 TEST=None Review URL: http://codereview.chromium.org/4709005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65778 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for restricting the cipher suites that SSLClientSocket(Mac,NSS) ↵rsleevi@chromium.org2010-11-115-53/+212
| | | | | | | | | | | | use. Restricting SSLClientSocketWin is handled by the existing Windows system policy (which deals in algorithms, not cipher suites). R=wtc BUG=58831 TEST=SSLClientSocketTest.CipherSuiteDisables Review URL: http://codereview.chromium.org/3845005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65773 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "net: add Snap Start tests""agl@chromium.org2010-11-101-0/+320
| | | | | | | | | | | | | | | | | | (Reland. First landed in r65714, reverted in r65715.) These tests are Linux only for now. Adding Mac support should be pretty easy. However, Windows will be tough to do without making the tests flakey. Given the huge amounts of pain caused by testserver.py and ephemeral ports I'd rather get the tests working well on a couple of platforms (since the Snap Start code is all platform-generic anyway), then add more flakiness. BUG=none TEST=snap_start_unittests http://codereview.chromium.org/4524003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65720 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: add Snap Start tests"agl@chromium.org2010-11-101-320/+0
| | | | | | | | | | This reverts commit r65714. It broke the Linux shared library builders: SOLINK(target) out/Debug/obj.target/net/libnet_base.so /usr/bin/ld: error: out/Debug/obj.target/openssl/third_party/openssl/openssl/crypto/sha/sha512t.o: multiple definition of 'main' /usr/bin/ld: out/Debug/obj.target/openssl/third_party/openssl/openssl/crypto/sha/sha256t.o: previous definition here git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65715 0039d316-1c4b-4281-b951-d872f2087c98
* net: add Snap Start testsagl@chromium.org2010-11-101-0/+320
| | | | | | | | | | | | | | | | These tests are Linux only for now. Adding Mac support should be pretty easy. However, Windows will be tough to do without making the tests flakey. Given the huge amounts of pain caused by testserver.py and ephemeral ports I'd rather get the tests working well on a couple of platforms (since the Snap Start code is all platform-generic anyway), then add more flakiness. BUG=none TEST=snap_start_unittests http://codereview.chromium.org/4524003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65714 0039d316-1c4b-4281-b951-d872f2087c98
* net: assorted changes needed for Snap Start tests.agl@chromium.org2010-11-108-18/+60
| | | | | | | | | | | | | | | | | | | | In IsAllowedBadCert, the pointer compare doesn't always work. Creating a certificate by X509Certificate::CreateFromBytes and putting it in the allowed bad list doesn't match the same certificate from a server. InvalidateSessionIfBadCertificate: I'm sure that there's history here that I don't know, so please review carefully. In order to test resumption against a server with a test certificate we need to avoid destroying the session. ClearSessionCache, AdoptSocket: only for testing BUG=none TEST=none http://codereview.chromium.org/4558004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65713 0039d316-1c4b-4281-b951-d872f2087c98
* net: add code for encrypting DNS cert check uploads.agl@chromium.org2010-11-101-1/+137
| | | | | | | | | | | (This code isn't live yet.) BUG=none TEST=none http://codereview.chromium.org/4698003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65677 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup style nits in SSLClientSocketTestrsleevi@chromium.org2010-11-101-101/+55
| | | | | | | | | | R=wtc BUG=none TEST=SSLClientSocketTest* Review URL: http://codereview.chromium.org/4130005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65626 0039d316-1c4b-4281-b951-d872f2087c98
* net: Silently disable False Start when NetNanny is detected.agl@chromium.org2010-11-052-18/+16
| | | | | | | | | | | | | | | | | | In r62209 we added code to detect ESET and NetNanny and to give users instructions for disabling their HTTPS scanning. This was because these products intercept Chrome's HTTPS connections and break because of False Start. NetNanny has been responsive to the issue and is rolling out a fix. In the mean time, we silently disable False Start when NetNanny is detected to give them time to update their users etc. BUG=59798 TEST=Navigate to https://www.paypal.com on Windows with NetNanny installed. http://codereview.chromium.org/4449003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65199 0039d316-1c4b-4281-b951-d872f2087c98
* net: add certificate provenance checking.agl@chromium.org2010-11-0415-31/+208
| | | | | | | | | BUG=none TEST=none http://codereview.chromium.org/4448001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65116 0039d316-1c4b-4281-b951-d872f2087c98
* Support for using OS-native certificates for SSL clientwtc@chromium.org2010-11-044-38/+174
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | auth. Known Limitations: - Only SSL3/TLS1.0 handshakes are supported. It's unlikely SSLv2 will/should ever be implemented. NSS does not yet support TLS1.1/1.2. - On Windows, only CryptoAPI keys are supported. Keys that can only be accessed via CNG will fail. Technical Notes: Windows: - Only the AT_KEYEXCHANGE key is used, per http://msdn.microsoft.com/en-us/library/aa387461(VS.85).aspx - CryptSetHashParam is used to directly set the hash value. This *should* be supported by all CSPs that are compatible with RSA/SChannel, AFAICT, but testing is needed. NSS: - The define NSS_PLATFORM_CLIENT_AUTH is used to guard all of the new/patched code. The primary implementation details are in sslplatf.c. Patch author: Ryan Sleevi <rsleevi@chromium.org> Original review URL: http://codereview.chromium.org/2828002 BUG=148,37560,45369 TEST=Attempt to authenticate with a site that requires SSL client authentication (e.g., https://foaf.me/simpleLogin.php with a FOAF+SSL client certificate). Review URL: http://codereview.chromium.org/3455019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65064 0039d316-1c4b-4281-b951-d872f2087c98
* net: Make Snap Start check cert verification and add metricsagl@chromium.org2010-11-033-12/+47
| | | | | | | | | | | | | | | | This CL causes Snap Start to only trigger if the certificate verification has completed by the time we are ready to send out the handshake message. It also adds a couple of NetLog entries and histograms around the Snap Start code. BUG=none TEST=none http://codereview.chromium.org/4408001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64986 0039d316-1c4b-4281-b951-d872f2087c98
* Don't resend payload after Snap Start misprediction.agl@chromium.org2010-11-031-3/+22
| | | | | | | | | | | | | | | | | | | | | The Snap Start code in NSS worked like the prototype implementation in tlsclient. This had the library take care of resending the application data in the event of a mispredict. However, that was safe because it did certificate verification as the message was received. However, in Chrome, it's possible that a mispret could be triggered by the server having a different certificate and NSS would resend the application data before Chrome verified the certificate. This change removes that behaviour from NSS and makes the retransmission the job of ssl_client_socket_nss.cc. BUG=none TEST=none http://codereview.chromium.org/4213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64953 0039d316-1c4b-4281-b951-d872f2087c98
* A follow-up of r64178.wtc@chromium.org2010-11-021-1/+12
| | | | | | | | | | | | | | | | | | | | Check for TLS 1.1 and TLS 1.2 (not yet supported) version numbers to be future-proof. Avoid a null pointer dereference when SSL client authentication is used with SSL 2.0. This will be removed when we remove SSL 2.0 support. Define the SSL_CONNECTION_VERSION_xxx enum constants separately so we can assert their values are in range at compile time. R=eroman BUG=53659 TEST=none Review URL: http://codereview.chromium.org/4211006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64814 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 2thakis@chromium.org2010-11-026-42/+59
| | | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2826041 I then did quite a bit of manual editing to fix style issues. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4291001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64798 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a new error (ERR_NETWORK_ACCESS_DENIED) for when networkmmenke@chromium.org2010-11-023-2/+7
| | | | | | | | | | | | | | | | | | | operations return an access is denied error. This is in preparation for adding new error text suggesting a firewall may be causing the problem, which would be a little embarrassing to do when an SSPI logon fails, or when trying to open a local file one doesn't have permissions to. BUG=57108 TEST=Install firewall, block Chrome, verify that you get ERR_NETWORK_ACCESS_DENIED. Unblock it, fail an SSPI logon (Or any other event that should generate an ERR_ACCESS_DENIED) and verify that you still get an ERR_ACCESS_DENIED. Review URL: http://codereview.chromium.org/3976004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64744 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-019-42/+42
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for built-in DNS resolver/cache.agayev@chromium.org2010-10-281-1/+1
| | | | | | | | | BUG=60149 TEST=None Review URL: http://codereview.chromium.org/4216001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64271 0039d316-1c4b-4281-b951-d872f2087c98
* net: use SSL_PeerCertificateChain for getting server certsagl@chromium.org2010-10-281-56/+17
| | | | | | | | | | | | | | Now that we have SSL_PeerCertificateChain, we can remove uses of CERT_GetCertChainFromCert. The latter would return a constructed certificate chain rather than the actual chain returned from the server. Thus we can also remove the Comodo cert workaround. BUG=none TEST=net_unittests http://codereview.chromium.org/4185001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64262 0039d316-1c4b-4281-b951-d872f2087c98
* net: merge certificate validation with SSLHostInfo'sagl@chromium.org2010-10-284-27/+97
| | | | | | | | | | | | | | | | Now that SSLHostInfo is doing an opportunistic certificate validation based on the predicted certificates we can skip a second validation if we find that the prediction was correct. (This is behind --enable-snap-start because the SSLHostInfo's aren't created otherwise.) BUG=none TEST=net_unittests http://codereview.chromium.org/4147003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64258 0039d316-1c4b-4281-b951-d872f2087c98
* net: use SSL_PeerCertificateChain for SSLHostInfoagl@chromium.org2010-10-281-19/+42
| | | | | | | | | | | | | | Previously we would extract the chain built by NSS which may not have matched the actual chain sent by the server. Since we use the SSLHostInfo recorded chain for Snap Start prediction, this would trigger mispredicts. TEST=none BUG=none http://codereview.chromium.org/4103005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64245 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to test_server.py to restrict the SSL/TLS bulk encryption ↵rsleevi@chromium.org2010-10-281-8/+12
| | | | | | | | | | | algorithms via the command-line argument --ssl-alg. BUG=58831 TEST=Run test_server.py as an HTTPS server with --ssl-alg=rc4. Connect via openssl s_client -connect 127.0.0.1:1337 -cipher DEFAULT:\!RC4. Observe a connection failure. Connect with openssl s_client -connect 127.0.0.1:1337, observe that a ciphersuite that uses RC4 is negotiated. Review URL: http://codereview.chromium.org/3812007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64233 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64202 - Initial support for built-in DNS resolver/cache.yusukes@chromium.org2010-10-281-1/+1
| | | | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 TBR=agayev@chromium.org Review URL: http://codereview.chromium.org/4208002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64204 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for built-in DNS resolver/cache.agayev@chromium.org2010-10-281-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64202 0039d316-1c4b-4281-b951-d872f2087c98
* Report the SSL protocol version in ssl_info.connection_status.wtc@chromium.org2010-10-272-55/+107
| | | | | | | | | | | | | | Refactor SSLClientSocketNSS::GetSSLInfo -- the code that sets ssl_info->connection_status is moved to a new UpdateConnectionStatus method, and CheckSecureRenegotiation is subsumed by UpdateConnectionStatus. R=agl,finnur BUG=53659 TEST=none Review URL: http://codereview.chromium.org/4198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64178 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of missing bug references to FLAKY testsstuartmorgan@chromium.org2010-10-271-0/+1
| | | | | | | | | BUG=None TEST=N/A Review URL: http://codereview.chromium.org/4135007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64150 0039d316-1c4b-4281-b951-d872f2087c98
* Add experimental option for TCP FastOpen.mbelshe@chromium.org2010-10-2623-32/+220
| | | | | | | | | | | Use chrome.exe --enable-tcp-fastopen BUG=none TEST=none yet Review URL: http://codereview.chromium.org/4039003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63913 0039d316-1c4b-4281-b951-d872f2087c98
* net: always save certs and trigger verify in SSLHostInfo.agl@chromium.org2010-10-264-9/+89
| | | | | | | | | | | | | | | | | | | | | (This is still behind --enable-snap-start because the SSLHostInfo's don't get created without it.) Have ssl_client_socket_nss always save certificates to the SSLHostInfo and have the SSLHostInfo kick off a validation as soon as possible if it has the certificates. For now the validation just primes the OCSP cache and isn't tied into anything else. In future patches, the SSL socket will compare the actual certificates against the predicted certificates and avoid a second validation if they match. BUG=none TEST=none http://codereview.chromium.org/3968003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63887 0039d316-1c4b-4281-b951-d872f2087c98
* net: move importing a DER certificate chain into X509Certificate.agl@chromium.org2010-10-262-113/+9
| | | | | | | | | | | | | | | | | | This is a prelude to having SSLHostInfo be able to kick off certificate validations. The vector of intermediate certificates is added on Linux because, otherwise, nothing is holding a reference to them. Previously, the nss_fd_ was holding a reference. However, without the vector holding references, CreateFromDERChain deletes them all at the end and NSS has to AIA chase up the chain. BUG=none TEST=net_unittests http://codereview.chromium.org/3920001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63881 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-0/+1
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63648 - Revert 63643 - Add Reset to ClientSocket::UseHistory, and ↵cbentzel@chromium.org2010-10-256-3/+35
| | | | | | | | | | | | | | | | | | | | | | | | call on TCP disconnect. The failures which caused me to revert the original looked sporadic. Relanding. The HttpProxyClientSocket reuses the same TcpClientSocket in the case that it is trying to establish a tunnel through an authenticating proxy, but the proxy closed the TCP connection. Also, fix SetOmniboxSpeculation on the TCPClientSocket implementations. BUG=54062 TEST=Tried normal connections to make sure histograms were only emitted once, as well as https tunnels through an authenticating proxy to ensure that the use_history was correctly reset. Review URL: http://codereview.chromium.org/3360007 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/4006004 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/3978008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63716 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63643 - Add Reset to ClientSocket::UseHistory, and call on TCP ↵cbentzel@chromium.org2010-10-236-35/+3
| | | | | | | | | | | | | | | | | | | | | disconnect. There were a few repeating failures after I landed this CL. They looked unrelated, but I decided to revert since I didn't have a ton of time to continue investigating. Will hopefully reland soon. The HttpProxyClientSocket reuses the same TcpClientSocket in the case that it is trying to establish a tunnel through an authenticating proxy, but the proxy closed the TCP connection. Also, fix SetOmniboxSpeculation on the TCPClientSocket implementations. BUG=54062 TEST=Tried normal connections to make sure histograms were only emitted once, as well as https tunnels through an authenticating proxy to ensure that the use_history was correctly reset. Review URL: http://codereview.chromium.org/3360007 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/4006004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63648 0039d316-1c4b-4281-b951-d872f2087c98
* Add Reset to ClientSocket::UseHistory, and call on TCP disconnect.cbentzel@chromium.org2010-10-236-3/+35
| | | | | | | | | | | | | | The HttpProxyClientSocket reuses the same TcpClientSocket in the case that it is trying to establish a tunnel through an authenticating proxy, but the proxy closed the TCP connection. Also, fix SetOmniboxSpeculation on the TCPClientSocket implementations. BUG=54062 TEST=Tried normal connections to make sure histograms were only emitted once, as well as https tunnels through an authenticating proxy to ensure that the use_history was correctly reset. Review URL: http://codereview.chromium.org/3360007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63643 0039d316-1c4b-4281-b951-d872f2087c98
* Thread IO safety: annotate file_util, and block IO thread from doing IOevan@chromium.org2010-10-231-0/+6
| | | | | | | | | | | | | | | - Mark functions in file_util_posix as requiring permission to perform disk actions. - Mark the IO thread as disallowed from performing disk actions. - Temporarily work around the protections in places where we currently have bugs. BUG=59847,59849,60207,60211,60394 TEST=no dchecks in debug builds Review URL: http://codereview.chromium.org/3872002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63636 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63600 - Thread IO safety: annotate file_util, and block IO thread ↵isherman@chromium.org2010-10-231-6/+0
| | | | | | | | | | | | | | | | | | | | | | from doing IO Reverting because this breaks the ChromiumOS (dbg) builder. - Mark functions in file_util_posix as requiring permission to perform disk actions. - Mark the IO thread as disallowed from performing disk actions. - Temporarily work around the protections in places where we currently have bugs. BUG=59847,59849,60207,60211 TEST=no dchecks in debug builds Review URL: http://codereview.chromium.org/3872002 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/3983005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63630 0039d316-1c4b-4281-b951-d872f2087c98
* Thread IO safety: annotate file_util, and block IO thread from doing IOevan@chromium.org2010-10-231-0/+6
| | | | | | | | | | | | | | | - Mark functions in file_util_posix as requiring permission to perform disk actions. - Mark the IO thread as disallowed from performing disk actions. - Temporarily work around the protections in places where we currently have bugs. BUG=59847,59849,60207,60211 TEST=no dchecks in debug builds Review URL: http://codereview.chromium.org/3872002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63600 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Thread IO safety: annotate file_util, and block IO thread from doing IO"evan@chromium.org2010-10-221-6/+0
| | | | | | This reverts commit r63580, build breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63586 0039d316-1c4b-4281-b951-d872f2087c98
* Thread IO safety: annotate file_util, and block IO thread from doing IOevan@chromium.org2010-10-221-0/+6
| | | | | | | | | | | | | | | - Mark functions in file_util_posix as requiring permission to perform disk actions. - Mark the IO thread as disallowed from performing disk actions. - Temporarily work around the protections in places where we currently have bugs. BUG=59847,59849,60207,60211 TEST=no dchecks in debug builds Review URL: http://codereview.chromium.org/3872002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63580 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: More dtor deinlining. (Can almost see the end!)erg@google.com2010-10-222-0/+13
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63527 0039d316-1c4b-4281-b951-d872f2087c98
* net: move SSL host info serialisation into SSLHostInfoagl@chromium.org2010-10-2012-157/+270
| | | | | | | | | | | | | | | | | This is a prelude to SSLHostInfo being able to kick off certificate validation based on predicted certificates. In order for that to happen, SSLHostInfo has to be able to parse the contents of the saved data, therefore the serialisation/deserialisation is moved into SSLHostInfo and we use a protocol buffer to clean things up. TEST=net_unittests BUG=none Review URL: http://codereview.chromium.org/3915001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63221 0039d316-1c4b-4281-b951-d872f2087c98
* Remove scoped_bstr_win, fix all callers to use the new location.brettw@chromium.org2010-10-202-2/+0
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3748012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63216 0039d316-1c4b-4281-b951-d872f2087c98
* net: comment/TODO cleanup and clarification, and don't raise ↵rsleevi@chromium.org2010-10-202-18/+25
| | | | | | | | | | | | ERR_SSL_PROTOCOL_ERROR for user_cancelled TLS alerts on Mac. TBR=wtc BUG=none TEST=none Review URL: http://codereview.chromium.org/3938002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63199 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more ctor/virtual deinlining.erg@google.com2010-10-192-11/+51
| | | | | | | | | | | (Only 424k off Linux debug .a files). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3859003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revert 62918 - net: clean up SSLHostInfo construction."agl@chromium.org2010-10-1918-53/+132
| | | | | | | Was reverted in r62922 due to a change landing between the try run and the commit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63046 0039d316-1c4b-4281-b951-d872f2087c98
* non-virtual-dtor cleanup: Make DNSSecProvider destructor private.cbentzel@chromium.org2010-10-181-0/+3
| | | | | | | | | | Interface classes are an example where the -Wnon-virtual-dtor warning can be a bit annoying, but this still seems reasonable and makes it clear that users should not delete through the interface. BUG=45135 TEST=Builds Review URL: http://codereview.chromium.org/3781010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62926 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62918 - net: clean up SSLHostInfo construction.agl@chromium.org2010-10-1818-132/+53
| | | | | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/3846005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62922 0039d316-1c4b-4281-b951-d872f2087c98