summaryrefslogtreecommitdiffstats
path: root/net/socket
Commit message (Collapse)AuthorAgeFilesLines
* Rename origin_bound_cert files to server_bound_cert.mattm@chromium.org2012-03-221-1/+1
| | | | | | | | | BUG=115348 TEST=try bots Review URL: https://chromiumcodereview.appspot.com/9814028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128323 0039d316-1c4b-4281-b951-d872f2087c98
* Make CertVerifier a pure virtual interface.rsleevi@chromium.org2012-03-218-6/+12
| | | | | | | | | | | | | The existing CertVerifier implementation has been renamed to MultiThreadedCertVerifier, consistent with ProxyResolver naming. This is patch 1 of N for http://crbug.com/114343 BUG=114343 TEST=Compiles and existing unittests pass. Review URL: https://chromiumcodereview.appspot.com/9476035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128090 0039d316-1c4b-4281-b951-d872f2087c98
* Increase number of max sockets per group for WebSocket connections.yutak@chromium.org2012-03-214-45/+107
| | | | | | | | | | | | | | | | | | | This change makes ClientSocketPoolManager aware of SocketPoolType so it can pick a different limit for normal socket pools and WebSocket socket pools. As an initial (experimental) setting, number of max sockets per group for WebSocket connections is raised to 30, and other limits are set to the same value as normal socket pools. This configuration should be revisited later when WebSocket protocol stack starts to work and a good amount of usage metrics are collected. BUG=118268 TEST=none Review URL: http://codereview.chromium.org/9764003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128044 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting to re-land the feature.rch@chromium.org2012-03-2112-33/+486
| | | | | | | | | | | | | | | | | | | | | | | Revert 127730 - Revert 127717 - Revert 118788 - Revert 113405 - Revert 113305 - Revert 113300 - Revert 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan). Added NET_EXPORT for layered_pool class defintion to fix windows shared compile. BUG=62364, 92244, 109876, 110368 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127717 Review URL: https://chromiumcodereview.appspot.com/9667016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127893 0039d316-1c4b-4281-b951-d872f2087c98
* Change Origin bound certs -> Domain bound certs.mattm@chromium.org2012-03-2018-138/+140
| | | | | | | | | | BUG=115348 TEST=unit tests, manually checked 'Origin Bound Certs' contents after browsing TBR=jam@chromium.org,willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/9617039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127817 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 127717 - Revert 118788 - Revert 113405 - Revert 113305 - Revert ↵rch@chromium.org2012-03-2012-486/+33
| | | | | | | | | | | | | | | | | | | | | | | | | 113300 - Revert 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan). Added NET_EXPORT for layered_pool class defintion to fix windows shared compile. BUG=62364, 92244, 109876, 110368 TEST= Review URL: http://codereview.chromium.org/9667016 TBR=rch@chromium.org Review URL: https://chromiumcodereview.appspot.com/9760002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127730 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118788 - Revert 113405 - Revert 113305 - Revert 113300 - Revert ↵rch@chromium.org2012-03-2012-33/+486
| | | | | | | | | | | | | | | | | | | | | | 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan). Added NET_EXPORT for layered_pool class defintion to fix windows shared compile. BUG=62364, 92244, 109876, 110368 TEST= Review URL: http://codereview.chromium.org/9667016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127717 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 125973 - Turn off TLS_RSA_WITH_RC4_128_MD5.wtc@chromium.org2012-03-181-3/+0
| | | | | | | | | | | | | | | | | | We received several bug reports of servers that only support TLS_RSA_WITH_RC4_128_MD5. Since HMAC-MD5 is still considered secure (see RFC 6151 Section 2.3), this patch reinistates TLS_RSA_WITH_RC4_128_MD5 support. Original review URL: http://codereview.chromium.org/9666016 TBR=agl@chromium.org,rsleevi@chromium.org BUG=118330 TEST=Visit https://missouristate.info/feeds/calendar.aspx. Should not get the net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH error. Review URL: https://chromiumcodereview.appspot.com/9722027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127398 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new set of socket pools for WebSocket connections to HttpNetworkSession.yutak@chromium.org2012-03-171-8/+17
| | | | | | | | | | | | | | | | | | This change adds a new ClientSocketPoolManager that manages a set of socket pools holding WebSocket connections. To be able to selectively return the socket pool for normal use or WebSocket use, a new SocketPoolType argument is added to socket pool getters. Due to changes to getter function signatures, many files (mostly testing code) have to be updated. BUG=118268 TEST=none Review URL: http://codereview.chromium.org/9703087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127306 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "base/values.h" import from "base/location.h", fix up downstream files.isherman@chromium.org2012-03-161-2/+2
| | | | | | | | | | BUG=none TEST=none TBR=sky@chromium.org,dmazzoni@chromium.org,thestig@chromium.org,joaodasilva@chromium.org,willchan@chromium.org,hclam@chromium.org Review URL: http://codereview.chromium.org/9703098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127256 0039d316-1c4b-4281-b951-d872f2087c98
* Add an SSLConfig option to explicit disable NSSHttpIO.agl@chromium.org2012-03-154-4/+14
| | | | | | | | | | | | | This appears to be the least-bad solution to the problem that remoting can't run SSL sockets on an IO MessageLoop. See linked bug for details. BUG=118247 TEST=remoting_unittests Review URL: http://codereview.chromium.org/9702075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127015 0039d316-1c4b-4281-b951-d872f2087c98
* Add a source id to global NetLog entries, which makes themmmenke@chromium.org2012-03-151-2/+2
| | | | | | | | | | | | | | easier to sort in about:net-internals, making the world a happier, fuzzier place. Also slightly simplifies the functions to add NetLog entries, and makes it impossible to create a BoundNetLog with both an invalid source and a non-NULL NetLog. BUG=116597 Review URL: https://chromiumcodereview.appspot.com/9585026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126849 0039d316-1c4b-4281-b951-d872f2087c98
* Add a boolean |has_context| argument to the TLS ExportKeyingMaterialwtc@chromium.org2012-03-1515-30/+48
| | | | | | | | | | | | method to support both nonexistent context and zero-length context. R=agl@chromium.org,rsleevi@chromium.org BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/9663043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126799 0039d316-1c4b-4281-b951-d872f2087c98
* net: always enable NSS's HTTP fetchesagl@chromium.org2012-03-141-6/+4
| | | | | | | | | | | | | | | By tying them to revocation checking and disabling revocation checking by default, I broke AIA chasing on Linux. This change also renames the public functions in nss_ocsp.cc to better reflect that HTTP fetching is used for more than just OCSP. BUG=117832 TEST=none (yet) Review URL: https://chromiumcodereview.appspot.com/9693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126637 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - integration of spdy/3 code.rtenneti@google.com2012-03-122-1/+6
| | | | | | | | TEST=network unit tests and browser unit_tests R=willchan Review URL: https://chromiumcodereview.appspot.com/9618002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126175 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 125571 - Turn off TLS_RSA_WITH_RC4_128_MD5.wtc@chromium.org2012-03-101-1/+4
| | | | | | | | | | | | | | Although HMAC-MD5 is still considered secure, it is an eyesore to people who audit the use of MD5. Enabling TLS_RSA_WITH_RC4_128_SHA is enough. R=rsleevi@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/9666016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125973 0039d316-1c4b-4281-b951-d872f2087c98
* Roll OpenSSL deps, implement keying material exporter and testhclam@chromium.org2012-03-082-1/+68
| | | | | | | | | | | | | | | Changes included: 1. OpenSSL deps to include support for keying material exporter. 2. Implement keying material exported in SSLClientSocket. 3. Add unit test to make the feature runs. BUG=None TEST=net_unittests Review URL: http://codereview.chromium.org/9648005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125720 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a failing SSL test when USE_OPENSSL is defined.rsleevi@chromium.org2012-03-081-5/+7
| | | | | | | | | | | | | | In order for the test to succeed in a default installation, it requires OpenSSL 1.1.0 or later. OpenSSL 1.1.0 has not yet been released. BUG=117196 TEST=linux_redux on the FYI tree & trybots goes green TBR=jnd@chromium.org Review URL: https://chromiumcodereview.appspot.com/9652007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125663 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 125571 - Turn off TLS_RSA_WITH_RC4_128_MD5.akalin@chromium.org2012-03-081-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | May be causing CertVerifierTest.CacheHit to fail on Mac 10.5 Tests(3). CertVerifierTest.CacheHit: [857:-1341378560:0307/223216:538014232777:ERROR:x509_certificate_mac.cc(63)] Unknown error mapped to ERR_FAILED: (-2147418109) /b/build/slave/cr-mac-rel/build/src/net/base/cert_verifier_unittest.cc:47: Failure Value of: IsCertificateError(error) Actual: false Expected: true Although HMAC-MD5 is still considered secure, it is an eyesore to people who audit the use of MD5. Enabling TLS_RSA_WITH_RC4_128_SHA is enough. R=rsleevi@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/9600072 TBR=wtc@chromium.org Review URL: https://chromiumcodereview.appspot.com/9638007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125583 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off TLS_RSA_WITH_RC4_128_MD5.wtc@chromium.org2012-03-081-1/+4
| | | | | | | | | | | | | | Although HMAC-MD5 is still considered secure, it is an eyesore to people who audit the use of MD5. Enabling TLS_RSA_WITH_RC4_128_SHA is enough. R=rsleevi@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/9600072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125571 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Pickle Read methods to use higher performance PickleIterator.jbates@chromium.org2012-03-071-1/+1
| | | | | | | | | | | | | | | | There was a lot of redundant error checking and initialization code in all Pickle Read methods because of the void** iterator type. This change replaces the void* iterator with PickleIterator, which encapsulates the read pointer so that less error checking and initialization code is needed for reading. PickleIterator has all the necessary data to do the actual reading. The advantage of having it provide Read methods (as opposed to leaving them solely in the Pickle interface) is that the callers do not need to pass around the const Pickle* once they have a PickleIterator. Followup CLs will refactor the call sites to remove const Pickle* arguments where they are now unnecessary. Then the Pickle::Read* methods can be removed entirely. The alternative approach would have been to change the Pickle::Read methods to non-const and remove the iterator parameter (making Read methods advance an internal read pointer). Unfortunately, the const Read with iterator design is entrenched throughout the chromium code, making this a much more complex change with the same performance outcome. BUG=13108 Review URL: https://chromiumcodereview.appspot.com/9447084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125447 0039d316-1c4b-4281-b951-d872f2087c98
* Use a scoped class for managing test root certs in unit testsrsleevi@chromium.org2012-03-071-2/+1
| | | | | | | | | | | BUG=none TEST=none R=rtenneti@chromium.org Review URL: http://codereview.chromium.org/9605026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125363 0039d316-1c4b-4281-b951-d872f2087c98
* When using SSLClientSocketWin, record the full certificate chain sent by the ↵rsleevi@chromium.org2012-03-061-43/+63
| | | | | | | | | | | server BUG=none TEST=SSLClientSocketTest.VerifyReturnChainProperlyOrdered Review URL: https://chromiumcodereview.appspot.com/7333001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125038 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some extra log spam from StaticSocketDataProvider::OnWritersleevi@chromium.org2012-03-041-1/+0
| | | | | | | | | | | BUG=none TEST=none R=rch@chromium.org Review URL: http://codereview.chromium.org/9594006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124888 0039d316-1c4b-4281-b951-d872f2087c98
* Fork SPDY/2 and SPDY/3 versions of our SPDY tests, in preparation for landingrch@chromium.org2012-03-041-1/+3
| | | | | | | spdy 3 framer changes. Review URL: https://chromiumcodereview.appspot.com/9582034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124886 0039d316-1c4b-4281-b951-d872f2087c98
* Update net/third_party/nss to NSS 3.13.3.wtc@chromium.org2012-03-032-12/+27
| | | | | | | | | | | | | | | | | | | | | | | | The following patches have been upstreamed: - net/third_party/nss/patches/handshakeshortwrite.patch - net/third_party/nss/patches/cbcrandomiv.patch - net/third_party/nss/patches/nextproto.patch - portions of patches/cachecerts.patch that add certificates to ss->ssl3.peerCertChain in the right order. - portions of net/third_party/nss/patches/clientauth.patch that fix NSS bug 616757. I omitted the net/third_party/nss/patches/cachedinfo.patch because Chrome isn't using the TLS cached info extension and I wanted to maintain fewer patches. We can add it back later. R=rsleevi@chromium.org,agl@chromium.org BUG=116617 TEST=Unit tests should pass. Manual tests of SSL client auth and origin-bound certs. Review URL: http://codereview.chromium.org/9558017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124862 0039d316-1c4b-4281-b951-d872f2087c98
* Provide the certificate chain as validated to SSLInfo.palmer@chromium.org2012-03-035-4/+108
| | | | | | | | | | | | | Previously, SSLInfo was given the cert chain as served by the server. It is more useful and correct to provide higher layers the cert chain as validated. BUG=77757, 87303, 115312 TEST=net_unittests SSLClientSocketTest.VerifyReturnChainProperlyOrdered Review URL: http://codereview.chromium.org/9442001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124804 0039d316-1c4b-4281-b951-d872f2087c98
* Add a force pipelining option to load flags.simonjam@chromium.org2012-03-013-0/+356
| | | | | | | | | | | | | | | | | | | | | Details: - Add a HttpPipelinedHostForced class for connections with forced requests. + Forced requests get their own pipeline and there's only one per host. + They always try to pipeline and won't retry if evicted. + Only one HttpStreamFactoryImpl::Job runs for all requests to the same origin with forced pipelining. All requests will fail if that Job fails. - Track HttpPipelinedHosts with a Key. Right now that's origin and force-pipelining, but it might be expanded to include content type. - Add a BufferedWriteStreamSocket that wraps a normal socket. It buffers Write() calls until a task fires to dispatch the buffer to the underlying socket. BUG=110794 TEST=net_unittests and unit_tests Review URL: http://codereview.chromium.org/9433015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove support for RSA Origin Bound Certificates.mattm@chromium.org2012-02-291-19/+0
| | | | | | | | | | | | | Generating them is too slow & power hungry, especially on mobile devices. BUG=none TEST=unittests Review URL: http://codereview.chromium.org/9372118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124124 0039d316-1c4b-4281-b951-d872f2087c98
* Set SSLInfo.client_cert_sent when origin bound cert was sent.mattm@chromium.org2012-02-255-9/+10
| | | | | | | | | | BUG=115376 TEST=none Review URL: http://codereview.chromium.org/9454025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123620 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of a deprecated TestServer constructor.erikwright@chromium.org2012-02-241-8/+24
| | | | | | | | | | | | | | | | | | Hostname must now be explicitly specified (previously default was 127.0.0.1). See the following CL for further details: http://codereview.chromium.org/9369029/ A follow-up CL will remove the deprecated constructor: http://codereview.chromium.org/9431002/ BUG=114369 TEST=everything still compiles and passes Review URL: http://codereview.chromium.org/9430050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123486 0039d316-1c4b-4281-b951-d872f2087c98
* Change MockRead and MockWrite (et. al.) to take an IoMode enum, insteadrch@chromium.org2012-02-238-222/+227
| | | | | | | | of a bool async. Review URL: http://codereview.chromium.org/9425016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123274 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify the initialization of the various NPN fields in SSLSocketDataProvider.rch@chromium.org2012-02-223-18/+15
| | | | | | Review URL: http://codereview.chromium.org/9413018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123125 0039d316-1c4b-4281-b951-d872f2087c98
* While calling IO methods on accepted TCP sockets we run into problem that ↵ygorshenin@chromium.org2012-02-222-7/+70
| | | | | | | | | | | AssertEventNotSignaled is triggered in TCPClientSocketWin::{Read|Write} methods. This CL fixes this issue and adds test. BUG=99602 TEST=TCPServerSocketTest Review URL: https://chromiumcodereview.appspot.com/9413007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122998 0039d316-1c4b-4281-b951-d872f2087c98
* Always log the SSL server certificate received and being verified.rsleevi@chromium.org2012-02-224-16/+10
| | | | | | | | | | | | Now that there is no passive NetLog interface, the overhead for always-logging is expected to be minimal. BUG=none TEST=none Review URL: http://codereview.chromium.org/9432018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122987 0039d316-1c4b-4281-b951-d872f2087c98
* net: log the number of certificates from NSS.agl@chromium.org2012-02-211-0/+2
| | | | | | | | | | | | | (Temporary change that should be reverted once the bug in question has been tracked down.) BUG=114709 TEST=none Review URL: http://codereview.chromium.org/9429010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122908 0039d316-1c4b-4281-b951-d872f2087c98
* net: remove special case for Kaspersky HTTPSagl@chromium.org2012-02-212-13/+1
| | | | | | | | | | | | Kaspersky released an updated version some months ago and hopefully most users have upgraded by now. BUG=86208 TEST=none Review URL: https://chromiumcodereview.appspot.com/9419014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122835 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 122760 - While calling IO methods on accepted TCP sockets we run into ↵jam@chromium.org2012-02-202-69/+7
| | | | | | | | | | | | | | problem that AssertEventNotSignaled is triggered in TCPClientSocketWin::{Read|Write} methods. This CL fixes this issue and adds test. BUG=99602 TEST=TCPServerSocketTest Review URL: http://codereview.chromium.org/9413007 TBR=ygorshenin@chromium.org Review URL: https://chromiumcodereview.appspot.com/9423044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122763 0039d316-1c4b-4281-b951-d872f2087c98
* While calling IO methods on accepted TCP sockets we run into problem that ↵ygorshenin@chromium.org2012-02-202-7/+69
| | | | | | | | | | | AssertEventNotSignaled is triggered in TCPClientSocketWin::{Read|Write} methods. This CL fixes this issue and adds test. BUG=99602 TEST=TCPServerSocketTest Review URL: http://codereview.chromium.org/9413007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122760 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the MockConnect constructor to take an enum of ASYNC or SYNCHRONOUS,rch@chromium.org2012-02-175-22/+28
| | | | | | | | instead of a boolean async. Review URL: http://codereview.chromium.org/9419032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122581 0039d316-1c4b-4281-b951-d872f2087c98
* Pull out debug instrumentation.mattm@chromium.org2012-02-172-12/+0
| | | | | | | | | | | | | | | | | The check hasn't been hit, and the crash has stopped after rch's change r121829. Revert 121851 - Add some instrumentation to track down a crash. See if the state machine in SSLClientSocketNSS is failing to cancel the origin bound certificate request. BUG=113233 Review URL: http://codereview.chromium.org/9383034 Review URL: http://codereview.chromium.org/9417035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122437 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the global HCERTSTORE from Windows in favour of using the NULL ↵rsleevi@chromium.org2012-02-151-10/+9
| | | | | | | | | | | | | | | | | HCERTSTORE. BUG=none TEST=Existing unit tests should cover all affected functionality. (Windows Only) On a fresh profile, navigate to different HTTPS sites. From the Page Info bubble, select Certificate Information, and in the Windows Certificate Viewer, click "Certification Path" to ensure the entire chain is displayed. This is a variation of http://crbug.com/45706, which should not regress. Review URL: http://codereview.chromium.org/9381016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122055 0039d316-1c4b-4281-b951-d872f2087c98
* Prefer ScopedNestableTaskAllower over manual save/restoredhollowa@chromium.org2012-02-142-5/+6
| | | | | | | | | | | | | | Cleanup. Changes various calls sites to use the ScopedNestableTaskAllower class to save/restore nestable task state. BUG=None TEST=Existing unit tests R=jar@chromium.org, scottbyer@chromium.org, sky@chromium.org, akalin@chromium.org, rsleevi@chromium.org, brettw@chromium.org, tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/9384024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121914 0039d316-1c4b-4281-b951-d872f2087c98
* Add some instrumentation to track down a crash.eroman@chromium.org2012-02-142-0/+12
| | | | | | | | | | | See if the state machine in SSLClientSocketNSS is failing to cancel the origin bound certificate request. BUG=113233 Review URL: http://codereview.chromium.org/9383034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121851 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CREDENTIALS frames when using spdy/2.1 or earlier.rch@chromium.org2012-02-141-0/+1
| | | | | | | | | | Add enum for spdy/3 which is used in CREDENTIAL frame unittests. BUG=113847 Review URL: http://codereview.chromium.org/9391027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121829 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the credentials frame.rch@chromium.org2012-02-0812-20/+89
| | | | | | | | | | | | Need to allow spdy sessions to see if the underlying socket is required OBCs. If so, and if pooling a connection, then we need to generate a CREDENTIALS frame for this origin. Need to add support for the RST_FRAME status code of INVALID CREDENTIALS Review URL: http://codereview.chromium.org/9294001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120923 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ref leak in WebSocketServerSocketImpl introduced in r115422.rnk@chromium.org2012-02-071-2/+2
| | | | | | | | | | | | | | Also remove the heapcheck and memcheck suppressions. Added cbentzel and timurrrr for OWNERS approval. R=jhawkins@chromium.org,cbentzel@chromium.org,timurrrr@chromium.org BUG=108399 TEST=ran WebSocketServerSocketTest.* under drmemory Review URL: https://chromiumcodereview.appspot.com/9309090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120775 0039d316-1c4b-4281-b951-d872f2087c98
* Fix calls in base and net unit tests to use TimeDelta.tedvessenes@gmail.com2012-02-042-9/+12
| | | | | | | | | | | | | | | | I found another batch of unit tests that needed their Sleep() and PostDelayedTask() interfaces updated. As far as I know, this is the last batch of changes required before the deprecated integer interfaces to these functions can be removed. R=jar@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9316036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120480 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118950 - Allow chrome to handle 407 auth challenges to CONNECT requestsrch@chromium.org2012-02-034-34/+15
| | | | | | | | | | | | | | | | | | | | through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Initially was http://codereview.chromium.org/8502024 which turned out to have problems with NTLM auth. Review URL: http://codereview.chromium.org/9148011 TBR=rch@chromium.org Review URL: https://chromiumcodereview.appspot.com/9316101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120370 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in files owned by jar.tedvessenes@gmail.com2012-01-285-34/+39
| | | | | | | | | | | R=jar@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9190027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119547 0039d316-1c4b-4281-b951-d872f2087c98