summaryrefslogtreecommitdiffstats
path: root/net/spdy/spdy_network_transaction_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* SPDY flow control: add support for receive window sizeagayev@chromium.org2010-08-261-11/+94
| | | | | | | | | BUG=48100 TEST=net_unittests Review URL: http://codereview.chromium.org/3137014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57453 0039d316-1c4b-4281-b951-d872f2087c98
* Move the stream initialization out of the HttpStreamRequest and backmbelshe@chromium.org2010-08-251-7/+48
| | | | | | | | | | | | | | into the HttpNetworkTransaction. The reason is because the stream factory should get the stream connected, but not actually initialize the stream; stream initialization should only happen when the stream uses it. BUG=none TEST=none Review URL: http://codereview.chromium.org/3137034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57342 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: change the spdy session pool key to take a ProxyServer instead of ↵eroman@chromium.org2010-08-251-3/+6
| | | | | | | | | a string representation of the proxy server. BUG=52668 Review URL: http://codereview.chromium.org/3197018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57297 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the key into the spdy session pool identifies the actual proxy ↵eroman@chromium.org2010-08-251-7/+17
| | | | | | | | | | used, and not the full list of possible proxies for the URL. BUG=52668 TEST=SpdyNetworkTransactionTest.DirectConnectProxyReconnect Review URL: http://codereview.chromium.org/3192011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57274 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where pushed SPDY streams were never actually closed.mbelshe@chromium.org2010-08-231-117/+235
| | | | | | | | | | | | | | | | | | | | | | | | The fix uncovers a few things. Previously, when we had an unclaimed push stream, we'd leave it as an "active" stream, even if the EOF had already been received on that stream. I changed it so that the push stream is removed from the active stream as soon as it is inactive, but it remains on the unclaimed_pushed_streams list. This seems more correct. The hardest part of the test was getting the test to verify the fix. To verify the fix, I modified the Push tests so that we leave the session open (e.g. terminate the list of reads with an ERR_IO_PENDING rather than an EOF so that it sits open), which gives us the opportunity to check if there are active streams left on the session when we completed the test. If so, then we'll pop an error. BUG=52898 TEST=Updated existing tests. Review URL: http://codereview.chromium.org/3108038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57023 0039d316-1c4b-4281-b951-d872f2087c98
* SpdySessionPool closes down sessions accurately now.erikchen@google.com2010-08-191-2/+2
| | | | | | | | | | This may or may not fix 50265. Regardless, the previous behavior was incorrect. TEST=none BUG=none Review URL: http://codereview.chromium.org/3150023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56696 0039d316-1c4b-4281-b951-d872f2087c98
* Extract connection logic from HttpNetworkTransaction into a newmbelshe@chromium.org2010-08-191-24/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HttpStreamFactory. The HttpNetworkTransaction now deals exclusively with streams rather than connections directly. This cut the size of HTN roughly in in half. The HttpNetworkTransaction is still responsible for all proxy and server authentication functions. This is because the streams may come and go - we could create a stream, have the server declare auth is needed, and then the next attempt would be on a different stream. So Auth belongs on the HNT. The HNT no longer has direct access to the connection itself; instead, it only knows of an HttpStream. The StreamRequest, however, is responsible for determining whether the connection needs to use a proxy, whether AlternateProtocols are available, and whether the connection should be SPDY or HTTP. Other changes: - moved some static configuration methods from HNT to HttpStreamFactory. - added some methods to the HttpStream. BUG=none TEST=all Review URL: http://codereview.chromium.org/3171002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56646 0039d316-1c4b-4281-b951-d872f2087c98
* Added a new MockSocket that enforces ordering of reads/writes.erikchen@google.com2010-08-181-29/+66
| | | | | | | | | | Re-enabled two broken SPDY tests, using new MockSocket. All SPDY tests should eventually convert to using this new object. TEST=none BUG=none Review URL: http://codereview.chromium.org/3179016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56560 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY flow control: fix for WINDOW_UPDATEs arriving while request is being sent.agayev@chromium.org2010-08-171-41/+70
| | | | | | | | | BUG=48100 TEST=net_unittests Review URL: http://codereview.chromium.org/3048058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56355 0039d316-1c4b-4281-b951-d872f2087c98
* SpdySession now closes all streams on receiving GoAway stream.erikchen@google.com2010-08-101-47/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55506 0039d316-1c4b-4281-b951-d872f2087c98
* Removed spdy_network_transaction.h file.erikchen@google.com2010-08-091-222/+230
| | | | | | | | | | Finished migrating last unit tests to use http_network_transaction. BUG=43330 TEST=net_unittests Review URL: http://codereview.chromium.org/3091019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55454 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SpdyStream.erikchen@google.com2010-08-061-0/+3
| | | | | | | | | | Removed a lot of duplicate/unnecessary logic. BUG=none TEST=none Review URL: http://codereview.chromium.org/3075023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55308 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/3068015lzheng@google.com2010-08-061-0/+143
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55250 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: flow-control fix: resume I/O once a WINDOW_UPDATE frame is received ↵agayev@chromium.org2010-08-051-97/+197
| | | | | | | | | | | for a stalled stream. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3018019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55125 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two SPDY tests, as they sometimes crash net_unittest.erikchen@google.com2010-08-051-2/+2
| | | | | | | | | | Working on fix. BUG=none TEST=none Review URL: http://codereview.chromium.org/3084018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55108 0039d316-1c4b-4281-b951-d872f2087c98
* Implement server push protocol 2.erikchen@google.com2010-08-051-18/+651
| | | | | | | | | TEST=net_unittests BUG=34761 Review URL: http://codereview.chromium.org/3020032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55095 0039d316-1c4b-4281-b951-d872f2087c98
* Minor change to: http://codereview.chromium.org/3064033rch@chromium.org2010-08-051-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to fix valgrind detected memeory leak. Instead of storing the spdy session in a smart pointer member field, use a smart pointer local var in the method. We end up checking the pool twice, but c'est la vie. Refactor HttpNetworkTransaction to eliminate the SPDY specific states of the state machine. This required adding two new states: STATE_INIT_STREAM STATE_INTI_STREAM_COMPLETE The http_stream_ and spdy_http_stream_ member fields have been removed, and replaced by a single stream_ member field which is initialized with either an HttpBasicStream, or SpdyHttpStream depending on the underlying connection. In the process, the NetLog no longer receives TYPE_SPDY events, only TYPE_HTTP, so spdy_network_transaction_unittest.cc needed to be modified accordingly. BUG=50267 TEST=none Review URL: http://codereview.chromium.org/3051034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55080 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54906 - Refactor HttpNetworkTransaction to eliminate the SPDYdhollowa@chromium.org2010-08-041-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | specific states of the state machine. This required adding two new states: STATE_INIT_STREAM STATE_INTI_STREAM_COMPLETE The http_stream_ and spdy_http_stream_ member fields have been removed, and replaced by a single stream_ member field which is initialized with either an HttpBasicStream, or SpdyHttpStream depending on the underlying connection. In the process, the NetLog no longer receives TYPE_SPDY events, only TYPE_HTTP, so spdy_network_transaction_unittest.cc needed to be modified accordingly. This seems to causing Valgrind leaks: http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/6887/steps/memory%20test:%20net/logs/stdio E.g.: Leak_DefinitelyLost 78,766 (888 direct, 77,878 indirect) bytes in 2 blocks are definitely lost in loss record 6,975 of 7,027 operator new(unsigned long) (mp/vg-bins/scripts/valgrind-memcheck/coregrind/m_replacemalloc/vg_replace_malloc.c:276) net::SpdySessionPool::GetSpdySessionFromSocket(std::pair<net::HostPortPair, std::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&, net::HttpNetworkSession*, net::ClientSocketHandle*, net::BoundNetLog const&, int, scoped_refptr<net::SpdySession>*, bool) net::HttpNetworkTransaction::DoInitStream() net::HttpNetworkTransaction::DoLoop(int) net::HttpNetworkTransaction::OnIOComplete(int) net::ClientSocketHandle::OnIOComplete(int) net::internal::ClientSocketPoolBaseHelper::InvokeUserCallback(net::ClientSocketHandle*) RunnableMethod<net::internal::ClientSocketPoolBaseHelper, void (net::internal::ClientSocketPoolBaseHelper::*)(net::ClientSocketHandle*), Tuple1<net::ClientSocketHandle*> >::Run() MessageLoop::RunTask(Task*) MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) MessageLoop::DoWork() base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) MessageLoop::RunInternal() MessageLoop::Run() TestCompletionCallback::WaitForResult() net::SpdyNetworkTransactionTest_SocketWriteReturnsZero_Test::TestBody() testing::Test::Run() testing::internal::TestInfoImpl::Run() testing::TestCase::Run() testing::internal::UnitTestImpl::RunAllTests() TestSuite::Run() main Suppression (error hash=#-444E9002#): { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN3net15SpdySessionPool24GetSpdySessionFromSocketERKSt4pairINS_12HostPortPairESsEPNS_18HttpNetworkSessionEPNS_18ClientSocketHandleERKNS_11BoundNetLogEiP13scoped_refptrINS_11SpdySessionEEb fun:_ZN3net22HttpNetworkTransaction12DoInitStreamEv fun:_ZN3net22HttpNetworkTransaction6DoLoopEi fun:_ZN3net22HttpNetworkTransaction12OnIOCompleteEi fun:_ZN3net18ClientSocketHandle12OnIOCompleteEi fun:_ZN3net8internal26ClientSocketPoolBaseHelper18InvokeUserCallbackEPNS_18ClientSocketHandleE fun:_ZN14RunnableMethodIN3net8internal26ClientSocketPoolBaseHelperEMS2_FvPNS0_18ClientSocketHandleEE6Tuple1IS4_EE3RunEv fun:_ZN11MessageLoop7RunTaskEP4Task fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE fun:_ZN11MessageLoop6DoWorkEv fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE fun:_ZN11MessageLoop11RunInternalEv } BUG=50267 TEST=none Review URL: http://codereview.chromium.org/3064033 TBR=rch@chromium.org Review URL: http://codereview.chromium.org/3038048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54963 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpNetworkTransaction to eliminate the SPDYrch@chromium.org2010-08-041-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | specific states of the state machine. This required adding two new states: STATE_INIT_STREAM STATE_INTI_STREAM_COMPLETE The http_stream_ and spdy_http_stream_ member fields have been removed, and replaced by a single stream_ member field which is initialized with either an HttpBasicStream, or SpdyHttpStream depending on the underlying connection. In the process, the NetLog no longer receives TYPE_SPDY events, only TYPE_HTTP, so spdy_network_transaction_unittest.cc needed to be modified accordingly. BUG=50267 TEST=none Review URL: http://codereview.chromium.org/3064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54906 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY correctly handles socket writes of zero length.erikchen@google.com2010-08-031-1/+38
| | | | | | | | | TEST=net_unittests BUG=none Review URL: http://codereview.chromium.org/2806085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54785 0039d316-1c4b-4281-b951-d872f2087c98
* SpdySessionPool now identifies SpdySessions by both HostPortPair and proxy ↵erikchen@google.com2010-08-021-7/+273
| | | | | | | | | | | | settings. This ensures SpdySessions are not improperly reused. TEST=net_unittests BUG=49874 Review URL: http://codereview.chromium.org/3047032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54577 0039d316-1c4b-4281-b951-d872f2087c98
* When we get a silent TCP RST, SPDY connections need to retry.mbelshe@chromium.org2010-07-311-4/+135
| | | | | | | | | | | | | | | | | | | | | Fixing this involved a couple of minor changes. * We were not tracking whether a SPDY session should be retried. The HTTP logic uses "is_socket_idle()" to determine if the socket was once good and is worth retrying. Because SPDY is not serialized added methods through the SpdySession and SpdyHttpStream for this. (See ShouldResendFailedRequest) * The spdy_http_stream was not notifying the caller when OnSendHeadersComplete occurred when there is no upload body. This isn't strictly necessary, but keeps the HttpNetworkTransaction state more consistent. BUG=50510 TEST=SpdyNetworkTransactionTest Review URL: http://codereview.chromium.org/3064021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54464 0039d316-1c4b-4281-b951-d872f2087c98
* Net: Fix leak in SpdyNetworkTransactionTest from r54398.thestig@chromium.org2010-07-311-10/+15
| | | | | | | | | BUG=none TEST=Valgind net goes green. TBR=lzheng Review URL: http://codereview.chromium.org/3078016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54430 0039d316-1c4b-4281-b951-d872f2087c98
* Implement prefetching in chromegavinp@google.com2010-07-311-4/+61
| | | | | | | | | | | | | | | | | | With this CL (see also issue 2910009), chrome will support basic prefetching. You can optionally deactivate prefetching with the command line argument --disable-prefetch. A new RequestPriority was created as well, IDLE, which is lower than LOWEST. Unfortunately, SPDY has only two bits for priority, so as a temporary measure (pending SPDY v3 which will have three), we have a mapping in SPDY that folds net::LOWEST and net::IDLE together. BUG=13505 TEST=http://gemal.dk/browserspy/prefetch.php Review URL: http://codereview.chromium.org/3050016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54421 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54381 - Revert 54378 - Add content-length to spdy post request header.lzheng@chromium.org2010-07-301-18/+87
| | | | | | | | | | | | | | | | | | I was rolled back due to this failure: http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac10.6%20(dbg)/builds/9160 I think that failure is not related to this CL (there might be a hidden problem with the WriteError test). I will disable that test and fix it if needed. TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 TBR=mbelshe@google.com Review URL: http://codereview.chromium.org/3041035 TBR=lzheng@chromium.org Review URL: http://codereview.chromium.org/3082009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54398 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54378 - Add content-length to spdy post request header.lzheng@chromium.org2010-07-301-87/+18
| | | | | | | | | | | | | http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac10.6%20(dbg)/builds/9160 TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 TBR=lzheng@google.com Review URL: http://codereview.chromium.org/3041035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54381 0039d316-1c4b-4281-b951-d872f2087c98
* Add content-length to spdy post request header.lzheng@google.com2010-07-301-18/+87
| | | | | | | | TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54378 0039d316-1c4b-4281-b951-d872f2087c98
* Bump the SPDY protocol version to version 2.mbelshe@chromium.org2010-07-301-4/+8
| | | | | | | | | | | | | Remove "http1.1" and "spdy" from the NPN advertisement string (the proper values are "http/1.1" and "spdy/2", which were included redundantly). BUG=50550 TEST=existing Review URL: http://codereview.chromium.org/3044034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54258 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY sends RST_STREAM upon cancelling request, or bad header parse data.erikchen@google.com2010-07-271-2/+44
| | | | | | | | | | | | Also fix tsan failure for spdy_http_stream_unittest. Attempted to commit in http://codereview.chromium.org/3014030/show, ran into different tsan failure. TEST=net_unittests, tsan on windows for SpdyHttpStreamTest. BUG=46589, 47478, 50198 Review URL: http://codereview.chromium.org/2811072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53829 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:erikchen@google.com2010-07-261-44/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53714 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY sends RST_STREAM upon cancelling request, or bad header parse data.erikchen@google.com2010-07-261-2/+44
| | | | | | | | | | Also fix spdy_http_stream_test errors. TEST=net_unittests BUG=46589, 47478, 50198 Review URL: http://codereview.chromium.org/3014030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53693 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY now always uses http_network_transaction instead of ↵erikchen@google.com2010-07-231-123/+142
| | | | | | | | | | | | | | | | spdy_network_transaction. It was previously possible to use spdy_network_transaction using the command line flags: --use-spdy=no-ssl --use-spdy=no-compress This does not affect instances of chrome that are not run with --use-spdy. Also changed spdy_network_transaction_unittest so that all tests are run with 3 different connection configurations: spdy over npn, spdy over ssl, and spdy without ssl. TEST=net_unittests BUG=49082 Review URL: http://codereview.chromium.org/3048003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53548 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY flow control: enforce obeying send window size via a command-line ↵agayev@chromium.org2010-07-221-11/+19
| | | | | | | | | | | switch, initial support for receive window size. BUG=48100 TEST=net_unittestss --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowUpdate:SpdyNetworkTransactionTest.WindowUpdateOverflow" Review URL: http://codereview.chromium.org/3052005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53297 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed memory leak in SpdyHttpStreamTest. Removed suppressions.erikchen@google.com2010-07-211-85/+29
| | | | | | | | | | Also cleaned up spdy unit tests a bit. TEST=SpdyHttpStreamTest should have no memleaks in valgrind. BUG=48865, 47950, 46886 Review URL: http://codereview.chromium.org/3033012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53200 0039d316-1c4b-4281-b951-d872f2087c98
* Add Spdy ConnectFailure test back into spdy network tests.erikchen@google.com2010-07-201-1/+78
| | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3040005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53049 0039d316-1c4b-4281-b951-d872f2087c98
* Initial SPDY flow control supportagayev@chromium.org2010-07-201-2/+129
| | | | | | | | | | | BUG=48100 TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowSizeChange:SpdyNetworkTransactionTest.WindowSizeOverflow" Contributed by: agayev@google.com Review URL: http://codereview.chromium.org/2805083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53039 0039d316-1c4b-4281-b951-d872f2087c98
* Implement MAX_CONCURRENT_STREAMS SETTINGS headergavinp@google.com2010-07-171-56/+557
| | | | | | | | | | | | | | | | | | | | | | | | This CL helps chrome respect the SETTINGS header MAX_CONCURRENT_STREAMS. Note that this means that SpdySession::CreateStream can now return ERR_IO_PENDING, so it requires a callback. There's a noted TODO that if an http_network_transaction dissapears betweeen STATE_SPDY_GET_STREAM and STATE_SPDY_SEND_REQUEST I don't know if we end up with an orphan stream in our spdy_session. As well, spdy_test_util.cc had a lot of functions with default arguments; I didn't fix them all, but the functions I modified no longer take default arguments and meet the coding standard. I'd like to circle back at some point and possibly make the tests call SpdyFramer directly: these test utils seem sometimes more trouble than they're worth if the framer was a bit more convenient for direct use. BUG=34750 TEST=net_unittests Spdy.ThreeGets* Review URL: http://codereview.chromium.org/2919011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52791 0039d316-1c4b-4281-b951-d872f2087c98
* Mac compile warning fix for r52670.erikchen@google.com2010-07-161-51/+47
| | | | | | | | | TEST=NONE BUG=NONE Review URL: http://codereview.chromium.org/3027002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52673 0039d316-1c4b-4281-b951-d872f2087c98
* spdy network tests now use http network transaction (production code).erikchen@google.com2010-07-161-604/+347
| | | | | | | | | BUG=NONE TEST=net_unittests Review URL: http://codereview.chromium.org/2804045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52670 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52352 - SPDY: Initial support for handling WINDOW_UPDATE frames and ↵cbentzel@chromium.org2010-07-141-121/+0
| | | | | | | | | | | | | | | | some cleanup. BUG=48100 TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowSizeChange:SpdyNetworkTransactionTest.WindowSizeOverflow" Contributed by: agayev@google.com Review URL: http://codereview.chromium.org/2807042 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/2908010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52362 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: Initial support for handling WINDOW_UPDATE frames and some cleanup.cbentzel@chromium.org2010-07-141-0/+121
| | | | | | | | | | | BUG=48100 TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowSizeChange:SpdyNetworkTransactionTest.WindowSizeOverflow" Contributed by: agayev@google.com Review URL: http://codereview.chromium.org/2807042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52352 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY incorrectly DCHECKed that the SYN_REPLY headers could never be an empty ↵erikchen@google.com2010-07-141-0/+2
| | | | | | | | | | | list. TEST=net_unittests BUG=47991 Review URL: http://codereview.chromium.org/2987002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52264 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: reverting broken commiterikchen@google.com2010-07-121-148/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52113 0039d316-1c4b-4281-b951-d872f2087c98
* Streams send a Rst frame upon being closed by client. Some minor editorial ↵erikchen@google.com2010-07-121-6/+148
| | | | | | | | | | | | | fixes. TEST=net_unittests BUG=46589 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51007 Review URL: http://codereview.chromium.org/2804008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52106 0039d316-1c4b-4281-b951-d872f2087c98
* Client attempts to start a new spdy transaction with a session that is ↵erikchen@google.com2010-07-091-3/+82
| | | | | | | | | | | closing down. TEST=net_unittests BUG=47455,48503 Review URL: http://codereview.chromium.org/2841029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52001 0039d316-1c4b-4281-b951-d872f2087c98
* Change a FAILS_ to DISABLED_, since FAILS_ doesnt help when the test crashes.eroman@chromium.org2010-07-091-1/+1
| | | | | | | | TBR=cbentzel BUG=48588 Review URL: http://codereview.chromium.org/2909004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51930 0039d316-1c4b-4281-b951-d872f2087c98
* CorrupFrameSessionError Fails.cbentzel@chromium.org2010-07-081-1/+2
| | | | | | | | | BUG=48588 TEST=None Review URL: http://codereview.chromium.org/2955001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51900 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51887 - Disable SpdyNetworkTransactionTest.CorruptFrameSessionError ↵eroman@chromium.org2010-07-081-2/+1
| | | | | | | | | | | | | which is failing on vista modules bot BUG=48588 TBR=willchan Review URL: http://codereview.chromium.org/2950001 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/2933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51897 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SpdyNetworkTransactionTest.CorruptFrameSessionError which is failing ↵eroman@chromium.org2010-07-081-1/+2
| | | | | | | | | | on vista modules bot BUG=48588 TBR=willchan Review URL: http://codereview.chromium.org/2950001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51887 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last hex frames from the SPDY unit tests...mlloyd@chromium.org2010-07-021-85/+76
| | | | | | | | | | | ...apart from the necessary ones in spdy_framer_test.cc. BUG=None. TEST=net_unittests pass. Review URL: http://codereview.chromium.org/2870044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51551 0039d316-1c4b-4281-b951-d872f2087c98