summaryrefslogtreecommitdiffstats
path: root/net/spdy/spdy_stream_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* [SPDY] Add strings and constants for HTTP/2 draft 04akalin@chromium.org2013-07-301-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | There are still differences between SPDY/4 and HTTP/2 draft 04; those will be ironed out in upcoming CLs. Add kProtoHTTP2Draft04 to SPDY NextProto-parametrized tests. Move NextProto -> SpdyMajorVersion conversion to buffered_spdy_framer.h. Remove unused SpdyMajorVersion -> NextProto conversion. Clean up HttpResponseInfo::ConnectionInfo a bit and add a TODO to remove it. Parametrize SSLClientSocketPoolTest on NextProto. BUG=265615 R=darin@chromium.org, rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214289 Review URL: https://codereview.chromium.org/21131002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214309 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 214289 "[SPDY] Add strings and constants for HTTP/2 draft 04"akalin@chromium.org2013-07-301-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | > [SPDY] Add strings and constants for HTTP/2 draft 04 > > There are still differences between SPDY/4 and HTTP/2 draft 04; those > will be ironed out in upcoming CLs. > > Add kProtoHTTP2Draft04 to SPDY NextProto-parametrized tests. > > Move NextProto -> SpdyMajorVersion conversion to buffered_spdy_framer.h. > > Remove unused SpdyMajorVersion -> NextProto conversion. > > Clean up HttpResponseInfo::ConnectionInfo a bit and add a TODO to > remove it. > > Parametrize SSLClientSocketPoolTest on NextProto. > > BUG=265615 > R=darin@chromium.org, rch@chromium.org > > Review URL: https://codereview.chromium.org/21131002 TBR=akalin@chromium.org Review URL: https://codereview.chromium.org/21202002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214296 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Add strings and constants for HTTP/2 draft 04akalin@chromium.org2013-07-301-1/+2
| | | | | | | | | | | | | | | | | | | | | | | There are still differences between SPDY/4 and HTTP/2 draft 04; those will be ironed out in upcoming CLs. Add kProtoHTTP2Draft04 to SPDY NextProto-parametrized tests. Move NextProto -> SpdyMajorVersion conversion to buffered_spdy_framer.h. Remove unused SpdyMajorVersion -> NextProto conversion. Clean up HttpResponseInfo::ConnectionInfo a bit and add a TODO to remove it. Parametrize SSLClientSocketPoolTest on NextProto. BUG=265615 R=darin@chromium.org, rch@chromium.org Review URL: https://codereview.chromium.org/21131002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214289 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Use WeakPtr<SpdySession> everywhere but SpdySessionPoolakalin@chromium.org2013-07-221-15/+15
| | | | | | | | | | | | | | | | | | | | | | | Make SpdyHttpStream cache it's SPDY stream's LoadTimingInfo on close. Also, make SpdyHttpStream query SpdySession::IsReused() when it's constructed and cache the value, as that's closer to the intent of its use. Avoid uses of SpdySession::IsClosed() in non-test code and add TODO to remove uses from test code. This is more correct since testing the WeakPtr is a stronger condition than testing openness and SpdySession functions already do the right thing if the SpdySession is already closed. Tweak some tests that implicitly depended on having refs to SpdySession. BUG=255701 R=rch@chromium.org Review URL: https://codereview.chromium.org/18546008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212858 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Fully implement handling of GOAWAY framesakalin@chromium.org2013-07-191-36/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In particular, keep the SpdySession owned by its pool but make it unavailable. Key |unclaimed_pushed_streams_| by GURL. Put logic for checking access to a stream in SpdySession::TryAccessStream() and use it everywhere. Add helper functions DcheckGoingAway() and DcheckClosed() for checking assertions for their respective states. Rename CloseAllStreamsAfter() to StartGoingAway(), and CloseAllStreams() to DoCloseSession() to better reflect how they're used. Also add new utility function MaybeFinishGoingAway(). Put all logic for logging abandoned streams and push streams into LogAbandoned{,Push}Streams(). Add comment/TODO regarding handling of pushed streams that are closed before they are claimed. Fix bug where pending_stream_request_completions_ wasn't being cleared properly. Store the full URL a SpdyStream is created with. Make it accessible via url() and rename {Get,Has}Url() to {Get,Has}UrlFromHeader(). Use descriptive names for iterators when there are more than one (instead of it2, it3, etc.). Add tests for new GOAWAY semantics. Also update existing ones slightly (e.g., no read attempt happens after a close triggered by a GOAWAY). Misc. clean up here and there. BUG=255701 R=rch@chromium.org Review URL: https://codereview.chromium.org/19076002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212541 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Refactor and clean up SpdySessionPoolakalin@chromium.org2013-07-031-61/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the map of keys to lists of sessions to a map of keys to sessions, since we were already limiting the lists to be of size 1 anyway. Remove the functions from SpdySessionPool that were used mostly by tests. Replace them with functions in spdy_test_util_common.{h,cc}. Make a bunch of tests use these functions. Make the Close*Sessions() behave consistently. Make SpdySession::CloseSessionOnError() always remove the session from its pool. Move the SpdySessionPool tests for spdy_session_unittest.cc to a new file spdy_session_pool_unittest.cc. Add a few more for the Close*Sessions() tests. Remove --max-spdy-sessions-per-domain switch. Parametrize HttpStreamFactoryTest on NextProto. Misc. cleanup here and there. BUG=255701 TBR=rch@chromium.org Review URL: https://codereview.chromium.org/18226004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210054 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Enable tests for SPDY/3.1 and SPDY/4a2akalin@chromium.org2013-06-271-118/+12
| | | | | | | | | | | | | | | | | | | | | | | | Make the sending of the initial stream window size part of SpdySession::SendInitialSettings(). Since this is already turned off for tests, this makes it a lot easier to enable tests for SPDY/3.1 and above, since we don't have to conditionally expect the initial WINDOW_UPDATE frame. Actually test handling of Alternate-Protocol header in http_network_transaction_unittest.cc. Fix handling of SPDY/3.1 and above in AlternateProtocolToString() and HttpStreamFactoryImpl::GetAlternateProtocolRequestFor(). Other misc. cleanup. BUG=230124 R=rch@chromium.org Review URL: https://codereview.chromium.org/17760008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208997 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Refactor SpdyStream's handling of response headersakalin@chromium.org2013-06-241-11/+352
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename OnResponseHeadersReceived() to OnResponseHeadersUpdated() and remove some of its extraneous parameters. Document its semantics and that of the other delegate functions. Fix bug in PushedStreamReplayData() where the stream being closed/deleted wasn't handled correctly. Also fix memory leaks of the pending frames. Use continue_buffering_data_ only for push streams. Rename request_/response_ to request_headers_/response_headers_. Keep track of whether all required response headers are complete, and send data to the delegate only after that becomes true. Rename OnResponseHeadersReceived() and OnHeaders() to On{Initial,Additional}ResponseHeadersReceived(), respectively. Add MergeWithResponseHeaders() utility function and call it from On{Initial,Additional}ResponseHeadersReceived(). Always convert ERR_INCOMPLETE_SPDY_HEADERS to OK for push streams. Rename ContainsUpperAscii() (ambiguous) to ContainsUppercaseAscii(). Move some tests from SpdyNetworkTransaction to SpdyStream. Some other miscellaneous renaming and cleanup. BUG=251442 R=rch@chromium.org Review URL: https://codereview.chromium.org/17382012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208169 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Merge the SpdyHttpStream unit tests and parametrize them on a NextProtoakalin@chromium.org2013-06-121-0/+1
| | | | | | | | | | | | Add (partial) support for SPDY/3.1 and SPDY/4a2 for SpdyHttpStream unit tests. BUG=226192 R=rch@chromium.org Review URL: https://codereview.chromium.org/16705004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205702 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Merge the SpdySession unit tests and parametrize them on a NextProtoakalin@chromium.org2013-06-111-1/+1
| | | | | | | | | | | | | | Add (partial) support for SPDY/3.1 and SPDY/4a2 for SpdySession unit tests. Add support for SPDY/4a2 for SpdyStream unit tests (which was mistakenly not done in r203570). BUG=226192 R=rch@chromium.org Review URL: https://codereview.chromium.org/16434012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205637 0039d316-1c4b-4281-b951-d872f2087c98
* [SPDY] Merge the SpdyStream unit tests and parametrize them on a NextProtoakalin@chromium.org2013-06-011-0/+805
| | | | | | | | | | | | | | | Add support for SPDY/3.1 and SPDY/4a2. Make SpdyTestUtil::*Key() methods public. Add a utility function to inject the right headers for a URL into a SpdyHeaderBlock. BUG=226192 Review URL: https://chromiumcodereview.appspot.com/15731012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203570 0039d316-1c4b-4281-b951-d872f2087c98
* Fork SPDY/2 and SPDY/3 versions of our SPDY tests, in preparation for landingrch@chromium.org2012-03-041-405/+0
| | | | | | | spdy 3 framer changes. Review URL: https://chromiumcodereview.appspot.com/9582034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124886 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - Better SPDY error logging in NetLog.rtenneti@chromium.org2012-02-231-0/+136
| | | | | | | | | | | | Moved all logging messages into net_log_.AddEvents. BUG=112657 R=willchan TEST=network unit tests. Review URL: http://codereview.chromium.org/9424041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123317 0039d316-1c4b-4281-b951-d872f2087c98
* Change MockRead and MockWrite (et. al.) to take an IoMode enum, insteadrch@chromium.org2012-02-231-1/+1
| | | | | | | | of a bool async. Review URL: http://codereview.chromium.org/9425016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123274 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the MockConnect constructor to take an enum of ASYNC or SYNCHRONOUS,rch@chromium.org2012-02-171-1/+1
| | | | | | | | instead of a boolean async. Review URL: http://codereview.chromium.org/9419032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122581 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to socket_test_util.cc.szym@chromium.org2012-01-221-2/+2
| | | | | | | | | | | | | | | - Removes ref-counting from DelayedSocketData and OrderedSocketData. - Calls CompleteRead (which reads from underlying data) only if a Socket::Read call is "blocked" (previously returned with ERR_IO_PENDING). - Removes unsafe pointers to the handed out sockets (the factory does not own them and cannot guarantee their lifetime). BUG=110626 TEST=./net_unittests --gtest_filter=Spdy*:Http*:Socket*:WebSocket*:Ftp* Review URL: http://codereview.chromium.org/9251019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118634 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert net/spdy.jhawkins@chromium.org2011-12-211-7/+8
| | | | | | | | | | BUG=none TEST=none R=groby Review URL: http://codereview.chromium.org/8956018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115392 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert most of net/http.jhawkins@chromium.org2011-12-201-1/+2
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8990001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115220 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert proxy_resolving_client_socket.[cc,h] and deps.jhawkins@chromium.org2011-12-151-7/+4
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8898036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114562 0039d316-1c4b-4281-b951-d872f2087c98
* Make ClientSocketPoolManager into an interface.willchan@chromium.org2011-11-171-1/+1
| | | | | | | | | | | | This allows for using a MockClientSocketPoolManager. The default implementation has been moved into ClientSocketPoolManagerImpl. This allows HttpNetworkSessionPeer to replace the whole ClientSocketPoolManager rather than individual socket pools, which is necessary because socket pools will become more integrated in the future. BUG=none TEST=none Review URL: http://codereview.chromium.org/8572041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110510 0039d316-1c4b-4281-b951-d872f2087c98
* Remove referrer from TransportSocketParams and SOCKSSocketParams.szym@chromium.org2011-11-151-1/+1
| | | | | | | | | | | | BUG=none TEST=compiles R=eroman Review URL: http://codereview.chromium.org/8572018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110168 0039d316-1c4b-4281-b951-d872f2087c98
* Begin CompletionCallback switchover.willchan@chromium.org2011-10-011-4/+4
| | | | | | | | | | | | | Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback. Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g. BUG=98719 TEST=none Review URL: http://codereview.chromium.org/8070013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some test ugliness. Stop using a global.willchan@chromium.org2011-07-011-16/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7273065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91276 0039d316-1c4b-4281-b951-d872f2087c98
* Rename a number of classes previously labeled "TCP" to "Transport" inmbelshe@chromium.org2011-04-071-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | preparation for non-TCP transports. This helps because the alternative is to either use non-TCP protocols (like SCTP) in classes which are called "TCPClientSocketPool", or to clone the code as "SCTPClientSocketPool", both of which are less than ideal. For now, we're just testing transports, so the TransportSocketPool classes will determine a single type of transport and just use them. In the future we'll likely need to figure out how to deal with runtime selection of transports, and probably support use of multiple transports either within the same pools or within subpools. But that is for the future. Note that the histograms have some "tcp" references to them. I didn't change these to "transport" yet, because it will effect existing histograms. Renames include: classes: TCPClientSocketPool -> TransportClientSocketPool MockTCPClientSocketPool -> MockTransportClientSocketPool TCPSocketParams -> TransportSocketParams methods (not the exhaustive list): CreateTCPClientSocket() -> CreateTransportClientSocket() DoTCPConnect() -> DoTransportConnect() BUG=none TEST=none Review URL: http://codereview.chromium.org/6804028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80781 0039d316-1c4b-4281-b951-d872f2087c98
* Add ignore limits flag and use for sync requestkristianm@google.com2011-03-301-1/+1
| | | | | | | | | | | | | Letting sync request ignore the socket and group limits when loading to prevent the WebCore thread from locking up. BUG=45986,58703 TEST=No new tests Review URL: http://codereview.chromium.org/6756004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79817 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Add chunked uploads support to SPDYsatish@chromium.org2011-03-041-2/+3
| | | | | | | | | | | | | | | As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData needs to serve both. BUG=none TEST=net_unittests (2 new tests added) Committed and rolled back: http://src.chromium.org/viewvc/chrome?view=rev&revision=76892 Review URL: http://codereview.chromium.org/6292013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76930 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add chunked uploads support to SPDY"satish@chromium.org2011-03-041-3/+2
| | | | | | | | This reverts commit 8431a6e7be70b1b50b0d5b851bbe728b7fef220f. TBR=satish git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76896 0039d316-1c4b-4281-b951-d872f2087c98
* Add chunked uploads support to SPDYsatish@chromium.org2011-03-041-2/+3
| | | | | | | | | | | | | As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData needs to serve both. BUG=none TEST=net_unittests (2 new tests added) Review URL: http://codereview.chromium.org/6292013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76892 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpStreamFactory.willchan@chromium.org2011-02-231-3/+1
| | | | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75668 Review URL: http://codereview.chromium.org/6543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75688 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75668 for breaking ChromeOS build - Refactor HttpStreamFactory.willchan@chromium.org2011-02-231-1/+3
| | | | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Review URL: http://codereview.chromium.org/6543004 TBR=willchan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75670 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpStreamFactory.willchan@chromium.org2011-02-221-3/+1
| | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Review URL: http://codereview.chromium.org/6543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75668 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpNetworkSession construction.willchan@chromium.org2011-02-031-0/+1
| | | | | | | | | | | Introduce HttpNetworkSession::Params. This should make it easy to add new optionally NULL parameters. I also took this opportunity to eliminate some copy/pastes of TestURLRequestContext and make them use the original. I was also able to remove the need for ClientSocketFactory::GetDefaultFactory() calls and new SpdySessionPool() calls in most places. BUG=none TEST=none Review URL: http://codereview.chromium.org/6349028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73669 0039d316-1c4b-4281-b951-d872f2087c98
* Add origin checking for server pushed resources.mbelshe@chromium.org2010-12-081-4/+50
| | | | | | | | | BUG=64108 TEST=PushedStream, ServerPushCrossOriginCorrectness Review URL: http://codereview.chromium.org/5516012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68605 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-011-2/+2
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 61015 (unnecessary revert due to flaky build) - Stop refcounting ↵willchan@chromium.org2010-09-301-2/+2
| | | | | | | | | | | | | | | | SpdySessionPool. BUG=57343 TEST=none Review URL: http://codereview.chromium.org/3602001 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3541005 TBR=willchan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61063 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61015 (broke fetch_client) - Stop refcounting SpdySessionPool.willchan@chromium.org2010-09-301-2/+2
| | | | | | | | | | | | BUG=57343 TEST=none Review URL: http://codereview.chromium.org/3602001 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3541005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61018 0039d316-1c4b-4281-b951-d872f2087c98
* Stop refcounting SpdySessionPool.willchan@chromium.org2010-09-301-2/+2
| | | | | | | | | BUG=57343 TEST=none Review URL: http://codereview.chromium.org/3602001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61015 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the references to HttpNetworkSession in SpdySessionrch@chromium.org2010-09-251-1/+3
| | | | | | | | | | | | | | | | and replace it with a reference to the SpdySessionPool and SpdySettingStorage, which are actually required. Modified SpdySessionPool to take a pointer to SpdySettingsStorage instead of to HttpNetworkSession in both GetSpdySessionFromSocket() Get(). Modified HttpStreamRequest (and various unit tests) accordingly when calling these methods. Review URL: http://codereview.chromium.org/3400024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60590 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SpdySession::Connect(). This methods was onlyrch@chromium.org2010-09-251-2/+6
| | | | | | | | | | | | | being called from a handful of unit tests. I modified those tests to call SpdySession::InitializeWithSocket() instead. This added a bit of code to these tests. BUG=56848 TEST=none Review URL: http://codereview.chromium.org/3435029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60589 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 59362 - net: Rename ProxyService::CreateNull to ↵tfarina@chromium.org2010-09-151-5/+0
| | | | | | | | | | | | | | | | | | | | | ProxyService::CreateDirect. (Note: This was a TODO for eroman). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3336021 Revert Review URL: http://codereview.chromium.org/3444001/show TBR=eroman@chromium.org Fix the bad git svn rebase (that caused a bad merge, that integrates other files in the original cl, now this should be fixed). Review URL: http://codereview.chromium.org/3413008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59481 0039d316-1c4b-4281-b951-d872f2087c98
* Trying to green up the tree, lots of mac and win red around this cl.thomasvl@chromium.org2010-09-141-0/+5
| | | | | | | | | | | | | | | | Revert 59362 - net: Rename ProxyService::CreateNull to ProxyService::CreateDirect. (Note: This was a TODO for eroman). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3336021 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/3444001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59373 0039d316-1c4b-4281-b951-d872f2087c98
* net: Rename ProxyService::CreateNull to ProxyService::CreateDirect.tfarina@chromium.org2010-09-141-5/+0
| | | | | | | | | | | (Note: This was a TODO for eroman). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3336021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59362 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: change the spdy session pool key to take a ProxyServer instead of ↵eroman@chromium.org2010-08-251-1/+1
| | | | | | | | | a string representation of the proxy server. BUG=52668 Review URL: http://codereview.chromium.org/3197018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57297 0039d316-1c4b-4281-b951-d872f2087c98
* Added a new MockSocket that enforces ordering of reads/writes.erikchen@google.com2010-08-181-1/+1
| | | | | | | | | | Re-enabled two broken SPDY tests, using new MockSocket. All SPDY tests should eventually convert to using this new object. TEST=none BUG=none Review URL: http://codereview.chromium.org/3179016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56560 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY flow control: fix for WINDOW_UPDATEs arriving while request is being sent.agayev@chromium.org2010-08-171-4/+1
| | | | | | | | | BUG=48100 TEST=net_unittests Review URL: http://codereview.chromium.org/3048058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56355 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SpdyStream.erikchen@google.com2010-08-061-1/+1
| | | | | | | | | | Removed a lot of duplicate/unnecessary logic. BUG=none TEST=none Review URL: http://codereview.chromium.org/3075023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55308 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: flow-control fix: resume I/O once a WINDOW_UPDATE frame is received ↵agayev@chromium.org2010-08-051-1/+5
| | | | | | | | | | | for a stalled stream. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3018019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55125 0039d316-1c4b-4281-b951-d872f2087c98
* SpdySessionPool now identifies SpdySessions by both HostPortPair and proxy ↵erikchen@google.com2010-08-021-2/+2
| | | | | | | | | | | | settings. This ensures SpdySessions are not improperly reused. TEST=net_unittests BUG=49874 Review URL: http://codereview.chromium.org/3047032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54577 0039d316-1c4b-4281-b951-d872f2087c98
* Implement prefetching in chromegavinp@google.com2010-07-311-1/+1
| | | | | | | | | | | | | | | | | | With this CL (see also issue 2910009), chrome will support basic prefetching. You can optionally deactivate prefetching with the command line argument --disable-prefetch. A new RequestPriority was created as well, IDLE, which is lower than LOWEST. Unfortunately, SPDY has only two bits for priority, so as a temporary measure (pending SPDY v3 which will have three), we have a mapping in SPDY that folds net::LOWEST and net::IDLE together. BUG=13505 TEST=http://gemal.dk/browserspy/prefetch.php Review URL: http://codereview.chromium.org/3050016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54421 0039d316-1c4b-4281-b951-d872f2087c98