summaryrefslogtreecommitdiffstats
path: root/net/spdy
Commit message (Collapse)AuthorAgeFilesLines
* Fix SpdyHttpStreamTest windows tsan bug.erikchen@google.com2010-08-021-6/+14
| | | | | | | | | BUG=50929 TEST=net_unittests Review URL: http://codereview.chromium.org/2836079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54601 0039d316-1c4b-4281-b951-d872f2087c98
* SpdySessionPool now identifies SpdySessions by both HostPortPair and proxy ↵erikchen@google.com2010-08-0211-65/+368
| | | | | | | | | | | | settings. This ensures SpdySessions are not improperly reused. TEST=net_unittests BUG=49874 Review URL: http://codereview.chromium.org/3047032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54577 0039d316-1c4b-4281-b951-d872f2087c98
* When we get a silent TCP RST, SPDY connections need to retry.mbelshe@chromium.org2010-07-316-8/+161
| | | | | | | | | | | | | | | | | | | | | Fixing this involved a couple of minor changes. * We were not tracking whether a SPDY session should be retried. The HTTP logic uses "is_socket_idle()" to determine if the socket was once good and is worth retrying. Because SPDY is not serialized added methods through the SpdySession and SpdyHttpStream for this. (See ShouldResendFailedRequest) * The spdy_http_stream was not notifying the caller when OnSendHeadersComplete occurred when there is no upload body. This isn't strictly necessary, but keeps the HttpNetworkTransaction state more consistent. BUG=50510 TEST=SpdyNetworkTransactionTest Review URL: http://codereview.chromium.org/3064021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54464 0039d316-1c4b-4281-b951-d872f2087c98
* Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found itbrettw@chromium.org2010-07-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in string_util.h. This should help some dependencies since string_util changes much more frequently than utf_string_conversions and fewer files will now need string_utils. Since this requires a lot of changes, this keeps a forward-declaration in string_util so I can update the entire project incrementally. This change updates base and net only. I removed some includes of string_util from header files in net. In particular, url_request_context which involved creating a new .cc file to implement a function (already virtual so there's no speed penalty). It turns out a lot of files were getting string_util from this include, so I had to update a bunch of random files to now explicitly include string_util.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3076013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54456 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-312-2/+4
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Convert src/net to use std::string/char* for DictionaryValue keys.viettrungluu@chromium.org2010-07-311-5/+5
| | | | | | | | | | | Hopefully I got them all. BUG=23581 TEST=net_unittests Review URL: http://codereview.chromium.org/3013048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54433 0039d316-1c4b-4281-b951-d872f2087c98
* Net: Fix leak in SpdyNetworkTransactionTest from r54398.thestig@chromium.org2010-07-311-10/+15
| | | | | | | | | BUG=none TEST=Valgind net goes green. TBR=lzheng Review URL: http://codereview.chromium.org/3078016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54430 0039d316-1c4b-4281-b951-d872f2087c98
* Implement prefetching in chromegavinp@google.com2010-07-314-15/+80
| | | | | | | | | | | | | | | | | | With this CL (see also issue 2910009), chrome will support basic prefetching. You can optionally deactivate prefetching with the command line argument --disable-prefetch. A new RequestPriority was created as well, IDLE, which is lower than LOWEST. Unfortunately, SPDY has only two bits for priority, so as a temporary measure (pending SPDY v3 which will have three), we have a mapping in SPDY that folds net::LOWEST and net::IDLE together. BUG=13505 TEST=http://gemal.dk/browserspy/prefetch.php Review URL: http://codereview.chromium.org/3050016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54421 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54381 - Revert 54378 - Add content-length to spdy post request header.lzheng@chromium.org2010-07-304-24/+115
| | | | | | | | | | | | | | | | | | I was rolled back due to this failure: http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac10.6%20(dbg)/builds/9160 I think that failure is not related to this CL (there might be a hidden problem with the WriteError test). I will disable that test and fix it if needed. TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 TBR=mbelshe@google.com Review URL: http://codereview.chromium.org/3041035 TBR=lzheng@chromium.org Review URL: http://codereview.chromium.org/3082009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54398 0039d316-1c4b-4281-b951-d872f2087c98
* More FRIEND_TEST_ALL_PREFIXES.phajdan.jr@chromium.org2010-07-304-9/+10
| | | | | | | | | TEST=none BUG=44549 Review URL: http://codereview.chromium.org/3053024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54388 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54378 - Add content-length to spdy post request header.lzheng@chromium.org2010-07-304-115/+24
| | | | | | | | | | | | | http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac10.6%20(dbg)/builds/9160 TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 TBR=lzheng@google.com Review URL: http://codereview.chromium.org/3041035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54381 0039d316-1c4b-4281-b951-d872f2087c98
* Add content-length to spdy post request header.lzheng@google.com2010-07-304-24/+115
| | | | | | | | TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54378 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-1/+2
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize SpdyStreamMember to kInitialWindowSize.finnur@chromium.org2010-07-301-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3081004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54333 0039d316-1c4b-4281-b951-d872f2087c98
* Uninitialized member in SpdyStream.finnur@chromium.org2010-07-301-1/+2
| | | | | | | | | | | BUG=None TEST=None CID=11904 Review URL: http://codereview.chromium.org/3083006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54330 0039d316-1c4b-4281-b951-d872f2087c98
* Fix new[]/delete mismatch caused by using scoped_ptr<char> to handle strings.glider@chromium.org2010-07-301-3/+3
| | | | | | | | TBR=mbelshe Review URL: http://codereview.chromium.org/3020046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54299 0039d316-1c4b-4281-b951-d872f2087c98
* Use relative instead of absolute URIs in SPDY requestsmbelshe@chromium.org2010-07-303-5/+37
| | | | | | | | | BUG=50549 TEST=existing Review URL: http://codereview.chromium.org/3035037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54260 0039d316-1c4b-4281-b951-d872f2087c98
* Bump the SPDY protocol version to version 2.mbelshe@chromium.org2010-07-303-33/+37
| | | | | | | | | | | | | Remove "http1.1" and "spdy" from the NPN advertisement string (the proper values are "http/1.1" and "spdy/2", which were included redundantly). BUG=50550 TEST=existing Review URL: http://codereview.chromium.org/3044034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54258 0039d316-1c4b-4281-b951-d872f2087c98
* I've refactored HttpStream, SpdyHttpStream and HttpBasicStream so thatrch@chromium.org2010-07-296-80/+144
| | | | | | | | | | | | SpdyHttpStream now implements (a slightly wider) HttpStream interface. BUG=50268 TEST=none Review URL: http://codereview.chromium.org/3079002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54154 0039d316-1c4b-4281-b951-d872f2087c98
* Net: Convert username and password to string16.thestig@chromium.org2010-07-292-10/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3040016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54101 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY sends RST_STREAM upon cancelling request, or bad header parse data.erikchen@google.com2010-07-275-16/+81
| | | | | | | | | | | | Also fix tsan failure for spdy_http_stream_unittest. Attempted to commit in http://codereview.chromium.org/3014030/show, ran into different tsan failure. TEST=net_unittests, tsan on windows for SpdyHttpStreamTest. BUG=46589, 47478, 50198 Review URL: http://codereview.chromium.org/2811072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53829 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: turn off flow-control by defaultagayev@chromium.org2010-07-271-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3035032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53825 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --testing-fixed-http-port and --testing-fixed-https-port.cbentzel@chromium.org2010-07-271-9/+0
| | | | | | | | | | | --host-rules seems like a reasonable enough substitute for these two command line flags, and removing them will simplifies the fairly complicated URL rewrite logic in HttpNetworkTransaction. BUG=None TEST=built and ran net_unittests Review URL: http://codereview.chromium.org/3041019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DeleteStream() being called twice per stream and CloseStream() reporting ↵agayev@chromium.org2010-07-271-7/+1
| | | | | | | | | | | a wrong stream number. BUG=49683 TEST=None Review URL: http://codereview.chromium.org/3035015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53784 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2613-0/+13
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:erikchen@google.com2010-07-265-70/+15
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53714 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY sends RST_STREAM upon cancelling request, or bad header parse data.erikchen@google.com2010-07-265-15/+70
| | | | | | | | | | Also fix spdy_http_stream_test errors. TEST=net_unittests BUG=46589, 47478, 50198 Review URL: http://codereview.chromium.org/3014030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53693 0039d316-1c4b-4281-b951-d872f2087c98
* Use SpecForRequest to get rid of anchor in url for spdy.lzheng@chromium.org2010-07-262-21/+68
| | | | | | | | | TEST=spdy_http_stream_unittest.cc BUG=50058 Review URL: http://codereview.chromium.org/3061011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53610 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY now always uses http_network_transaction instead of ↵erikchen@google.com2010-07-235-133/+160
| | | | | | | | | | | | | | | | spdy_network_transaction. It was previously possible to use spdy_network_transaction using the command line flags: --use-spdy=no-ssl --use-spdy=no-compress This does not affect instances of chrome that are not run with --use-spdy. Also changed spdy_network_transaction_unittest so that all tests are run with 3 different connection configurations: spdy over npn, spdy over ssl, and spdy without ssl. TEST=net_unittests BUG=49082 Review URL: http://codereview.chromium.org/3048003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53548 0039d316-1c4b-4281-b951-d872f2087c98
* Net: Get rid of ProxyServer::host_and_port() and friends.thestig@chromium.org2010-07-222-9/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3032017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53403 0039d316-1c4b-4281-b951-d872f2087c98
* Spdy_network_transaction incorrectly labeled tcp connections with hostname ↵erikchen@google.com2010-07-221-2/+1
| | | | | | | | | | | but not port number. TEST=none BUG=48078 Review URL: http://codereview.chromium.org/2834062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53344 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY flow control: enforce obeying send window size via a command-line ↵agayev@chromium.org2010-07-225-43/+92
| | | | | | | | | | | switch, initial support for receive window size. BUG=48100 TEST=net_unittestss --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowUpdate:SpdyNetworkTransactionTest.WindowUpdateOverflow" Review URL: http://codereview.chromium.org/3052005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53297 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed memory leak in SpdyHttpStreamTest. Removed suppressions.erikchen@google.com2010-07-216-284/+131
| | | | | | | | | | Also cleaned up spdy unit tests a bit. TEST=SpdyHttpStreamTest should have no memleaks in valgrind. BUG=48865, 47950, 46886 Review URL: http://codereview.chromium.org/3033012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53200 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SpdyHttpStream dependency in SpdySessionukai@chromium.org2010-07-214-18/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3035010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53146 0039d316-1c4b-4281-b951-d872f2087c98
* Add Spdy ConnectFailure test back into spdy network tests.erikchen@google.com2010-07-201-1/+78
| | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3040005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53049 0039d316-1c4b-4281-b951-d872f2087c98
* Initial SPDY flow control supportagayev@chromium.org2010-07-2012-16/+264
| | | | | | | | | | | BUG=48100 TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowSizeChange:SpdyNetworkTransactionTest.WindowSizeOverflow" Contributed by: agayev@google.com Review URL: http://codereview.chromium.org/2805083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53039 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tsan failure in SpdyStreamTest.ukai@chromium.org2010-07-201-0/+2
| | | | | | | | | | | | | Under tsan, tcp connect job tries to connect several times and fails to find data provider for mock socket. Make connect synchronous (as done in SpdySessionTest) fixes the issue. BUG=none TEST=./tools/valgrind/chrome_tests.sh --build_dir out/Debug --test net --tool tsan --gtest_filter='SpdyStreamTest.*' Review URL: http://codereview.chromium.org/3054002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53036 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SpdyStream state for WebSocket supportukai@chromium.org2010-07-208-51/+359
| | | | | | | | | | | | | | In HTTP, it doesn't use STATE_READ_BODY/STATE_READ_BODY_COMPLETE states. Reading body message is handled in OnDataReceived() and DoLoop() is not involved in this state. In WebSocket, it will send frame after handshake has been finished, and need to get how many data has been written. STATE_OPEN handles this. BUG=none TEST=none Review URL: http://codereview.chromium.org/2962015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53000 0039d316-1c4b-4281-b951-d872f2087c98
* Implement MAX_CONCURRENT_STREAMS SETTINGS headergavinp@google.com2010-07-1711-145/+805
| | | | | | | | | | | | | | | | | | | | | | | | This CL helps chrome respect the SETTINGS header MAX_CONCURRENT_STREAMS. Note that this means that SpdySession::CreateStream can now return ERR_IO_PENDING, so it requires a callback. There's a noted TODO that if an http_network_transaction dissapears betweeen STATE_SPDY_GET_STREAM and STATE_SPDY_SEND_REQUEST I don't know if we end up with an orphan stream in our spdy_session. As well, spdy_test_util.cc had a lot of functions with default arguments; I didn't fix them all, but the functions I modified no longer take default arguments and meet the coding standard. I'd like to circle back at some point and possibly make the tests call SpdyFramer directly: these test utils seem sometimes more trouble than they're worth if the framer was a bit more convenient for direct use. BUG=34750 TEST=net_unittests Spdy.ThreeGets* Review URL: http://codereview.chromium.org/2919011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52791 0039d316-1c4b-4281-b951-d872f2087c98
* Mac compile warning fix for r52670.erikchen@google.com2010-07-161-51/+47
| | | | | | | | | TEST=NONE BUG=NONE Review URL: http://codereview.chromium.org/3027002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52673 0039d316-1c4b-4281-b951-d872f2087c98
* spdy network tests now use http network transaction (production code).erikchen@google.com2010-07-161-604/+347
| | | | | | | | | BUG=NONE TEST=net_unittests Review URL: http://codereview.chromium.org/2804045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52670 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52352 - SPDY: Initial support for handling WINDOW_UPDATE frames and ↵cbentzel@chromium.org2010-07-1411-250/+13
| | | | | | | | | | | | | | | | some cleanup. BUG=48100 TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowSizeChange:SpdyNetworkTransactionTest.WindowSizeOverflow" Contributed by: agayev@google.com Review URL: http://codereview.chromium.org/2807042 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/2908010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52362 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: Initial support for handling WINDOW_UPDATE frames and some cleanup.cbentzel@chromium.org2010-07-1411-13/+250
| | | | | | | | | | | BUG=48100 TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowSizeChange:SpdyNetworkTransactionTest.WindowSizeOverflow" Contributed by: agayev@google.com Review URL: http://codereview.chromium.org/2807042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52352 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY incorrectly DCHECKed that the SYN_REPLY headers could never be an empty ↵erikchen@google.com2010-07-142-1/+2
| | | | | | | | | | | list. TEST=net_unittests BUG=47991 Review URL: http://codereview.chromium.org/2987002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52264 0039d316-1c4b-4281-b951-d872f2087c98
* Remove hex frames from spdy_session_unittest.ccmlloyd@chromium.org2010-07-121-27/+10
| | | | | | | | | BUG=None TEST=net_unittests pass Review URL: http://codereview.chromium.org/2896004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52118 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: reverting broken commiterikchen@google.com2010-07-129-263/+47
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52113 0039d316-1c4b-4281-b951-d872f2087c98
* Make the various SocketParams reference counted.vandebo@chromium.org2010-07-124-8/+12
| | | | | | | | | | | This is so that the SSLSocketParam can hold one of any of the existing SocketParams. BUG=30357 TEST=existing unit tests Review URL: http://codereview.chromium.org/2848029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52107 0039d316-1c4b-4281-b951-d872f2087c98
* Streams send a Rst frame upon being closed by client. Some minor editorial ↵erikchen@google.com2010-07-129-47/+263
| | | | | | | | | | | | | fixes. TEST=net_unittests BUG=46589 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51007 Review URL: http://codereview.chromium.org/2804008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52106 0039d316-1c4b-4281-b951-d872f2087c98
* Client attempts to start a new spdy transaction with a session that is ↵erikchen@google.com2010-07-096-21/+117
| | | | | | | | | | | closing down. TEST=net_unittests BUG=47455,48503 Review URL: http://codereview.chromium.org/2841029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52001 0039d316-1c4b-4281-b951-d872f2087c98
* Mark differences in the hex dumpsmlloyd@chromium.org2010-07-091-18/+46
| | | | | | | | | BUG=None TEST=net_unittests pass Review URL: http://codereview.chromium.org/2936002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51989 0039d316-1c4b-4281-b951-d872f2087c98