summaryrefslogtreecommitdiffstats
path: root/net/spdy
Commit message (Collapse)AuthorAgeFilesLines
* Revert 118950 - Allow chrome to handle 407 auth challenges to CONNECT requestsrch@chromium.org2012-02-033-96/+34
| | | | | | | | | | | | | | | | | | | | through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Initially was http://codereview.chromium.org/8502024 which turned out to have problems with NTLM auth. Review URL: http://codereview.chromium.org/9148011 TBR=rch@chromium.org Review URL: https://chromiumcodereview.appspot.com/9316101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120370 0039d316-1c4b-4281-b951-d872f2087c98
* net: Replace UploadDataStream::Create() with Init().satorux@chromium.org2012-02-022-6/+9
| | | | | | | | | | | | | This is in preparation of adding asynchronous API to UploadDataStream. Doing initialization in Init() is cleaner anyway. BUG=72001 TEST=try bots Review URL: http://codereview.chromium.org/9235079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120182 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in files owned by jar.tedvessenes@gmail.com2012-01-283-13/+12
| | | | | | | | | | | R=jar@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9190027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119547 0039d316-1c4b-4281-b951-d872f2087c98
* Add NetLog entries to preconnect HttpStreamFactoryImpl::Jobs.mmenke@chromium.org2012-01-281-1/+1
| | | | | | | | | R=eroman@chromium.org BUG=111640 Review URL: http://codereview.chromium.org/9225028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119543 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - Change all tests to use SPDY/2.1 protocol. Madertenneti@chromium.org2012-01-273-19/+56
| | | | | | | | | | | | changes to SPDY code to support enabling or disabling flow_control independent of NPN protocol negotiated. TEST=network unit tests R=wtc Review URL: http://codereview.chromium.org/9252029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119360 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chrome to handle 407 auth challenges to CONNECT requestsrch@chromium.org2012-01-253-34/+96
| | | | | | | | | | | | | | | | | through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Initially was http://codereview.chromium.org/8502024 which turned out to have problems with NTLM auth. Review URL: http://codereview.chromium.org/9148011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118950 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r113405, since it appears to be causing a crash and a hang. Also ↵eroman@chromium.org2012-01-242-21/+2
| | | | | | | | | | reverted r118506 since it is no longer applicable. BUG=109876, 110368, 62364, 92244 Review URL: https://chromiumcodereview.appspot.com/9226039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118788 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to socket_test_util.cc.szym@chromium.org2012-01-224-110/+116
| | | | | | | | | | | | | | | - Removes ref-counting from DelayedSocketData and OrderedSocketData. - Calls CompleteRead (which reads from underlying data) only if a Socket::Read call is "blocked" (previously returned with ERR_IO_PENDING). - Removes unsafe pointers to the handed out sockets (the factory does not own them and cannot guarantee their lifetime). BUG=110626 TEST=./net_unittests --gtest_filter=Spdy*:Http*:Socket*:WebSocket*:Ftp* Review URL: http://codereview.chromium.org/9251019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118634 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - SpdyFramer close the session for header compression/decompression errors.rtenneti@google.com2012-01-211-1/+4
| | | | | | | | | BUG=99766 R=wtc TEST=network unit tests Review URL: https://chromiumcodereview.appspot.com/9232019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118595 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - FlipServer - changes to use BufferedSpdyFramer.rtenneti@chromium.org2012-01-182-2/+18
| | | | | | | | | TEST=network unittests R=wtc Review URL: http://codereview.chromium.org/9174026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118139 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - bug fix for WINDOW_UPDATE loggingrtenneti@chromium.org2012-01-181-3/+3
| | | | | | | | | | BUG=108356 R=wtc TEST=network unit tests Review URL: http://codereview.chromium.org/9242021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118036 0039d316-1c4b-4281-b951-d872f2087c98
* Handle Z_BUF_ERROR as a non-fatal error while incrementally decompressingrtenneti@google.com2012-01-132-4/+2
| | | | | | | | | | | | | | SYN_STREAM/SYN_REPLY headers. This also fixes bug when server sends SYN_REPLY in separate chunks (i.e. header + zlib chunks ) chrome fails to recognize it. BUG=108596 R=jar TEST=ASAN tests and network unit tests Review URL: http://codereview.chromium.org/9185036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117563 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - delete unused code from spdy_framer.rtenneti@chromium.org2012-01-073-316/+42
| | | | | | | | | | | | | | | | - Deleted all code associated with SPDY_INTERPRET_CONTROL_FRAME_COMMON_HEADER - Deleted OldProcessControlFrameHeaderBlock and OldIncrementallyDecompressControlFrameHeaderData - Changed unittests to reflect the above changes. Deleted uses of ParseHeaderBlock (server code doesn't use ParseHeaderBlock). BUG=108608 R=wtc TEST=network unit tests. Review URL: http://codereview.chromium.org/9124022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116814 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 116772 - Enabled SpdyFramerTest's UnclosedStreamDataCompressors.rtenneti@chromium.org2012-01-072-7/+16
| | | | | | | | | | | | | | | | | Wasn't able to duplicate ASAN tests failing in UnclosedStreamDataCompressors on my linux build. Enabling it to see if the failure was flaky. BUG=108596 R=rch TEST=network unittests. Review URL: http://codereview.chromium.org/8982009 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/9141002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116777 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled SpdyFramerTest's UnclosedStreamDataCompressors.rtenneti@chromium.org2012-01-062-16/+7
| | | | | | | | | | | | | | Wasn't able to duplicate ASAN tests failing in UnclosedStreamDataCompressors on my linux build. Enabling it to see if the failure was flaky. BUG=108596 R=rch TEST=network unittests. Review URL: http://codereview.chromium.org/8982009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116772 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Fixed uninitialized member in ctorgroby@chromium.org2011-12-301-1/+2
| | | | | | | | | | | | | TBR=rtenneti@chromium.org CID=102867 BUG=none TEST=none Review URL: http://codereview.chromium.org/9034028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116010 0039d316-1c4b-4281-b951-d872f2087c98
* Move net/base/sys_byteorder.h to base/sys_byteorder.hisherman@chromium.org2011-12-283-3/+3
| | | | | | | | | | | | | | Two motivations: (1) There are currently clients in src/crypto that need the same logic. (2) There is soon to be a client in src/chrome/common that needs the 64-bit version of this logic, which is currently inlined in a src/crypto implementation file. BUG=103480 TEST=compiles Review URL: http://codereview.chromium.org/8949026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115926 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fix: Logically dead codearthurhsu@chromium.org2011-12-281-0/+1
| | | | | | | | | | CID=102525 TEST=none Review URL: http://codereview.chromium.org/9013001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115904 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to SpdyFramer for the CREDENTIAL frame.rch@chromium.org2011-12-279-6/+462
| | | | | | | | | BUG=106103 TEST=None Review URL: http://codereview.chromium.org/8893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115835 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed permissionrtenneti@google.com2011-12-251-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115773 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled UnclosedStreamDataCompressors to fix ASAN error.rtenneti@google.com2011-12-251-1/+3
| | | | | | | | | | R=Ryan Sleevi TBR=rch BUG=108596 TESTS= ASAN net unittests. Review URL: http://codereview.chromium.org/9020043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115770 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to read SPDY headers incrementally. rtenneti@chromium.org2011-12-259-156/+763
| | | | | | | | | | | | | | | | | | | | | Added buffered_spdy_framer class to support buffering of spdy control header frames. It calls SpdySession's OnSyn, OnSynReply and OnHeaders methods after receiving all the control frame header data. spdy_framer*.* - integrated changes from the server. Changed OnControlFrameHeaderData to send control frame instead of stream_id. Merged changes from the following issue into this issue. http://codereview.chromium.org/8953012/ R=willchan TEST=network unit tests Review URL: http://codereview.chromium.org/8980015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115769 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate no-arg constructor for CallbackResultPairtbreisacher@chromium.org2011-12-222-3/+2
| | | | | | | | | | | CID=102680 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/9023010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115597 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fixing dead code bug.dpapad@chromium.org2011-12-211-4/+0
| | | | | | | | | | | CID=102542 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/9006044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115414 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert net/spdy.jhawkins@chromium.org2011-12-215-70/+82
| | | | | | | | | | BUG=none TEST=none R=groby Review URL: http://codereview.chromium.org/8956018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115392 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert most of webkit/appcache.jhawkins@chromium.org2011-12-211-1/+3
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8991001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115353 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert most of net/http.jhawkins@chromium.org2011-12-2013-293/+327
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8990001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115220 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize protocol_version to Unknown.rtenneti@chromium.org2011-12-202-3/+8
| | | | | | | | | | R=mmenke TEST=network unittests BUG=108134 Review URL: http://codereview.chromium.org/8956042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115196 0039d316-1c4b-4281-b951-d872f2087c98
* Added protocol_version negotiated with the server.rtenneti@google.com2011-12-206-9/+29
| | | | | | | | | | | | | protocol_version will be printed by the LoadTimes extension. R=willchan BUG=108134 TEST=network unittests Review URL: http://codereview.chromium.org/8914005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115145 0039d316-1c4b-4281-b951-d872f2087c98
* Retry 114494 - Remove BindStateHolder and have Bind() return a Callback<> ↵ajwong@chromium.org2011-12-201-2/+2
| | | | | | | | | | | | | | | object directly." This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch. Also makes the static type checking a bit more strict when assigning into a Callback<>. BUG=none TEST=new unittests Review URL: http://codereview.chromium.org/8915024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115045 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert proxy_resolving_client_socket.[cc,h] and deps.jhawkins@chromium.org2011-12-155-52/+38
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8898036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114562 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114494 - Remove BindStateHolder and have Bind() return a Callback<> ↵sail@chromium.org2011-12-141-2/+2
| | | | | | | | | | | | | | | | | object directly. This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch. BUG=none TEST=new unittests Review URL: http://codereview.chromium.org/8738001 TBR=ajwong@chromium.org Review URL: http://codereview.chromium.org/8914022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114495 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BindStateHolder and have Bind() return a Callback<> object directly.ajwong@chromium.org2011-12-141-2/+2
| | | | | | | | | | | | This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch. BUG=none TEST=new unittests Review URL: http://codereview.chromium.org/8738001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114494 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110965 - Allow chrome to handle 407 auth challenges to CONNECT requestsrch@chromium.org2011-12-143-98/+11
| | | | | | | | | | | | | | through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Review URL: http://codereview.chromium.org/8912010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114447 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SPDY flow control.willchan@chromium.org2011-12-141-1/+1
| | | | | | | | | | | | | We were calling SpdyStream::OnWriteComplete() (which indicates successful DATA frame writes) when we write a WINDOW_UPDATE frame on behalf of a stream. That's wrong. TODO: write regression test. BUG=107449 TEST=none Review URL: http://codereview.chromium.org/8929021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114356 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - add support for spdy/2.1 to support flow control.rtenneti@google.com2011-12-105-15/+33
| | | | | | | | | | | | | | | | | | | | 1) Add spdy/2.1 as a supported NPN protocol. 2) Advertise that chrome supports spdy/2.1 when --flow-control (spdy flag) is enabled. 3) When SPDY protocol is negotiated, enable flow_control in spdy_session if spdy/2.1 is negotiated as NPN protocol. BUG=106911 R=willchan TEST=network unit tests and if possible test with SPDY 2.1 server with command line flag --flow-control. This CL is same as the following CL. Implemented changes suggested by willchan in the following review. http://codereview.chromium.org/8890044/ Review URL: http://codereview.chromium.org/8892026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113942 0039d316-1c4b-4281-b951-d872f2087c98
* Fix use-after-frees in some SPDY tests.willchan@chromium.org2011-12-101-4/+4
| | | | | | | | | | BUG=106979 TEST=none Review URL: http://codereview.chromium.org/8896016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113912 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate SpdyControlFrame::size in favor of SpdyControlFrame::kHeaderSizethakis@chromium.org2011-12-094-17/+14
| | | | | | | | | | | | | | | | | | | inherited from the base class. Manual changes only to spdy_protocol.h, the rest of the CL generated by running and then manually fixing the one 80 col violation: perl -pi -e "s/SpdyControlFrame::size\(\)/SpdyControlFrame::kHeaderSize/" $(git grep -l SpdyControlFrame::size) This is the same as the google-internal CL 25980588 BUG=none TEST=none Review URL: http://codereview.chromium.org/8898003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113865 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind().ajwong@chromium.org2011-12-095-147/+94
| | | | | | | | | | | This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users. BUG=none TEST=existing. Review URL: http://codereview.chromium.org/8824006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113825 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113699 - base::Bind: Convert Socket::Write.jhawkins@chromium.org2011-12-092-67/+12
| | | | | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8831001 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/8889036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113719 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert Socket::Write.jhawkins@chromium.org2011-12-082-12/+67
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8831001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113699 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113305 - Revert 113300 - Revert of 112134 of Revert 112130 - Close ↵rtenneti@google.com2011-12-072-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | idle connections / SPDY sessions when needed. Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan). Added NET_EXPORT for layered_pool class defintion to fix windows shared compile. BUG=62364, 92244, 105839 TEST=none Review URL: http://codereview.chromium.org/8340012 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8745007 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8803019 TBR=rtenneti@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113305 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8836002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113405 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert Socket::Read.jhawkins@chromium.org2011-12-072-3/+30
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8801005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113326 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113300 - Revert of 112134 of Revert 112130 - Close idle connections / ↵rtenneti@chromium.org2011-12-072-23/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | SPDY sessions when needed. Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan). BUG=62364,92244, 105839 TEST=none Review URL: http://codereview.chromium.org/8340012 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8745007 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8803019 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/8825014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113305 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of 112134 of Revert 112130 - Close idle connections / SPDY sessions ↵rtenneti@chromium.org2011-12-062-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | when needed. Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan). BUG=62364,92244, 105839 TEST=none Review URL: http://codereview.chromium.org/8340012 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8745007 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8803019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113300 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY PING - log the type of PING if it is receivedrtenneti@chromium.org2011-12-061-3/+8
| | | | | | | | | | | | | | | | | | or sent ping (like below): t=1323200233634 [st=196851] SPDY_SESSION_PING --> type = "sent" --> unique_id = 3 t=1323200233638 [st=196855] SPDY_SESSION_PING --> type = "received" --> unique_id = 3 BUG=106499 R=willchan TEST=spdy unit tests Review URL: http://codereview.chromium.org/8824005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113295 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert StreamSocket::Connect.jhawkins@chromium.org2011-12-062-18/+52
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8801004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113283 0039d316-1c4b-4281-b951-d872f2087c98
* Make SpdyFrame::size a constant instead of a static method so gcc can ↵thakis@chromium.org2011-12-047-57/+63
| | | | | | | | | | | | | | | | | | optimize the call away. Manual changes to spdy_protocol.h and spdy_framer.cc, rest of the CL generated by running: perl -pi -e "s/SpdyFrame::size\(\)/SpdyFrame::kHeaderSize/" $(git grep -l SpdyFrame::size) This is the same as the google-internal CL 25917366 and 25938381 BUG=94125 TEST=none TBR=willchan Review URL: http://codereview.chromium.org/8790015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112929 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash bug in SpdyProxyClientSocket.GetPeerAddress whererch@chromium.org2011-12-033-21/+24
| | | | | | | | | | | | spdy_stream_ was used when NULL. We now copy the peer address and local address from spdy_stream_ when we connect. BUG=106073 TEST=SpdyProxyClientSocket.GetPeerAddressReturnsCorrectValue Review URL: http://codereview.chromium.org/8771012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112871 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112130 - Close idle connections / SPDY sessions when needed.sail@chromium.org2011-11-302-23/+2
| | | | | | | | | | | | | | | | | Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. BUG=62364,92244, 105839 TEST=none Review URL: http://codereview.chromium.org/8340012 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8745007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112134 0039d316-1c4b-4281-b951-d872f2087c98