| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
In light of recent analysis of RC4, this seems like a prudent measure.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/13985023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't build with NSS_ENABLE_ZLIB defiend because we are no longer
enabling the SSL_ENABLE_DEFLATE option.
Define AES_256_KEY_SIZE in sslsnce.c if the system blapit.h doesn't
define it. We used to work around this in ssl/bodge/blapi.h.
R=agl@chromium.org,rsleevi@chromium.org
BUG=179524
TEST=no compilation errors, especially on Linux.
Review URL: https://chromiumcodereview.appspot.com/12386065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libssl is used both by net (as part of SSL) and part of content (as part
of WebRTC). Built in component mode, two copies get built in, with
independent global variables - thus causing the net/ initialization
functions to initialize the net.dll version, rather than the content.dll
version.
Make libssl build as a dll in component mode (roughly). Rather than using
a linker script like upstream, just export all the symbols.
BUG=webrtc:1390
TEST=component builds are happy
Review URL: https://chromiumcodereview.appspot.com/12383007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clear any existing certificate status messages received.
Failure to clear the status results in handshake failures.
BUG=170328
TEST=See bug
Review URL: https://chromiumcodereview.appspot.com/12327032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This merges the fix from upstream NSS bug 822433:
https://bugzilla.mozilla.org/show_bug.cgi?id=822433
R=fischman@chromium.org
BUG=174898
TEST=none
Review URL: https://chromiumcodereview.appspot.com/12210091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
renamed macAlg in the NSS upstream.
R=agl@chromium.org
BUG=172658
TEST=none
Review URL: https://chromiumcodereview.appspot.com/12220054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change contains the libssl changes needed to process CBC records in
constant time. This has no effect unless the underlying NSS library has also
been updated.
BUG=172658
Review URL: https://chromiumcodereview.appspot.com/12193010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=166496
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11830032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
upstream when handling client auth
When configuring client auth callbacks, ensure that the modified libssl used
on Win/Mac behaves the same as a stock upstream libssl, in that the NSS
client auth callback function is called if it is set. The previous behaviour
was to only call the platform-specific client auth hook, but that relies on
applications being aware of the platform-specific client auth patch, which
is not desirable for WebRTC.
BUG=158504
Review URL: https://chromiumcodereview.appspot.com/11359197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of the changes are related to the MPL 2 license upgrade and the
new NO_PKCS11_BYPASS macro. Nine of our patches have been subsumed.
The fixes for the following bugs are included:
https://bugzilla.mozilla.org/show_bug.cgi?id=793033
https://bugzilla.mozilla.org/show_bug.cgi?id=792681
https://bugzilla.mozilla.org/show_bug.cgi?id=764649
https://bugzilla.mozilla.org/show_bug.cgi?id=751793
https://bugzilla.mozilla.org/show_bug.cgi?id=745281
https://bugzilla.mozilla.org/show_bug.cgi?id=734519
https://bugzilla.mozilla.org/show_bug.cgi?id=697910
https://bugzilla.mozilla.org/show_bug.cgi?id=565047
R=agl@chromium.org,rsleevi@chromum.org
BUG=159669
TEST=none
Review URL: https://codereview.chromium.org/11275240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=rsleevi@chromium.org
BUG=159669
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11364140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DSA1_SIGNATURE_LEN.
R=rsleevi@chromium.org
BUG=151692
TEST=no compilation error
Review URL: https://chromiumcodereview.appspot.com/10969058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138571
TBR=tony
Review URL: https://chromiumcodereview.appspot.com/10855238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initial ClientHello to work around a Windows SChannel bug.
Cap the record layer version number to TLS 1.0 only for the initial
ClientHello. The record layer version number of the ClientHello in
a renegotiation should use the currently negotiated version number.
R=agl@chromium.org,rsleevi@chromium.org
BUG=141629
TEST=Visit https://solutionscenter.naradana.net/, an IIS server that
requests (but doesn't require) client certificates over renegotiation.
The page should be laid out correctly.
Review URL: https://chromiumcodereview.appspot.com/10828269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=rsleevi@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10836273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of these directories are currently excluded from the license check. This change fixes the metadata where required and removes them from PRUNE_PATHS.
Other directories contain third-party code, but aren't in directories named 'third-party', so aren't checked by the license tool by default. This change fixes the metadata where required and adds them to ADDITIONAL_PATHS.
To avoid adding to about:credits licenses for modules that don't ship as part of the product, this change also introduces a special 'NOT_SHIPPED' value for the 'License File' field.
This will simplify the process of adding a tool to check license compatibility for the Android WebView build.
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10830201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if we don't know what TLS version the server supports.
Fix the -p option for the patch commands in applypatches.sh.
R=agl@chromium.org,rsleevi@chromium.org
BUG=136666
TEST=manual: visit https://cybozulive.com/, https://www.billpaysite.com/,
and https://members.mh-frontier.jp/mypage/ on Linux or Mac. The connection
should succeed.
Review URL: https://chromiumcodereview.appspot.com/10777021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was renamed upstream as part of
https://bugzilla.mozilla.org/show_bug.cgi?id=681065#c37 for NSS 3.14
Update the local NSS patch to reflect this naming so that code built
against the DTLS functionality can be tested with upstream trunk or
with Chromium NSS-SSL.
BUG=none
TEST=it compiles
R=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10693078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nothing builds these targets yet, but getting these working makes it easier to get all.gyp working for iOS.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10692060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=`SSLKEYLOGFILE=/ ./out/Release/chrome` shouldn't crash.
Review URL: https://chromiumcodereview.appspot.com/10636062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=129174
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10649007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By the time that NSS makes a ChannelID callback, we have already committed to
sending a ChannelID on the current connection. Therefore, if we cannot, it's
fatal to the connection.
The only time that we should fail to generate a keypair is if we've been
compiled without ECC support. In that case, we need to ensure that we don't
advertise ChannelID support in the first place.
BUG=127506
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10640007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
cwSpec instead of crSpec to support False Start.
R=agl@chromium.org
BUG=132947
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10542176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to do this in https://chromiumcodereview.appspot.com/9982019.
TBR=rsleevi@chromium.org,ekr@rtfm.com
BUG=120938
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10572010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This addresses wtc's follow-up comment in
https://chromiumcodereview.appspot.com/10509009/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves SSL keylogging (see [1]) out from behind the TRACE and DEBUG defines
and allows normal builds to use it when the correct environment variable is
set. It also adds a new CLIENT_RANDOM format to support ECDHE-RSA key-agreement
(and others).
[1] https://developer.mozilla.org/en/NSS_Key_Log_Format
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10509009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the core state machine of SSLClientSocketNSS into a thread-safe Core
NSS SSL functions may block on the underlying PKCS#11 modules or on
user input. On ChromeOS, which has a hardware TPM, calls may take upwards
of several seconds, preventing any IPC due to the I/O thread being
blocked.
To avoid blocking the I/O thread on ChromeOS, move the core SSL
implementation to a dedicated worker thread, so that only SSL sockets
are blocked.
BUG=122355
TEST=existing net_unittests + see bug.
Review URL: https://chromiumcodereview.appspot.com/10454066
TBR=rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10546033
TBR=rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10543036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and this will be relanded), but revert to be sure it wasn't something else.
Move the core state machine of SSLClientSocketNSS into a thread-safe Core
NSS SSL functions may block on the underlying PKCS#11 modules or on
user input. On ChromeOS, which has a hardware TPM, calls may take upwards
of several seconds, preventing any IPC due to the I/O thread being
blocked.
To avoid blocking the I/O thread on ChromeOS, move the core SSL
implementation to a dedicated worker thread, so that only SSL sockets
are blocked.
BUG=122355
TEST=existing net_unittests + see bug.
Review URL: https://chromiumcodereview.appspot.com/10454066
TBR=rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10546033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSS SSL functions may block on the underlying PKCS#11 modules or on
user input. On ChromeOS, which has a hardware TPM, calls may take upwards
of several seconds, preventing any IPC due to the I/O thread being
blocked.
To avoid blocking the I/O thread on ChromeOS, move the core SSL
implementation to a dedicated worker thread, so that only SSL sockets
are blocked.
BUG=122355
TEST=existing net_unittests + see bug.
Review URL: https://chromiumcodereview.appspot.com/10454066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10540014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch is contributed by Eric Rescorla.
R=rsleevi@chromium.org,ekr@rtfm.com
BUG=120938
TEST=none (eventually covered by libjingle tests)
Review URL: https://chromiumcodereview.appspot.com/9982019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=129174
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10424013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
support."
Cleaning up git-svn mess with drover.
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10451012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Screwed up git branches in that change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is the result of running patch -R to revert the two patches.
A minor change is needed to ssl_client_socket_nss.cc in order for the result to
compile.
BUG=129174
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This patch is about to be removed in another change but, for the sake of
code history, this change corrects the URL.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Picks up r137477 - Split the nssckbi target off from the 'nss' target and r137925 - post review comment update
BUG=123666
TEST=compiles
R=wtc
Review URL: https://chromiumcodereview.appspot.com/10386177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=125768
TEST=hack ServerBoundCertService::GenerateCert to always fail
Review URL: https://chromiumcodereview.appspot.com/10315008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works around the locking problem with SSL_OptionSet in
a renegotiation.
The previous fix r134584 is reverted.
R=agl@chromium.org,rsleevi@chromium.org
BUG=125299
TEST=Run a Chrome debug build on Windows. Visit a site that
does SSL renegotiation. There should be no assertion failure.
For example, visit http://foaf.me, click the
"Login to your account" link at the upperright corner of the
page. Then press the "sign in" button.
Review URL: http://codereview.chromium.org/10290002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This debugger traps in debug mode due to the locks held at the time that the callback is made.
BUG=125299
TEST=none
Review URL: http://codereview.chromium.org/10221018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=124836
TEST=none
Review URL: http://codereview.chromium.org/10173004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=rsleevi@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10134025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bodo made the point that we originally sacrificed an aspect of forward secrecy
in order to use False Start widely. Specifically, an attacker can alter the
handshake and cause a non-forward secure ciphersuite to be selected and the
client's initial write will not be forward secret.
Since we are no longer trying to use False Start everywhere, we can close that
gap by only allowing it for forward secret connections.
This change also addresses follow up comments on
https://chromiumcodereview.appspot.com/10014010/ and adds the patch file that
was missing in that change.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/10136001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change causes NSS only to False Start with NPN capable servers. It also
removes the False Start blacklist and this has the effect of enabling 1/n-1
record splitting for those hosts that were previously on the blacklist.
However, those hosts have been getting 1/n-1 from Opera, Firefox and IE for a
few months now.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/10014010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=rsleevi@chromium.org
BUG=120938
TEST=none
Review URL: http://codereview.chromium.org/9958008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=rsleevi@chromium.org
BUG=120938
TEST=none
Review URL: http://codereview.chromium.org/9764001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes two changes required for Eric Rescorla's DTLS patch:
- the new SSL version range API
- TLS 1.1
clang-sslcon.patch, nextprotocleanup.patch, secret_exporter.patch,
and secret_exporter2.patch are removed because they have been checked
in.
R=rsleevi@chromium.org
BUG=118983
TEST=no build or test errors.
Review URL: http://codereview.chromium.org/9733012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
method to support both nonexistent context and zero-length context.
R=agl@chromium.org,rsleevi@chromium.org
BUG=none
TEST=existing unit tests
Review URL: http://codereview.chromium.org/9663043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
functions.
R=agl@chromium.org
BUG=116617
TEST=none
Review URL: http://codereview.chromium.org/9663034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build 64-bit version of chrome using 64-bit chromeos sysroot
Review URL: http://codereview.chromium.org/9654001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125925 0039d316-1c4b-4281-b951-d872f2087c98
|