| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
This is the third attempt at a landing. First attempt was
reverted: https://codereview.chromium.org/1151753002
This is a re-land of the second attempt which was
reverted speculatively (wrongly as it turned out):
https://codereview.chromium.org/1158283003
TBR=cpu
Review URL: https://codereview.chromium.org/1146303007
Cr-Commit-Position: refs/heads/master@{#332982}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original change is suspected of breaking the build
and the second one is followup that needs to be reverted
along with it.
Revert "Fix use of 'sysroot' variable in harfbuzz.gyp"
https://codereview.chromium.org/1158283003
Revert "Fix common.gypi when run with target_arch=mips"
https://codereview.chromium.org/1166523004
TBR=cpu
BUG=496462
Review URL: https://codereview.chromium.org/1159083004
Cr-Commit-Position: refs/heads/master@{#332766}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
Second attempt at landing this. First attempt was here:
https://codereview.chromium.org/1151753002
TBR=cpu
Review URL: https://codereview.chromium.org/1158283003
Cr-Commit-Position: refs/heads/master@{#332311}
|
|
|
|
|
|
|
|
|
| |
BUG=492448
R=davidben@chromium.org
Review URL: https://codereview.chromium.org/1156003004
Cr-Commit-Position: refs/heads/master@{#331665}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:100001 of https://codereview.chromium.org/1151753002/)
Reason for revert:
Breaks GYP for Chrome OS builds. Repro steps:
cros chrome-sdk --board=amd64-generic
gclient runhooks
Updating projects from gyp files...
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs-only-l nss | sed -e "s/-lssl3//"' returned exit status 0.
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs libcras' returned exit status 127.
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --cflags x11' returned exit status 127.
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /ssd/src/chromium
TEST=cros chrome-sdk --board=amd64-generic && gclient runhooks
Original issue's description:
> Fix use of 'sysroot' variable in harfbuzz.gyp
>
> The sysroot variable is set conditionally in common.gypi
> but not at the nesting level required for other conditional
> to depend on it like the one in hardbuzz does. This means
> that sysroot always appeared to be empty to harfbuzz.gyp,
> and hence the special handling for ARM linux was required.
>
> This change moves the setting of 'sysroot' up one level of
> nesting and defines 'pkg-config' in common.gypi so it can
> be shared.
>
> Committed: https://crrev.com/6a80b32f309490f44347f2925589a6f0fc23c3ff
> Cr-Commit-Position: refs/heads/master@{#331506}
TBR=mazda@chromium.org,dpranke@chromium.org,cpu@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1154213004
Cr-Commit-Position: refs/heads/master@{#331642}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
Review URL: https://codereview.chromium.org/1151753002
Cr-Commit-Position: refs/heads/master@{#331506}
|
|
|
|
|
|
|
|
|
|
| |
Since some platforms are still using NSS for now, this change mirrors https://boringssl-review.googlesource.com/#/c/4813/ in NSS.
BUG=490240
Review URL: https://codereview.chromium.org/1143303002
Cr-Commit-Position: refs/heads/master@{#330791}
|
|
|
|
|
|
|
|
|
|
| |
See https://bugzilla.mozilla.org/show_bug.cgi?id=1162521.
BUG=484543,462283
Review URL: https://codereview.chromium.org/1134493002
Cr-Commit-Position: refs/heads/master@{#328795}
|
|
|
|
|
|
|
|
| |
BUG=469516
Review URL: https://codereview.chromium.org/1053903002
Cr-Commit-Position: refs/heads/master@{#323840}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch updates the dynamic lookup of NSS symbols to use
dlsym(RTLD_DEFAULT) instead of dlsym on the dlopen(NULL) handle.
The latter doesn't work if the binary that does the dynamic lookup was
loaded dynamically itself (as dlopen(NULL) gives access only to the
symbols loaded at the start of the program).
Note that RTLD_DEFAULT requires setting _GNU_SOURCE.
BUG=462203
Review URL: https://codereview.chromium.org/962593002
Cr-Commit-Position: refs/heads/master@{#318863}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes process_version template. In GYP this is used in two ways and the GN version only supported one of these. This change also deletes an unnecessary fork of the template file, and fixes the dependencies for the extra files (previously they were just passed with "-f" and not added to the inputs of the target.
Adds a cdm_adapter template which basically matches the GYP version. Uses this for the media clearkey adapter and the widevine one in the official build.
Fixes for the crypto targets when compiling with the official build's checked-in sysroots.
Review URL: https://codereview.chromium.org/949233003
Cr-Commit-Position: refs/heads/master@{#318083}
|
|
|
|
|
|
|
|
|
|
| |
This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.
Minor updates to Win64 build, including some fixes for size_t to int conversions.
Review URL: https://codereview.chromium.org/929793006
Cr-Commit-Position: refs/heads/master@{#317162}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In crrev.com/316164, a bug was fixed to handle comments in
a source list correctly.
In this patch, a bug was fixed to handle comments at the
end of a source list.
Along the way, sort some GYP files in sub directories under
base and net, which I forgot to sort previously.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/924743002
Cr-Commit-Position: refs/heads/master@{#316418}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GYP files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/919333002
Cr-Commit-Position: refs/heads/master@{#316182}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excluded mojo because I think that needs to happen on the other side.
At gn --version = 306668 for which roll is in CQ.
R=brettw@chromium.org
TBR=scherkus@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/774353003
Cr-Commit-Position: refs/heads/master@{#306708}
|
|
|
|
|
|
|
|
|
|
|
| |
The warning got stricter recently.
BUG=82385
TBR=brettw
Review URL: https://codereview.chromium.org/758963003
Cr-Commit-Position: refs/heads/master@{#305685}
|
|
|
|
|
|
|
|
| |
BUG=314403
Review URL: https://codereview.chromium.org/691193002
Cr-Commit-Position: refs/heads/master@{#302185}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yngve Pettersen reports better compatibility with this value at the end of the list and OpenSSL had a bug around process it when it was first.
(I pondered moving the reneg SCSV to the end also but that code is from upstream and reneg SCSV is only sent for SSLv3, which is not a going concern any longer.)
BUG=none
Review URL: https://codereview.chromium.org/678413002
Cr-Commit-Position: refs/heads/master@{#301941}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the LICENSE file with the contents of the current COPYING file in
the NSS source tree.
R=rsleevi@chromium.org,tjblasi@google.com
BUG=none
Review URL: https://codereview.chromium.org/685253002
Cr-Commit-Position: refs/heads/master@{#301913}
|
|
|
|
|
|
|
|
|
|
| |
This workaround is no longer needed as the NSS bug was fixed in NSS 3.12.10 (see: https://bugzilla.mozilla.org/show_bug.cgi?id=635778), and Chromium requires NSS 3.14.3 or later now.
BUG=138571
Review URL: https://codereview.chromium.org/616093002
Cr-Commit-Position: refs/heads/master@{#297809}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSS upstream patches:
https://hg.mozilla.org/projects/nss/rev/2cb5c73ac307
https://hg.mozilla.org/projects/nss/rev/544eb0f50d40
R=agl@chromium.org
BUG=416841
Review URL: https://codereview.chromium.org/595823003
Cr-Commit-Position: refs/heads/master@{#297772}
|
|
|
|
|
|
|
|
|
|
| |
This is required to workaround typo in the guard macro of secmod.h. See details in bug.
BUG=415498
Review URL: https://codereview.chromium.org/582403002
Cr-Commit-Position: refs/heads/master@{#297754}
|
|
|
|
|
|
|
|
|
| |
R=rsleevi@chromium.org,rch@chromium.org
BUG=
Review URL: https://codereview.chromium.org/613353002
Cr-Commit-Position: refs/heads/master@{#297657}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=354261
R=brettw
TBR=piman,wtc
NOTRY=true
Review URL: https://codereview.chromium.org/603143002
Cr-Commit-Position: refs/heads/master@{#297481}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apply Eric Rescorla's patch from upstream NSS:
https://bugzilla.mozilla.org/show_bug.cgi?id=1009227
R=agl@chromium.org,ekr@rtfm.com
BUG=369855
Review URL: https://codereview.chromium.org/319573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already have a variable for tracking the system libdir name in the
gyp files, so let's use that instead of hardcoding the logic based on
the arch.
BUG=chromium:219015
TEST=`cbuildbot amd64-generic-tot-chrome-pfq-informational` works
Review URL: https://codereview.chromium.org/244593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is happening when running the following command line:
$ gn gen out/Debug --args='is_component_build=true'
ERROR at //net/third_party/nss/ssl/BUILD.gn:122:18: Item not found
configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
^--------------------------------------------
You were trying to remove "//build/config/gcc:symbol_visibility_hidden"
from the list but it wasn't there.
BUG=None
TEST=above
R=brettw@chromium.org,wtc@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/285293009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSphere Application Server 7.0 appears to be intolerant of an
empty extension at the end. To that end, also ensure we never
send an empty padding extension.
BUG=363583
Review URL: https://codereview.chromium.org/240633006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a TODO about private symbols on GCC.
Moves many third party BUILD.gn files from the secondary tree to the main one.
Fixes the dependencies on Linux so "gn check" passes again.
BUG=367595
R=scottmg@chromium.org
Previous review: https://codereview.chromium.org/256153003/
Review URL: https://codereview.chromium.org/264463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> GN build improvements.
>
> Fixes a TODO about private symbols on GCC.
>
> Moves many third party BUILD.gn files from the secondary tree to the main one.
>
> Fixes the dependencies on Linux so "gn check" passes again.
>
> BUG=367595
> R=scottmg@chromium.org
>
> Review URL: https://codereview.chromium.org/256153003
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/257243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a TODO about private symbols on GCC.
Moves many third party BUILD.gn files from the secondary tree to the main one.
Fixes the dependencies on Linux so "gn check" passes again.
BUG=367595
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/256153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bunch of minor issues, mostly header file dependencies for undeclared dependencies.
This also fixes some random TODOs.
R=scottmg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/246303005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This does the net target. I started doing some more that are commented out at the bottom, and there are a few more after that do do. The deps of these targets started to build up to an unreasonable level and this should be a good checkpoint.
Fix grit rule.
Fix SSL dependent configs
Add TLD cleanup
Add gconf and gio targets for Linux.
Add sources filtering for ChromeOS, .rc, and .mm files. Remove built-in code that removes .rc and .mm files (this wasn't quite complete so causes problems).
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/236713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This moves files from the secondary tree to the main one, and renames the "meta" one to //crypto:ssl. It also adds the crypto unit tests.
R=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/231673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=agl@chromium.org,davidben@chromium.org,rsleevi@chromium.org
BUG=361311
Review URL: https://codereview.chromium.org/233633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The status quo was unmaintainable. These 'component build specific .isolate
files' are superseeded by tools/isolate_driver.py which packages dynamic
libraries automatically.
The new way is much more sane and dynamic, isolate_driver.py is currently very
crude but 'does the job', the expected way to make it work is to read the .ninja
files to extract all the dynamic libraries marked as a dependency to the main
target being executed.
TBR=csharp@chromium.org
BUG=333473
Review URL: https://codereview.chromium.org/226123004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were computing the signature length incorrectly. In addition, Apple's
implementation returns the signatures in DER-encoded form, so there is no need
to re-encode them. (Instead, convert DSA signatures back into raw form in SSL3
to match NSS behavior on other platforms.)
BUG=349775
TEST=see bug
Review URL: https://codereview.chromium.org/190753005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Hack for Mac 10.9 hang when the Keychain is modified with Chrome running.
>
> BUG=326011
R=rsesek@chromium.org,rsleevi@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/177093021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to flush out any problems with padding, Chrome has always been
adding it, even when the ClientHello was small enough not to need it.
Since that change is in Chrome 33 (and the Chrome 34 branch), it's time
to remove it.
BUG=315828
Review URL: https://codereview.chromium.org/171713011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, this adds support to run net_unittests isolated via 'isolate.py
run' when built with component build.
R=vadimsh@chromium.org,brettw@chromium.org,rsleevi@chromium.org
BUG=336439
Review URL: https://codereview.chromium.org/134003004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, this adds support to run base_unittests isolated
via 'isolate.py run' when built with component build.
This requires rolling icu @ 246118 to get the new icu.isolate.
R=thakis@chromium.org,jshin@chromium.org,frankf@chromium.org,rsleevi@chromium.org
BUG=336439
Review URL: https://codereview.chromium.org/132233030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
alpn.patch and paddingextension.patch have been committed in the NSS
upstream.
In addition to calling SSL_SetNextProtoNego, the SSL_ENABLE_NPN and
SSL_ENABLE_ALPN options need to be used to control whether each of
NPN and APLN will be negotiated. SSL_ENABLE_NPN is enabled by default,
but we enable it explicitly to be safe.
R=agl@chromium.org
BUG=331625
TEST=none
Review URL: https://codereview.chromium.org/142283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the lock rank checking code in PRRWLock.
Remove the suppression for the memory leak in _PR_SET_THREAD_RWLOCK_RANK.
R=agl@chromium.org,thestig@chromium.org
BUG=124445,331625
TEST=none
Review URL: https://codereview.chromium.org/129413003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes:
1. Reorder the cipher suites offered in ClientHello.
https://bugzilla.mozilla.org/show_bug.cgi?id=936828
https://bugzilla.mozilla.org/show_bug.cgi?id=946147
2. Store a random value in the gmt_unix_time field of ClientHello and
ServerHello.
https://bugzilla.mozilla.org/show_bug.cgi?id=937976
3. Handle >= 2048-bit DSA certificates.
https://bugzilla.mozilla.org/show_bug.cgi?id=925591
4. Session ticket renewal bug fixes.
https://bugzilla.mozilla.org/show_bug.cgi?id=930857
https://bugzilla.mozilla.org/show_bug.cgi?id=930874
The following patches are removed.
1. Patches that are no longer necessary because we require NSS 3.14.3:
versionskew.patch
ecpointform.patch
cbc.patch
2. Patches that have been committed in NSS upstream:
renegoscsv.patch
peercertchain.patch
peercertchain2.patch
negotiatedextension.patch
sslsock_903565.patch
aesgcm.patch
tls12backuphash.patch
tls12backuphash2.patch
ciphersuiteversion.patch
resumeclienthelloversion.patch
canfalsestart.patch
nullcipher_934016.patch
3. Miscellaneous:
channelid2.patch: merged with channelid.patch.
disableticketrenewal.patch: bug fixed in the NSS upstream.
R=agl@chromium.org,rsleevi@chromium.org
BUG=331625
TEST=none
Review URL: https://codereview.chromium.org/111853013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=326011
R=rsleevi@chromium.org
TEST=On 10.9, open Chrome and Keychain Access. Install a certificate in Keychain. Chrome does not hang.
Review URL: https://codereview.chromium.org/106423010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=305220
R=wtc
Review URL: https://codereview.chromium.org/112183006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Defer TLS session caching until after certificate verification
>
> BUG=305220
> R=wtc@chromium.org, wtc
>
> Review URL: https://codereview.chromium.org/93773007
TBR=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/120043007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=305220
R=wtc@chromium.org, wtc
Review URL: https://codereview.chromium.org/93773007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=agl@chromium.org
BUG=327881
TEST=none
Review URL: https://codereview.chromium.org/109523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240615 0039d316-1c4b-4281-b951-d872f2087c98
|