| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.
No functionality change: virtual is only added
to destructors that are already implicitly virtual.
Also fix a couple of in-line destructor definitions.
BUG=83408
TEST=none
Review URL: http://codereview.chromium.org/7064033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=82098
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/7016011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as advertised. If the ssl cert and key fields are left empty to disable ssl,
flip_in_mem_edsm_server will segfault.
For these switches, the split function is expected to return a std::vector of size 4, but leaving the ssl cert and key fields empty results in a std::vector of size 2.
BUG=NONE
TEST=none
Review URL: http://codereview.chromium.org/6949002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a compile error on the new 32-bit Lucid buildbots:
In file included from net/tools/flip_server/balsa_headers.cc:7:
/usr/lib/gcc/i486-linux-gnu/4.4.3/include/emmintrin.h:32:3: error: #error "SSE2 instruction set not enabled"
In file included from net/tools/flip_server/balsa_frame.cc:8:
/usr/lib/gcc/i486-linux-gnu/4.4.3/include/emmintrin.h:32:3: error: #error "SSE2 instruction set not enabled"
BUG=
TEST=Lucid builbot compiles
Review URL: http://codereview.chromium.org/6677116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fix from Kevin Lindsay (kelindsay@gmail.com)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6623085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Set-Cookie delimiter was a comma, but should have been a NUL.
- Requests with query strings containing 'http://' caused request url paths
to be truncated.
Fix from Kevin Lindsay (kelindsay@gmail.com)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6628084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
render because we didn't close out the SPDY stream.
Fix from Kevin Lindsay (kelindsay@gmail.com)
http://codereview.chromium.org/6597074/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6628083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6609008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This turns on style checking for reals on the bots.
Review URL: http://codereview.chromium.org/6531017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6602060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles; existing unit tests.
Review URL: http://codereview.chromium.org/6602049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Misc fixes:
* The forward-for header was not being added to non-spdy https traffic.
* Fix a memory leak
Review URL: http://codereview.chromium.org/6541078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6542024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net/tools/flip_server/balsa_frame.cc:1285:23: error: equality comparison with extraneous parentheses [-Wparentheses]
if ((parse_state_ == BalsaFrameEnums::READING_HEADER_AND_FIRSTLINE)) {
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/tools/flip_server/balsa_frame.cc:1285:23: note: use '=' to turn this equality comparison into an assignment
if ((parse_state_ == BalsaFrameEnums::READING_HEADER_AND_FIRSTLINE)) {
^~
=
net/tools/flip_server/balsa_frame.cc:1285:23: note: remove extraneous parentheses around the comparison to silence this warning
if ((parse_state_ == BalsaFrameEnums::READING_HEADER_AND_FIRSTLINE)) {
~ ^ ~
1 error generated.
BUG=none
TEST=none
TBR=mbelshe
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(I've separated this chunk out since mbelshe said he was working here and I
don't want to accidentally clobber his work. This is the last patch before Nico
can turn the inlining plugin on for all targets.)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6368037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
broken by r73491.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6250117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For the most part, this is a straight refactor. I'm sure I broke something.
BUG=monolithic code
TEST=none
Review URL: http://codereview.chromium.org/6392011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it was closing the socket while in the middle of IO callbacks which could
crash.
Instead, set a flag which will cleanup and dropout after we've finished
processing IO.
BUG=none
TEST=n/a
Review URL: http://codereview.chromium.org/6269025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6298021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Optimizations to fill packets better for the edsm server.
Problems:
- the SETTINGS frame was the first packet we'd send, uncorked (~45B).
This was wasting the first packet of our cwnd.
- uncork was overaggressive. We now only uncork when there are
no more packets in our queue.
- rework the packet sizing to fully fill packets better.
BUG=none
TEST=n/a
Review URL: http://codereview.chromium.org/6245015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reject. Strip headers with 0 length header names or 0 length header values.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6286012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problems:
- the SETTINGS frame was the first packet we'd send, uncorked.
This was wasting the first packet of our cwnd.
- uncork was overaggressive. We now only uncork when there are
no more packets in our queue.
- rework the packet sizing to fully fill packets better.
Question - should I remove the MSG_MORE code now? It seems to be an
alternative way to do corking, but it just doesn't work with the SSL layer.
BUG=none
TEST=n/a
Review URL: http://codereview.chromium.org/6327022
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/6359016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problems:
- the SETTINGS frame was the first packet we'd send, uncorked.
This was wasting the first packet of our cwnd.
- uncork was overaggressive. We now only uncork when there are
no more packets in our queue.
- rework the packet sizing to fully fill packets better.
Question - should I remove the MSG_MORE code now? It seems to be an
alternative way to do corking, but it just doesn't work with the SSL layer.
BUG=none
TEST=n/a
Review URL: http://codereview.chromium.org/6327022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Refactor the first-read logic for the in-mem server.
Split out functions from the initial connection setup on first read.
* Fixed the SPDY-only (non-NPN negotiated) case.
* Hardened the server against invalid protocol attacks; would happily
crash when an invalid-looking frame arrived.
BUG=none
TEST=self
Review URL: http://codereview.chromium.org/6262014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the base namespace. Fix several files including lock.h unnecessarily.
BUG=none
TEST=none
Original review=http://codereview.chromium.org/6142009/
Patch by leviw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=<this is the test>
Review URL: http://codereview.chromium.org/6338013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pidfile.
SPDY frames were leaking when used with DataFrame and OutputList.
HUP signal will now reopen the log file.
Remote IP obtained for 'forward-ip-header' was incorrect.
Added connection idle timeout.
Fixed up pidfile handling.
Flip server now creates and locks a pid file.
Patch from Kevin Lindsay: kelindsay@gmail.com
BUG=none
TEST=self
Review URL: http://codereview.chromium.org/6332010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
negotiate it. This is used for debugging.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6291004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Records, which should fit into MSS.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5966003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920
Review URL: http://codereview.chromium.org/6070006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782
Review URL: http://codereview.chromium.org/6070006
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6099012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782
Review URL: http://codereview.chromium.org/6070006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Review URL: http://codereview.chromium.org/6070006
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6100007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Review URL: http://codereview.chromium.org/6070006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
namespace. This does not move the "hard" thread stuff (thread.h).
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6079009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which can span multiple packets. Since the entire SSL record must be
received before any of it can be handed up to the app, this delays
the time at which the client can start processing the data.
BUG=none
TEST=self
Review URL: http://codereview.chromium.org/5941002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Explicitly cast the returned value into the void. Clang complains
about this unused return value otherwise.
BUG=none
TEST=flip_in_mem_edsm_server
Review URL: http://codereview.chromium.org/5727003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The friend function declaration ParseHTTPFirstLine must not be
qualified, since it is introducing a new name, rather than
referring to an already declared function.
BUG=none
TEST=flip_in_mem_edsm_server still builds
Review URL: http://codereview.chromium.org/5675007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
idx_ is of type HeaderLines::size_type, which is
std::vector<>::size_type, which is always unsigned.
So idx_ >= 0 is always going to be true, and Clang warns about
such tests.
BUG=none
TEST=flip_in_mem_edsm_server
Review URL: http://codereview.chromium.org/5712006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
General fixes to spdy test server:
* Add ability to disable compression on the SSL server.
* Modified the SSL cipher list.
* Updated the --help command line argument.
* Ignore SIGPIPE signals.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5290008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added proxy and NPN support as well as basic command line configuration for the flip server.
Turn on building of flip server for linux by default.
BUG=none
TEST=test tool
Review URL: http://codereview.chromium.org/5255008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the callers to append base:: in the calls to StringAppendF.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4974001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=It builds.
Review URL: http://codereview.chromium.org/4094002
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/4541002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=It builds.
Review URL: http://codereview.chromium.org/4094002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch on behalf of Jon Leighton (leighton@cis.udel.edu)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3550005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Landing on behalf of fenix@google.com (Roberto Peon)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3583004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
src/{app,base,net}.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3136025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had to implement UrlUtilities::Unescape and ported over the tests as well.
Deleted redundant copy of url_to_filename_encoder.h and pointed the one link to that at the new location: net/tools/dump_cache/url_to_filename_encoder.h
This patch is on behalf of sligocki@google.com
BUG=none
TEST=url_to_filename_encoder_unittest.
Review URL: http://codereview.chromium.org/3117019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/3013049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54482 0039d316-1c4b-4281-b951-d872f2087c98
|