| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
has more control about the backend instantiation.
BUG=none
TEST=current unit tests.
Review URL: http://codereview.chromium.org/2000011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(DNS request tracing is the only feature lost in this transition; it needs to be added back under the new framework).
BUG=37421
Review URL: http://codereview.chromium.org/2008007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This patch is a bit ugly. I think it might make sense to split out the SYN_STREAM parsing from the SYN_REPLY parsing at this point.
Review URL: http://codereview.chromium.org/1769012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It was reverted as http://codereview.chromium.org/1822001 the fix in Valgrind scripts has been commited as http://codereview.chromium.org/1736026
TEST=trybots
Review URL: http://codereview.chromium.org/1763023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This broke the memory waterfall, failed to import protobuf.
TBR=nick
Review URL: http://codereview.chromium.org/1822001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.
Make the sync_integration_tests run by default against the test server. An externally-provided --sync-url will give the old behavior.
Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf).
Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.
Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work.
Flakiness fix: Port sync_integration_tests to the out-of-process test runner.
Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.
BUG=20905,40980
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45916
Review URL: http://codereview.chromium.org/1622012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.
Make the sync_integration_tests run by default against the test server. An externallyprovided syncurl will give the old behavior.
Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf). This might be a bad place, or a bad name open to suggestions. The main thing is that there will be runtime dependencies on it, so it didn't seem right to put it in obj/.
Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.
Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work.
Flakiness fix: Port sync_integration_tests to the outofprocess test runner.
Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.
BUG=20905,40980
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708
Review URL: http://codereview.chromium.org/1622012
TBR=nick@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.
Make the sync_integration_tests run by default against the test server. An externally-provided --sync-url will give the old behavior.
Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf). This might be a bad place, or a bad name -- open to suggestions. The main thing is that there will be run-time dependencies on it, so it didn't seem right to put it in obj/.
Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.
Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work.
Flakiness fix: Port sync_integration_tests to the out-of-process test runner.
Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.
BUG=20905,40980
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708
Review URL: http://codereview.chromium.org/1622012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
passing NULL in place of a const BoundNetLog&.
BUG=37421
Review URL: http://codereview.chromium.org/1783008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
epan\libwireshark.def:
o tvb_child_uncompress
o p_remove_proto_data
In the past I've modified libwireshark.def locally but this is a bit of a pain to do for each version. So, I just duplicated code for now and added a "spdy" prefix.
Review URL: http://codereview.chromium.org/1771005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
cracker won't parse our URLs that start with "GEThttp:"
properly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1572036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1695003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.
Make the sync_integration_tests run by default against the test server. An externallyprovided syncurl will give the old behavior.
Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf). This might be a bad place, or a bad name open to suggestions. The main thing is that there will be runtime dependencies on it, so it didn't seem right to put it in obj/.
Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.
Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work.
Flakiness fix: Port sync_integration_tests to the outofprocess test runner.
Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.
BUG=20905,40980
Review URL: http://codereview.chromium.org/1622012
TBR=nick@chromium.org
Review URL: http://codereview.chromium.org/1633015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.
Make the sync_integration_tests run by default against the test server. An externally-provided --sync-url will give the old behavior.
Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf). This might be a bad place, or a bad name -- open to suggestions. The main thing is that there will be run-time dependencies on it, so it didn't seem right to put it in obj/.
Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.
Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work.
Flakiness fix: Port sync_integration_tests to the out-of-process test runner.
Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.
BUG=20905,40980
Review URL: http://codereview.chromium.org/1622012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1623014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(FT_STRING, FT_BYTES) etc.
Review URL: http://codereview.chromium.org/803001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestTwoAuths and TestDigestAuth to fail when they take more than 10
seconds to send auth (which happens sometimes under valgrind).
Now the unittest can control whether it wants to receive a stale
nonce reply by requesting /auth-digest/stale. I plan to add a test
for the stale flow in a subsequent patch.
Also, this patch cleans up NavigateToURL calls in LoginPromptTest
so that they are all in-place ASSERTs. This makes the messages more
useful.
BUG=36163,25794,38580
TEST=sh tools/valgrind/chrome_tests.sh -t ui --gtest_filter=LoginPromptTest.*
Review URL: http://codereview.chromium.org/1508001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1128007/show
Integrated changes for the spdy-in-memory-server from the google server side.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1526005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type.
* Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF.
TBR=evanm
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
request does not generate a separate row in the history
database.
BUG=34350
Review URL: http://codereview.chromium.org/668051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/650167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The driving rationale for this change was to prevent choosing an AuthHandler when it
is not supported on the system due to a missing runtime component (such as not being
able to locate a gssapi shared library when seeing a Negotiate scheme).
It also has the advantage (currently unused) of determining some per-auth-scheme properties
only the first time that a challenge for that scheme is seen (such as maximum token length for
the SSPI implementation of NTLM).
Finally, it may make unit tests easier to generate since the factory can be easily mocked.
BUG=34795
TEST=New unit test for HttpAuthHandlerDispatchFactory.
Review URL: http://codereview.chromium.org/582007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mozilla.
This corresponds to their patch ec019978e8dc, from 2010-02-11 13:39 +0000.
Also update instructions for updating this file.
BUG=27523
TEST=none
Review URL: http://codereview.chromium.org/600077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/578026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires the following refactors:
(1) NetworkChangeNotifier moves out of HttpNetworkSession into IOThread.
(2) HostResolver gets initialized with NetworkChangeNotifier.
(3) NetworkChangeNotifier needs to get passed into HttpCache and HttpNetworkSession (required updating a lot of files).
(4) NetworkChangeNotifier is no longer reference counted. It is owned by IOThread.
(5) IOThread gains a new struct: Globals. It can only be used on the io thread.
(6) ChromeURLRequestContextFactory uses IOThread::Globals to initialize ChromeURLRequest objects with the host resolver and network change notifier.
BUG=26159
Review URL: http://codereview.chromium.org/552117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently this limit is very high (50), but it can be tuned through a variable.
BUG=9598
TEST=
HostResolverImplTest.HigherPriorityRequestsStartedFirst
HostResolverImplTest.CancelPendingRequest
HostResolverImplTest.QueueOverflow
Review URL: http://codereview.chromium.org/542086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
diagnose way when a .mock-http-headers file is not perfectly formatted.
Add a --never-die option that makes it more convenient to manually run some tests by preventing the server from dying when a /kill url is visited.
Review URL: http://codereview.chromium.org/549110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/550030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/543079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the chrome tree.
Checkin for Roberto Peon (fenix@google.com)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/543029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/26159
Review URL: http://codereview.chromium.org/545003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation. This verb is supported
in the Chrome network stack.
Added a urlrequest test for the HTTP PUT verb and corresponding support in the HTTP test server.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=31629
Bug=31629
Test=Covered by net tests.
Review URL: http://codereview.chromium.org/538012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/515008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
On my very fast machine, building the std::set in release mode on startup and blocks the UI thread for 15ms (there are > 3300 entries). It also uses 275KB of memory, not including 50KB of data in the dll. Using a perfect hash map, there's no startup cost. The dll's size increases by 135KB but there's no extra memory consumption, leading to a memory reduction of 140KB.
Review URL: http://codereview.chromium.org/515001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implicit non-virtual public destructors.
Was originally:
Replace public nonvirtual destructors in classes with virtual members
with protected nonvirtual destructors where possible, and with
public virtual destructors where destruction of a derived class occurs.
(Excluding chrome/browser/...)
(Part 4 of http://www.gotw.ca/publications/mill18.htm
has a rationale for why public nonvirtual destructors in classes with
virtual members is dangerous.)
Patch by: Jacob Mandelson (jlmjln@gmail.com)
BUG=none
TEST=base_unittests & app_unittests
Review URL: http://codereview.chromium.org/200106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing: http://codereview.chromium.org/479012/show
Fix by Roberto Peon.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/491088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
includes needed for struct addrinfo / struct sockaddr, since we were duplicating that #if #else logic in a growing number of places.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/491038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a very small time to live, since we want to be able to respond quickly when formerly unresolvable names become resolvable.
Even such a small time is still useful, since cache misses for unresolvable names can be extremely costly (order of several seconds).
For example, in our corp PAC script, the URL's host is resolved 3 times, so:
Without caching, total runtime is (2.5 seconds) * 3 --> 7.5 seconds.
Whereas with caching it would be: (2.5 seconds) * 1 --> 2.5 seconds
This time to live will need to be tuned as part of bug 25472.
BUG=11079
Review URL: http://codereview.chromium.org/464084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/428004
Command line utility to run the HostResolver.
The user provides a list of hosts to resolve, as well as optional timestamps
for when the resolutions should happen. These can be provided on the command
line as additional arguments or in a specified file.
Options:
--async: Specifies that the resolution should happen asynchronously.
--verbose: Spew out extra data.
--cachesize: Size of the DNS cache.
--cachettl: TTL of DNS cache entries in milliseconds.
--inputpath: File containing host name and optional timestamp, one per line.
BUG=NONE
TEST=Built and ran on Linux and Windows. Built on OSX via trybots but not run.
R=eroman
Review URL: http://codereview.chromium.org/485006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=vitaliyl@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/467030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/463009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=None
Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/296004
Review URL: http://codereview.chromium.org/373013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/368001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
path (like "C:\foo\bar"). The current code was attempting to
append "c:\foo\bar" to "\\?\" for long filename support. Reworked
so that this could work. I feel back about using the ToWStringHack()
function, but there is literally no other choice.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/337033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It would work with:
dump_cache.exe foo bar baz
But it would fail with:
dump_cache foo bar baz
The latter caused an odd crash which was all too difficult to
find!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/330024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a ctor for creating a CommandLine for carrying arguments;
convert all the users to either that or the FilePath version.
BUG=24672
Review URL: http://codereview.chromium.org/329017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
|