| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
net::HttpResponseInfo struct in it entirety.
BUG=none
TEST=URLRequestTestHTTP.ResponseHeadersTest
Review URL: http://codereview.chromium.org/251082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Use the HTML5 doctype + 0.8em fonts + WebKit monospace workaround.
Review URL: http://codereview.chromium.org/257050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- BaseTestServer already has virtual functions and clients that derive from it
- Its tripping a magic checker that I am building
BUG=none
TEST=existing unit tests suffice
TBR=tony
Review URL: http://codereview.chromium.org/251045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't fix anything, it just prevents asserting (and consequently crashing) when the leak is observed, restoring the earlier behavior.
There are already a couple of know leaks, so crashing during shutdown isn't real useful until the known issues are fixed.
BUG=18372,23284
TBR=darin
Review URL: http://codereview.chromium.org/255017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This output is testing the prospect that the cause of the flakiness is a race to the IO thread between the renderer that is requesting a chrome-extension page and the message to insert the correct mapping to service the request.
BUG=22668
Review URL: http://codereview.chromium.org/251025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23108
TEST=none
TBR=senorblanco
Review URL: http://codereview.chromium.org/243009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ones were set in URLRequest
BUG=20894
TEST=enabled layout test LayoutTests/http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html
Review URL: http://codereview.chromium.org/218015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The goal is to end up with more meaningful errors if a page fails to load.
BUG=22623
Review URL: http://codereview.chromium.org/222009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/210027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=net_unittests
BUG=21184
Review URL: http://codereview.chromium.org/201083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
StrictTransportSecurityPersister needs to unregister itself as the delegate before it gets deleted.
BUG=21897
TEST=see bug
Review URL: http://codereview.chromium.org/217012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use better name for FTP LIST parsing code in about:credits
- don't open a second data socket
- add a comment explaining why we close the data socket at one point
TEST=Covered by net_unittests.
BUG=none
Review URL: http://codereview.chromium.org/207014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like this CL caused failure in Modules Linux (valgrind)
http://chrome-buildbot.corp.google.com:8010/builders/Modules%20Linux%20(valgrind)/builds/1104/steps/valgrind%20test:%20base/logs/stdio
http://chrome-buildbot.corp.google.com:8010/builders/Modules%20Linux%20(valgrind)/builds/1103/steps/valgrind%20test:%20base/logs/stdio
[----------] 6 tests from ClipboardTest
[ RUN ] ClipboardTest.ClearTest
command timed out: 1200 seconds without output, killing pid 7479
process killed by signal 9
program finished with exit code -1
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/212007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=net_unittests
BUG=21184
Review URL: http://codereview.chromium.org/201083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"net-internal:*" ==> "chrome://net-internals/*"
"view-cache:*" ==> "chrome://net-internals/view-cache/*"
"view-cache:stats" ==> "chrome://net-internals/httpcache.stats"
As before, there are also aliases from the "about:*" page:
"about:net-internal[/*]" aliases "chrome://net-internals/*"
"about:cache[/*]" aliases "chrome://net-internals/view-cache"
BUG=http://crbug.com/21551
Review URL: http://codereview.chromium.org/202067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with the StringPiece class in icu4.2, which is a problem
when trying to use the system version of icu.
Review URL: http://codereview.chromium.org/193072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
GURL that was passed to URLRequest(const GURL&) is invalid.
BUG=http://crbug.com/21423
Review URL: http://codereview.chromium.org/192057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
With this change, Strict Transport Security is active by default and
doesn't need the --force-https flag any more.
http://codereview.chromium.org/193067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
required changes.
This way future merging would be much easier.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/201034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Original Review URL: http://codereview.chromium.org/174189
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/193047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
BUG=none
Review URL: http://codereview.chromium.org/197052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/194057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=See bug.
http://crbug.com/21006
Review URL: http://codereview.chromium.org/197044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/196050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The histograms will be more accurate after this change.
TEST=none
BUG=20335
Review URL: http://codereview.chromium.org/192038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, remove StrictTransportSecurity code from SSLPolicy because that code
doesn't work.
R=agl
Review URL: http://codereview.chromium.org/198035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
better handle on its lifetime as there are cases where this object is handed out to URLRequestContext instances which outlive the URLRequestContext object which created it.
Partial fix for http://code.google.com/p/chromium/issues/detail?id=15289
Bug=15289
Review URL: http://codereview.chromium.org/197023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource after the original request was interrupted.
BUG=8995
TEST=unittests
Review URL: http://codereview.chromium.org/197016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was the test was expecting |response_time| of cached responses to be the timestamp of the original request, rather than the timestamp of the last cache validation.
Also updated the header to clarify what |request_time| and |response_time| correspond to in the cached cases.
BUG=http://crbug.com/20594
Review URL: http://codereview.chromium.org/197030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we just generated a cryptic error when the user attempted
to navigate to a ForceTLS site with HTTP. With this patch, we generate
an internal redirect to the HTTPS version of the site.
(This collided with Dave's r25496, which also added
url_request_redirect_job.cc. Thankfully our code was almost identical.)
http://codereview.chromium.org/193014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as pdf) and redirect the user to the appropriate URL for viewing.
Original patch by skrulx@gmail.com
http://codereview.chromium.org/174016
Review URL: http://codereview.chromium.org/199019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and broke with r25484.
Will follow up with a fix once I investigate this (probably the test just needs to be adjusted not to depend on that).
TBR=rvargas
Review URL: http://codereview.chromium.org/199029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is probably the most important metric, since it measures the initial latency of the request (until when we get the headers back).
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/194018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* linkify the subsection's URL rather than just displaying the URL
* also changed the URL scheme of the text from about:net-internal to view-net-internal
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/196013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
net-internals page.
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/184008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/172100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
destroyed.
This functionality will be used by the "about:net-internal" page to display profiling information for the in-progress requests, as well as the recently completed requests.
This does not have any performance impact. Note that all of the tracking operations are constant time.
In particular:
* Global tracking of all URLRequest instances is done by chaining them as
linked list nodes. So we get constant-time insertion/deletion without
needing to do any extra heap allocs.
* The recent requests list is a circular queue, backed by an array. So
insertions are constant time (and we never erase entries, just overwrite).
Moreover, the entry types themselves are comprised of {GURL, LoadLog*},
so very little copying actually happens -- LoadLog is refcounted so
copy is cheap, and GURL is backed by a std::string which is also refcounted
so the copy is cheap.
R=darin
BUG=http://crbug.com/14478
TEST=unittests.
Review URL: http://codereview.chromium.org/173175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This page contains low-level debug information that is of interest to power users, and bug investigators.
The output can be filtered by using special sub-URLs.
The sub-URLs themselves are listed when visiting about:net-internal, but to give an idea:
about:net-internal -- everything
about:net-internal/proxyservice -- all things proxy
about:net-internal/proxyservice.config -- current settings
about:net-internal/hostresolver.hostcache -- dns cache
BUG=http://crbug.com/14478
R=darin
Review URL: http://codereview.chromium.org/173024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should make licensing terms and third-party origin of the code more clear.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/179041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I managed to save 30s with this change!
I had to change the interface of the test server a bit. Now the credentials
to be used are passed (optionally) for TestPage request, not in the ctor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/182031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
process ID with an internally-generated id() function. This allows us the
guarantee that the IDs are unique over the entire run of the application.
This also cleans up some code associated with managing the PID.
The main potentially interesting change is now the PID is set uniquely for
every creation of RenderProcessHost. It used to be set cleared if the process
went away, and re-set if the process was re-created. The ID generation is in
ChildProcesInfo so it is also unique between workers and plugins. I had to
change some significant things in resource_dispatcher_host_unittest to take
into account this new generation of IDs.
BUG=17828
TEST=none
Review URL: http://codereview.chromium.org/160203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
request.TEST=Run automation unit tests.BUG=none
Review URL: http://codereview.chromium.org/183004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a comma-separated list of ports.
BUG= http://crbug.com/18307
TEST= url_request_unittest, use commandline flag allowed_ports=1,600. Navigate to http://www.google.com:1 or http://www.google.com:600. You should not get an ERR_UNSAFE_PORT, it will attempt to load the page.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should help with decision which FTP server types we can safely stop supporting.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/176020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r24792.
TBR=estade
Review URL: http://codereview.chromium.org/179028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InterceptRestartRequired fail.
The unit tests still fail, but don't crash which allows the other tests to run.
TEST=Run UrlRequest unit tests.
BUG=none
Review URL: http://codereview.chromium.org/173572
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
http://crbug.com/20112
Review URL: http://codereview.chromium.org/173270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added unit tests for the above functionality plus the do not save cookies functionality.
BUG=http://crbug.com/10961
TEST=Added unit tests for this. Also, this isn't yet called from the rest of the code.
Review URL: http://codereview.chromium.org/173206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=run base_unittests.exe
Review URL: http://codereview.chromium.org/173181
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24208 0039d316-1c4b-4281-b951-d872f2087c98
|