| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Based on a patch by Chris Evans.)
Doesn't yet actually get the information from the HSTS header, but all the
infrastructure is in place.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6835033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This switches over device policy handling in the test server to the
new-style ChromeDeviceSettignsProto protobuf.
BUG=none
TEST=compiles and passes tests
Review URL: http://codereview.chromium.org/6837024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The change introduced a regression in the WebRequestEvents api test.
TBR=mpcomplete
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6839024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
fromdisk to detect obvious corruption going undetected.BUG=77841TEST=net_unittestsReview URL: http://codereview.chromium.org/6821064
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/6837035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60101
TEST=no
Review URL: http://codereview.chromium.org/6677148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
disk to detect obvious corruption going undetected.
BUG=77841
TEST=net_unittests
Review URL: http://codereview.chromium.org/6821064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed a couple of erroneous unit tests of offsets into username/password.
Note: This does not complete the work required for 78153 -- tis but the first 2/3rds.
Previously reviewed as: http://codereview.chromium.org/6822038/.
BUG=78153
TEST=Many unit tests updated and added.
Review URL: http://codereview.chromium.org/6839007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
strong validators.
BUG=77085
TEST=net_unittests
Review URL: http://codereview.chromium.org/6824048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems to be caused by CertVerifier's verification result cache.
- Added a new OnCertTrustChanged to CertDatabase::Observer;
- For NSS cert database, SetCertTrust triggers OnCertTrustChanged;
- Clear CertVerifier's result cache when OnCertDatabaseChanged is fired;
BUG=chromium-os:7988
TEST=Verify #2 issue in chromium-os:7988 where cert trust change only takes
effect after chrome restart.
Review URL: http://codereview.chromium.org/6816035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on WebKit patch to add new TargetType.
https://bugs.webkit.org/show_bug.cgi?id=57659
BUG=11961
TEST=browser_tests --gtest_filter=LoginPromptBrowserTest.NoLoginPromptForFavicon
Review URL: http://codereview.chromium.org/6728038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6837012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests ExtractSPKIFromDERCert & PublicKeyHashes are failing (you can see them here: http://goo.gl/Rc3OA )
Follow up to http://src.chromium.org/viewvc/chrome?view=rev&revision=81259
- implements GetDEREncoded for opensll
- adds public_key_hashes support in openssl X509Certificate::Verify
- small change to unit test to make it much easier to diagnose failures.
BUG=None
TEST=net_unittests --gtest_filter=X509Certificate*
Review URL: http://codereview.chromium.org/6826065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
functions. Fixed a couple of erroneous unit tests of offsets into username/password.Note: This does not complete the work required for 78153 -- tis but the first 2/3rds.BUG=78153TEST=Many unit tests updated and added.Review URL: http://codereview.chromium.org/6822038
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/6833011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed a couple of erroneous unit tests of offsets into username/password.
Note: This does not complete the work required for 78153 -- tis but the first 2/3rds.
BUG=78153
TEST=Many unit tests updated and added.
Review URL: http://codereview.chromium.org/6822038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
data_ char array is deleted. Hoping to prevents
reads/writes after free to allocated memory.
BUG=79234
TEST=net uint tests
R=jar
Review URL: http://codereview.chromium.org/6826066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=net_unittests --gtest_filter=NetUtilTest.StripWWW.
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/6824088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up all the callers to use the new location and namespace.
Also, delete the stub file since it isn't included by anyone more.
(Note: This was a TODO for brettw).
BUG=None
TEST=None
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/6825055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts r61181 although, due to the age of that revision, the revert was
mostly done manually. This is the start of ripping out Snap Start support.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(First attempt in r81260.)
In file included from ./net/base/cert_verifier.h:16:
./net/base/cert_verify_result.h:17:1: error: [chromium-style] Complex class/struct needs a declared destructor.
class CertVerifyResult {
^
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In file included from ./net/base/cert_verifier.h:16:
./net/base/cert_verify_result.h:19:3: error: [chromium-style] Complex constructor has an inlined body.
CertVerifyResult() { Reset(); }
^
./net/base/cert_verify_result.h:17:1: error: [chromium-style] Complex class/struct needs a declared destructor.
class CertVerifyResult {
^
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended for use with future support for HSTS or CAA pinning of
certificate chains. Since we build certificate chains from a pool of
certificates, and certificates get reissued with updated expiries etc, only the
public keys in the chain will always match. Thus we match on SHA1 hashes of
SubjectPublicKeyInfos.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/6821010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
all connections (which is done in the benchmark code, and also when changing
networks)
BUG=78811
TEST=SpdySessionPoolTest.IPPoolingCleanedOnClose
Review URL: http://codereview.chromium.org/6820052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
transport_client_socket_test. This allows us to create new tests which test
against all transports. For now, that is just TCP. Soon we'll add SCTP.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6822022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tlslite does some autodetection which when m2crypto is installed and importable is more strict when parsing certificate files. This CL makes our certificate files acceptable by both the more strict and more lenient versions of code used by tlslite.
Swap the certificate and private key in [ok|expired]_cert.pem, so that
s.startswith() will return true for OpenSSL_RSAKey. tlslite.X509 uses
s.find() to locate the BEGIN CERTIFICATE, so it should be unaffected.
For more info see http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/903f65ad685da9b2#
Review URL: http://codereview.chromium.org/6814045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove that test and replace it with cwnd10, which fixes the cwnd at 10.
BUG=none
TEST=this is the test
Review URL: http://codereview.chromium.org/6792026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the old certificate-handling code and make the test server read a
private key file instead. Public key is sent to the client in PKCS#1/DER
format as required by the protocol.
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/6823004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a ConfigAvailability enum such that ProxyConfigService is able to return configuration status at a finer granularity level. This allows to fall back to default values (potentially configured through policy) if the system service doesn't have configuration.
BUG=none
TEST=unit tests, recommended proxy policy works on CrOS.
Review URL: http://codereview.chromium.org/6597070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix detection of KOI8-R and possibly other encodings
- fix parsing Russian month names
When detecting the listing encoding, we need to not only
check whether the data can be converted using given encoding,
but also whether the result can be parsed as a valid directory listing.
Also, we only need to compare the first three characters of the
abbreviated month name, because that's how they're abbreviated
in FTP directory listings.
Finally, the Russian directory listings have swapped the "month" and "day of month" columns.
BUG=65917
Review URL: http://codereview.chromium.org/6718043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are important because although they don't have any content, they often form
the start of a user navigation into Gmail. If https is used, then the chain of
redirects to login is secured (https://gmail.com -> https://mail.google.com ->
https://www.google.com/accounts). Without https, an sslstrip attack can be
fully mounted all the way to the login page (Tunisia?)
It's a tricky add because https on these domains is SNI-only and the
availability of SNI varies depending on preferences, but I added the
plumbing to take care of this easily for future additions.
TEST=TransportSecurityStateTest.Preloaded
Review URL: http://codereview.chromium.org/6812031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not char16; this triggers an assertion on Windows,
see http://codereview.chromium.org/6802006/
and http://msdn.microsoft.com/en-us/library/y13z34da(v=vs.71).aspx)
This change replaces isspace with ICU's u_isspace.
The original problem was introduced by http://codereview.chromium.org/449011/
The problem was detected while landing http://codereview.chromium.org/6718043,
which adds more tests with non-ASCII characters.
BUG=none
Review URL: http://codereview.chromium.org/6802012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=78303
TEST=net_unittests
Review URL: http://codereview.chromium.org/6814017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(disabled in r80801)
I can't find anything wrong with it with Valgrind so I want to see
if the TSAN blowup was a fluke.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=n/a
BUG=none
Review URL: http://codereview.chromium.org/6813042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=80778
BUG=None
TEST=./out/Debug/net_unittests --gtest_filter=X509CertificateTest.DISABLED_TestKnownRoot --vmodule=*openssl*=3 --gtest_also_run_disabled_tests
Review URL: http://codereview.chromium.org/6816020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6814027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6815020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=78679
TEST=see bug
Review URL: http://codereview.chromium.org/6814009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame IE6 builder. These tests
randomly fail as IE6 caches the response as per the directive passed back by the python webserver.
Proposed fix is to send back the no-cache header for all echoheader requests. The URLRequestTestHTTP.VaryHeader
test expects the response to be cached. Added a new url substring /echoheadercache which returns back the
expected cache header.
Removed the echoheaderoverride url handling from the test server.
BUG=none
TEST=ChromeFrame net tests should pass on IE6. Net tests should continue to pass everywhere else.
Review URL: http://codereview.chromium.org/6810001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on ChromeOS.
After this change, on ChromeOS we will use the TPM to generate keys
for keygen tags in forms. NSS will also have opencryptoki loaded so
it can talk to the TPM.
BUG=chromium-os:12416, chromium-os:12417
TEST=Generated keys on a ChromeOS device.
Review URL: http://codereview.chromium.org/6667020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
It hung the TSAN bot, although I don't know why:
http://build.chromium.org/p/chromium.memory/builders/Windows%20Tests%20%28tsan%29/builds/3531/steps/memory%20test%3A%20net/logs/stdio
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests were failing with Release builds because ASSERT() was used
instead of ASSERT_TRUE(), and so the code in ASSERT() wasn't executing.
Also fixed a bug in IPEndPoint::GetFamily() which caused the crash in unittests.
BUG=78663
TEST=Unittests
Review URL: http://codereview.chromium.org/6816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some web servers reportedly send header parameters that aren't
quoted properly. So we end up with headers like:
Content-Disposition: attachment; filename="Foo.bar
Rather than discarding the filename parameter in this case, we
now treat it as if there was a closing quote at the end of the
line.
BUG=58840
TEST=net_unittests --gtest_filter=NetUtilTest.GetFileNameFromCD
Review URL: http://codereview.chromium.org/6802019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for non-TCP transports. This helps because the alternative
is to either use non-TCP protocols (like SCTP) in classes which are called
"TCPClientSocketPool", or to clone the code as "SCTPClientSocketPool", both
of which are less than ideal.
For now, we're just testing transports, so the TransportSocketPool classes
will determine a single type of transport and just use them. In the future
we'll likely need to figure out how to deal with runtime selection of
transports, and probably support use of multiple transports either within
the same pools or within subpools. But that is for the future.
Note that the histograms have some "tcp" references to them. I didn't change
these to "transport" yet, because it will effect existing histograms.
Renames include:
classes:
TCPClientSocketPool -> TransportClientSocketPool
MockTCPClientSocketPool -> MockTransportClientSocketPool
TCPSocketParams -> TransportSocketParams
methods (not the exhaustive list):
CreateTCPClientSocket() -> CreateTransportClientSocket()
DoTCPConnect() -> DoTransportConnect()
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6804028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have several places where a need to distinguish `real' root CAs from
user-added root CAs will be useful:
1) Monoscope wants to inspect correctly signed, but unknown certificates, but
doesn't want to deal with proxy MITM certificates.
2) HSTS is likely to add a method for pinning to a certificate, but we don't
want to break every proxy MITM with it.
This change adds several lists of known, `real' roots. These lists present an
ongoing maintainance issue. However, in the event that the lists are incomplete
in the future, we fail open. This is because roots not in these lists are
treated as user-added and user-added roots have more authority than `real'
roots.
In some sense, this is a problem because it might be a security issue that new
roots are given too much authority. On the other hand, we're not breaking
things when we're behind on updating the lists so the maintainance issue isn't
too pressing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6793041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files are part of [1], but I need to submit them first in order for
try server runs to be effective.
This change does not affect the build.
[1] http://codereview.chromium.org/6793041/
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This lets us stop refcounting URLRequestHttpJob.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6749044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from local_state on Windows and Mac.
BUG=76551
TEST=testing SSL preferences with options UI
R=wtc
Review URL: http://codereview.chromium.org/6693077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(No code changes.)
nist.der contains a certificate issued directly from a root. This will be used
in a future unittest however, committing it now allows the try servers to
process the unittest before it's landed.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80628 0039d316-1c4b-4281-b951-d872f2087c98
|