summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Moving two http utility functions to a separate source file due to ↵tommi@chromium.org2009-09-183-16/+33
| | | | | | | | | | | | | dependency on icu. This allows usage of e.g. HeadersIterator without pulling in all of icu. TEST=no code change. BUG=none Review URL: http://codereview.chromium.org/213017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26545 0039d316-1c4b-4281-b951-d872f2087c98
* Retry landing the flip changes. This time with DEPS!mbelshe@google.com2009-09-1817-0/+3770
| | | | | | | | | BUG=none TEST=flip_session_unittest.cc flip_network_transaction_unittest.cc flip_framer_test.cc Review URL: http://codereview.chromium.org/210016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26533 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Strict transport security: add checkbox to clear state."agl@chromium.org2009-09-183-24/+0
| | | | | | | This reverts commit r25955. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26528 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26484 "This is not production code; landing some experimental ↵nsylvain@chromium.org2009-09-1716-3769/+0
| | | | | | | | | | network code." because it broke the "check_deps" step on Chromium XP Review URL: http://codereview.chromium.org/212015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26524 0039d316-1c4b-4281-b951-d872f2087c98
* This is not production code; landing some experimental network code.mbelshe@google.com2009-09-1716-0/+3769
| | | | | | | | | BUG=none TEST=flip_session_unittest.cc flip_network_transaction_unittest.cc flip_framer_test.cc Review URL: http://codereview.chromium.org/200084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26484 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a few data races on reference counters.timurrrr@chromium.org2009-09-171-1/+1
| | | | | | | BUG=18488 Review URL: http://codereview.chromium.org/215011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26476 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing gclient dependencies to .gitignore.maruel@chromium.org2009-09-174-345/+345
| | | | | | | | | | | | | | Fix the format of many directories so they don't show up in git status anymore. Run dos2unix on *.cc, caught many inconsistent and CRLF files. TBR=evan TEST=still build, git status shows nothing BUG=none Review URL: http://codereview.chromium.org/211010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26441 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26419.tyoshino@google.com2009-09-176-226/+91
| | | | | | | | | | | | | | | | | | | | | | Looks like this CL caused failure in Modules Linux (valgrind) http://chrome-buildbot.corp.google.com:8010/builders/Modules%20Linux%20(valgrind)/builds/1104/steps/valgrind%20test:%20base/logs/stdio http://chrome-buildbot.corp.google.com:8010/builders/Modules%20Linux%20(valgrind)/builds/1103/steps/valgrind%20test:%20base/logs/stdio [----------] 6 tests from ClipboardTest [ RUN ] ClipboardTest.ClearTest command timed out: 1200 seconds without output, killing pid 7479 process killed by signal 9 program finished with exit code -1 TBR=phajdan.jr Review URL: http://codereview.chromium.org/212007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26430 0039d316-1c4b-4281-b951-d872f2087c98
* Cache login identity for NewFTP transactions.phajdan.jr@chromium.org2009-09-166-91/+226
| | | | | | | | | TEST=net_unittests BUG=21184 Review URL: http://codereview.chromium.org/201083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26419 0039d316-1c4b-4281-b951-d872f2087c98
* Excluded a few tests that hang under ThreadSanitizer on Mactimurrrr@chromium.org2009-09-161-0/+22
| | | | | | | This patch was prepared by Alexander Potapenko (cc'ed) Review URL: http://codereview.chromium.org/205019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26368 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky DiskCacheBackendTest.NewEvictionDisableSuccess4.phajdan.jr@chromium.org2009-09-161-1/+3
| | | | | | | | | | This is #9 flaky test and rising (#5 in tests failing recently). TBR=rvargas Review URL: http://codereview.chromium.org/193127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26345 0039d316-1c4b-4281-b951-d872f2087c98
* More correctly handle username and password in FtpNetworkTransaction.phajdan.jr@chromium.org2009-09-169-86/+226
| | | | | | | | | | | | - prevent newline injection attacks - correctly unescape credentials provided in the URL TEST=Covered by net_unittests. http://crbug.com/20336 Review URL: http://codereview.chromium.org/183046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26305 0039d316-1c4b-4281-b951-d872f2087c98
* Force inclusion of build/common.gypi for all chromium gyp files.yaar@chromium.org2009-09-152-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Why: Simpler build code. If everybody includes it, it should be included automatically. Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi. What was done: 1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi 2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi. 3. lots of gyp files were fixed to not refer to build/common.gypi any more. 4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 5. build/common.gypi was left empty, because there are some external projects that still refer to it. Things that are left to do after this patch is in: 1. The following external files (in other repositories) need to stop include common.gypi ./third_party/hunspell/hunspell.gyp ./third_party/icu/icu.gyp ./v8/tools/gyp/v8.gyp 2. Once nobody refers to common.gypi anymore, delete common.gypi -or- Delete gyp_chromium.gypi and move its content back to common.gypi Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify. Review URL: http://codereview.chromium.org/206006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
* Uncouple the cert verifier when disconnecting to avoid a callback after a ↵hawk@chromium.org2009-09-151-0/+2
| | | | | | | | | | SSLClientSocketMac object has bee freed. BUG=21832 TEST=none Review URL: http://codereview.chromium.org/206007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26236 0039d316-1c4b-4281-b951-d872f2087c98
* Change the URLs used to access "view-cache:" and "view-net-internals:".eroman@chromium.org2009-09-1410-127/+184
| | | | | | | | | | | | | | | | | | "net-internal:*" ==> "chrome://net-internals/*" "view-cache:*" ==> "chrome://net-internals/view-cache/*" "view-cache:stats" ==> "chrome://net-internals/httpcache.stats" As before, there are also aliases from the "about:*" page: "about:net-internal[/*]" aliases "chrome://net-internals/*" "about:cache[/*]" aliases "chrome://net-internals/view-cache" BUG=http://crbug.com/21551 Review URL: http://codereview.chromium.org/202067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26158 0039d316-1c4b-4281-b951-d872f2087c98
* Non-blocking connect() attempts may fail synchronously in some cases. Whenmark@chromium.org2009-09-112-40/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this occurs, connect() should be retried with another address if possible and appropriate. On Mac OS X 10.6 ("Snow Leopard"), getaddrinfo() returns IPv6 addresses even when inappropriate due to the use of AI_ADDRCONFIG. connect() fails immediately when trying to connect to an IPv6 address from a system that only has IPv4 connectivity. The existing net::TCPClientSocketLibevent is not prepared to deal with immediate connect() failures, so it fails without trying additional addresses. Some sites, such as python.org, publish both IPv4 and IPv6 addresses. On Snow Leopard, name resolution always returns the IPv6 addresses first, rendering such sites impossible to connect to unless reachable by IPv6. This change restores the previous behavior of setting AI_ADDRCONFIG when calling getaddrinfo() on Mac OS X. AI_ADDRCONFIG was removed in a previous attempt to fix this bug. AI_ADDRCONFIG is now documented in Snow Leopard. The associated comment, written for Mac OS X 10.5 ("Leopard"), is no longer correct. In most cases, the presence or absence of this flag seems to have no impact on the system resolver's behavior, but I believe that its presence is correct per the documentation. A separate bug will be filed with Apple. BUG=12711 TEST=http://python.org/ on Snow Leopard should load on a machine where only IPv4 is available; it (and all other sites) should continue to function properly on Leopard Review URL: http://codereview.chromium.org/196094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26051 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two issues with a downloaded file's extension:paul@chromium.org2009-09-111-5/+0
| | | | | | | | | | | | | | | | | | | 1. On Mac, we were prepending an extra '.' to the extension causing it to fail a comparison (resulting in second extension being added). 2. For downloads with the extension '.tgz' and mime type 'application/x-gzip', we were appending an extra '.gz' extension. The extension compare code is starting to get a little long, but I don't think it's too bad if there are only a few of these cases. BUG=21591,21595 TEST=1. Download a file on Mac with a well known extension type (mp3, gz) and notice that there are no double extensions. 2. Download a tgz file and notice that the file's extension is '.tgz', not '.tgz.gz'. Review URL: http://codereview.chromium.org/195064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26028 0039d316-1c4b-4281-b951-d872f2087c98
* Followup after http://codereview.chromium.org/201034 to correctly handle months.phajdan.jr@chromium.org2009-09-113-0/+16
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/199082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26012 0039d316-1c4b-4281-b951-d872f2087c98
* Add a NOTREACHED() to catch users of pre-release NSS.chase@chromium.org2009-09-111-0/+5
| | | | | | | | | | | | | | Catch a crash for debug build users who followed the Linux 64bit instructions. BUG=21454 TEST=debug chrome crashes at NOTREACHED in error condition using old NSS, skips past in new NSS and under both conditions in release builds. Review URL: http://codereview.chromium.org/201086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25969 0039d316-1c4b-4281-b951-d872f2087c98
* Add a histogram for measuring SSL Connect times.mbelshe@google.com2009-09-112-2/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/194035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25956 0039d316-1c4b-4281-b951-d872f2087c98
* Strict transport security: add checkbox to clear state.agl@chromium.org2009-09-113-0/+24
| | | | | | | | | | | | | | | This patches add a checkbox to the "Clear Browsing Data" dialog which clears the STS state when checked. Since we don't timestamp our entries (for now at least, should we?), the duration selected has no effect: we always clear everything. Mac doesn't appear to have a dialog for this yet, so no Mac specific changes. http://codereview.chromium.org/196070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25955 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the maximum number of entries in LoadLog to 40.eroman@chromium.org2009-09-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/194075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25935 0039d316-1c4b-4281-b951-d872f2087c98
* Add trace points for the "dnsResolve()" and "myIpAddress()" PAC javascript ↵eroman@chromium.org2009-09-1017-106/+236
| | | | | | | | | | | | | | bindings. This makes note of the calls in the request's LoadLog. Since the LoadLog is not thread-safe, SingleThreadedProxyResolver creates a private LoadLog for ProxyResolverV8 to write into, and then copies it into the mainLoadLog on completion (on the origin thread). BUG=http://crbug.com/14478 Review URL: http://codereview.chromium.org/193037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25926 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-108-24/+28
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* Use "GURL::possibly_invalid_spec()" rather than "GURL::spec()", in case the ↵eroman@chromium.org2009-09-103-7/+29
| | | | | | | | | | GURL that was passed to URLRequest(const GURL&) is invalid. BUG=http://crbug.com/21423 Review URL: http://codereview.chromium.org/192057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25903 0039d316-1c4b-4281-b951-d872f2087c98
* Strict transport security: come out from behind the flag.agl@chromium.org2009-09-101-13/+1
| | | | | | | | | | With this change, Strict Transport Security is active by default and doesn't need the --force-https flag any more. http://codereview.chromium.org/193067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25888 0039d316-1c4b-4281-b951-d872f2087c98
* Get the latest ParseFTPList code from Mozilla, and apply only the absolutelyphajdan.jr@chromium.org2009-09-106-1128/+2091
| | | | | | | | | | | | | required changes. This way future merging would be much easier. TEST=none BUG=none Review URL: http://codereview.chromium.org/201034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25878 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Convert data writes from sysnchronous to asynchronous.rvargas@google.com2009-09-103-35/+89
| | | | | | | | | | BUG=21383 TEST=covered by current unit tests. Review URL: http://codereview.chromium.org/201065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25873 0039d316-1c4b-4281-b951-d872f2087c98
* Add methods for setting socket buffers to the Socket mbelshe@google.com2009-09-0918-10/+130
| | | | | | | | | | | | class. Also add a few stats counters for TCP read/write stats. BUG=none TEST=none Review URL: http://codereview.chromium.org/199048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25803 0039d316-1c4b-4281-b951-d872f2087c98
* Add an SSLConfigService implementation for Mac OS Xhawk@chromium.org2009-09-095-0/+324
| | | | | | | | BUG=19293 TEST=https://test-ssev.verisign.com/ has three links: one should work OK, the other should warn that the certificate is expired, the other that the certificate is revoked. Review URL: http://codereview.chromium.org/193009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25798 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath version of PathService::Get.thestig@chromium.org2009-09-091-2/+2
| | | | | | | | | | | BUG=None TEST=None Original Review URL: http://codereview.chromium.org/174189 Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/193047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25778 0039d316-1c4b-4281-b951-d872f2087c98
* Return ERR_FILE_NOT_FOUND from FtpNetworkTransaction when we can.phajdan.jr@chromium.org2009-09-092-3/+34
| | | | | | | | | | | This way it provides more specific error code for the user. TEST=Covered by net_unittests. http://crbug.com/20405 Review URL: http://codereview.chromium.org/197050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25771 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the data socket completely when data transfer is finished.phajdan.jr@chromium.org2009-09-091-0/+4
| | | | | | | | | | | | Fixes an FTP transaction hang when we wait for server's response and the server apparently waits for us. TEST=See bug. http://crbug.com/21127 Review URL: http://codereview.chromium.org/192042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25750 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unit test for FTP directory listing.phajdan.jr@chromium.org2009-09-091-0/+17
| | | | | | | | | TEST=Covered by net_unittests. BUG=none Review URL: http://codereview.chromium.org/197052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25740 0039d316-1c4b-4281-b951-d872f2087c98
* Check in patch for pierre.lafayette, http://codereview.chromium.org/178059/show.mirandac@chromium.org2009-09-098-79/+75
| | | | | | Review URL: http://codereview.chromium.org/194057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25738 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Don't delete sparse entries when wervargas@google.com2009-09-092-11/+54
| | | | | | | | | | | cancel the request. BUG=20930 TEST=unittests Review URL: http://codereview.chromium.org/193043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25736 0039d316-1c4b-4281-b951-d872f2087c98
* Display symlinks on FTP directory listings.phajdan.jr@chromium.org2009-09-091-1/+18
| | | | | | | | | TEST=See bug. http://crbug.com/21006 Review URL: http://codereview.chromium.org/197044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25729 0039d316-1c4b-4281-b951-d872f2087c98
* Replace icu38/icu38.gyp with icu/icu.gyp in gyp files replace all the ↵jshin@chromium.org2009-09-092-8/+8
| | | | | | | | | | | | | | | | | | references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). Also updated is the test results for net_util_unittests. This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). BUG=8198 TEST=On all platforms, all the targets are built fine. Review URL: http://codereview.chromium.org/172031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
* Include fixes for gcc >= 4.3evan@chromium.org2009-09-091-0/+2
| | | | | | | | Patch by Joel Stanley <joel@jms.id.au> Review URL: http://codereview.chromium.org/197055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25699 0039d316-1c4b-4281-b951-d872f2087c98
* ForceTLS: hash hostnames, handle subdomains, canonicalise.agl@chromium.org2009-09-097-24/+343
| | | | | | | | | | | | | | | | It turns out that JSON[Reader|Writer] cannot handle periods in key names(!). Because of this, an also to avoid leaking a sort of ForceTLS browser history in the state file, we hash the domain names. Also, this patch tries to implement the RFCs with respect to canonicalising the names. Since IDN processing has already occured by the time the name reaches us, there's only so much that we can do however. http://codereview.chromium.org/201033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25696 0039d316-1c4b-4281-b951-d872f2087c98
* Add an href to help page for view-net-internal.eroman@chromium.org2009-09-081-1/+4
| | | | | | | | BUG=http://crbug.com/14478 Review URL: http://codereview.chromium.org/196050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25684 0039d316-1c4b-4281-b951-d872f2087c98
* Don't log empty FTP LIST responses as unknown server type.phajdan.jr@chromium.org2009-09-081-0/+5
| | | | | | | | | | | The histograms will be more accurate after this change. TEST=none BUG=20335 Review URL: http://codereview.chromium.org/192038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25638 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Strict-Transport-Security grammar to match the spec.abarth@chromium.org2009-09-082-14/+28
| | | | | | | | R=agl Review URL: http://codereview.chromium.org/200033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25634 0039d316-1c4b-4281-b951-d872f2087c98
* Properly concatenate URL components in directory listing.phajdan.jr@chromium.org2009-09-081-2/+6
| | | | | | | | | | | This time really properly. TEST=none http://crbug.com/20347 Review URL: http://codereview.chromium.org/196019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25624 0039d316-1c4b-4281-b951-d872f2087c98
* Avoids the use of "namespace using-directives" in a few places.thakis@chromium.org2009-09-071-2/+1
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/183008 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25607 0039d316-1c4b-4281-b951-d872f2087c98
* Aesthetic changes to the proxy configuration log format.eroman@chromium.org2009-09-063-40/+192
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also in this change, I stop brodacasting the proxy settings changes to LOG(INFO) --- This is because navigating to "view-net-internal:proxyservice.config" offers a better solution, so no point polluting the log file. Note that the format change is intended to make the string more succint and human readable. For example, here is a before and after comparison: ------------ New version: ------------ Automatic settings: Auto-detect: No Custom PAC script: [None] Manual settings: Proxy server: [None] Bypass list: [None] Bypass local names: No ------------ Old version: ------------ { auto_detect: 0 pac_url: proxy_rules: { type: TYPE_NO_RULES single_proxy: proxy_for_http: proxy_for_https: proxy_for_ftp: socks_proxy: } proxy_bypass_local_names: 0 proxy_bypass_list: id: 1 } BUG=http://crbug.com/14478 TEST=ProxyConfigTest.ToString Review URL: http://codereview.chromium.org/198039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25584 0039d316-1c4b-4281-b951-d872f2087c98
* Add some trace-points to HttpCache for request profiling (cache entry ↵eroman@chromium.org2009-09-063-13/+107
| | | | | | | | | | | "open", "create", "waiting" and "read_info"). BUG=http://crbug.com/14478 TEST=HttpCache unittests. Review URL: http://codereview.chromium.org/201035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25583 0039d316-1c4b-4281-b951-d872f2087c98
* Rename X-Force-TLS to Strict-Transport-Security.abarth@chromium.org2009-09-057-94/+101
| | | | | | | | | | | Also, remove StrictTransportSecurity code from SSLPolicy because that code doesn't work. R=agl Review URL: http://codereview.chromium.org/198035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25577 0039d316-1c4b-4281-b951-d872f2087c98
* Bug fixing for range request support in HttpCachehclam@chromium.org2009-09-053-2/+36
| | | | | | | | | | | | | | | | | | | TEST=net_unittests --gtest_filter=HttpCache.GET_Previous206_NotModified Step to reproduce the failure: 1. Sparse cache has data for (0 - 9) 2. Make a non-range request for the resource 3. Server replies with 304 not modified 4. User would get 304 modified while 200 is expected The cause is that PartialData::ResponseHeadersOK requires a full specified range to accept the response when server replies with 304. This is not a valid assumption as the response of 304 can be caused by the cache submitting a range request for validation purpose. Review URL: http://codereview.chromium.org/198018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25569 0039d316-1c4b-4281-b951-d872f2087c98
* [Second attempt of r25461]wtc@chromium.org2009-09-059-703/+1095
| | | | | | | | | | | | | | | | | | | | | | | Use SSPI for NTLM authentication on Windows. Add an explicit embedded_identity_used_ boolean member to make sure we use the username/password in the URL only once for the transaction. This allows us to reset auth_identity_[target].source to HttpAuth::IDENT_SRC_NONE after auth failed. Initial patch by Arindam. Original review URL: http://codereview.chromium.org/159656 R=arindam,eroman BUG=19,18009,20560 TEST=1. Open a webpage that requests NTLM authentication on Windows. 2. New unit test for wrong auth identity in URL. Review URL: http://codereview.chromium.org/193022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25564 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 21:18:23 +0000