| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
(At the request of Aaron Swartz)
BUG=none
TEST=Go to http://jottit.com and note that the URL is rewritten to https://jottit.com
http://codereview.chromium.org/2867049/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This was a TODO)
BUG=None
TEST=included
Review URL: http://codereview.chromium.org/2843048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also removes a TODO which is no longer relevant.
BUG=NONE
Review URL: http://codereview.chromium.org/2895001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
identified by Darin after commit.
BUG=none
TEST=net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.*
Review URL: http://codereview.chromium.org/2844043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookies related to URL (found by inspection.) Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.
BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51544
Review URL: http://codereview.chromium.org/2857029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We basically don't do late socket binding when a connect has already
been started for a request, even if another socket frees up earlier.
The reassignment logic was quite complicated, so I reworked it. Fixing
this bug was easy by changing the way FindTopStalledGroup worked, but
because that function is called in that loop, changing this case
caused the loop to go infinitely in some cases. This led me to look
into unwinding the loop.
The problem really came down to ReleaseSocket/DoReleaseSocket. Because
we allow for a pending queue of released sockets, we had to do this
looping (which has been a source of bugs before). To fix, I
eliminated the pending_releases queue. I also reworked the routes
through OnAvailableSocketSlot to unify them and always run asynchronously.
The result is that now we no longer have the loop. So when one
socket is released, we hand out exactly one socket. Note also that
this logic slightly changes the priority of how we recycle sockets.
Previously, we always consulted the TopStalledGroup. The TopStalledGroup
is really only interesting in the case where we're at our max global
socket limit, which is rarely the case. In the new logic, when a
socket is released, first priority goes to any pending socket in the
same group, regardless of that group's priority. The reason is why
close a socket we already have open? Previously, if the released
socket's group was not the highest priority group, the socket would
be marked idle, then closed (to make space for a socket to the
TopStalledGroup), and finally a new socket created. I believe the
new algorithm, while not perfectly matching the priorities, is more
efficient (less churn on sockets), and also is more graceful to the
common case.
Finally OnAvailableSocketSlot does two things. First, it tries to
"give" the now available slot to a particular group, which is dependent
on how OnAvailableSocketSlot was called. If we're currently
stalled on max sockets, it will also check (after giving the socket
out) to see if we can somehow free something up to satisfy a
stalled group. If that second step fails for whatever reason,
we don't loop. In theory, this could mean that we go under the
socket max and didn't dish out some sockets right away. To make
sure that multiple stalled groups can get unblocked, we'll record
the number of stalled groups, and once in this mode,
OnAvailableSocketSlot will keep checking for stalled groups until the
count finally drops to zero.
BUG=47375
TEST=DelayedSocketBindingWaitingForConnect,CancelStalledSocketAtSocketLimit
Review URL: http://codereview.chromium.org/2861023
TBR=mbelshe@chromium.org
BUG=48094
Review URL: http://codereview.chromium.org/2809052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This logs to both LOG(INFO), and also to the NetLog (about:net-internals).
BUG=46822
Review URL: http://codereview.chromium.org/2815046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
They're apparently problematic with threads.
R=agl
BUG=48006
TEST=KeygenHandler.ConcurrencyTest
Review URL: http://codereview.chromium.org/2832047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43919
TEST=net_unittests
Review URL: http://codereview.chromium.org/2810051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2829046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2802032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48330
TEST=WebSocketHandshakeResponseHandlerTest.BadResponse and BadResponse2 don't crash and passes
Review URL: http://codereview.chromium.org/2870047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Upstreamed support for partial results from devtools' version
- Made DidRead receive data and length (in order to support websockets data)
- Fixed all the clients.
Added net/server with http socket implementation that supports websockets. Will remove net/tools fetch client and server later.
Review URL: http://codereview.chromium.org/2868036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=green tree
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838041
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2864039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
changes on Windows.
BUG=48204
TEST=NetworkChangeNotifier works on Windows
Review URL: http://codereview.chromium.org/2807036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change is responsible for the XP tests (dbg)(4) browser_tests going
red, and we're heading into a long weekend. I'll revert, and resubmit
next week if it turns out that it wasn't my problem.
Original description:
Fix bug in DeleteAllForURL; deletes entire store instead of just
cookies related to URL (found by inspection.) Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.
BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)
Review URL: http://codereview.chromium.org/2857029
TBR=rdsmith@google.com
Review URL: http://codereview.chromium.org/2858046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
...apart from the necessary ones in spdy_framer_test.cc.
BUG=None.
TEST=net_unittests pass.
Review URL: http://codereview.chromium.org/2870044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will enable chrome to display all cookies used/blocked on the current site to the user instead of just the information that something was blocked. The cookies are collected in data structures suitable for displaying them using the cookies tree model.
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2370001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookies related to URL (found by inspection.) Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.
BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)
Review URL: http://codereview.chromium.org/2857029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Addresses wtc's comments in http://codereview.chromium.org/2834030/show)
http://codereview.chromium.org/2827042/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(Builder compilers are dumb.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Addresses wtc's comments in http://codereview.chromium.org/2834030/show)
http://codereview.chromium.org/2827042/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fix broke some tests which were also fixed.
BUG=47480
TEST=net_unittests
Contributed by: agayev@google.com
Review URL: http://codereview.chromium.org/2805066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16932
TEST=compiles
Review URL: http://codereview.chromium.org/2862041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
To avoid the sporadic leaks in unit tests, explicitly trigger a V8 garbage collection during teardown.
BUG=48145
Review URL: http://codereview.chromium.org/2833051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IM context when it has focus.
BUG=http://crosbug.com/4449
TEST=See bug report.
Review URL: http://codereview.chromium.org/2856028
TBR=suzhe@chromium.org
Review URL: http://codereview.chromium.org/2848036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it has focus.
BUG=http://crosbug.com/4449
TEST=See bug report.
Review URL: http://codereview.chromium.org/2856028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an InFlightBackendIO class that handles posting of
cacheoperations back and forth between the IO thread and
the cachethread.
BUG=26730
TEST=unit tests
Review URL: http://codereview.chromium.org/2841034
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/2881010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is tickling sporadic leaks in linux heapchecker.
BUG=48145
TBR=iposva
Review URL: http://codereview.chromium.org/2866040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should make it easier to diagnose problems.
R=agl
BUG=48006
TEST=none
Review URL: http://codereview.chromium.org/2810044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an InFlightBackendIO class that handles posting of
cacheoperations back and forth between the IO thread and
the cachethread.
BUG=26730
TEST=unit tests
Review URL: http://codereview.chromium.org/2841034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests run against a local python sync server. The
extensions datatype was recently added to the client code, causing the
python server to require this update.
BUG=48040
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/2878017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This provides the really basic serialization/deserialization of the frame, and does introduce a behavior change.
BUG=48100
TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs"
Review URL: http://codereview.chromium.org/2886009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=net_unittests pass.
BUG=None.
Review URL: http://codereview.chromium.org/2870039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in proxy_resolver_v8.cc.
This is done by sharing the string storage using ExternalStringResource.
An accompanying change was to pass around the PAC script data as a UTF16 string16 rather than a UTF8 std::string -- this required changing plumbing in the other files.
This optimization will be important when creating multiple ProxyResolverV8's so they don't end up duplicating the script text.
BUG=11079
Review URL: http://codereview.chromium.org/2817043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Addresses wtc's comments in http://codereview.chromium.org/2834030/show)
http://codereview.chromium.org/2827042/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the HttpNetworkTransaction correctly handles asynchronous auth token
generation, HttpAuthHandlerNegotiate can be turned into a state machine. This
also removes the need for the externally exposed "Resolve Canonical Name"
details to users of this handler.
BUG=42222
TEST=net_unittests
Review URL: http://codereview.chromium.org/2867022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2838018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If SocketStream is deleted while ResolvProxy is running, proxy service
might access SocketStream's member fields, such as proxy_info_, after
SocketStream is deleted, so it would cause crash like
http://crash/reportdetail?reportid=40166b9529ce6b74
In SocketStream destructor, it will set context to NULL, so it will
cancel proxy request if pac_request_ is not NULL.
BUG=46750
TEST=none
Review URL: http://codereview.chromium.org/2852034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(tsan errors on the unit tests)
Add an InFlightBackendIO class that handles posting of
cacheoperations back and forth between the IO thread and
the cachethread.
BUG=26730
TEST=unit tests
Review URL: http://codereview.chromium.org/2829008
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/2819032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an InFlightBackendIO class that handles posting of
cacheoperations back and forth between the IO thread and
the cachethread.
BUG=26730
TEST=unit tests
Review URL: http://codereview.chromium.org/2829008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It turns out that we need to update our XMPP servers with a more recent
version of OpenSSL.
Review URL: http://codereview.chromium.org/2860042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=48006
TEST=KeygenHandlerTest.ConcurrencyTest
TBR=stuartmorgan,wtc
Review URL: http://codereview.chromium.org/2827039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
spdy_test_util.h
BUG=None
TEST=net_unittests pass
Review URL: http://codereview.chromium.org/2861038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NSS (which is the default SSL library on all platforms now) has a set
of callbacks via which it fetches OCSP responsese and CRLs. This patch
adds histograms so that we can measure the amount of time spent in
these operations. (Note that these operations block SSL handshakes).
http://codereview.chromium.org/2834030/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The renegotiation extension was introduced into TLS in [1], to address
the attack described in [2]. In order to fully protect ourselves,
clients need to require support from servers. However, these things
take a long time to roll out.
As an initial measure, we start to require the extension from a
whitelist of servers that we known to support the extension. We are
then protected from prefix attacks against these servers. Over time,
if the list grows we might want to share it with Mozilla, but we'll
start simple.
[1] http://tools.ietf.org/html/rfc5746
[2] http://www.educatedguesswork.org/2009/11/understanding_the_tls_renegoti.html
http://codereview.chromium.org/2045006/show
TEST=Setup a dummy TLS server without renegotiation extension support (Hardy) will do and force mail.google.com to it using /etc/hosts. Navigate to https://mail.google.com and check for ERR_SSL_UNSAFE_NEGOTIATION.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=47482
TEST=net_unittests
Contributed by: agayev@google.com
Review URL: http://codereview.chromium.org/2884003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51255 0039d316-1c4b-4281-b951-d872f2087c98
|