summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Don't poll the PAC script during periods of network inactivity.eroman@chromium.org2012-01-133-69/+373
| | | | | | | | | BUG=109310 Review URL: http://codereview.chromium.org/9139070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117709 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent callbacks after URLRequest/URLRequestJob have been ↵battre@chromium.org2012-01-138-29/+304
| | | | | | | | | | | | | | | | | | | | canceled/completed/killed. With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks. Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled. Both cases could happen in rare race conditions. BUG=108968 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117342 Review URL: http://codereview.chromium.org/9147018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117685 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Debug checks that URLRequest::set_method arguments match the contract."apavlov@chromium.org2012-01-131-4/+1
| | | | | | | | | | | | This change broke WebKit test http/tests/xmlhttprequest/methods-lower-case.html This reverts commit a964df83606a31b3674e20989e7dc6db9f3d4e86. TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/9207003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117641 0039d316-1c4b-4281-b951-d872f2087c98
* chrome.experimental.downloads.download works for non-GET methods.cbentzel@chromium.org2012-01-131-4/+13
| | | | | | | | | | | | This wasn't working because ResourceDispatcherHost::BeginDownload was overriding the method. I traced through all callers of BeginDownload and confirmed that the method did not need to be set. BUG=110044 TEST=DownloadsApiTest.Downloads [the downloadPost test case] Review URL: http://codereview.chromium.org/9148070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117637 0039d316-1c4b-4281-b951-d872f2087c98
* Debug checks that URLRequest::set_method arguments match the contract.cbentzel@chromium.org2012-01-131-1/+4
| | | | | | Review URL: http://codereview.chromium.org/9187060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117635 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect constant used in status bitmaskjoth@chromium.org2012-01-131-2/+2
| | | | | | | | | | | | Turns out the test passes OK (given access to java side pieces, failure of which this bug masks) BUG=109783 TEST= Review URL: http://codereview.chromium.org/9187007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117632 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117342 - Prevent callbacks after URLRequest/URLRequestJob have been ↵battre@chromium.org2012-01-134-290/+17
| | | | | | | | | | | | | | | | | | | | | canceled/completed/killed. With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks. Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled. Both cases could happen in rare race conditions. BUG=108968 TEST=no Review URL: http://codereview.chromium.org/9147018 TBR=battre@chromium.org Review URL: http://codereview.chromium.org/9173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117620 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup for UploadDataStream's constructor.satorux@chromium.org2012-01-132-2/+5
| | | | | | | | | | | | | This is in preparation for reworking UploadDataStream. We'll make more changes in the upcoming patches. BUG=72001 TEST=try bots Review URL: http://codereview.chromium.org/9187021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117588 0039d316-1c4b-4281-b951-d872f2087c98
* Initialized variable to fix -Wmaybe-uninitialized warning.asharif@chromium.org2012-01-131-1/+1
| | | | | | | | | | BUG=none TEST=try bots. Review URL: http://codereview.chromium.org/9139041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117584 0039d316-1c4b-4281-b951-d872f2087c98
* The network_moved check in DoHandshakeLoop should only apply towtc@chromium.org2012-01-131-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | STATE_HANDSHAKE. After transport I/O completes synchronously, stay in the handshake loop only if the next state is STATE_HANDSHAKE, which is the only state that requires transport I/O to make progress. If the next state is any other state, we should ignore network_moved when determing if we should stay in the handshake loop. This changelist is the synchronous completion version of http://codereview.chromium.org/660131, which dealt with this bug when transport I/O completes asynchronously. R=agl@chromium.org BUG=109706 TEST=Run a Chrome debug build with --enable-origin-bound-certs and connect to a Google server such as gmail over HTTPS. Should not hit a DCHECK failure in net_log.cc. Review URL: http://codereview.chromium.org/9172005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117578 0039d316-1c4b-4281-b951-d872f2087c98
* Handle Z_BUF_ERROR as a non-fatal error while incrementally decompressingrtenneti@google.com2012-01-132-4/+2
| | | | | | | | | | | | | | SYN_STREAM/SYN_REPLY headers. This also fixes bug when server sends SYN_REPLY in separate chunks (i.e. header + zlib chunks ) chrome fails to recognize it. BUG=108596 R=jar TEST=ASAN tests and network unit tests Review URL: http://codereview.chromium.org/9185036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117563 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup after debugging with the XP builder.agl@chromium.org2012-01-122-23/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117437 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code from UploadData and URLRequest.satorux@chromium.org2012-01-125-37/+11
| | | | | | | | | | | | | URLRequest::AppendFileToUpload() is no longer used as now file uploads are done with UploadData. TEST=chrome and tests build as before. BUG=72001 Review URL: http://codereview.chromium.org/9148016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117357 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent callbacks after URLRequest/URLRequestJob have been ↵battre@chromium.org2012-01-124-17/+290
| | | | | | | | | | | | | | | | | | canceled/completed/killed. With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks. Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled. Both cases could happen in rare race conditions. BUG=108968 TEST=no Review URL: http://codereview.chromium.org/9147018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117342 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing to debug via the builders since there's no XP trybot.agl@chromium.org2012-01-111-1/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117310 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing to debug with the XP builders.agl@chromium.org2012-01-111-0/+10
| | | | | | (There aren't any XP/Vista trybots any more.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117298 0039d316-1c4b-4281-b951-d872f2087c98
* Add debugging to trace down a problem on WinXP/Vista.agl@chromium.org2012-01-112-5/+80
| | | | | | (We don't have trybots any longer for those platforms.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117265 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CRLSet checking on Mac.agl@chromium.org2012-01-112-3/+63
| | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/9152019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117225 - Implement CRLSet checking on Windows.flackr@chromium.org2012-01-112-67/+3
| | | | | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/9153014 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/9186009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117236 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CRLSet checking on Windows.agl@chromium.org2012-01-112-3/+67
| | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/9153014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117225 0039d316-1c4b-4281-b951-d872f2087c98
* net: add a test for X509Certificate integration with CRLSet.agl@chromium.org2012-01-113-0/+142
| | | | | | | | | | | | It's #ifdef'ed USE_NSS for now because we don't yet have implementations for Windows and OS X. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/9152011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117223 0039d316-1c4b-4281-b951-d872f2087c98
* Split the initialisation of NeworkChangeNotifierMac.droger@google.com2012-01-115-35/+48
| | | | | | | | | | | | | The initialization function is split into two: - to register for SCNetworkReachability notifications, - to register for SCDynamicStore notifications. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/9150002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117200 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve style nits and clean up Strict-Transport-Security header handling code.palmer@chromium.org2012-01-113-13/+13
| | | | | | | | | | | | | | | | | Per wtc. Note that we purposefully do not set MODE_STRICT when processing Public-Key-Pins headers, because it is possible (and desirable by some) to note and validate pins when using HTTPS, but not to require HTTPS. The dynamic key pinning spec requires this behavior, although my first draft and instincts were also to have pinning imply MODE_STRICT. BUG=78369, 109772 TEST=net_unittests TransportSecurityStateTest.*, browser_tests NetInternalsTest.* Review URL: http://codereview.chromium.org/9167024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117175 0039d316-1c4b-4281-b951-d872f2087c98
* net: allow CRLSets to block specific SPKIs.agl@chromium.org2012-01-104-45/+148
| | | | | | | | | | | | | | | | This change allows CRLSets to include a list of blocked SPKI fingerprints, which may save us doing emergency binary pushes in the future. It also corrects a bug where the NSS code was passing in the full SPKI rather than the SHA256 hash. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/9149010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117069 0039d316-1c4b-4281-b951-d872f2087c98
* Adds HostResolverImplTest.FailedAsynchronousLookupszym@chromium.org2012-01-091-1/+40
| | | | | | | | | | | Improves code coverage. TEST=./net_unittests --gtest_filter=HostResolverImplTest.FailedAsynchronousLookup Review URL: http://codereview.chromium.org/9122013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116879 0039d316-1c4b-4281-b951-d872f2087c98
* net: all GeoTrust to sign Google certs.agl@chromium.org2012-01-091-2/+0
| | | | | | | | | BUG=109621 TEST=none Review URL: http://codereview.chromium.org/8956067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116873 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - delete unused code from spdy_framer.rtenneti@chromium.org2012-01-073-316/+42
| | | | | | | | | | | | | | | | - Deleted all code associated with SPDY_INTERPRET_CONTROL_FRAME_COMMON_HEADER - Deleted OldProcessControlFrameHeaderBlock and OldIncrementallyDecompressControlFrameHeaderData - Changed unittests to reflect the above changes. Deleted uses of ParseHeaderBlock (server code doesn't use ParseHeaderBlock). BUG=108608 R=wtc TEST=network unit tests. Review URL: http://codereview.chromium.org/9124022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116814 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 116772 - Enabled SpdyFramerTest's UnclosedStreamDataCompressors.rtenneti@chromium.org2012-01-072-7/+16
| | | | | | | | | | | | | | | | | Wasn't able to duplicate ASAN tests failing in UnclosedStreamDataCompressors on my linux build. Enabling it to see if the failure was flaky. BUG=108596 R=rch TEST=network unittests. Review URL: http://codereview.chromium.org/8982009 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/9141002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116777 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled SpdyFramerTest's UnclosedStreamDataCompressors.rtenneti@chromium.org2012-01-062-16/+7
| | | | | | | | | | | | | | Wasn't able to duplicate ASAN tests failing in UnclosedStreamDataCompressors on my linux build. Enabling it to see if the failure was flaky. BUG=108596 R=rch TEST=network unittests. Review URL: http://codereview.chromium.org/8982009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116772 0039d316-1c4b-4281-b951-d872f2087c98
* Remove task.h and finish base::Bind() migration.ajwong@chromium.org2012-01-0614-14/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
* Adds PriorityQueue and PrioritizedDispatcher.szym@chromium.org2012-01-066-1/+849
| | | | | | | | | | | This will be used in HostResolverImpl to dispatch Jobs. BUG=109426 TEST=./net_unittests --gtest_filter=PriorityQueue*:PrioritizedDispatcher* Review URL: http://codereview.chromium.org/9113022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116736 0039d316-1c4b-4281-b951-d872f2087c98
* net: don't pass the CRLSet in the SSLConfig.agl@chromium.org2012-01-066-17/+37
| | | | | | | | | | | | | | | | | The SSLConfig was a poor choice of location to carry the CRLSet because the CRLSet can be updated while Chrome is running, but the SSLConfig is relatively static and is cached in several places in the code. This change causes the locations which call X509Certificate::Verify to grab a new reference to the current CRLSet. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/9044011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116720 0039d316-1c4b-4281-b951-d872f2087c98
* net: change how CRL sets interact with online revocation checking.agl@chromium.org2012-01-061-30/+20
| | | | | | | | | | | | | | | | Currently the use of a CRLSet replaces online revocation checking. With this change, CRL sets become purely an additional check. This allows us to enable CRL sets to test the full pipeline without changing any other variables. BUG=none TEST=none Review URL: http://codereview.chromium.org/9044012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116688 0039d316-1c4b-4281-b951-d872f2087c98
* Followup to address post-commit comments on 9041015agl@chromium.org2012-01-062-2/+3
| | | | | | http://codereview.chromium.org/9041015/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116684 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: Update the internal logic of a block file to makervargas@google.com2012-01-054-20/+144
| | | | | | | | | | | | | | | | | sure that the number of entries on the file is not out of sync. * Check the counters on every session * Make sure that num_entries is always >= number of used bits (create/delete order) * Make sure that the updating flag works for gcc & co. * Fail initialization if we cannot fix the file. BUG=108375 TEST=net_unittests Review URL: http://codereview.chromium.org/9016033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116565 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Chrome to process CRL set delta updates.agl@chromium.org2012-01-052-2/+30
| | | | | | | | | | | | | Now that we can serialise CRL sets, we can handle delta updates by applying them to the current CRL set and writing the result back to disk. BUG=none TEST=none Review URL: http://codereview.chromium.org/9041015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116533 0039d316-1c4b-4281-b951-d872f2087c98
* Poll PAC scripts for content changes.eroman@chromium.org2012-01-058-95/+896
| | | | | | | | | | | | | | | | | | An exponential poll delay is used which doubles the delay after each attempt (for instance polls might occur at 4 seconds, then 8 seconds, then 16 seconds, up to a maximum of 2 minutes). This same mechanism also applies to the resolution of "auto-detect" settings. The intent of this change is to make it possible to (1) Notice server-side changes made to the PAC scripts (2) Recover from spurious network errors when initially downloading PAC scripts. BUG=90581 TEST=Configure Chrome to use a PAC script which fails to load (i.e. a non-existent file:// url, or remap the host's DNS record). Start Chrome and verify using about:net-internals that it has failed to fetch the PAC script and has fallen back to DIRECT settings. Fix the PAC URL to work and wait for chrome to notice the change and reconfigure itself (will take a maximum of 2 minutes). Review URL: http://codereview.chromium.org/9078003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116462 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HTTP header-based public key pinning.palmer@chromium.org2012-01-055-141/+686
| | | | | | | | | | | | | | | | | | | | | | Upon receipt of the Public-Key-Pins header, check the syntax and the pins, and set the pins in the TransportSecurityState. From then on, use these new dynamic pins to validate TLS connections: as with preloaded pins, refuse to connect to TLS servers that fail the pin check. The Public-Key-Pins header is defined in an IETF Internet-Draft, and discussed on the websec@ietf.org mailing list. Clarified TransportSecurityState member function and field documentation. Also: Minor "gcl lint" repairs, and a new typedef std::vector<net::SHA1Fingerprint> FingerprintVector used everywhere relevant. BUG=78369 TEST=net_unittests TransportSecurityStateTest.*, browser_tests NetInternalsTest.* Review URL: http://codereview.chromium.org/8082016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116443 0039d316-1c4b-4281-b951-d872f2087c98
* When rejecting weak keys, do not mask more serious X509 errors.palmer@chromium.org2012-01-051-2/+6
| | | | | | | | | BUG=107479 TEST=net_unittests X509CertificateTest.* Review URL: http://codereview.chromium.org/8956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116442 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind(): directory_lister.cc - get rid of DataEvent classtbreisacher@chromium.org2012-01-043-70/+64
| | | | | | | | | | | | | Originally, I tried to get rid of the DirectoryLister::Core class to simplify the implementation of DirectoryLister. What I didn't realize was that the purpose of the Core was to outlive the DirectoryLister itself in case the DirectoryLister is destroyed. I think this is probably the most straightforward: Keep the Core, but still make the implementation simpler than it was before we did the base::Bind conversion. For reference, the previous CL was http://codereview.chromium.org/8989052 BUG=NONE TEST=visit any file:// url Review URL: http://codereview.chromium.org/9008059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116394 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Merge the server-side protocol changes.albertb@chromium.org2012-01-041-6/+7
| | | | | | | | | | R=ncarter BUG=b/3051801 TEST=it builds Review URL: http://codereview.chromium.org/8966034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116319 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 116259 - base::Bind(): directory_lister.cc - get rid of DataEvent classtbreisacher@chromium.org2012-01-043-98/+144
| | | | | | | | | | | | | | Resubmit of http://codereview.chromium.org/9026001/ BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8989052 TBR=tbreisacher@chromium.org Review URL: http://codereview.chromium.org/9008058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116268 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind(): directory_lister.cc - get rid of DataEvent classtbreisacher@chromium.org2012-01-043-144/+98
| | | | | | | | | | | Resubmit of http://codereview.chromium.org/9026001/ BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8989052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116259 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert the disk_cache change part of ↵jhawkins@chromium.org2012-01-041-17/+5
| | | | | | | | | | | | | | | http://codereview.chromium.org/9035012" The hanging test is unrelated to this change (it's merely tickled by a potential timing change). BUG=50346 TEST=none TBR=awong Review URL: http://codereview.chromium.org/9088002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116252 0039d316-1c4b-4281-b951-d872f2087c98
* And now NewRunnableMethod(), you die.ajwong@chromium.org2012-01-041-3/+1
| | | | | | | | | | | Kill off NewRunnableMethod() and remove silly declarations of unused ScopedRunnableMethodFactory(s). BUG=none TEST=existing. Review URL: http://codereview.chromium.org/9034032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116250 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove callback_old.h.jhawkins@chromium.org2012-01-032-4/+2
| | | | | | | | | | BUG=none TEST=none R=groby,awong,csilv Review URL: http://codereview.chromium.org/9028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116169 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove OldCompletionCallback.jhawkins@chromium.org2012-01-033-68/+3
| | | | | | | | | | BUG=none TEST=none R=groby,awong,csilv Review URL: http://codereview.chromium.org/9064007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116158 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the disk_cache change part of http://codereview.chromium.org/9035012thakis@chromium.org2012-01-021-5/+17
| | | | | | | | | | | | The net unit tests have been red under windows tsan continuously since this landed. BUG=50346 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/9028008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116102 0039d316-1c4b-4281-b951-d872f2087c98
* Replace MessageLoop::DeleteSoon implementation with one that uses base::Bind.dcheng@chromium.org2011-12-301-2/+2
| | | | | | | | | | | | BUG=none TEST=none TBR=willchan,brettw,tony Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115997 Review URL: http://codereview.chromium.org/9004051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116026 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Fixed uninitialized member in ctorgroby@chromium.org2011-12-301-1/+2
| | | | | | | | | | | | | TBR=rtenneti@chromium.org CID=102867 BUG=none TEST=none Review URL: http://codereview.chromium.org/9034028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116010 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 20:03:24 +0000