summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Detect NULL characters in certificate Subject commonwtc@chromium.org2009-10-081-17/+87
| | | | | | | | | | | names. R=hawk BUG=24190 TEST=the X509CertificateTest.PaypalNullCertParsing test Review URL: http://codereview.chromium.org/261016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28434 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out some more ICU from base and into base/i18n.brettw@chromium.org2009-10-083-14/+43
| | | | | | | | | | | | | | | | | | | | This moves string_util_icu. I moved the number formatting function into base/i18n/number_formatting and just removed the other function in string_util_icu which was TrimWhitespaceUTF8. It is only used in a few places and isn't actually helpful (and the fact that it round-trips through UTF-16 is better for the caller to see). This takes out the sorting from the FileEnumerator. The comment says the sorting is not guaranteed. I moved it into file_util_icu as a standalone function for callers of FileEnumerator to call manually if they need sorted results. I modified the directory lister to use this sorting instead, and filed a bug on doing more optimal JS-based sorting. TEST=none BUG=none Review URL: http://codereview.chromium.org/267001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28405 0039d316-1c4b-4281-b951-d872f2087c98
* Make HttpResponseInfo pickle'able, just moves some code from HttpCache to ↵michaeln@google.com2009-10-083-124/+150
| | | | | | | | | | | HttpResponseInfo. TEST=none BUG=none Review URL: http://codereview.chromium.org/269012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28363 0039d316-1c4b-4281-b951-d872f2087c98
* Linux port for flip_session.mbelshe@chromium.org2009-10-072-18/+25
| | | | | | | | | | | | Several minor cleanups. BUG=none TEST=none Review URL: http://codereview.chromium.org/265004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28320 0039d316-1c4b-4281-b951-d872f2087c98
* Fix signed/unsigned mismatch for linuxmbelshe@chromium.org2009-10-071-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/261004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28319 0039d316-1c4b-4281-b951-d872f2087c98
* Change many of the int and uint32 uses to size_t.mbelshe@chromium.org2009-10-072-24/+24
| | | | | | | | | | | | | | | | | I think we should avoid using uint32 except where we're defining protocol elements which specifically are intended to be 32 bits. Using size_t for lengths is a good way to avoid any accidental signed/unsigned comparisons. This cleanup is a result of the linux port, which gets lots of unsigned/signed warnings (which we treat as errors). BUG=none TEST=none Review URL: http://codereview.chromium.org/263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28318 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off the X509Certificate::Verify call for non-Windows platformswtc@chromium.org2009-10-071-3/+5
| | | | | | | | | | | | because it hits a DCHECK failure in nss_ocsp.cc on Linux. TBR=abarth,ukai BUG=24038 TEST=Debug build of net_unittests should not hit a DCHECK failure in nss_ocsp.cc during the X509CertificateTest.PaypalNullCertParsing test. Review URL: http://codereview.chromium.org/270005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28270 0039d316-1c4b-4281-b951-d872f2087c98
* Add a certificate blacklist for Windows and put thewtc@chromium.org2009-10-072-0/+191
| | | | | | | | | | | | faux www.paypal.com certificate with a NULL byte on the blacklist. R=abarth BUG=24038 TEST=new unit test Review URL: http://codereview.chromium.org/261002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28265 0039d316-1c4b-4281-b951-d872f2087c98
* Linux port fixup.mbelshe@chromium.org2009-10-071-4/+4
| | | | | | | | | | | Remove unused local variables. BUG=none TEST=none Review URL: http://codereview.chromium.org/265005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28254 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the UrlToFilenameEncoder to be more cross platform.mbelshe@chromium.org2009-10-071-29/+30
| | | | | | | | | | | | | | | | | FilePath::StringType on linux is a std::string, while on Windows it is a std::wstring. The old implementation assumed wstrings. Rework the class to deal entirely with narrow strings (since wide-strings are not relevant for this utility). Note: This file is only used in some tools. BUG=none TEST=none Review URL: http://codereview.chromium.org/261001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28224 0039d316-1c4b-4281-b951-d872f2087c98
* Remove VLOG statements which aren't needed and don't work well in chrome.mbelshe@chromium.org2009-10-074-46/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/257074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28212 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments setting emacs and vim tab width and expansion variables.sgk@google.com2009-10-062-0/+12
| | | | | | | | BUG=none TEST=successful builds Review URL: http://codereview.chromium.org/256059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the timeout for TcpConnectJob from 60 seconds to 240 seconds.eroman@chromium.org2009-10-061-1/+8
| | | | | | | | BUG=23364 Review URL: http://codereview.chromium.org/255085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28087 0039d316-1c4b-4281-b951-d872f2087c98
* Initial CL for fixing some of the proxy auth issues.chron@chromium.org2009-10-066-3/+18
| | | | | | | | | | | | | | Auth_cache is contained in the http session. We need to share the http session with the parent profile request context in order to retain http authentication. Weirdly enough, Profile::GetDefaultRequestContext() is not the same as profile_->GetRequestContext(), It does NOT yet pop up a dialog if the user hasn't done so already. BUG=19581 TEST=Included. Review URL: http://codereview.chromium.org/241001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28086 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the maximum headers size from 32Kb to 256Kb.eroman@chromium.org2009-10-062-3/+3
| | | | | | | | BUG=22928 Review URL: http://codereview.chromium.org/242152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28079 0039d316-1c4b-4281-b951-d872f2087c98
* Add a response_info() accessor to URLRequest to get a reference to the ↵michaeln@google.com2009-10-052-0/+7
| | | | | | | | | | | net::HttpResponseInfo struct in it entirety. BUG=none TEST=URLRequestTestHTTP.ResponseHeadersTest Review URL: http://codereview.chromium.org/251082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28067 0039d316-1c4b-4281-b951-d872f2087c98
* Make the font sizes on about:net-internals consistent.evan@chromium.org2009-10-051-3/+4
| | | | | | | | Use the HTML5 doctype + 0.8em fonts + WebKit monospace workaround. Review URL: http://codereview.chromium.org/257050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28065 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Assert that socket() returns a successful value.jhawkins@chromium.org2009-10-051-3/+4
| | | | | | | | | CID=6383 BUG=none TEST=none Review URL: http://codereview.chromium.org/256055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28011 0039d316-1c4b-4281-b951-d872f2087c98
* Move the clipboard stuff out of base and into app/clipboard. I renamedbrettw@chromium.org2009-10-032-26/+2
| | | | | | | | | | | clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Review URL: http://codereview.chromium.org/260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
* Second try. r27819 was missing a null pointer check forwtc@chromium.org2009-10-021-38/+22
| | | | | | | | | | | | | | | | | | | | | the return value of CERT_GetCommonName, etc. Map SEC_ERROR_OCSP_BAD_HTTP_RESPONSE (-8073) to CERT_STATUS_UNABLE_TO_CHECK_REVOCATION. Change ParsePrincipal to take the decoded CERTName as argument. Use the NSS functions for getting the common name, locality name, state or province name, and country name because they escape the strings properly. R=dank BUG=none TEST=none (covered by existing unit tests) Review URL: http://codereview.chromium.org/255055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27903 0039d316-1c4b-4281-b951-d872f2087c98
* The Python test server now ignores querystrings params when serving local files.finnur@chromium.org2009-10-021-2/+8
| | | | | | | | | | | | | | | | I'm having no luck getting the try bots to recognize this change to the python file, so I am separating my already LG'ed changelist (http://codereview.chromium.org/246066) into two (this part and a followup patch) in the hopes that my tests (next CL) will succeed. I fixed our python test server to serve files even though there is a querystring in the url (the server basically just ignores the querystring). This is needed in my next cl because the html we serve has js that acts on data in the querystring. Also made it have the right content-header when serving xml files (text/html). TBR=aa BUG=None TEST=None Review URL: http://codereview.chromium.org/242120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27862 0039d316-1c4b-4281-b951-d872f2087c98
* Handle range request on a truncated entryhclam@chromium.org2009-10-023-3/+48
| | | | | | | | | | This change will doom the truncated entry and creates a new sparse entry. TEST=unit tests Review URL: http://codereview.chromium.org/251067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27859 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r27819 because it causes net_unittests to crash in thewtc@chromium.org2009-10-021-20/+38
| | | | | | HTTPSRequestTest.HTTPSGetTest test. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27821 0039d316-1c4b-4281-b951-d872f2087c98
* Map SEC_ERROR_OCSP_BAD_HTTP_RESPONSE (-8073) towtc@chromium.org2009-10-021-38/+20
| | | | | | | | | | | | | | | | | | CERT_STATUS_UNABLE_TO_CHECK_REVOCATION. Change ParsePrincipal to take the decoded CERTName as argument. Use the NSS functions for getting the common name, locality name, state or province name, and country name because they escape the strings properly. R=dank BUG=none TEST=none (covered by existing unit tests) Review URL: http://codereview.chromium.org/248028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27819 0039d316-1c4b-4281-b951-d872f2087c98
* Rename EscapeUrl and expand the code comment.brg@chromium.com2009-10-013-5/+5
| | | | | | | | BUG=none TEST=Escape.EscapeUrlEncodedData Review URL: http://codereview.chromium.org/257021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27782 0039d316-1c4b-4281-b951-d872f2087c98
* Handle reading to the end of a sparse entryhclam@chromium.org2009-10-013-1/+7
| | | | | | | | | | | | TEST=run chrome with --enable-byte-range-support --incognito and watch a video in http://tinyvid.tv/, seeking should be fine. http_cache::PartialData used to read a length of zero when reading has reached the end. The zero parameter will cause MemEntryImpl to complain about invalid argument, so early return for the case that we know we have nothing to read. Review URL: http://codereview.chromium.org/255034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27776 0039d316-1c4b-4281-b951-d872f2087c98
* The "Copy URL" link is always greyed out in the Chrome menu on popups ↵ericu@google.com2009-10-012-0/+24
| | | | | | | | | | | | | | [crbug.com/13488]. This turns out to be because it was never implemented. Tested manually on Windows; I'll test on Linux before submitting. BUG=13488 TEST=Tested manually on Windows and added a unit test for the new Clipboard function. Review URL: http://codereview.chromium.org/210042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27772 0039d316-1c4b-4281-b951-d872f2087c98
* Two features:mbelshe@google.com2009-10-014-14/+116
| | | | | | | | | | | | | | | | | | | | | | - Enable FLIP over SSL. - Rework the X-Associated-Content. The server can send us a list of subresources that it plans to push. The client will keep track of these in a pending list. If the client tries to request the resource before the server pushes it, the client will not issue the request, and will wait until the push stream arrives. Conversely, if the pushed stream arrives before the client makes a request for the resource, the stream is added to the pushed_streams list and waits for a FlipNetworkTransaction to arrive that wants it (this part of the logic was already in place). BUG=none TEST=none Review URL: http://codereview.chromium.org/249046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27746 0039d316-1c4b-4281-b951-d872f2087c98
* Add EscapeURL to the ASCII escape methods.EscapeURL escapes all forbidden ↵brg@chromium.com2009-10-013-1/+31
| | | | | | | | | | ascii characters in an URL and repalces spaces with '+'. Test=Escape.EscapeUrl BUG=23029 Review URL: http://codereview.chromium.org/244056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27713 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove a check for index < 0 because index is size_t and can never ↵jhawkins@chromium.org2009-09-301-2/+4
| | | | | | | | | | | be < 0. CID=5378 BUG=none TEST=none Review URL: http://codereview.chromium.org/242084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27671 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the ClientSocketFactory from the HttpNetworkTransactionmbelshe@google.com2009-09-306-139/+60
| | | | | | | | | | | constructor and instead get it from the HttpNetworkLayer. BUG=none TEST=none Review URL: http://codereview.chromium.org/244032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27660 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a virtual dtor to BaseTestServercpu@chromium.org2009-09-301-0/+2
| | | | | | | | | | | | | | | | - BaseTestServer already has virtual functions and clients that derive from it - Its tripping a magic checker that I am building BUG=none TEST=existing unit tests suffice TBR=tony Review URL: http://codereview.chromium.org/251045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27647 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding:mbelshe@google.com2009-09-301-1/+39
| | | | | | | | | | | | | | | Implement a readsize throttle within the TCP socket. Add a fieldgroup trial for testing it. BUG=none TEST=none Original Review URL: http://codereview.chromium.org/173259 Review URL: http://codereview.chromium.org/243038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27595 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27389.darin@chromium.org2009-09-301-6/+5
| | | | | | Review URL: http://codereview.chromium.org/246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the leak tracking of URLRequests.eroman@chromium.org2009-09-301-2/+3
| | | | | | | | | | | | | | This doesn't fix anything, it just prevents asserting (and consequently crashing) when the leak is observed, restoring the earlier behavior. There are already a couple of know leaks, so crashing during shutdown isn't real useful until the known issues are fixed. BUG=18372,23284 TBR=darin Review URL: http://codereview.chromium.org/255017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27586 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ExtensionApiTest.Toolstrip and add additional debug output.rafaelw@chromium.org2009-09-291-0/+1
| | | | | | | | | | This output is testing the prospect that the cause of the flakiness is a race to the IO thread between the renderer that is requesting a chrome-extension page and the message to insert the correct mapping to service the request. BUG=22668 Review URL: http://codereview.chromium.org/251025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27516 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: End the experiment and use the new evictionrvargas@google.com2009-09-295-96/+78
| | | | | | | | | | | | algorithm by default. BUG=none TEST=none Review URL: http://codereview.chromium.org/248022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27514 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid potential "NULL used as int" warnings by changing ASSERT_EQ(NULL, ...) ↵pkasting@chromium.org2009-09-296-39/+36
| | | | | | | | | to ASSERT_TRUE(... == NULL). Patch by Jacob Mandelson (see http://codereview.chromium.org/202057 ), r=me. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27511 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we leaked the decompressor state.mbelshe@google.com2009-09-281-0/+3
| | | | | | Review URL: http://codereview.chromium.org/243031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27433 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27379, in hopes of fixing browser_tests.senorblanco@chromium.org2009-09-281-5/+6
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that thread-safe reference counting is used withdarin@chromium.org2009-09-281-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits<T> to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted<T> and RefCountedThreadSafe<T>. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ScopedRunnableMethodFactory using WeakPtr.darin@chromium.org2009-09-252-20/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This required some changes to WeakPtr to support the addition of WeakPtrFactory::HasWeakPtrs(), which is used to implement ScopedRunnableMethodFactory::empty(). Now, the WeakReferenceOwner just holds a pointer to the Flag class, and the Flag holds a back-pointer that it can use to clear the WeakReferenceOwner's pointer when the Flag is destroyed. I use the null'ness of this back-pointer in place of the bool member that was previously used to indicate if the WeakReference is valid. It was also necessary to expose a HasOneRef method on RefCounted. I included one on RefCountedThreadSafe for completeness. Finally, I switched HttpCache over to using WeakPtr instead of RevocableStore so that I could delete RevocableStore. (I'm making this change to consolidate similar functionality.) R=abarth BUG=none TEST=none Review URL: http://codereview.chromium.org/235027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27287 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky FTPCacheURLCredentials test.thestig@chromium.org2009-09-251-2/+1
| | | | | | | | | BUG=23108 TEST=none TBR=senorblanco Review URL: http://codereview.chromium.org/243009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27254 0039d316-1c4b-4281-b951-d872f2087c98
* Add an additional test for dnsDomainIs() to verify that it doesn't simply ↵eroman@chromium.org2009-09-251-2/+3
| | | | | | | | | | | | match any substring. This is working correctly, but since it was failing in WinHTTP we should have a regression test. BUG=18511 Review URL: http://codereview.chromium.org/245008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27246 0039d316-1c4b-4281-b951-d872f2087c98
* Add an additional unit-test for when PAC script is missing newline.eroman@chromium.org2009-09-252-4/+26
| | | | | | | | | | This variation uses a statement without semi-colon, rather than a comment, as the last line. BUG=http://crbug.com/22864 Review URL: http://codereview.chromium.org/238004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27171 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back Markus's CL ( http://codereview.chromium.org/196053)jshin@chromium.org2009-09-252-37/+11
| | | | | | | | | BUG=none TEST=UI test and valgrind test pass TBR=markus Review URL: http://codereview.chromium.org/222031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27160 0039d316-1c4b-4281-b951-d872f2087c98
* When converting between units of time or data types of different precision,markus@chromium.org2009-09-242-11/+37
| | | | | | | | | | | | | | | | | | | we have to be careful to consistently round in the same direction. Timeout checks usually check if Now() is less or equal to a deadline in order to determine if a timeout has occurred. This correctly handles the case where actual sleep times are equal or longer than requested sleep times. But if we round down when setting the sleep delay, this can result in unnecessary and expensive looping. Make sure, we always round up when converting to a format with less precision. BUG=none TEST=none Review URL: http://codereview.chromium.org/196053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27146 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly talk to VMS servers (translate UNIX paths to VMS and vice versa).phajdan.jr@chromium.org2009-09-247-12/+445
| | | | | | | | | | | | This way we get a native VMS listing and not a UNIX emulation mode, which is slightly different than native UNIX and confuses the parser. TEST=Covered by net_unittests. BUG=22193 Review URL: http://codereview.chromium.org/215058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27129 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary fixes to enable link dependent objects.maruel@chromium.org2009-09-241-1/+1
| | | | | | | | BUG=22926 TEST=still builds Review URL: http://codereview.chromium.org/231020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27112 0039d316-1c4b-4281-b951-d872f2087c98
* oldpath is wchar_t, so use arraysize, not sizeof.mattm@chromium.org2009-09-241-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/209027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27104 0039d316-1c4b-4281-b951-d872f2087c98