| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Organization Issuing CA, Level 2
BUG=118081
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9677067
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9706002
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@126526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=116398
TEST=Set a SPDY proxy with a certificate error. Ensure that requests always get ERR_PROXY_CERTIFICATE_INVALID, even with several reloads.
Review URL: http://codereview.chromium.org/9600022
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9616050
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@125285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSS has a built-in cache, so rolling our own is redundant. Also the
chrome-side cache doesn't know about the NSS nick name field, and thus
may make wrong decisions in case of identical certificates tagged with
different nick names.
BUG=chromium-os:23478
TEST=Unit tests.
Review URL: http://codereview.chromium.org/9416029
TBR=mnissler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9531005
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@124095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
was sent.
BUG=115376
TEST=none
TBR=mattm@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9481020
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@123850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bound cert was sent.
BUG=115376
TEST=none
Review URL: http://codereview.chromium.org/9454025
TBR=mattm@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9478016
TBR=mattm@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9478017
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@123836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=115376
TEST=none
Review URL: http://codereview.chromium.org/9454025
TBR=mattm@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9478016
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@123833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=rsleevi@chromium.org
BUG=55520
TEST=visit https://juice.certum.pl/ on Linux (with NSS 3.12.10 or
newer) or Windows. Should see EV status and the certificate chain
should consists of three certificates, terminating in the root named
"Certum Trusted Network CA". This may not work on Windows.
Review URL: http://codereview.chromium.org/9347059
TBR=wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9416078
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@122906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Entries in create_stream_queues_ don't have a SpdyStream.
BUG=113935
R=willchan
TEST=network unit tests
Review URL: https://chromiumcodereview.appspot.com/9406029
TBR=rtenneti@google.com
Review URL: https://chromiumcodereview.appspot.com/9416041
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@122383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with command line option --use-spdy=flow-control.
The following are the two CL's that are related to spdy/2.1
http://codereview.chromium.org/8892026
http://codereview.chromium.org/9252029/
R=wtc
BUG=114105
TEST=test gmail, docs with spdy proxy enabled and disabled.
Review URL: http://codereview.chromium.org/9390027
TBR=rtenneti@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9418026
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@122380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114168
TEST=https://www.verisign.co.jp appears correctly regardless of system
locale. Additionally, net_unittests:X509TypesTest* should cover this.
Review URL: https://chromiumcodereview.appspot.com/9358080
TBR=rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9414018
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@122341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They will be updating their serving infrastructure in the coming months,
so this is acceptably short term. It's not clear whether they have
issues with False Start or record splitting.
BUG=113625
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9384017
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@121524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
current)
based on initial window size sent in settings frame from the server.
R=willchan
BUG=112778
TEST=network unit tests
Review URL: http://codereview.chromium.org/9346003
TBR=rtenneti@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9372001
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@121088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Always check the dictionary returned by SecTrustCopyExtendedResult for
kSecEVOrganizationName to determine EV status of a certificate. As of 10.7.3,
SecTrustCopyExtendedResult returns noErr and populates the CFDictionary even
for non-EV certificates, but will only include kSecEVOrganizationName for EV
certificates.
BUG=112443, 112582
TEST=Lock icon should only be shown in a green box with the organization name
for EV certificates, such as https://www.bankofamerica.com/. Non-EV
certificates, such as https://encrypted.google.com/, should only show a
lock icon, but no green bubble or organization name. Certificates with no
organization name, such as the one at https://dev.symvaro.com/ (cancel
authentication), should not cause a crash when clicking on the lock icon
to examine the Page Info bubble.
Review URL: https://chromiumcodereview.appspot.com/9325072
Review URL: https://chromiumcodereview.appspot.com/9340010
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
proxy settings changes.
This ended up being a use-after-free bug after all, as the memory allocator was
overwriting the sentinel value I was storing to indicate this, so I had
previously thought it was stray memory corruption. The problem was that the
GConf library was returning the same GConf client object multiple times, and
merely increasing the reference count. That's fine except that we were counting
on being able to stop incoming notifications by unreferencing it; however, this
only works when there is only one reference. So, as soon as you ended an
incognito session, any further changes to proxy settings would cause a crash.
We now explicitly stop the notifications before unreferencing the client.
BUG=75508
TEST=changing proxy settings after opening and closing an incognito window does not crash
Review URL: http://codereview.chromium.org/9309104
TBR=mdm@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9333013
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through HTTPS Proxies. This also changes the mechanism used
to restart HttpProxyClientSocket requests with auth. Previously
the transport socket would be Disconnected, and then re-Connected
(which was not implemented for SSLClientSockets). However, the
approach was problematic in the face of, for example, ipv6. The
new approach is to close the HttpProxyClientSocket, and request
a new socket from the pool.
Initially was http://codereview.chromium.org/8502024
which turned out to have problems with NTLM auth.
Review URL: http://codereview.chromium.org/9148011
TBR=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9310101
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=112328
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9316081
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=102968
TBR=rsleevi@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9159051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browsers and the specs slightly better.
There are two changes in this patch:
1) We now require disposition-type to match the RFC 2616 token production in
order to treat the response as an attachment (i.e., a download).
2) When there are multiple filename parameters, we now take the first one,
which maches our behavior prior to the new parser and matches what other
browsers do.
Review URL: http://codereview.chromium.org/9225046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This function is a trap. It's a quick-and-dirty parser that has many nutty
quirks. There's only one caller left, and that callers should really be using
a Content-Type-specific parser anyway.
Review URL: http://codereview.chromium.org/9296005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few more uses of the old Sleep(int ms) and PostDelayedTask()
interfaces slipped through since my last round of updates. Can you review
these?
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9104014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9159035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pending.
This is a speculative fix for bug 105320. The chain of events that could tickle this is:
1. A HttpNetworkTransaction is canceled while a Read is blocked.
2. When the transaction is deleted:
- It calls HttpPipelinedStream::Close(true), which queues tasks to evict the
other streams on the pipeline.
- It deletes the HttpPipelinedStream, which deletes the active
HttpStreamParser.
4. The response has already arrived and is already on the message queue. It
runs and tries to callback to the deleted HttpStreamParser. We likely crash.
5. The eviction tasks run and delete their streams, which allows the
HttpPipelinedConnectionImpl destructor to run, which closes the socket.
BUG=105320
TEST=net_unittests
Review URL: http://codereview.chromium.org/9223033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
introducing static initializers.
Member variables can stay TLS::Slots and their behavior doesn't change.
Static instances use TLS::StaticSlot instead.
Kind of like http://codereview.chromium.org/8491043 but for TLS.
BUG=none
TEST=none
TBR=agl
Review URL: https://chromiumcodereview.appspot.com/9297010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
X509CertificateTest.PublicKeyHashes.
This change disables a couple of tests that fails due ot an expired certificate.
TBR=agl
BUG=111893
TEST=make the "XP Tests (dbg)(2)" bot green.
Review URL: https://chromiumcodereview.appspot.com/9225052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Content-Disposition
Now that we have net::HttpContentDisposition to parse the Content-Disposition
header, BufferedResourceHandler::ShouldDownload shouldn't use its own ad-hoc
parser.
Review URL: http://codereview.chromium.org/9297039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chains.
NSS bug 721288 causes CERT_PKIXVerifyCert to continue extending the
certificate chain after it has reached a root certificate. Detect that
bug and ignore such extraneous root certificates in certificate chains
when checking for weak signature algorithms.
R=rsleevi@chromium.org
BUG=108514
TEST=a new unit test (to be added) that uses the certificate chain sent
by https://images.etrade.wallst.com/ during SSL handshake.
Review URL: http://codereview.chromium.org/9271060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
after the certificate expires.
R=rsleevi@chromium.org
BUG=111742
TEST=net_unittests should pass
Review URL: http://codereview.chromium.org/9232067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=asanka
Review URL: http://codereview.chromium.org/9225035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=102816
BUG=
TEST=
Review URL: http://codereview.chromium.org/9298034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9225012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9190027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=eroman@chromium.org
BUG=111640
Review URL: http://codereview.chromium.org/9225028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ide0e496c6919282ee707847c4d11db8a182eeac2
BUG=24403
TEST=Add a certificate. Ensure that it shows up when adding Wifi or VPN networks. Remove the certificate. Make sure it is no longer available when adding Wifi or VPN networks. Also, see issue.
Review URL: http://codereview.chromium.org/9280014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when we have a source to add.
R=eroman@chromium.org
BUG=111641
Review URL: http://codereview.chromium.org/9121055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9235084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We pass the vast majority of these tests. In a future CL, I will go through
and fix the ones where we disagree with tc2231 (as appropriate).
Review URL: https://chromiumcodereview.appspot.com/9121044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous, we were using GetHeaderParamValue to parse the Content-Disposition
header, which describes itself as a "quick and dirty implementation." After
this patch, we use more of our normal HTTP parsing machinery, making our
parsing much less quirky and better aligned with RFC 6266.
Some notes:
1) Many of the test cases for parsing the Content-Disposition header included
the string "Content-Disposition: " in the input. I've looked through all
of the callers of these functions, and that seems to be completely bogus.
The old parser wasn't careful enough to see that as a problem, but the new
one follows the spec more closely. I've updated the test cases to remove
this string.
2) After this patch, there's a bunch of code in net_util.cc that really should
be moved to http_content_disposition.cc. I didn't move that code in this
patch because I didn't want this path to be too large. I'll move it in a
future patch.
3) In a future patch, I'll audit the codebase for callers of
GetHeaderParamValue. With any luck, we'll be able to remove them all and
delete this less-than-amazing function.
BUG=65423
Review URL: http://codereview.chromium.org/9234055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This API wasn't tested at all.
BUG=72001
TEST=net_unittests
Review URL: http://codereview.chromium.org/9169091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes to SPDY code to support enabling or disabling
flow_control independent of NPN protocol negotiated.
TEST=network unit tests
R=wtc
Review URL: http://codereview.chromium.org/9252029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=100673
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9290029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting
new users.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9117038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9288034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=102809
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9289026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsClient::Request ==> DnsTransaction
DnsTransaction ==> DnsTransactionImpl
DnsClient ==> DnsTransactionFactory
BUG=109949
TEST=net_unittests --gtest_filter=Dns*
Review URL: http://codereview.chromium.org/9190031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=102811
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9271046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107056
TEST="Delete cookies and other site and plug-in data" option in Clear
Browsing Data dialog should clear origin bound certs.
Review URL: https://chromiumcodereview.appspot.com/9120001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(broke in r108543).
Refactor test DB code so that nss_util owns the test DB dir.
Keeping the test DB dir until exit prevents later tests that would use the test DB from failing. The dir will still be deleted by the LazyInstance atexit handler.
BUG=108748
TEST=see bug
Review URL: http://codereview.chromium.org/9255034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110798
TEST=net_unittests
Review URL: http://codereview.chromium.org/9113036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118965 0039d316-1c4b-4281-b951-d872f2087c98
|