| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Originally, testserver was sending "Content-type: text/html" header regardless
of a file extension, due to a bug in TestPageHandler.GetMIMETypeFromName.
Patch by Yuta Kitamura <yutak@google.com>.
Original code review: <http://codereview.chromium.org/100357>
Review URL: http://codereview.chromium.org/115058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9952
TEST=none
Review URL: http://codereview.chromium.org/115006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When testing IPv4 addresses, use a pass-through
HostMapper. The previous version wasn't actually testing
anything, because there's a default HostMapper which maps
all unknown inputs to 127.0.0.1
- Make sure bare IPv6 literals can be resolved. This was
going to handle [brackets], but we've decided these should
be stripped at a higher layer.
- Add an empty address test.
The patch is contributed by Paul Marks of Google.
Original review: http://codereview.chromium.org/113026
R=wtc
BUG=N/A
TEST=N/A
Review URL: http://codereview.chromium.org/113066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
races.
Patch by Stephane Doyon.
BUG=11442
Review URL: http://codereview.chromium.org/109040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
This is an initial codebase - there is a lot of work to do.
But I wanted to get an initial version checked in.
http://crbug.com/6754
Review URL: http://codereview.chromium.org/99333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after failing to map the index file.
BUG=11414
TEST=none
Review URL: http://codereview.chromium.org/100349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
on different threads safe.
BUG=11323
Review URL: http://codereview.chromium.org/102023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a tiny bug, where we were consulting gnome's settings
based on whether the DESKTOP_SESSION *wasn't* gnome.
TEST=Covered by new unit test.
Review URL: http://codereview.chromium.org/100318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I now have accumulated too many evolutions of histograms for SDCH,
and it is getting harder to pull out the most recent set from the
lengthly list (and confusing other folks). I've created a new
prefix of "Sdch2." rather than "Sdch." for all the histogram
names.
I also include a few lint fixups on DCHECKs.
r=rafaelw
Review URL: http://codereview.chromium.org/100275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for file download via context-menu.
For a download initiated with a click on a link in a web page, a webkit-side change is necessary, which will be done later.
Add a field (referrer_charset) to URLRequestContext and DownloadCreateInfo. It's set to the character encoding of a document where the download request originates from when it's known (download initiated via "save as" in the context menu).
If it's not known (a download initiated by clicking on a download link or typing a url directly to the omnibox), it's initialized to the default character encoding in the user's preference. I guess this is marginally better than leaving it empty (in that case, step 2b below will be skipped and step 2c will be taken) because a user has a better control over how raw 8bit characters in C-D are interpreted (especially on Windows where a reboot is required to change the OS default codepage).
This is later passed to GetSuggestedFilename and used as one of fallback encodings (1. UTF-8, 2. origin_charset, 3. default OS codepage). With this change, we support the following:
1. RFC 2047
2. Raw-8bit-characters : a. UTF-8, b. origin_charset, c. default os codepage.
3. %-escaped UTF-8.
In this CL, for #3, I didn't add a fallback similar to one used for #2. If necessary, it can be added easily. New entries are added to 3 existing tests. What's previously not covered (raw 8bit Content-Disposition header) is now covered in all 3 tests.
BUG=1148
TEST=net unit test: NetUtilTest.GetFileNameFromCD
NetUtilTest.GetSuggestedFilename
unittest : DownloadManagerTest.TestDownloadFilename
Review URL: http://codereview.chromium.org/83002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On POSIX systems, system calls can be interrupted by signals. In this
case, they'll return EINTR, indicating that the system call needs to
be restarted.
(The situation is a little more complicated than this with SA_RESTART,
but you can read man 7 signal if you like.)
The short of it is that you need to catch EINTR and restart the call
for these system calls:
* read, readv, write, writev, ioctl
* open() when dealing with a fifo
* wait*
* Anything socket based (send*, recv*, connect, accept etc)
* flock and lock control with fcntl
* mq_ functions which can block
* futex
* sem_wait (and timed wait)
* pause, sigsuspend, sigtimedwait, sigwaitinfo
* poll, epoll_wait, select and 'p' versions of the same
* msgrcv, msgsnd, semop, semtimedop
* close (although, on Linux, EINTR won't happen here)
* any sleep functions (careful, you need to handle this are restart
with different arguments)
We've been a little sloppy with this until now. This patch adds a
macro for dealing with this and corrects every case of these system
calls (that I found).
The macro is HANDLE_EINTR in base/eintr_wrapper.h. It's safe to
include on Windows and is a no-op there.
On POSIX, it uses GCC magic to return the correct type based on the
expression and restarts the system call if it throws EINTR.
And you can use it like:
HANDLE_EINTR(close(fd));
Or:
ssize_t bytes_read = HANDLE_EINTR(read(fd, buffer, len));
*BEWARE* that it will evaluate the argument multiple times, so this is
not safe:
HANDLE_EINTR(close(FireMissiles()));
http://groups.google.com/group/chromium-dev/browse_thread/thread/41a35b2a457d73a0
http://codereview.chromium.org/100225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to DoHandshakeReadComplete() is performed somewhere else
than on DoHandshakeRead().
BUG=11296
TEST=navigate to an SSL page (see the bug, and
crbug.com/1135 for a simpler test case).
Review URL: http://codereview.chromium.org/100269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After we're sure we can do SDCH compression to a given URL, toss
a 50-50 coin each time we have a chance to advertise SDCH, and
either completely avoid advertisement, or advertise (including
the dictionary). Histogram both compression download times, as
well as the download times for the "completely avoid" case.
http://crbug.com/11236
bug=11236
r=wtc,openvcdiff
Review URL: http://codereview.chromium.org/100004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpNetworkTransaction (to the Socket class).
This is the first step to remove the blocking call on the
destructor of the network transaction, from IO thread.
BUG=9258
R=wtc
Review URL: http://codereview.chromium.org/87073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is established.
Review URL: http://codereview.chromium.org/99205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Move linux version of X509Certificate::IsEV in x509certificate_nss.cc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added range request support in URLRequestFileJob to respect
"Range" HTTP header. Fail with ERR_REQUESTED_RANGE_NOT_SATISFIABLE
if range is bad.
The following range request modes are supported:
1. Fully specified: bytes=x-y
2. With first byte position only: bytes=x-
3. With suffix length: bytes=-y
Multiple ranges in a single request is not supported as we need to multipart
encoding..
Last review was here: http://codereview.chromium.org/92149
Review URL: http://codereview.chromium.org/102006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
sockets with pending IO.
BUG=9258
Review URL: http://codereview.chromium.org/100129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r14799, as it broke linux ui tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added range request support in URLRequestFileJob to respect
"Range" HTTP header. Fail with ERR_REQUESTED_RANGE_NOT_SATISFIABLE
if range is bad.
The following range request modes are supported:
1. Fully specified: bytes=x-y
2. With first byte position only: bytes=x-
3. With suffix length: bytes=-y
Multiple ranges in a single request is not supported as we need to multipart encoding..
Review URL: http://codereview.chromium.org/92149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rolling forward v8 version to pull in one with v8.gyp.
Review URL: http://codereview.chromium.org/100076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Parses "Range" HTTP request header so this request information
can be used in URLRequestFileJob and HttpCache.
Review URL: http://codereview.chromium.org/92006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'm preparing to move some of this functionality out to a HttpStream object or something. I'm hindered here by the mutation of state in functions that seemingly should be const. I've refactored some code into non-member functions to make the dependencies more explicit. This will make it easier for me to pull some of this code out.
Also dropped the net:: qualifiers in the unittest.
TESTED=Ran net_unittests
Review URL: http://codereview.chromium.org/100001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only small changes to the V8 code base itself. The main reason for
this push is to get the V8 latest builder working again and to move
the v8.gyp file to the v8 sources to make DEPS rolls easier.
Updated all references to v8.gyp and the generated projects. Added a
missing dependency to chrome.sln: mksnapshot depends on v8_nosnapshot.
Review URL: http://codereview.chromium.org/100037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
socket because CancelIo doesn't work when there is a Winsock
layered service provider.
R=rvargas,darin
BUG=9258
TEST=Doing web searches from the Omnibox will exercise the
code. Clicking a link on a page that is still loading will
also exercise the code. The browser should stay responsive.
Review URL: http://codereview.chromium.org/99025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SDCH might compress so well, that the return of the ack
may come late, and a server may stall on a congestion
window limitation. This set of histograms is intended
to track that issue during SDCH experimentation.
r=huanr
Review URL: http://codereview.chromium.org/92139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Parse "Content-Range" header in HttpResponseHeaders according to
RFC 2616 14.16.
Review URL: http://codereview.chromium.org/88068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Enable the new eviction algorithm for 10% of the current
users on the dev channel.
Review URL: http://codereview.chromium.org/79064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add a 'javascript_engine' variable to control that setting
(as well as whether we use v8.gyp at all).
Review URL: http://codereview.chromium.org/88070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Set $RPATH to $LIB_DIR in the SCons configuration.
* Add missing dependencies:
* net/net.gyp:net
=> testing/gtest.gyp:gtest
* third_party/libxml/libxml.gyp:xmlcatalog
=> third_party/icu38/icu38.gyp:icuuc
* chrome/chrome.gyp:perf_tests
=> renderer
=> views
=> webkit/webkit.gyp:glue
* Add files:
* third_party/WebKit/WebCore/loader/icon/IconRecord.cpp
* third_party/WebKit/WebCore/page/Coordinates.cpp
* skia/sgl/SkUnPreMultiply.cpp
* Exclude on Linux:
* chrome/views/controls/scroll_view.cc
* chrome/views/focus/external_focus_tracker.cc
* media/filter/ffmpeg_demuxer.{cc,h}
* Remove files:
* third_party/WebKit/WebCore/Configurations/Version.xcconfig
* Sort the chrome.gyp:views linux exclusion list.
* DEPS roll for $SHLINKFLAGS settings in gyp.
Review URL: http://codereview.chromium.org/88058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
response header.
Log an INFO message whenever we receive an auth challenge.
R=eroman
BUG=8771
Review URL: http://codereview.chromium.org/67117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in the normal case, with a non-zero-length response body.
R=eroman
BUG=9880
Review URL: http://codereview.chromium.org/67129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing histogram appears ot have too much "noise" introduced
by including existing connections. The goal is to quantify
impact of DNS prefetching via an experiment, and this should
produce more focused info for that FieldTrial.
r=willchan
Review URL: http://codereview.chromium.org/90005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
linux ProxyConfigService.
BUG=8143
Review URL: http://codereview.chromium.org/73038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=openvcdiff
Review URL: http://codereview.chromium.org/67286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Currently this FieldTrial is measuring the transaction latencies of requests, separated into frame/subframe requests vs subresource requests. We run a 2% holdback experiment where the people in the holdback don't have http prioritization enabled. Add class static method to ResourceDispatcherHost to disable http prioritization.
BUG=10486
Review URL: http://codereview.chromium.org/67119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This is a revert of r13987. There is a 3 line fix in Write() with s/read_watcher_/write_watcher_/, s/read_callback_/write_callback_/ etc.
Review URL: http://codereview.chromium.org/79076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Establishes a ProxyConfig by reading settings from gconf or consulting
environment variables.
BUG=8143
Thanks to ermilov.maxim@gmail.com for his contribution: some ideas<
and code snippets from his patch were folded into this one.
(See http://codereview.chromium.org/49009)
Review URL: http://codereview.chromium.org/60009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Comment came back after landing a related CL earlier. This is
the assert, and teh comment per reviewer request.
r=openvcdiff
Review URL: http://codereview.chromium.org/79063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/77036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move tcp_client_socket.h stuff to tcp_client_socket_libevent.h and
tcp_client_socket_win.h.
Add tests.
Review URL: http://codereview.chromium.org/75030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some servers are splitting packets in SDCH responses, and we need to
be more careful about gathering counts with underfilled packets.
r=huanr,openvcdiff
Review URL: http://codereview.chromium.org/67254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cl 13909 added more tests that intentionally leak memory.
see http://codereview.chromium.org/79031
TBR=nsylvain
Review URL: http://codereview.chromium.org/77010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13913 0039d316-1c4b-4281-b951-d872f2087c98
|