| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
R=ian
BUG=22679
TEST=https://nerys.wellsfargo.com/test.html should have the
EV status. Make sure "Check for server certificate revocation"
is enabled in the Options menu.
Review URL: http://codereview.chromium.org/342061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VERIFY_REV_CHECKING_ENABLED flag. This allows us to enable
part of the X509CertificateTest.PaypalNullCertParsing test
for Linux because the test disables revocation checking,
thereby avoiding the overly strict assertion in nss_ocsp.cc.
Enable cert_pi_useAIACertFetch to fetch missing
intermediate CA certificates.
Handle a non-certificate error reported by PKIXVerifyCert.
R=ukai
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/333033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/348021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/342057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/350001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Finish() when entered bad state.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/345025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
error status will be reported to the delegate (e.g. websocket experiment task)
Finish() should be called at most once when STATE_CLOSE to STATE_NONE.
BUG=none
TEST=net_unittests didn't crash.
Review URL: http://codereview.chromium.org/347026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/342050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
error status will be reported to the delegate (e.g. websocket experiment task)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/346010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also backs out r26610 (these are the changes to host_resolver_impl.cc), since that code is no longer necessary if LoadLog is refcounted thread safe.
LoadLog itself is not thread safe -- however making its refcounting threadsafe simplifies passing it across thread boundaries.
Initially I had avoided doing this, and instead was trying to be very careful in when callers would AddRef/Release to avoid races.
This approach however turned out to be fragile, and it was difficult to chase down all of the dependencies (they just kept popping up).
So now I am changing that decision, and opting for the simpler approach which will be much more robust.
The performance impact should be negligable.
BUG=22272
Review URL: http://codereview.chromium.org/347021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
its own file, and have it carry a FlipStream pointer.
The PrioritizedIOBuffer was more generic, but after we queued IO,
we couldn't track which stream should be notified about the IO
completion. Having it carry the FlipStream pointer will enable
IO tracking, but with a FlipStream pointer, it is really specific
to Flip, so I renamed to FlipIOBuffer. I could have kept a generic
(void*) pointer (or used a template), but that seemed unnecessary
in this case.
This CL just changes the refactoring. Will remove the
PrioritizedIOBuffer next.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/340031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/294025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
BUG=25520
Review URL: http://codereview.chromium.org/343022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
its own files. This is a straight refactoring with no other
changes
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/348007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the unit test as well.
BUG=none
TEST=flip_transaction_unittest.cc
Review URL: http://codereview.chromium.org/340025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mapped to SEC_E_ILLEGAL_MESSAGE.
R=willchan
BUG=19255
TEST=none
Review URL: http://codereview.chromium.org/345018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to AcquireCredentialsHandle to cause the TLS certificate
status request extension (commonly known as OCSP stapling)
to be sent on Windows Vista or later. I don't know if this
is all we need to do to enable OCSP stapling though.
R=hawk
BUG=26013
TEST=none
Review URL: http://codereview.chromium.org/329042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/22623
TEST=Browse to https://www.bankalbilad.com.sa/retail/logon.do. It should fallback from TLS to SSL and thus properly display the page instead of showing an error.
Review URL: http://codereview.chromium.org/347011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24687
TEST=unit tests still pass
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
speedup test.
BUG=24687
TEST=unit tests still pass
Review URL: http://codereview.chromium.org/345012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Document the API for FlipDelegate in flip_session.h.
Remove the method OnCancel, since it was not needed.
Add the method OnBodySent, which is not yet used but will
be.
FlipNetworkTransaction is a FlipDelegate, so the changes
there are just to reflect the new API.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/339047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
start==0 and end==9223372036854775807, i.e. the full positive range of a
64-bit signed int.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/346003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
BUG=25520
TBR=eroman
Review URL: http://codereview.chromium.org/344015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added parser for "ls" listing style, and tests. This is not yet used by the browser (will do that in a following CL).
TEST=Covered by net_unittests.
BUG=25520
Review URL: http://codereview.chromium.org/244008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as the FLIP client reads. Then, enable the use of the
CONTROL_FLAG_FIN on a request which has no data.
Added a new test for a POST. The test passes today, but I
will make it stronger with my next pass at fully implementing
POST.
POST uploads are still not complete
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/338055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If X509Certificate is created in URLRequestAutomationJob or
URLRequestInterceptJob, cert_handle_ is NULL.
So if such certificate is being to be verified (not sure it happens), it would cause crash or some
problem.
BUG=15614
TEST=none
Review URL: http://codereview.chromium.org/329036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/341006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25826
TEST=none
Review URL: http://codereview.chromium.org/338049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
allowed hyphens, to match real-world needs.
I don't believe further loosening will be required but that data will hopefully be coming soon. In the meantime people are asking for this fix.
BUG=25714
TEST=Entring "a_b.com" in the omnibox should default to navigate, not search
Review URL: http://codereview.chromium.org/339017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
path (like "C:\foo\bar"). The current code was attempting to
append "c:\foo\bar" to "\\?\" for long filename support. Reworked
so that this could work. I feel back about using the ToWStringHack()
function, but there is literally no other choice.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/337033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/data-race-test/issues/detail?id=11
TEST=net_unittests should become green on TSAN Mac bot
TBR=dank
Review URL: http://codereview.chromium.org/339025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/330016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25873
TEST=unittest
Review URL: http://codereview.chromium.org/330026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It would work with:
dump_cache.exe foo bar baz
But it would fail with:
dump_cache foo bar baz
The latter caused an odd crash which was all too difficult to
find!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/330024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following descriptions were taken from <http://blogs.msdn.com/wndp/articles/IPV6_PAC_Extensions_v0_9.aspx>
----------------------------
* myIpAddressEx():
Returns a semi-colon delimited string containing all IP addresses for localhost (IPv6 and/or IPv4), or an empty string if unable to resolve localhost to an IP address.
* dnsResolveEx(host):
Returns semi-colon delimited string containing IPv6 and IPv4 addresses or an empty string if host is not resolvable.
* isResolvableEx():
Returns TRUE if the host is resolvable to a IPv4 or IPv6 address, FALSE otherwise.
----------------------------
These differ from the vanilla PAC functions in the following ways:
* myIpAddressEx() returns all the addrsses for localhost (including IPv6 ones), whereas myIpAddress() only returns the first IPv4 one.
* On failure, myIpAddress() returns "127.0.0.1" whereas on failure myIpAddressEx() returns empty string.
* dnsResolveEx() returns a list of addresses (including IPV6 ones), whereas dnsResolve() only returns the first IPv4 address.
* On failure, dnsResolve() returns |null|, whereas on failure dnsResolveEx() returns empty string.
BUG=25407
TEST=ProxyResolverV8Test.DNSResolutionFailure, ProxyResolverJSBindingsTest.RestrictAddressFamily, ProxyResolverJSBindingsTest.ExFunctionsReturnList
Review URL: http://codereview.chromium.org/333006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a ctor for creating a CommandLine for carrying arguments;
convert all the users to either that or the FilePath version.
BUG=24672
Review URL: http://codereview.chromium.org/329017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/297015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25823
TEST=HostCacheTest.KeyComparator
Review URL: http://codereview.chromium.org/338023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
HostResolver::SetDefaultAddressFamily(), to make it more general.
This came up in a codereview comment, but was after I had checked in.
Review URL: http://codereview.chromium.org/303026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because we get CERT_RDN_ENCODED_BLOB on machines patched for the
CryptoAPI ASN.1 security vulnerabilities.
R=rvargas
BUG=24190
TEST=the X509CertificateTest.PaypalNullCertParsing test
in net_unittests (debug build) should not hit a NOTREACHED()
assertion failure when running on a patched Windows machine.
Review URL: http://codereview.chromium.org/337014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when they belong to a doomed entry.
BUG=25588
TEST=unittests
Review URL: http://codereview.chromium.org/335015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ThreadSanitizer hang.
Usually, if several tests hang in the same way, that means there's some common code between them that makes TSAN's address space manager unhappy.
Then it's likely that a new test from the same test case exploits the same code and breaks ThreadSanitizer again.
BUG=http://code.google.com/p/data-race-test/issues/detail?id=11
TBR=dank
Review URL: http://codereview.chromium.org/335024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If Read in DoReadWrite succeeded synchronously, it failed to call next Read.
Changed to call Read repeatedly after a Read finished both in synchronous return and asynchronous return.
Also fixes Write case as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/326009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG:25748
Review URL: http://codereview.chromium.org/334021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
but they do measure accurately.
Also add some minor cleanup to the FlipSession and added
a new test. There is a lot more cleanup to do in FlipSession.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/333009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
names list copy.
Patch by Jaime Soriano <jsorianopastor@gmail.com>.
Original review URL: http://codereview.chromium.org/302004
R=wtc
BUG=16830
TEST=Try to connect to a web page that requires SSL authentication and
confirm that it connects if and only if a valid certificate is stored in
.pki/nssdb database.
Review URL: http://codereview.chromium.org/329015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a CHECK
BUG=25554
TEST=none
Review URL: http://codereview.chromium.org/327005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
makes the naming of string_escape more clear (it's actually JSON-specific).
Move the files into the base namespace.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/316016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These were erroneously removed in r29702 and broke the system library build.
http://codereview.chromium.org/337003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29907 0039d316-1c4b-4281-b951-d872f2087c98
|