summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Update to NSS 3.12.9. falsestart.patch, falsestart2.patch, andwtc@chromium.org2011-02-1817-594/+22
| | | | | | | | | | | | | | | weakserverkey.patch have been upstreamed. SSL_ERROR_WEAK_SERVER_KEY has been renamed SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY. Pick up fixes for two bugs: - https://bugzilla.mozilla.org/show_bug.cgi?id=586697 - https://bugzilla.mozilla.org/show_bug.cgi?id=588698 R=agl BUG=none TEST=none Review URL: http://codereview.chromium.org/6487026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75446 0039d316-1c4b-4281-b951-d872f2087c98
* Removing AccessLog class. This is a partial revert of yzshen's r74872.joi@chromium.org2011-02-182-69/+1
| | | | | | | | | | | | | | | | | | | | The AccessLog class was something we added to track down a crash, which is no longer happening after that change. Reverting piece by piece and waiting for the next canary build before doing the next part. Note that the use of the AccessLog class could have introduced slight serialization to the method URLRequestThrottlerManager::RegisterRequestUrl as it would call the AccessLog::Add method which synchronized on a lock. So removing is not 100% safe; I will watch for crashes in the canary builds after this. BUG=71721 TEST=none Review URL: http://codereview.chromium.org/6538061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75438 0039d316-1c4b-4281-b951-d872f2087c98
* Add field trial for A/B testing of SSL False Start.mbelshe@chromium.org2011-02-181-0/+14
| | | | | | | | | | | | | Enable two histograms for measurement: - measure PLT differences - measure SSL_Connect_Latency conditioned on the test. BUG=none TEST=none Review URL: http://codereview.chromium.org/6544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75402 0039d316-1c4b-4281-b951-d872f2087c98
* Check and invalidate cached credentials if they were used for preemptive ↵asanka@chromium.org2011-02-187-25/+84
| | | | | | | | | | | authentication and were rejected by the server. BUG=72589 TEST=net_unittests --gtest_filter=HttpAuthHandler*.HandleAnotherChallenge Review URL: http://codereview.chromium.org/6525035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75390 0039d316-1c4b-4281-b951-d872f2087c98
* Add stats-table counters to the disk cache so we can expose stats throughmbelshe@chromium.org2011-02-181-0/+3
| | | | | | | | | | | the benchmark lab. BUG=none TEST=none Review URL: http://codereview.chromium.org/6519042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75364 0039d316-1c4b-4281-b951-d872f2087c98
* Update the NSS patches. Add snapstart2.patch and peercertchain.patch.wtc@chromium.org2011-02-176-32/+243
| | | | | | | | | | | | | | | Tweak sslimpl.h to eliminate one conflict when applying clientauth.patch. Unfortunately one conflict in sslimpl.h and one conflict in ssl3con.c still remain in clientauth.patch. Add the applypatches.sh script to make it easier to apply the patches. R=agl BUG=none TEST=none Review URL: http://codereview.chromium.org/6538005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75311 0039d316-1c4b-4281-b951-d872f2087c98
* HSTS: add net-internals UI.agl@chromium.org2011-02-176-24/+119
| | | | | | | | | | | | | | This change adds a simple DOMUI interface to the HSTS list. Since the list is stored, hashed in memory and on disk, there's no list of entries. But the set can be queried and we can provide insertion and deletion. BUG=none TEST=Open about:net-internals, goto HSTS tab. Review URL: http://codereview.chromium.org/6500010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75282 0039d316-1c4b-4281-b951-d872f2087c98
* New policy protobuf protocol.jkummerow@chromium.org2011-02-172-4/+3
| | | | | | | | | | | | | | | (Third attempt to land http://codereview.chromium.org/6409040/ -- now without memory leaks) - cloud_policy.proto autogenerated from policy_templates.json - C++ method decoding the protobuf also autogenerated from policy_templates.json - changed policy fetching mechanism to fetch new-style policy protobufs BUG=68309, chromium-os:11253, chromium-os:11255 TEST=CloudPolicyCacheTest.*; also manual test against python testserver Review URL: http://codereview.chromium.org/6532019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75259 0039d316-1c4b-4281-b951-d872f2087c98
* Add unique identifier to url requestsjochen@chromium.org2011-02-173-1/+30
| | | | | | | | | BUG=60101 TEST=net_unittests Review URL: http://codereview.chromium.org/6526014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75241 0039d316-1c4b-4281-b951-d872f2087c98
* Include subdomains in the *.google.com HSTS entries.cevans@chromium.org2011-02-171-3/+3
| | | | | | | | | | | | | | | It is neccessary in order to fully protect against "Cookie Forcing": http://scarybeastsecurity.blogspot.com/2008/11/cookie-forcing.html (The attack would otherwise be: 302 the user to http://blah.checkout.google.com/ and then respond with a Set-Cookie for the .checkout.google.com domain, in order to mess with the integrity of that domain via cookie collisions). BUG=none TEST=none Review URL: http://codereview.chromium.org/6529048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75231 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Always initialize disabled_rvargas@google.com2011-02-161-0/+2
| | | | | | | | | BUG=73129 TEST=none Review URL: http://codereview.chromium.org/6529056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75203 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: More files for unit tests.rvargas@google.com2011-02-166-0/+166
| | | | | | | | | | BUG=62085 TEST=none TBR=gavinp@chromium.org Review URL: http://codereview.chromium.org/6519028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75202 0039d316-1c4b-4281-b951-d872f2087c98
* Add the NSS patch for SSL client auth with native crypto APIs on Macwtc@chromium.org2011-02-163-99/+708
| | | | | | | | | | | | and Windows. The original dheclientauth.patch is subsumed by this patch because it is hard to separate the two patches. R=rsleevi BUG=37560,45369,62027 TEST=none Review URL: http://codereview.chromium.org/6528039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75191 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74842willchan@chromium.org2011-02-169-97/+111
| | | | | | | | | | | Merged correctly this time. BUG=none TEST=none Review URL: http://codereview.chromium.org/6523067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75165 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75143 - Reland r74842willchan@chromium.org2011-02-169-111/+97
| | | | | | | | | | | | | | The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6526029 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6480120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75152 0039d316-1c4b-4281-b951-d872f2087c98
* Remove whitespace at the end of lines.wtc@chromium.org2011-02-161-4/+4
| | | | | | | | | R=rsleevi BUG=37560,45369,62027 TEST=none Review URL: http://codereview.chromium.org/6525042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75151 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74842willchan@chromium.org2011-02-169-97/+111
| | | | | | | | | | | The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6526029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75143 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75106 - New policy protobuf protocol.jkummerow@chromium.org2011-02-162-3/+4
| | | | | | | | | | | | | | | | | (Second attempt to land http://codereview.chromium.org/6409040/) - cloud_policy.proto autogenerated from policy_templats.json - C++ method decoding the protobuf also autogenerated from policy_templates.json - changed policy fetching mechanism to fetch new-style policy protobufs BUG=68309, chromium-os:11253, chromium-os:11255 TEST=CloudPolicyCacheTest.*; also manual test against python testserver Review URL: http://codereview.chromium.org/6523058 TBR=jkummerow@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75115 0039d316-1c4b-4281-b951-d872f2087c98
* New policy protobuf protocol.jkummerow@chromium.org2011-02-162-4/+3
| | | | | | | | | | | | | | | (Second attempt to land http://codereview.chromium.org/6409040/) - cloud_policy.proto autogenerated from policy_templats.json - C++ method decoding the protobuf also autogenerated from policy_templates.json - changed policy fetching mechanism to fetch new-style policy protobufs BUG=68309, chromium-os:11253, chromium-os:11255 TEST=CloudPolicyCacheTest.*; also manual test against python testserver Review URL: http://codereview.chromium.org/6523058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75106 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of custom PAC scripts in Proxy Settings API.battre@chromium.org2011-02-163-2/+56
| | | | | | | | | BUG=50725 TEST= Review URL: http://codereview.chromium.org/6504004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75102 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75082 - New policy protobuf protocol.jkummerow@chromium.org2011-02-162-3/+4
| | | | | | | | | | | | | | | - cloud_policy.proto autogenerated from policy_templates.json - C++ method decoding the protobuf autogenerated from policy_templates.json - changed policy fetching mechanism to fetch new-style policy protobufs BUG=68309, chromium-os:11253, chromium-os:11255 TEST=CloudPolicyCacheTest.*; also manual test against python testserver Review URL: http://codereview.chromium.org/6409040 TBR=jkummerow@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75084 0039d316-1c4b-4281-b951-d872f2087c98
* New policy protobuf protocol.jkummerow@chromium.org2011-02-162-4/+3
| | | | | | | | | | | | | - cloud_policy.proto autogenerated from policy_templates.json - C++ method decoding the protobuf autogenerated from policy_templates.json - changed policy fetching mechanism to fetch new-style policy protobufs BUG=68309, chromium-os:11253, chromium-os:11255 TEST=CloudPolicyCacheTest.*; also manual test against python testserver Review URL: http://codereview.chromium.org/6409040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75082 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: Compatibility fix for "ls -l" style directory listing parser.phajdan.jr@chromium.org2011-02-165-10/+13
| | | | | | | | | | | | | | | Some servers, for example smallftpd, add an empty line at the end of the listing. We should not fail on those. I think this bug was introduced in 2009 by http://codereview.chromium.org/449011 Now we have more test cases, and this change shouldn't introduce new compatibility problems. BUG=72060 TEST=net_unittests Review URL: http://codereview.chromium.org/6515009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75079 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Fix the initialization order of the backend.rvargas@google.com2011-02-162-5/+29
| | | | | | | | | | BUG=72963 TEST=net_unittests Review URL: http://codereview.chromium.org/6529007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75036 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unused PlatformAuthInfo structure definition.wtc@chromium.org2011-02-161-13/+0
| | | | | | | | | R=eroman,rsleevi BUG=71928 TEST=none Review URL: http://codereview.chromium.org/6524021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75032 0039d316-1c4b-4281-b951-d872f2087c98
* Enable sdch_filter_unittest to run on Linux by removing theadamk@chromium.org2011-02-152-5/+2
| | | | | | | | "MOZ_Z_" prefixes from zlib calls. Review URL: http://codereview.chromium.org/6525004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75016 0039d316-1c4b-4281-b951-d872f2087c98
* Directions for how to build SPDY dissector for Windows.cbentzel@chromium.org2011-02-151-0/+49
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6484045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74983 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call the zlib functions with the MOZ_Z_ prefixwtc@chromium.org2011-02-152-21/+6
| | | | | | | | | | | in the source code. R=agl,hclam,jar BUG=none TEST=No build or test failures Review URL: http://codereview.chromium.org/6529006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74975 0039d316-1c4b-4281-b951-d872f2087c98
* In spdy_session dont call CloseAllStreams if it hasrtenneti@chromium.org2011-02-151-3/+5
| | | | | | | | | | | | | | already been called (state_ is already CLOSED). We (willchan, Wan-Teh and I) would like to see if this change fixes the memory corruption bug (in Dev channel). BUG=65948 TEST=accessing google.com and gmail via https Review URL: http://codereview.chromium.org/6479010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74893 0039d316-1c4b-4281-b951-d872f2087c98
* Add checks to URLRequestThrottlerManager to help identify the cause of crashes.yzshen@chromium.org2011-02-142-17/+108
| | | | | | | | | BUG=71721 TEST=None Review URL: http://codereview.chromium.org/6474024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74872 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74842 - It seems to have broken the ChromeOS "PFQ bot"?willchan@chromium.org2011-02-149-111/+97
| | | | | | | | | | | | | | | | r74561 added a DCHECK to make sure users didn't try to access the ChromeURLRequestContextGetter from the Profile, since the Profile should only be read on the UI thread. ChromeOS apparently tried to access it from another thread, and therefore hit the new DCHECK. I'm relanding without the DCHECK. I'm also eagerly initializing the off the record context getter to prevent the ChromeOS race. ChromeOS should fix that code so the eager initialization isn't necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/6484041 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6517021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74848 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r74728 which reverted r74561 for exposing a ChromeOS bug.willchan@chromium.org2011-02-149-97/+111
| | | | | | | | | | | | | r74561 added a DCHECK to make sure users didn't try to access the ChromeURLRequestContextGetter from the Profile, since the Profile should only be read on the UI thread. ChromeOS apparently tried to access it from another thread, and therefore hit the new DCHECK. I'm relanding without the DCHECK. I'm also eagerly initializing the off the record context getter to prevent the ChromeOS race. ChromeOS should fix that code so the eager initialization isn't necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/6484041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74842 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r74632 "Reland r74561 after fixing ChromeOS build breakage."oshima@google.com2011-02-129-111/+97
| | | | | | | | | | | | This reverts commit f19e6d524e086ed8182a475680e931a9a870d2a8. TBR=willchan@chromium.org BUG=none TEST=chromeos pfq bot should cycle green Review URL: http://codereview.chromium.org/6512009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74728 0039d316-1c4b-4281-b951-d872f2087c98
* In Dev build, we would like to see if SSLClientSocketNSS objectrtenneti@chromium.org2011-02-122-6/+39
| | | | | | | | | | | | | | | | | is Connected and Disconnected on the same thread. Wan-Teh and I had thought it is more logical to disconnect the transport socket before closing the NSS SSL socket (and the underlying memory buffers). Test to see if this stops memory corruption crashes, will revert after a Dev release. BUG=65948 TEST=accessing google.com and gmail via https and sync'ing of personal stuff. Review URL: http://codereview.chromium.org/6474027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74717 0039d316-1c4b-4281-b951-d872f2087c98
* The current implementation of client authentication for Windows and Mac ↵rsleevi@chromium.org2011-02-125-214/+1
| | | | | | | | | | | | | matches the NSS implementation, in that it continously checks that the private key is still accessible. The intent is that once the user removes the private key (such as by ejecting a smart card, if it's stored on one), then the existing SSL sessions will become invalidated. However, depending on the smart card middleware, this may involve non-trivial work being done every SSL record, and may be causing a performance regression for authentication. The new behaviour is that any negotiated SSL connections remain valid, even after the smart card is ejected, and any established SSL sessions are not invalidated and may be reused. This matches the observed behaviours of IE and Safari. Smart card client auth on Linux is unaffected and will continue polling the smart card to determine if it's been ejected / the key has been deleted. BUG=71928 TEST=none Review URL: http://codereview.chromium.org/6413010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74716 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity UNINIT_CTOR defect in the HttpAuthCache::Entrywtc@chromium.org2011-02-111-1/+2
| | | | | | | | | | | | constructor. R=cbentzel CID=8793 BUG=none TEST=none Review URL: http://codereview.chromium.org/6492001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74672 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing with the out-of-lining of test code.erg@google.com2011-02-117-78/+166
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6485015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74660 0039d316-1c4b-4281-b951-d872f2087c98
* clang: Fix several -Woverloaded-virtual warnings.thakis@chromium.org2011-02-112-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Real bugs: net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:310:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>' requested here CaptureGroupNameHttpProxySocketPool::CaptureGroupNameSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:10: ./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:316:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>' requested here CaptureGroupNameSSLSocketPool::CaptureGroupNameSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:12: ./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:5511:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>' requested here new CaptureGroupNameTCPSocketPool(NULL, NULL); ^ In file included from ./net/socket/socket_test_util.h:34: ./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:5630:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>' requested here new CaptureGroupNameSOCKSSocketPool(NULL, NULL); ^ In file included from ./net/http/http_network_session_peer.h:11: ./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ CXX(target) out/Debug/obj.target/net_unittests/net/http/http_response_body_drainer_unittest.o 4 errors generated. net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:170:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>' requested here CapturePreconnectsHttpProxySocketPool::CapturePreconnectsSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:10: ./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:176:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>' requested here CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:12: ./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:188:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>' requested here new CapturePreconnectsTCPSocketPool( ^ In file included from ./net/socket/socket_test_util.h:34: ./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:237:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>' requested here new CapturePreconnectsSOCKSSocketPool( ^ In file included from net/http/http_stream_factory_unittest.cc:17: In file included from ./net/http/http_network_session_peer.h:11: ./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ CXX(target) out/Debug/obj.target/net_unittests/net/http/http_vary_data_unittest.o 4 errors generated. make: *** [out/Debug/obj.target/net_unittests/net/http/http_stream_factory_unittest.o] Error 1 media/audio/linux/alsa_output_unittest.cc:83:3:error: 'MockAudioManagerLinux::MakeAudioInputStream' hides overloaded virtual function [-Woverloaded-virtual] MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ In file included from media/audio/linux/alsa_output_unittest.cc:12: In file included from ./testing/gmock/include/gmock/gmock.h:61: testing/gmock/include/gmock/gmock-generated-function-mockers.h:632:28: note: instantiated from: ^ media/audio/linux/alsa_output_unittest.cc:83:3: note: instantiated from: MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ media/audio/linux/alsa_output_unittest.cc:83:16: note: instantiated from: MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ In file included from media/audio/linux/alsa_output_unittest.cc:9: ./media/audio/linux/audio_manager_linux.h:30:29: note: hidden overloaded virtual function 'AudioManagerLinux::MakeAudioInputStream' declared here virtual AudioInputStream* MakeAudioInputStream(AudioParameters params); ^ CXX(target) out/Debug/obj.target/media_unittests/media/base/data_buffer_unittest.o CXX(target) out/Debug/obj.target/media_unittests/media/base/djb2_unittest.o 1 error generated. No bug, just confusing: In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5: ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual] void HandleEvent(int event_index); ^ In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5: In file included from ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:9: ./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here virtual int16 HandleEvent(void* event); ^ 1 error generated. make: *** [out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_schedule_timer_test.o] Error 1 CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_private_test.o CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_test_factory.o In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:17: ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual] void HandleEvent(int event_index); ^ In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:7: In file included from ./webkit/plugins/npapi/test/plugin_arguments_test.h:8: ./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here virtual int16 HandleEvent(void* event); ^ 1 error generated. BUG=72205 TEST=none Review URL: http://codereview.chromium.org/6503001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74642 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74561 after fixing ChromeOS build breakage.willchan@chromium.org2011-02-119-97/+111
| | | | | | | | | | | | | | | | | Introduce OffTheRecordProfileIOData and ProfileImplIOData. They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6500002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74632 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity UNINIT_CTOR defect in the ChildrenDeleter constructor.wtc@chromium.org2011-02-111-1/+1
| | | | | | | | | | | R=rvargas CID=13450 BUG=none TEST=none Review URL: http://codereview.chromium.org/6495003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74565 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74561 for breaking the ChromeOS buildwillchan@chromium.org2011-02-119-111/+97
| | | | | | | | | | | | | | | | | | | | Introduce OffTheRecordProfileIOData and ProfileImplIOData. They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6286133 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6489020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74564 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce OffTheRecordProfileIOData and ProfileImplIOData.willchan@chromium.org2011-02-119-97/+111
| | | | | | | | | | | | | | | They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6286133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74561 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary #include "base/sys_info.h". Reformatwtc@chromium.org2011-02-112-5/+3
| | | | | | | | | | | | LOG statements. R=rsleevi BUG=none TEST=none Review URL: http://codereview.chromium.org/6474023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity PASS_BY_VALUE defect in SdchManager::Dictionary::CanSet.wtc@chromium.org2011-02-112-2/+2
| | | | | | | | | | | R=jar CID=14718 BUG=none TEST=none Review URL: http://codereview.chromium.org/6493001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74539 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused HttpResponseHeaders::GetRawHeaders method.adamk@chromium.org2011-02-112-27/+0
| | | | | | Review URL: http://codereview.chromium.org/6469003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74530 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity UNINIT_CTOR defects in constructors.wtc@chromium.org2011-02-113-4/+8
| | | | | | | | | | | R=eroman CID=14767,1304,8594 BUG=none TEST=none Review URL: http://codereview.chromium.org/6493003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74528 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity UNINIT_CTOR defect in thewtc@chromium.org2011-02-112-8/+10
| | | | | | | | | | | | | | DiskCacheBasedSSLHostInfo::CallbackImpl constructor. Fix cpplint nits. R=agl CID=14184 BUG=none TEST=No compilation errors. Review URL: http://codereview.chromium.org/6474009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74527 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: Make sure that file descriptors are valid before calling close().rvargas@google.com2011-02-101-1/+1
| | | | | | | | | BUG=71399 TEST=none Review URL: http://codereview.chromium.org/6490007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74486 0039d316-1c4b-4281-b951-d872f2087c98
* Even more test cleanup.erg@google.com2011-02-103-74/+136
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6471013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74484 0039d316-1c4b-4281-b951-d872f2087c98
* Display more information at chrome://net-internals/#spdyrch@chromium.org2011-02-092-2/+31
| | | | | | | | | | | | In particular, list the mapping from host:port to port:alternate-protocol and the global spdy configuration state. BUG=none TEST=chrome://net-internals/#spdy Review URL: http://codereview.chromium.org/6465001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74355 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 22:01:42 +0000