summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Annotated the known leak in TestServerLauncher::LoadTestRootCertglider@chromium.org2010-03-222-0/+12
| | | | | | | TBR=wtc Review URL: http://codereview.chromium.org/1155001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42209 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the out-of-bounds array read in the ftp response.inferno@chromium.org2010-03-221-1/+1
| | | | | | | | BUG=38845 TEST=Pass a ftp server response having two double quotes with no character in between and verify no browser crash happens. Review URL: http://codereview.chromium.org/1082008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42204 0039d316-1c4b-4281-b951-d872f2087c98
* 2 experiments: DNS prefetch limit concurrency: TCP split a packetjar@chromium.org2010-03-201-3/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some firewalls apparently try to preclude a "syn flood to host" by limiting the number of syn's (used to open a TCP/IP socket) that are outstanding without having received a syn-ack. Presumably this is to prevent a user from participating in a syn-flood attack (which traditional sends a lot of syn packets, with false return addresses, resulting in no responses). Apparently this firewall technology has in some cases been extended to include UDP sessions for which there has been no response, and this may include DNS resolutions. Since the prefetcher currently resolves as many as 8 names simultaneously, this is remarkably close to the reported threshold of 10 un-answered connections. This test attempts to limit connections to 2, 4, or 6, so that we can see if this helps users. In TCP, the RTO remains (under windows) at a full 3 seconds until after the first ack is received. As a result, if the first data packet sent (after the SYN) is lost, then TCP won't resend until after 3 seconds without an ack. As a test, we split up the first packet into two parts (the second part containing only one byte). This is done as an A/B test, and we'll see if we get a measurable improvement in page-load-time latency. Finally, to get better page load stats, I adjusted the PLT histograms so that we record a "final" time for abandoned pages when they are closed (even if they didn't finish rendering, etc.). This should give a much more fair PLT comparison for all network latency experiments. BUG=3041 BUG=12754 r=mbelshe,darin Review URL: http://codereview.chromium.org/1088002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42181 0039d316-1c4b-4281-b951-d872f2087c98
* Disable backup connect jobs for all pools except TCPClientSocketPoolvandebo@chromium.org2010-03-204-14/+16
| | | | | | | | | BUG=36629 TEST=net_unittests Review URL: http://codereview.chromium.org/1120007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42179 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42152 - Fix the case where the browser livelocks if we cannot open a ↵vandebo@chromium.org2010-03-197-195/+68
| | | | | | | | | | | | | | | | | | | | | | file. If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. BUG=30850 Review URL: http://codereview.chromium.org/541022 TBR=vandebo@chromium.org Review URL: http://codereview.chromium.org/1145004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42154 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.vandebo@chromium.org2010-03-197-68/+195
| | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. BUG=30850 Review URL: http://codereview.chromium.org/541022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42152 0039d316-1c4b-4281-b951-d872f2087c98
* Improved SSL handshake processing on Mac.snej@chromium.org2010-03-192-51/+77
| | | | | | | | | | We now guarantee the server cert is verified before sending a client cert. BUG=38550 TEST=none (manual testing with five different public sites that use client certs) Review URL: http://codereview.chromium.org/1116003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42149 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use cert_pi_useAIACertFetch by default. Use it onlywtc@chromium.org2010-03-193-163/+207
| | | | | | | | | | | | | | | | | | | | | | | | when we are likely to be missing intermediate CA certificates. Work around the SEC_ERROR_POLICY_VALIDATION_FAILED error from CERT_PKIXVerifyCert by retrying CERT_PKIXVerifyCert with the certificate policy in the certificate. Map SEC_ERROR_POLICY_VALIDATION_FAILED to ERR_CERT_INVALID if we can't work around the error. Start the migration away from test_certificate_data.h to the certificate files in the src/net/data/ssl/certificates directory. R=eroman BUG=31497,30891,37549 TEST=A new unit test. To verify the fix for issue 31497 manually, must install the "DoD Root CA 2" certificate first (see comment 9 of bug 31497). Review URL: http://codereview.chromium.org/545103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42118 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42074 - Try to fix flaky websocket tests.amit@chromium.org2010-03-194-40/+40
| | | | | | | | | | | | | | | | | | | Some websoket layout tests became flaky from r41818. This is because it adds websocket throttling in WebSocketJob. Make sure Close() will call OnClose() even if it is waiting resolving or waiting in throttling queue, so that WebSocketJob is removed from throttling queue and wake up next WebSocketJob. BUG=38397 TEST=layout tests websocket/tests passes Review URL: http://codereview.chromium.org/1096001 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/1120004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42078 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix flaky websocket tests.ukai@chromium.org2010-03-194-40/+40
| | | | | | | | | | | | | | | | Some websoket layout tests became flaky from r41818. This is because it adds websocket throttling in WebSocketJob. Make sure Close() will call OnClose() even if it is waiting resolving or waiting in throttling queue, so that WebSocketJob is removed from throttling queue and wake up next WebSocketJob. BUG=38397 TEST=layout tests websocket/tests passes Review URL: http://codereview.chromium.org/1096001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42074 0039d316-1c4b-4281-b951-d872f2087c98
* Pass license check script for most of the tree.evan@chromium.org2010-03-192-0/+38
| | | | | | | | | | | | | Modified license-checker script to allow pruning directories we know to be ok. Still need to do a bit of third_party/* , as well as file a bunch of bugs on pieces where the licenses aren't clear, but I'm running out of energy. Review URL: http://codereview.chromium.org/1100003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42045 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache" Convert some of the unit tests to the newrvargas@google.com2010-03-184-171/+231
| | | | | | | | | | | disk cache interface (async) BUG=26730 TEST=unit tests Review URL: http://codereview.chromium.org/1135002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42031 0039d316-1c4b-4281-b951-d872f2087c98
* Support for viewing text/cache-manifest resources in a browser window ↵michaeln@chromium.org2010-03-181-0/+1
| | | | | | | | | | | instead of downloading them. BUG=38463 TEST=navigate to a resource with that mime type, see it in the browser frame Review URL: http://codereview.chromium.org/1120002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42003 0039d316-1c4b-4281-b951-d872f2087c98
* EndEvent when context has been changedukai@chromium.org2010-03-181-1/+1
| | | | | | | | | | | as URLRequest::set_context() does. BUG=none TEST=none Review URL: http://codereview.chromium.org/1000006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41933 0039d316-1c4b-4281-b951-d872f2087c98
* Add a certificate chain to be used by a new unit test.wtc@chromium.org2010-03-183-0/+0
| | | | | | | | | R=eroman BUG=31497 TEST=none Review URL: http://codereview.chromium.org/1069001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41900 0039d316-1c4b-4281-b951-d872f2087c98
* AppCache: Migrate to the DiskCache's async interface and use the ↵michaeln@chromium.org2010-03-172-0/+13
| | | | | | | | | | | CacheType::APP_CACHE value. BUG=38273 TEST=existing layout tests and unit tests apply Review URL: http://codereview.chromium.org/886003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41884 0039d316-1c4b-4281-b951-d872f2087c98
* Move cert_test_util.{h,cc} and ssl_test_util.{h,cc} to thewtc@chromium.org2010-03-172-7/+11
| | | | | | | | | | | net_test_support build target. R=eroman BUG=none TEST=no build errors Review URL: http://codereview.chromium.org/1047003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41856 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor WebSocket throttling feature.ukai@chromium.org2010-03-1711-417/+305
| | | | | | | | | Protocol specific handling should be done in SocketStreamJob subclasss, so websocket throttling should be handled in WebSocketJob. Review URL: http://codereview.chromium.org/669157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41818 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor WebSocketHandshake out of WebSocket.ukai@chromium.org2010-03-177-356/+546
| | | | | | | | | | | | Make similar code structure with WebKit. Add unittest for WebSocketHandshake. BUG=none TEST=none Review URL: http://codereview.chromium.org/783005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41810 0039d316-1c4b-4281-b951-d872f2087c98
* Move LoadTemporaryCert to the new files cert_test_util.{h,cc} andwtc@chromium.org2010-03-175-105/+135
| | | | | | | | | | | | rename it LoadTemporaryRootCert, so that it can be used by x509_certificate_unittest.cc. R=eroman BUG=none TEST=No compilation and test failures. Review URL: http://codereview.chromium.org/997006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41794 0039d316-1c4b-4281-b951-d872f2087c98
* Correct readability items from previous checkinjar@chromium.org2010-03-172-8/+9
| | | | | | | | | See http://src.chromium.org/viewvc/chrome?view=rev&revision=41743 r=wtc Review URL: http://codereview.chromium.org/1057001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41792 0039d316-1c4b-4281-b951-d872f2087c98
* Move over another legacy "LoadLog-style" event generator to routing its ↵eroman@chromium.org2010-03-163-51/+60
| | | | | | | | | | messages through the NetLog. BUG=37421 Review URL: http://codereview.chromium.org/1052002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41768 0039d316-1c4b-4281-b951-d872f2087c98
* Refine IPv6 probe to require that the client has an IPv6 address on an interfacejar@chromium.org2010-03-163-21/+205
| | | | | | | | | | | | | | | | | | | | This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is performed on a worker thread, so latency should not be an issue (even if we created much slower tests). The current test appears to takes in the raneg of 50-100ms, and probably (under the covers) does some reading from files). BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/1006001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41743 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Ignoring optional client-cert requests from serversnej@chromium.org2010-03-161-24/+76
| | | | | | | | | BUG=37765 TEST=none Review URL: http://codereview.chromium.org/746002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41742 0039d316-1c4b-4281-b951-d872f2087c98
* ssl_SecureSend should not do handshake when the handshake wait state iswtc@chromium.org2010-03-163-62/+104
| | | | | | | | | | | wait_finished and we are false starting. R=agl BUG=38103 TEST=SSLClientSocketTest.Read_FullDuplex should not hang on Ubuntu Karmic. Review URL: http://codereview.chromium.org/850008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41731 0039d316-1c4b-4281-b951-d872f2087c98
* Rename url_request_new_ftp_job -> url_request_ftp_jobphajdan.jr@chromium.org2010-03-164-41/+41
| | | | | | | | TEST=net_unittests BUG=none Review URL: http://codereview.chromium.org/960001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41713 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix some regressions after landing 41689.eroman@chromium.org2010-03-161-11/+4
| | | | | | | | | | The changes to passive_log_collector.cc are a speculative fix for crash seen in dom_perf. TBR=willchan Review URL: http://codereview.chromium.org/969004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41695 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize the net module's LoadLog facility from a passive container, to an ↵eroman@chromium.org2010-03-16105-2208/+1682
| | | | | | | | | | | | | | | | event stream (NetLog). This makes it possible to associate a single NetLog with a URLRequestContext, and then attach observers to that log to watch the stream of events. This changelist attempts to do the most direct translation, so there will be subsequent iterations to clean up. The user-visible behavior should remain unchanged. BUG=37421 Review URL: http://codereview.chromium.org/848006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41689 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the mime sniffer's limit for searching for binary looking bytes fromabarth@chromium.org2010-03-163-65/+142
| | | | | | | | | | | | 512 to 1024 bytes. Contributed by tonyg@chromium.org BUG=15314 TEST=net_unittests --gtest_filter=MimeSnifferTest.LooksBinary git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41687 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Make sure that we don't oveload the IO messagervargas@google.com2010-03-152-3/+9
| | | | | | | | | | | | loop when there are (active) doomed entries that we want to remove from the "deleted" list. BUG=32119 TEST=unittests Review URL: http://codereview.chromium.org/969002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41657 0039d316-1c4b-4281-b951-d872f2087c98
* When connect takes too long for a new socket group, issue a singlembelshe@chromium.org2010-03-146-19/+283
| | | | | | | | | | | | backup socket request to retry the connect. This reduces latency in the presence of packet loss. BUG=36629 TEST=TCPClientSocketPoolTest.BackupSocket* Review URL: http://codereview.chromium.org/842004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41543 0039d316-1c4b-4281-b951-d872f2087c98
* Remove locks from StrictTransportSecurityState.abarth@chromium.org2010-03-142-14/+0
| | | | | | | | | | | | These locks can cause the IO thread to block on the FILE thread writing to disk, which is bad news bears. BUG=21518 TEST=No behavior change. Review URL: http://codereview.chromium.org/904005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41538 0039d316-1c4b-4281-b951-d872f2087c98
* We need to sniff from file:// URLs so that we don't do silly things like try toabarth@chromium.org2010-03-131-1/+2
| | | | | | | | | | download README files. BUG=18342 Review URL: http://codereview.chromium.org/916003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41530 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r41459:willchan@chromium.org2010-03-121-1/+3
| | | | | | | | | "Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by destruction time." Apparently NetworkChangeNotifierMac's observers are still getting leaked in ExtensionApiTest.ShowPageActionPopup. Review URL: http://codereview.chromium.org/871007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41464 0039d316-1c4b-4281-b951-d872f2087c98
* Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by ↵willchan@chromium.org2010-03-121-3/+1
| | | | | | | | destruction time. Review URL: http://codereview.chromium.org/870003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41459 0039d316-1c4b-4281-b951-d872f2087c98
* When using NSS for SSL on Windows, fall back on SSLClientSocketWinwtc@chromium.org2010-03-124-14/+102
| | | | | | | | | | | | | if the server requests a client certificate. This is an interim solution until we modify SSLClientSocketNSS to use CryptoAPI to do SSL client authentication. R=mbelshe BUG=37560 TEST=SSL client authentication should continue to work on Windows. Review URL: http://codereview.chromium.org/795006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41444 0039d316-1c4b-4281-b951-d872f2087c98
* NSS and NPN: send NextProtocol on resume and disable NPN without SPDY.agl@chromium.org2010-03-123-19/+41
| | | | | | | | | | | | | | | | | | | NPN on resume was broken symmetrically between OpenSSL and NSS (which is probably why we didn't notice for so long). OpenSSL wasn't expecting the message and NSS wasn't sending it. This change sends the NextProtocol message when resuming and disables NPN when not using SPDY. The reason for the latter is that we have GFEs deployed which don't expect NextProtocol when resuming and we have to wait some time before they get replaced. Because of this, we can't have NPN enabled by default. Instead, we'll use --host-resolver-rules to redirect everything to known-good GFEs in the mean time. http://codereview.chromium.org/841003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41433 0039d316-1c4b-4281-b951-d872f2087c98
* Do not call OnGetCookiesBlocked or OnSetCookieBlocked when cookies aredarin@chromium.org2010-03-122-9/+12
| | | | | | | | | | | | | restricted by load flags. Only issue those callbacks in response to the CookiePolicy's CanGetCookies / CanSetCookie methods. R=eroman BUG=37922 TEST=covered by url_request_unittest.cc Review URL: http://codereview.chromium.org/893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41393 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-115-2/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* Remove LOG(WARNING)s for when fails to parse proxy bypass rules.eroman@chromium.org2010-03-111-5/+3
| | | | | | | | | | This can pollute the log since it gets hit often (each time poll for checks). BUG=none Review URL: http://codereview.chromium.org/781001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41243 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: Basic peer GoAway frame support.willchan@chromium.org2010-03-103-30/+130
| | | | | | | | | This only handles peer GoAway frames. Does not implement support for client GoAway frames. TODO: Cancel any streams that are past the GoAway frame's last_accepted_stream_id. Review URL: http://codereview.chromium.org/820002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41189 0039d316-1c4b-4281-b951-d872f2087c98
* Add paypal.com to the preloaded STS list.agl@chromium.org2010-03-103-74/+163
| | | | | | | | | TEST=Navigating to http://paypal.com should always be rewritten to https BUG=none http://codereview.chromium.org/815003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41180 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: Alternate-Protocol changes.willchan@chromium.org2010-03-106-41/+122
| | | | | | | | | Add npn-spdy fallback support. Update protocol from spdy=>npn-spdy. Don't process Alternate-Protocol unless it we enabled NPN. Review URL: http://codereview.chromium.org/763001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41169 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: Add basic support for Alternate-Protocol header.willchan@chromium.org2010-03-0911-18/+546
| | | | | | Review URL: http://codereview.chromium.org/668197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41032 0039d316-1c4b-4281-b951-d872f2087c98
* svn prop fixes. Applied to all files not in third_party.pkasting@chromium.org2010-03-092-49/+49
| | | | | | | | | | | | * Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type. * Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF. TBR=evanm BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Reorder the files after the previous mess-up.rvargas@google.com2010-03-083-629/+630
| | | | | | | | | | | | No real code change. BUG=none TEST=none Review URL: http://codereview.chromium.org/669142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40967 0039d316-1c4b-4281-b951-d872f2087c98
* Use 0 for successful end of stream.vandebo@chromium.org2010-03-084-19/+13
| | | | | | | | | BUG=25032 TEST=none Review URL: http://codereview.chromium.org/669122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40938 0039d316-1c4b-4281-b951-d872f2087c98
* net: string_utils.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-0822-3/+25
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/668267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40935 0039d316-1c4b-4281-b951-d872f2087c98
* Add checks to track down bug 31096vandebo@chromium.org2010-03-082-0/+5
| | | | | | | | | BUG=31096 TEST=none Review URL: http://codereview.chromium.org/669226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40934 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle trailing dots in hostname blacklist. jschuh@google.com2010-03-082-0/+11
| | | | | | | | | | | Submitted for inferno@chromium.org BUG=35510 TEST=HostContentSettingsMapTest.HostTrimEndingDotCheck Review URL: http://codereview.chromium.org/669284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40921 0039d316-1c4b-4281-b951-d872f2087c98