| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14231
Review URL: http://codereview.chromium.org/125235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original code review that this belongs to is: <http://codereview.chromium.org/125171>. (BUG=14138)
The original was backed out because of a valgrind linux error (BUG=14218), so I relanded it in smaller chunks to see at which point problem happens.
This differs from the original, in that I have changed the unit-test to no longer use ScopedMapper + WaitingMapper, which I believe was the source of a race.
Review URL: http://codereview.chromium.org/125232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14231
Review URL: http://codereview.chromium.org/126257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification of cancellation during destruction).
The original code review that this belongs to is:<http://codereview.chromium.org/125171>. (BUG=14138)
The original was backed out because of a valgrind linux error (BUG=14218), so I am now re-landing in smaller chunks to identify where the problem resides
Review URL: http://codereview.chromium.org/126254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This particular subset should be a no-op: It adds an unused interface method (OnResolutionCancelled), and an unused test (CancelObserver), and lastly renames Cancel --> MarkAsCanceled().
The code in "dns_global.cc" is also unused since it is unreachable.
The original code review that this belongs to is:<http://codereview.chromium.org/125171>. (BUG=14138)
The original was backed out because of a valgrind linux error (BUG=14218), so I am now re-landing in smaller chunks to identify where the problem resides.
Review URL: http://codereview.chromium.org/126253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original code review for this change was:
<http://codereview.chromium.org/125171>
The particular subset is the third bullet point in original description:
* Fix a bug where completion notification wasn't being sent when the response
was cached. (BUG=14188)
Note that the original was rolled-back because something was upsetting valgrind (BUG=14218).
Review URL: http://codereview.chromium.org/125227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original code review for this change was:
<http://codereview.chromium.org/125171>
It is being reverted because it seems to have caused a valgrind on linux regression:
<http://crbug.com14218>
BUG=14218,14138,14188
Review URL: http://codereview.chromium.org/126248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The code has a glitch in handling LWS near to the "bytes" token.
BUG=14216
Review URL: http://codereview.chromium.org/126229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The cause of the problem is not fully understood yet, suppressing to remove noise from the tree.
BUG=14218
Review URL: http://codereview.chromium.org/126236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/13289
TEST=covered by existing tcp_client_socket_pool_unittest.cc tests.
Review URL: http://codereview.chromium.org/125170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
observers can tell when a request has been cancelled.
* Use OnCancelResolution() in DNS prefetcher observer, to avoid leaking entries in the |resolution| table when requests are cancelled. (BUG=14138)
* Fix a bug where completion notification wasn't being sent when the response was cached. (BUG=14188)
BUG=14138,14188
TEST=HostResolverTest.CancellationObserver, HostResolverTest.Observer
Review URL: http://codereview.chromium.org/125171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes a small refactoring which allows using a different socket factory.
TEST=Covered by net_unittests.
BUG=http://crbug.com/14107
Review URL: http://codereview.chromium.org/126147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13163
TEST=HttpNetworkTransactionTest.BypassHostCacheOnRefresh, HostResolverTest.BypassCache
Review URL: http://codereview.chromium.org/125154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix connecting_sockets_map_ to get updated before running callback.
BUG=none
TEST=TCPClientSocketPoolTest.RequestTwice
BUG=http://crbug.com/13952
Review URL: http://codereview.chromium.org/126168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts r18414.
Broke reliability bot.
Review URL: http://codereview.chromium.org/128001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sets the "referrer" field expected by the DNS prefetch observer.
BUG=14056
Review URL: http://codereview.chromium.org/126112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Defines enums for kParentEntry and kChildEntry in
MemEntryImpl. Also has code in MemBackendImpl to
create a slave entry. Parent entries are non-sparse
entries until sparse API are called on them, and
they would start to keep a list of child entries.
Child entries hold partial content and are not
susposed to be accessible from the public and
are managed by the parent entry that created it.
Child entries are registered in the backend's
ranking list to allow individual eviction. More
details about how child entries are to be used
are in the comments.
TEST=DiskCacheEntryTest.MemoryOnlyEnumerationWithSlaveEntries
Review URL: http://codereview.chromium.org/120004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Re-enable the disabled URLRequest tests.
BUG=http://crbug.com/13952
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/126065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is rather a workaround for the root cause (test touches the network),
but it should not crash anyway.
After this patch the test will fail, not segfault.
TEST=Covered by net_unittest. Check with network connection disabled.
BUG=http://crbug.com/13195
Review URL: http://codereview.chromium.org/125128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=http://crbug.com/12409
Review URL: http://codereview.chromium.org/126120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
http://crbug.com/12409
Review URL: http://codereview.chromium.org/115779
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=this is striclty a refactoring; just needs to compile and pass existing tests.
BUG=14056
Review URL: http://codereview.chromium.org/126110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefetcher, into HostResolver. This has the advantage that consumers of DNS no longer have to remember to call "DidFinishDnsResolutionWithStatus()" followed by "DidStartDnsResolution()" in order for the prefetcher to observe the resolution. Instead it just happens automatically, and subscribers register via HostResolver::AddObserver() on a particular resolver instance.
* To accomodate the prefetcher's observer, HostResolver::Resolve() needs an additional "referrer" parameter. This is slightly awkward since "referrer" has nothing to do with the actual resolve request. To simplify plumbing through this and other optional parameters, Resolve() was changed to take a "RequestInfo&" parameter in place of say {hostname, port, flags}.
* Added an option to HostResolver::Resolve() for disallowing cached responses (RequestInfo::allow_cached_response). This will be used when you refresh a page, to bypass the host cache. The code to do this has been added to HttpNetworkTransaction, but is commented out pending an appropriate unit-test to verify it.
BUG=14056
Review URL: http://codereview.chromium.org/125107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See the changes to url_request.h and ssl_cert_request_info.h.
They are similar to the methods for handling SSL certificate
errors and HTTP authentication.
The handling of servers that request but don't require SSL
client authentication is reimplemented using the new methods.
R=rvargas,eroman
BUG=http://crbug.com/318
TEST=none
Review URL: http://codereview.chromium.org/118039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now css files are opened inside browser instead of download.
Also - making lint happy on the mime_util.cc
BUG=7192
R=abarth
TEST=MimeTypeTests.MimeTypeTests
Patch by Yuri Gorobets.
Original review URL: http://codereview.chromium.org/125005
Review URL: http://codereview.chromium.org/125058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first pass to implement support for range
requests and the asociated sparse cache entry.
It is disabled by default, and requires ENABLE_RANGE_SUPPORT
to be defined in order to activate the code: all the code
is compiled in, but Start() bypasses the cache for range
requests, and OnNetworkInfoAvailable ignores 206.
Big parts are still not implemented. Most notably we are
not modifying the response headers that we send to the
user, so the content-range and content-length info
are not correct.
BUG=12258
TEST=Unit tests.
Review URL: http://codereview.chromium.org/118345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The focus on DNS prefetching has moved to optimize primarilly the
RequestToFinish time in the renderer. As a result, I've removed most
of the modulations of the histogram names other than that focal
histogram. I've also extended the duration for RequestToFinish, and
enhanced its granularity, changing the name to RequestToFinish_L.
Dave: Please review the renderer histogram changes.
Will: Please review the network histogram changes. You can also suggest
any histograms that you think would be removed at this point.
r=davemoore,willchan
Review URL: http://codereview.chromium.org/126023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13952
TBR=willchan
Review URL: http://codereview.chromium.org/126044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Most of the changes were simply because the requests after the first one don't return ERR_IO_PENDING, but instead succeed synchronously.
Along the way, make some test improvements. Don't have to Sleep anymore in tests. Re-enable a broken test from before.
Review URL: http://codereview.chromium.org/125038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I understand the bug now, but need more time to fix it. Will look at this tomorrow.
Review URL: http://codereview.chromium.org/126042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is needed for the "chromium-rel-linux-jaunty" builder.
BUG=13163
Review URL: http://codereview.chromium.org/126038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
leak in URLRequestTest.Cancel[24].
Review URL: http://codereview.chromium.org/126035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add exception handling code for GetLoadState() for when a ClientSocketHandle doesn't exist.
BUG=http://crbug.com/13908
Review URL: http://codereview.chromium.org/125025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=willchan
Review URL: http://codereview.chromium.org/126028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add a 1 minute cache for host resolves.
* Refactor HostResolver to handle multiple requests.
* Make HostResolver a dependency of URLRequestContext. operate the HostResolver
in async mode for proxy resolver (bridging to IO thread).
TEST=unittests
BUG=13163
Review URL: http://codereview.chromium.org/118100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the beginning of the http pipelining work. Introduce HttpStream, an interface for reading and writing to http streams. Provide a basic implementation with HttpBasicStream. Switch HttpNetworkTransaction to reading/writing via HttpStream rather than directly to the socket.
Note that the interface will have to change later on. Read/Write() is the wrong interface, since a pipelining HttpStream implementation will have to detect the end of an http response, rather than having the client (HttpNetworkTransaction) do that. This is just the first step.
For information of the general roadmap for http pipelining, please refer to the bug.
BUG=http://crbug.com/8991
TEST=none
Review URL: http://codereview.chromium.org/119346
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TrimCacheV2() calls EvictEntry() to move a given entry to
the "deleted" list. EvictEntry() deletes the actual data,
and that may end up calling ModifyStorageSize() and
TrimCacheV2() again.
BUG=b/1909376
TEST=none
Review URL: http://codereview.chromium.org/121002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketPoolBase..."
This reverts r18034.
Review URL: http://codereview.chromium.org/119413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We'd like to run EV cert verification in cert verifier's context, but
EV cert verification is expensive and it is only relevant to main frame.
So, pass the LOAD_VERIFY_EV_CERT flag when the resource is main frame
to request EV cert verification.
BUG=10911
TEST=none
Review URL: http://codereview.chromium.org/118373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketPoolBase and TCPConnectingSocket for reuse.
When I write SSLClientSocketPool, it will need to reuse lots of this functionality. This isn't quite the interface we want yet, since we'll need a ConnectingSocket interface for both SSLConnectingSocket and TCPConnectingSocket to derive from, but this is a start.
BUG=http://crbug.com/13289
TEST=none
Review URL: http://codereview.chromium.org/118423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
Review URL: http://codereview.chromium.org/119404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch is contributed by Ibrar Ahmed <ibrar.ahmad@gmail.com>.
Original review: http://codereview.chromium.org/118455
R=wtc
BUG=http://crbug.com/4965
TEST=Run with --new-ftp, and try to download a file.
Review URL: http://codereview.chromium.org/118459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, order files/directories lexicographically.
TEST=on linux, type file:///usr/ in the address bar and make sure the contents
are sorted and include an entry for '..', which is [parent directory].
On windows, type file:///C:/Users/ .
BUG=12621, 12812
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the callback id... it's not useful anymore.
BUG=none
TEST=current unit tests.
Review URL: http://codereview.chromium.org/118407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the common case, the server sends the same certificate during
renegotiation. Since the certificate has been verified, we can
assume the certificate is good or has been accepted by the user.
If the server sends a different certificate that has an error,
we need to return an error code that won't trigger our
certificate error handling code, which doesn't handle this case
correctly. Add the ERR_CERT_ERROR_IN_SSL_RENEGOTIATION error
for this purpose.
R=rvargas
BUG=http://crbug.com/13226
TEST=See http://crbug.com/13226 comment 9
Review URL: http://codereview.chromium.org/118410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://www.crbug.com/13289
Review URL: http://codereview.chromium.org/119251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/119165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If the socket doesn't exist, don't try to Disconnect() it.
BUG=http://www.crbug.com/13375
TEST=See bug for repro.
Review URL: http://codereview.chromium.org/119228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
TBR=wtc
Review URL: http://codereview.chromium.org/114084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17772 0039d316-1c4b-4281-b951-d872f2087c98
|