| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Also fix spdy_http_stream_test errors.
TEST=net_unittests
BUG=46589, 47478, 50198
Review URL: http://codereview.chromium.org/3014030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(The string doesn't match the current NPN string for SPDY, so this wasn't
triggering.)
http://codereview.chromium.org/3060014/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(Patch from Jacob Appelbaum)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=rsleevi
BUG=49887
TEST=net_unittests still passes on the Mac.
Review URL: http://codereview.chromium.org/3020028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2870062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50198
TBR=glider,lzheng
TEST=TSan/Win should become green
Review URL: http://codereview.chromium.org/3061016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=spdy_http_stream_unittest.cc
BUG=50058
Review URL: http://codereview.chromium.org/3061011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49854
TEST=manual
Review URL: http://codereview.chromium.org/2847068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
spdy_network_transaction.
It was previously possible to use spdy_network_transaction using the command line flags:
--use-spdy=no-ssl
--use-spdy=no-compress
This does not affect instances of chrome that are not run with --use-spdy.
Also changed spdy_network_transaction_unittest so that all tests are run with 3 different connection configurations: spdy over npn, spdy over ssl, and spdy without ssl.
TEST=net_unittests
BUG=49082
Review URL: http://codereview.chromium.org/3048003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows SChannel.
R=agl
BUG=49699
TEST=Run Chrome with the --use-system-ssl command-line option on
Mac and Windows. Visit an HTTPS site. Click the lock icon on
the left of the location bar. The Security Information dialog
should display the SSL cipher suite info.
Review URL: http://codereview.chromium.org/3042015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- simplify the public interface
- remove unneeded methods
- make it easier to understand
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/2881028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Requested by a representative of Wikileaks.)
http://codereview.chromium.org/3054010/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a utility function to determine if only loopback address are configured.
Add a mechanism to add supplemental HostResolverFlags in the HostResolver.
Change the resolver on Linux to not use AI_ADDRCONFIG if only loopback addresses are configured.
BUG=41408
TEST=localhost works when offline
Review URL: http://codereview.chromium.org/3036011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PEM-encoded PKCS#7 certificates that are marked with PEM pre-encapsulation boundary of BEGIN CERTIFICATE.
OS X ignores the caller-supplied format if it determines that the incoming data is PEM encoded, attempting to parse using an internal routine that determines the incoming format based on the PEM block header. On 10.5, this results in invalid certificate handles being returned, because the data is not actually a certificate, and this propagates into invalid X509Certificates. By sanity checking the returned handles using the same method as CreateOSCertHandleFromBytes, the problem can be caught and the data can be decoded by PEMTokenizer into a format that 10.5 will respect.
R=wtc
BUG=49887
TEST=X509CertificateParseTest.CanParseFormat no longer fails on OS X 10.5 for variations /5 and /11
Review URL: http://codereview.chromium.org/3019019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
observers.
The Windows implementation is still using a polling mechanism under the hood, however that polling has been moved to the worker pool so it won't block the IO thread in case WinHttpGetIEProxyConfigForCurrentUser is slow (crbug.com/12189).
BUG=12189
Review URL: http://codereview.chromium.org/3056011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed duplicated IsHex functions and converted the callers along the way.
(Note: this was a TODO for jungshik).
BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/2870058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=49547
TEST=none
Review URL: http://codereview.chromium.org/3008014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It broke download ui tests, but was not noticed because of the FLAKY marks.
TBR=cbentzel, bmcquade@google.com
Review URL: http://codereview.chromium.org/3008022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3032017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverses the order that sockets removed from the idle list and deleted.
It also detects and handles recursive calls to CleanupIdleSockets.
BUG=49387
TEST=none
Review URL: http://codereview.chromium.org/2856049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but not port number.
TEST=none
BUG=48078
Review URL: http://codereview.chromium.org/2834062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two classes of refactoring in this submission:
* Enabled by moving domain->CanonicalCookie. This is mostly just
eliminating domain from various argument lists.
* Combination of code that will make the next CL easier. This is
rewriting GetAllCookiesForURL in terms of FindCookiesForHostAndDomain
and nuking FindRawCookies; it'll allow me to change the basic
algorithm for probing the cookie map in a single place.
BUG=8850
TEST=Linux, net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.*
Review URL: http://codereview.chromium.org/2904006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Function override signature doesn't match the one in its base class.
BUG=None
TEST=Fixing a unit test.
Review URL: http://codereview.chromium.org/3015017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
X509CertificateParseTest is failing for PKCS#7 data from PEM encoded blocks. When it fails, it crashes net_unittests because of an out-of-bounds read.
Mark the test as FLAKY on OS X, and change the EXPECT to an ASSERT to suppres the crash
BUG=49887
TEST=X509CertificateParseTest.CanParseFormat on OS X 10.5 no longer crashes
Review URL: http://codereview.chromium.org/2868064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
certificates - specifically formats that represent collections of certificates. The certificate format can now be specified as an explicit format, or as a bit-mask of formats that are acceptable/expected, with the first parsable format winning.
This is one half of a commit to address BUG #37142, with the second half involving connecting this through the X509UserCertHandler and the actual UI.
R=wtc
BUG=37142
TEST=X509CertificateParseTest* and PEMTokenizerTest.*
Review URL: http://codereview.chromium.org/2819018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
switch, initial support for receive window size.
BUG=48100
TEST=net_unittestss --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowUpdate:SpdyNetworkTransactionTest.WindowUpdateOverflow"
Review URL: http://codereview.chromium.org/3052005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33033
TEST=None
Review URL: http://codereview.chromium.org/2883031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also cleaned up spdy unit tests a bit.
TEST=SpdyHttpStreamTest should have no memleaks in valgrind.
BUG=48865, 47950, 46886
Review URL: http://codereview.chromium.org/3033012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It returned a wstring, when really we wanted the native encoded
strings. Fixing the majority of callers actually simplified them
in many cases because the callers wanted native strings too.
Since I'm touching every caller, I gave it a more useful name.
I'm not sure where "loose" came from but it never made sense to me.
BUG=24672
Review URL: http://codereview.chromium.org/3028010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
destructors from classes with instance members of type
scoped_ptr_malloc<>
Also remove #include of iostream from remaining header file.
Review URL: http://codereview.chromium.org/2861065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Originally, it was a vector of pair<domain_string, CanonicalCookie>.
TEST=Refactor; all relevant unit tests should still pass.
BUG=8850
Review URL: http://codereview.chromium.org/2799057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for code at http://code.google.com/p/page-speed/source/browse/bin/trunk/src/pagespeed/pagespeed_input_populator.cc#148
Contributed by: bmcquade@google.com
BUG=48192
TEST=Added new unit tests, ran net_unittests.
Review URL: http://codereview.chromium.org/2849041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3035010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/2847058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first step to make test server easier to use
and more reliable.
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/3040011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=49396
Review URL: http://codereview.chromium.org/2836060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<iostream> creates a static initializer. Most people don't need <iostream>
anyway--they really need <ostream> for operator<< overloads. <iostream>
should *never* be included in a header file; <iosfwd> exists for that purpose.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3014015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2824059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29625
TEST=none
Review URL: http://codereview.chromium.org/2832057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/3040005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids racing on the initialization of the statics usually declared
when doing histogram accumulation.
BUG=49142
TEST=net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.* (to confirm I didn't break anyting; this doesn't reproduce the race.)
Review URL: http://codereview.chromium.org/2832061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=48100
TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowSizeChange:SpdyNetworkTransactionTest.WindowSizeOverflow"
Contributed by: agayev@google.com
Review URL: http://codereview.chromium.org/2805083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Under tsan, tcp connect job tries to connect several times and fails to find
data provider for mock socket.
Make connect synchronous (as done in SpdySessionTest) fixes the issue.
BUG=none
TEST=./tools/valgrind/chrome_tests.sh --build_dir out/Debug --test net --tool tsan --gtest_filter='SpdyStreamTest.*'
Review URL: http://codereview.chromium.org/3054002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user has a stale TGT, or is unable to generate a TGS for the server they are trying to communicate to, then generating an authentication token fails.
Rather than fail the entire network transaction in that case, we resend the request with an empty Authenticate (or Proxy-Authenticate) header, and remember that the Negotiate scheme is not a valid option for this particular transaction.
If the server responds back with headers like
WWW-Authenticate: Negotiate
WWW-Authenticate: Digest realm=foo
then the digest scheme is chosen in the next round.
BUG=33033
TEST=None
Review URL: http://codereview.chromium.org/3010010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In HTTP, it doesn't use STATE_READ_BODY/STATE_READ_BODY_COMPLETE states. Reading body message is handled in OnDataReceived() and DoLoop() is not involved in this state.
In WebSocket, it will send frame after handshake has been finished, and need to get how many data has been written.
STATE_OPEN handles this.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2962015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GSSAPI expects SPNs to be in the form HTTP@<server_name> and SSPI expects
SPNs to be in the form HTTP/<server_name>.
BUG=33033
TEST=net_unittests --gtest_filter="*HttpAuthHandlerNegotiate*", go against Kerberized server on Linux or OSX and see that the TGS is retrieved correctly.
Review URL: http://codereview.chromium.org/3055001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The evictions code may post tasks for further processing and
that is a problem at cache destruction, so add an explicit
method to stop evictions.
BUG=49547
TEST=none
Review URL: http://codereview.chromium.org/2854053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GSSAPI does not provide a mechanism for the user to specify username/password to obtain a TGT. If default credentials are not allowed for an end site, skip negotiate and use a different scheme.
Arguably in this case it may make sense to simply prompt the user whether they want to use their existing Kerberos credentials to authenticate to the server and use the existing TGT, but we'll need UI changes.
BUG=33033
TEST=net_unittests, try to authenticate to a Kerberized server which is not in the whitelist.
Review URL: http://codereview.chromium.org/3013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52943 0039d316-1c4b-4281-b951-d872f2087c98
|