summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Improve parsing of the Content-Disposition headerabarth@chromium.org2012-01-278-356/+498
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous, we were using GetHeaderParamValue to parse the Content-Disposition header, which describes itself as a "quick and dirty implementation." After this patch, we use more of our normal HTTP parsing machinery, making our parsing much less quirky and better aligned with RFC 6266. Some notes: 1) Many of the test cases for parsing the Content-Disposition header included the string "Content-Disposition: " in the input. I've looked through all of the callers of these functions, and that seems to be completely bogus. The old parser wasn't careful enough to see that as a problem, but the new one follows the spec more closely. I've updated the test cases to remove this string. 2) After this patch, there's a bunch of code in net_util.cc that really should be moved to http_content_disposition.cc. I didn't move that code in this patch because I didn't want this path to be too large. I'll move it in a future patch. 3) In a future patch, I'll audit the codebase for callers of GetHeaderParamValue. With any luck, we'll be able to remove them all and delete this less-than-amazing function. BUG=65423 Review URL: http://codereview.chromium.org/9234055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119378 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add tests for UploadDataStream::position().satorux@chromium.org2012-01-271-7/+17
| | | | | | | | | | | | This API wasn't tested at all. BUG=72001 TEST=net_unittests Review URL: http://codereview.chromium.org/9169091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119363 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - Change all tests to use SPDY/2.1 protocol. Madertenneti@chromium.org2012-01-2710-91/+129
| | | | | | | | | | | | changes to SPDY code to support enabling or disabling flow_control independent of NPN protocol negotiated. TEST=network unit tests R=wtc Review URL: http://codereview.chromium.org/9252029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119360 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Do key_file NULL check earliertbreisacher@chromium.org2012-01-271-2/+4
| | | | | | | | | | | CID=100673 BUG=none TEST=none Review URL: http://codereview.chromium.org/9290029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119347 0039d316-1c4b-4281-b951-d872f2087c98
* Don't force groups.google.com to HTTPS.agl@chromium.org2012-01-262-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119250 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all remaining explicit LeakyLazyInstanceTraits users to ::Leakyfischman@chromium.org2012-01-266-16/+9
| | | | | | | | | | | | | and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting new users. BUG=none TEST=none Review URL: http://codereview.chromium.org/9117038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
* Fix warnings (which are now errors) in the Android build.jrg@chromium.org2012-01-264-7/+11
| | | | | | | | | | BUG=None TEST= Review URL: http://codereview.chromium.org/9288034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119155 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Another UNINIT_CTOR...tbreisacher@chromium.org2012-01-261-2/+7
| | | | | | | | | | | CID=102809 BUG=none TEST=none Review URL: http://codereview.chromium.org/9289026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119154 0039d316-1c4b-4281-b951-d872f2087c98
* DnsClient refactoring + features (timeout, suffix search, server rotation).szym@chromium.org2012-01-2623-1148/+1312
| | | | | | | | | | | | | | DnsClient::Request ==> DnsTransaction DnsTransaction ==> DnsTransactionImpl DnsClient ==> DnsTransactionFactory BUG=109949 TEST=net_unittests --gtest_filter=Dns* Review URL: http://codereview.chromium.org/9190031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119146 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Fix an UNINIT_CTOR in PartialData::Core constructortbreisacher@chromium.org2012-01-251-2/+2
| | | | | | | | | | | CID=102811 BUG=none TEST=none Review URL: http://codereview.chromium.org/9271046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119141 0039d316-1c4b-4281-b951-d872f2087c98
* Add origin bound certs to BrowsingDataRemover and extensions clear API.mattm@chromium.org2012-01-259-36/+123
| | | | | | | | | | BUG=107056 TEST="Delete cookies and other site and plug-in data" option in Clear Browsing Data dialog should clear origin bound certs. Review URL: https://chromiumcodereview.appspot.com/9120001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119084 0039d316-1c4b-4281-b951-d872f2087c98
* CertDatabaseNSSTest: Don't delete test DB dir since we don't close the DB ↵mattm@chromium.org2012-01-251-16/+5
| | | | | | | | | | | | | | | | (broke in r108543). Refactor test DB code so that nss_util owns the test DB dir. Keeping the test DB dir until exit prevents later tests that would use the test DB from failing. The dir will still be deleted by the LazyInstance atexit handler. BUG=108748 TEST=see bug Review URL: http://codereview.chromium.org/9255034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119003 0039d316-1c4b-4281-b951-d872f2087c98
* Skip checking headers for pipelining if there was a socket error.simonjam@chromium.org2012-01-252-1/+24
| | | | | | | | | | BUG=110798 TEST=net_unittests Review URL: http://codereview.chromium.org/9113036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118965 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chrome to handle 407 auth challenges to CONNECT requestsrch@chromium.org2012-01-2520-163/+940
| | | | | | | | | | | | | | | | | through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Initially was http://codereview.chromium.org/8502024 which turned out to have problems with NTLM auth. Review URL: http://codereview.chromium.org/9148011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118950 0039d316-1c4b-4281-b951-d872f2087c98
* net: Give more descriptive names for code around the request merging logic.satorux@chromium.org2012-01-244-21/+33
| | | | | | | | | | | | | This is a follow-up patch based on wtc's comments on the earlier patch: http://codereview.chromium.org/9270030/ BUG=72001 TEST=no logic change Review URL: http://codereview.chromium.org/9284033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118942 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "FALSE START" logspam.thakis@chromium.org2012-01-241-1/+0
| | | | | | | | | | | | | | | | | | This was added here: http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_client_socket_nss.cc?r1=118833&r2=118832&pathrev=118833 But that change was not in the review: http://codereview.chromium.org/9131012 So I guess it was debug output not intended to be committed. BUG=none TEST=less logspam TBR=agl Review URL: https://chromiumcodereview.appspot.com/9283027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118889 0039d316-1c4b-4281-b951-d872f2087c98
* Improve readability of UploadDataStream.satorux@chromium.org2012-01-242-80/+114
| | | | | | | | | | | | | | | | Many variable names in the code are misleading or not descriptive. In particular, next_element_* are misleading as these are referring to the current element currently being read. Along the way, add some comments, and clean up some pieces of code. BUG=72001 TEST=run tests via try bots Review URL: http://codereview.chromium.org/9212015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118854 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary preventative build fixjoth@chromium.org2012-01-242-4/+6
| | | | | | | | | | | | | | Openssl 1.0.0 is const correct for SSL_METHOD - adding a temporary const cast so we can land the new versin without a build break. (Once that is in, we can switch the SSLState member to be const instead) BUG=None TEST=try servers remain green Review URL: http://codereview.chromium.org/9129019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118836 0039d316-1c4b-4281-b951-d872f2087c98
* net: add a policy option: DisableSSLRecordSplittingagl@chromium.org2012-01-243-18/+4
| | | | | | | | | | | | | | | | | | | Microsoft are providing a similar policy option and it looks like some groups may need it while their proxies are updated. It's rather unfortunate that the underlying SSLConfigService member is called enable_false_start, but I don't want to conflate a clean up of that with this CL. BUG=107728 TEST=none http://codereview.chromium.org/9131012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118833 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r113405, since it appears to be causing a crash and a hang. Also ↵eroman@chromium.org2012-01-2417-659/+46
| | | | | | | | | | reverted r118506 since it is no longer applicable. BUG=109876, 110368, 62364, 92244 Review URL: https://chromiumcodereview.appspot.com/9226039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118788 0039d316-1c4b-4281-b951-d872f2087c98
* net: Don't merge HTTP headers and body if the body is not in memory.satorux@chromium.org2012-01-249-27/+197
| | | | | | | | | | | | | UploadDataStream::MarkConsumedAndFillBuffer() may touch the file system if the body data comes from a file. BUG=72001,107966 TEST=added tests. Review URL: http://codereview.chromium.org/9270030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118769 0039d316-1c4b-4281-b951-d872f2087c98
* Add a convenience typedef LazyInstance<T>::Leaky to avoid repeating T.fischman@chromium.org2012-01-235-13/+8
| | | | | | | | | | | | | Converted the first 20 or so hits for LeakyLazyInstanceTraits on codesearch to demonstrate the benefit at callsites. The real change is base/lazy_instance.h; everything else is example. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9192024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118754 0039d316-1c4b-4281-b951-d872f2087c98
* Remove expired certificate from CertDatabaseNSSTest.ImportCACertHierarchyTree.joaodasilva@chromium.org2012-01-231-5/+10
| | | | | | | | | | TBR=eroman@chromium.org BUG=111029 TEST=CertDatabaseNSSTest.ImportCACertHierarchyTree Review URL: https://chromiumcodereview.appspot.com/9200012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118669 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to socket_test_util.cc.szym@chromium.org2012-01-2212-230/+206
| | | | | | | | | | | | | | | - Removes ref-counting from DelayedSocketData and OrderedSocketData. - Calls CompleteRead (which reads from underlying data) only if a Socket::Read call is "blocked" (previously returned with ERR_IO_PENDING). - Removes unsafe pointers to the handed out sockets (the factory does not own them and cannot guarantee their lifetime). BUG=110626 TEST=./net_unittests --gtest_filter=Spdy*:Http*:Socket*:WebSocket*:Ftp* Review URL: http://codereview.chromium.org/9251019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118634 0039d316-1c4b-4281-b951-d872f2087c98
* Split DoSendBody() to DoSendChunkedBody() and DoSendNonChunkedBody().satorux@chromium.org2012-01-222-49/+65
| | | | | | | | | | | | | The two code paths perform the send-body operation differently. Split it to separate functions to make the code easier to read. BUG=72001 TEST=net_unittests passed as before. Review URL: http://codereview.chromium.org/9252035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118632 0039d316-1c4b-4281-b951-d872f2087c98
* The network_moved check in DoHandshakeLoop and calling OnHandshakeIOCompletejnd@chromium.org2012-01-211-15/+13
| | | | | | | | | | | | | | | | | | in Send/Recv IO completion callbacks should only apply to STATE_HANDSHAKE After transport I/O completes synchronously, stay in the handshake loop only if the next state is STATE_HANDSHAKE, which is the only state that requires transport I/O to make progress and the only state that allow us to call OnHandshakeIOComplete in Send/Recv IO completion callbacks. The change is mainly from http://codereview.chromium.org/9172005. BUG=109706 BUG=net_unittests::SSLClientSocketTest.*, should not be hung when running those tests. Review URL: http://codereview.chromium.org/9138010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix nit: Clarify code by using locally-declared alias for complex expression.palmer@chromium.org2012-01-211-1/+1
| | | | | | | | Noted by wtc in CL 9231029. Review URL: http://codereview.chromium.org/9226022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118603 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY - SpdyFramer close the session for header compression/decompression errors.rtenneti@google.com2012-01-211-1/+4
| | | | | | | | | BUG=99766 R=wtc TEST=network unit tests Review URL: https://chromiumcodereview.appspot.com/9232019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118595 0039d316-1c4b-4281-b951-d872f2087c98
* Adds TTL argument to HostCache::Set.szym@chromium.org2012-01-219-121/+134
| | | | | | | | | | | | | Re-lands r118489 but with static initializers removed. BUG=25472, 107880 TEST=net_unittests R=mmenke Review URL: http://codereview.chromium.org/9226035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118574 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out chunk encoding logic into HttpStreamParser::EncodeChunk().satorux@chromium.org2012-01-216-29/+156
| | | | | | | | | | | | | | | | | | The logic is meaty enough to be factored out. Add unit tests along the way. The original patch (crrev.com/118265) was reverted as it introduced a new static initializer. This version fixed that problem by defining the constant in the .h file. To be extra careful, replaced kChunkBufferSize with a member variable chunk_buffer_size_. BUG=72001 TEST=add unit tests. run tools/linux/dump-static-initializers.py locally to confirm that new static initializers are not introduced. Review URL: http://codereview.chromium.org/9176009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118566 0039d316-1c4b-4281-b951-d872f2087c98
* Decrease the PAC polling delay even further.eroman@chromium.org2012-01-203-72/+97
| | | | | | | | | | Reduces the poll interval for success to 12 hours, and for failures to a maximum of 4 hours. BUG=110551 Review URL: https://chromiumcodereview.appspot.com/9255033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118551 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up the fix for NSS bug 718554 (a SSL_ForceHandshake bug).wtc@chromium.org2012-01-202-4/+4
| | | | | | | | | | | | | | | | SSL_ForceHandshake returns wrong positive results after sending pending data. See https://bugzilla.mozilla.org/show_bug.cgi?id=718554. Fortunately this bug doesn't affect Chromium because Chromium compares the return value of SSL_ForceHandshake with SECSuccess (0). R=agl@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/9265015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118547 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118489 since it seems to regress linux-sizes.sadrul@chromium.org2012-01-209-133/+121
| | | | | | | | | | | | | | | | """ Adds custom ttl argument to HostCache::Set. BUG=25472,107880 TEST=net_unittests Review URL: http://codereview.chromium.org/9197009 TBR=szym@chromium.org Review URL: https://chromiumcodereview.appspot.com/9138039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118512 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117772 - Add instrumentation to help track down a use-after-free.eroman@chromium.org2012-01-202-58/+4
| | | | | | | | | | | | | | This instrumentation checks to see if a deleted ClientSocketPoolBaseHelper::Group is being re-used. If it catches a use-after-free of this class then it will save the callstack where the deletion occurred into the mini-dump, for manual inspection by bug investigator. BUG=109876 Review URL: http://codereview.chromium.org/9207014 TBR=eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/9226030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118074 - Disable FPO throughout client_socket_pool_base.cc.eroman@chromium.org2012-01-201-13/+0
| | | | | | | | | | | | | | This will help track down the origin of a use-after-free bug. BUG=109876 Review URL: http://codereview.chromium.org/9240036 TBR=eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/9271013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118510 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a use-after free in socket pool which can happen after reaching the ↵eroman@chromium.org2012-01-201-0/+5
| | | | | | | | | | | maxium number of sockets. BUG=109876 Review URL: http://codereview.chromium.org/9226011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118506 0039d316-1c4b-4281-b951-d872f2087c98
* Adds custom ttl argument to HostCache::Set.szym@chromium.org2012-01-209-121/+133
| | | | | | | | | | BUG=25472,107880 TEST=net_unittests Review URL: http://codereview.chromium.org/9197009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118489 0039d316-1c4b-4281-b951-d872f2087c98
* net: remove SSL blacklisted hosts that were included because of record ↵agl@chromium.org2012-01-201-28/+0
| | | | | | splitting. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118473 0039d316-1c4b-4281-b951-d872f2087c98
* Move operator<< for StringPiece into string_piece.{h,cc}akalin@chromium.org2012-01-201-1/+2
| | | | | | | | | BUG=110651 TEST= Review URL: https://chromiumcodereview.appspot.com/9159005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118416 0039d316-1c4b-4281-b951-d872f2087c98
* [uber page] make references to chrome_shared2.css relativeestade@chromium.org2012-01-201-1/+2
| | | | | | | | | | | otherwise open_sans.woff doesn't get loaded (not sure why) BUG=none TEST=open sans is used Review URL: https://chromiumcodereview.appspot.com/9254001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118402 0039d316-1c4b-4281-b951-d872f2087c98
* The network_moved check in DoHandshakeLoop should only apply towtc@chromium.org2012-01-191-12/+13
| | | | | | | | | | | | | | | | | | | | | | | | | STATE_HANDSHAKE. After transport I/O completes synchronously, stay in the handshake loop only if the next state is STATE_HANDSHAKE, which is the only state that requires transport I/O to make progress. If the next state is any other state, we should ignore network_moved when determing if we should stay in the handshake loop. This changelist is the SSLServerSocketNSS version of http://codereview.chromium.org/9172005. SSLServerSocketNSS doesn't need this change now because it has no other handshake states, but this change will make it future-proof. Also remove unnecessary net:: prefixes. R=agl@chromium.org BUG=109706 TEST=existing unit tests for SSLServerSocket should continue to pass Review URL: http://codereview.chromium.org/9250031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118356 0039d316-1c4b-4281-b951-d872f2087c98
* Disable pipelining if we encounter HTTP Authentication.simonjam@chromium.org2012-01-196-5/+56
| | | | | | | | | | BUG=102970 TEST=net_unittests Review URL: http://codereview.chromium.org/9241028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118346 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up uses of static data around singletons.rsesek@chromium.org2012-01-191-2/+7
| | | | | | | | | | | | This is in preparation for destroying singletons between each test. BUG=110594 TEST=Test suites. Review URL: http://codereview.chromium.org/9255020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118320 0039d316-1c4b-4281-b951-d872f2087c98
* net: merge HTTP headers and body when the sum is small enough.agl@chromium.org2012-01-191-36/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (This is a reland of r118099 which was reverted in r118149 because it changed intermediate XMLHttpRequest events - breaking layout tests. We not don't free the request_body_ so that we continue to generate the same intermediate events.) When sending a small POST message we currently do two writes: one for the headers and one for the body. With 1/n-1 record splitting, this results in four TLS records when the connection uses CBC. Plesk correctly handles record splitting in HTTP headers, but incorrectly assumes that the entire POST body is in a single TLS record. Thus record splitting causes Chrome to be unable to log into Plesk (or perform any other action that requires a POST.) IE and Firefox 10 also do record splitting, but they merge the headers and body so there's only a single split after the first byte of the headers and Plesk can handle this. Our histogram data suggests that ~4% of requests can be merged in the fashion of this patch, so it seems independently worthwhile to do this. BUG=107966 TEST=none Review URL: http://codereview.chromium.org/9133007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118265 (added a static initializer on linux)thakis@chromium.org2012-01-196-148/+28
| | | | | | | | | | | | | | | | | | - Factor out chunk encoding logic into HttpStreamParser::EncodeChunk(). The logic is meaty enough to be factored out. Add unit tests along the way. BUG=72001 TEST=add unit tests. Review URL: http://codereview.chromium.org/9242018 TBR=satorux@chromium.org Review URL: https://chromiumcodereview.appspot.com/9264010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118295 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out chunk encoding logic into HttpStreamParser::EncodeChunk().satorux@chromium.org2012-01-196-28/+148
| | | | | | | | | | | | | The logic is meaty enough to be factored out. Add unit tests along the way. BUG=72001 TEST=add unit tests. Review URL: http://codereview.chromium.org/9242018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118265 0039d316-1c4b-4281-b951-d872f2087c98
* Minor clean-up for HttpStreamParser::DoSendBody()satorux@chromium.org2012-01-191-4/+3
| | | | | | | | | | | | | This shouldn't change the behavior, as chunk_lengths_ is guaranteed to be zero at the two places, as wtc pointed out. BUG=72001 TEST=run tests. Review URL: http://codereview.chromium.org/9232032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118227 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where an alternate protocol request to an unsafe portmmenke@chromium.org2012-01-193-26/+94
| | | | | | | | | | | | | | would hang indefinitely, and a logging bug from the same original CL, add unit test. Buggy commit: http://codereview.chromium.org/8898008/ R=wtc@chromium.org BUG=93326 Review URL: http://codereview.chromium.org/9240012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118210 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments to HttpStreamParser::DoSendBody().satorux@chromium.org2012-01-191-2/+10
| | | | | | | | | | | | | This function is relatively complex. Add comments to clarify what this function does. Will clean up the code in a separate patch. BUG=72001 TEST=chrome and tests build as before. Review URL: http://codereview.chromium.org/9213018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118193 0039d316-1c4b-4281-b951-d872f2087c98
* Change the polling policy for PAC scripts to be much less frequent (new: 2 ↵eroman@chromium.org2012-01-182-48/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | hours, old: 2 minutes). The poll intervals are now as follows: In response to a failure fetching the PAC script: 8 seconds 32 seconds 2 minutes 2 hours 2 hours ... (2 hours) In response to a success fetching the PAC script: 2 minutes 2 hours 2 hours ... (2 hours) BUG=110551 Review URL: http://codereview.chromium.org/9255023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118180 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-08 15:20:17 +0000