| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
ERR_SSL_PROTOCOL_ERROR for user_cancelled TLS alerts on Mac.
TBR=wtc
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3938002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build with use_openssl=1, HTTPSRequestTest.HTTPSExpiredTest
Review URL: http://codereview.chromium.org/3678001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Only 424k off Linux debug .a files).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Was reverted in r62922 due to a change landing between the try run and the
commit.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59642
TEST=win32 tsan bot goes green.
Review URL: http://codereview.chromium.org/3808011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Only 916k this time off Debug Linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3814013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=1634, 11587, 5007, 13234, 13398, 9295, 8294, 8285
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3817007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The interface to CookieMonster::GarbageCollectDeleteList() was
signalling "delete all cookies in list" by specifying "delete all
cookies in list with last access time before Now()". This was failing
to work properly when the system clock wasn't updated frequently
enough (== flaky test) and is also vulnerable to changes in systems
clocks. That semantic is now explicitly signalled by a null time.
BUG=58197
TEST=net_unittests CookieMonsterTest.* on Win/Linux and CookieMonsterTest.TestHostGarbageCollection (flaky test) repeatedly on Windows.
Review URL: http://codereview.chromium.org/3780004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57686
TEST=net_unittests CookieMonsterTest.* on Linux, running original valgrind test and confirming that it completed.
Review URL: http://codereview.chromium.org/3752004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang would complain
/Users/thakis/src/chrome-git/src/net/base/host_resolver_impl.cc:557:5: error: template argument uses local type 'net::HostResolverImpl::Job::Category' [-Wlocal-type-template-args]
DCHECK_LT(category, RESOLVE_MAX); // Be sure it was set.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /Users/thakis/src/chrome-git/src/net/base/host_resolver_impl.cc:5:
In file included from ../net/base/host_resolver_impl.h:18:
In file included from ../net/base/network_change_notifier.h:10:
In file included from ../base/observer_list_threadsafe.h:14:
../base/logging.h:662:31: note: instantiated from:
#define DCHECK_LT(val1, val2) DCHECK_OP(LT, < , val1, val2)
^
../base/logging.h:635:9: note: instantiated from:
logging::Check##name##Impl((val1), (val2), \
^~~~~~~
This seems to be a new warning. Since it only affects this file, we might as well fix the problem instead of disabling the warning.
BUG=None
TEST=clang/mac waterfall stays green after clobber build.
Review URL: http://codereview.chromium.org/3816009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=45135
TEST=Build works.
Review URL: http://codereview.chromium.org/3747008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Interface classes are an example where the -Wnon-virtual-dtor warning can be a bit annoying, but this still seems reasonable and makes it clear that users should not delete through the interface.
BUG=45135
TEST=Builds
Review URL: http://codereview.chromium.org/3781010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests --gtest_filter=*X509*
Review URL: http://codereview.chromium.org/3785001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create an SSLHostInfoFactory interface and plumb it from the HttpCache
to the SSLConnectJob. Also, move the SSLHostInfo reference from the
ssl_config to being passed to the SSLClientSocket.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/3747003
TBR=agl@chromium.org
Review URL: http://codereview.chromium.org/3846005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create an SSLHostInfoFactory interface and plumb it from the HttpCache
to the SSLConnectJob. Also, move the SSLHostInfo reference from the
ssl_config to being passed to the SSLClientSocket.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/3747003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
removes windows_message_list which isn't used.
This keeps a stub for registry in the old location until we can update that.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3836005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
properly (scoped_cftyperef -> ScopedCFTypeRef).
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3855001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The check-in r62746 clobbered the changes I made in r62689 to host_resolver_impl.cc.
I believe that was an accident since r62746 moved code within the file.
TBR=jar
Review URL: http://codereview.chromium.org/3828008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
living in IOThread.
I had to make some other changes to make this fit well: moved ProxyScriptFetcherImpl to its own set of files, and added a IOThread::Get() accessor to avoid plumbing through several layers in connection_tester.
I find the registry living in IOThread is preferable, as globals in net/ limit the ability to run on safely on multiple threads, and also leads to confusion on what needs to be called at shutdown.
Review URL: http://codereview.chromium.org/3823001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only use Alternate-Protocol for latching onto existing SpdySessions.
This is a temporary change until SSL improvements are made, so we
can begin sending http over spdy when available.
Note that we have to do proxy resolution one time to figure out how to check for the appropriate existing SpdySession. If no SpdySession exists, we fallback again and have to redo proxy resolution (since the alternate protocol of npn-spdy requires rewriting the URI from http:// to https://). So we may end up doing two proxy resolutions in the fallback case.
I had to disable all the tests that test establishing a new
SpdySession for http:// URIs, since we don't do that for now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3573013
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3751009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--use-spdy=off
BUG=none
TEST=SpdyNetworkTransactionTest.SpdyOnOffToggle
Review URL: http://codereview.chromium.org/3807008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can't have a namespace called "linux" because it's ifdefed by GCC to be a
number. Same for "unix". "x11" was discarded because some future stuff in
here will not be related to x11.
This also renames base_paths_posix to base_paths_linux since this does not
apply to mac, and normally posix applies to mac (this confused me when I had to
edit it for the XDG stuff).
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3778007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::win namespace.
This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch.
This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there.
I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3781009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also converts COOKIE_DLOG (since VLOG can be toggled on a granular basis), removes some unneeded "endl"s and {}s, aligns "<<"s per style guide, and changes KeygenHandler::GenKeyAndSignChallenge() to avoid using "goto".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3846001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54450
TEST=none
Review URL: http://codereview.chromium.org/3750009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because the encryption strength is unknown (0 means no
encryption).
R=finnur
BUG=53366,13049
TEST=no unit test failures
Review URL: http://codereview.chromium.org/3749003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm doing tests to see what the impact of changing the
speculative resolution system parameters is on
resolution time. By default, the speculative system
limits itself to no more than 8 pending resolutions
at any time, and this test looks at 6, 4, and 2
as limits.
It also modulates the speculative congestion avoidance
system, which purges the speculative queue when there is
too much resolution latency, and tries various durations
of time. (the latter was less important... but was already
part of this existing A/B test.)
I also pushed the test rates up to 10% for each case, so
that we'd get data from the canary and/or dev builds.
r=eroman
Review URL: http://codereview.chromium.org/3762006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56734
TEST=see bug
Review URL: http://codereview.chromium.org/3775005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getaddrinfo() has unexpectedly failed.
For example when the system returns WSA_NOT_ENOUGH_MEMORY, we will now show ERR_NAME_RESOLUTION_FAILED rather than ERR_NAME_NOT_RESOLVED.
This allows propagating the error to the user, rather than simply showing them say the linkdoctor page as if the domain they entered was incorrect.
The data shows that a small number of users are getting these sorts of unexpected failures, and I want to get more visibility into it. By having a separate error code we can track how often this actually floats up onto an error page (as opposed to just errors on non-essential background requests).
On Linux we also see EAI_AGAIN with some frequency. My theory is that these occur when you DNS resolve immediately after the network change notification was broadcast (since I can repro this 100% on my laptop). If this is in fact the major cause, then once I land this new error we should NOT see an influx of ERR_NAME_RESOLUTION_FAILED in Net.ErrorCodesForMainFrame.
Review URL: http://codereview.chromium.org/3781005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This makes it easier to display the symbolic names of each error code on the server side, since we specify a mapping per histogram name.
Review URL: http://codereview.chromium.org/3771005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended for the beta/stable branch.
BUG=none
TEST=none
TBR=gavinp
Review URL: http://codereview.chromium.org/3788002
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/3775009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(3.5 megs off debug linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3806005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended for the beta/stable branch.
BUG=none
TEST=none
TBR=gavinp
Review URL: http://codereview.chromium.org/3788002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(increasing the number of deleted entries)
BUG=none
TEST=none
TBR=gavinp
Review URL: http://codereview.chromium.org/3778002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Options menu ("Under the Hood" tab) on Windows.
R=mattm
BUG=59125
TEST=net_unittests.exe --gtest_filter=SSLConfigServiceWinTest.SetTest.
Manually verify the Options menu has the two new checkboxes.
Review URL: http://codereview.chromium.org/3779003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54745
TEST=manual
Review URL: http://codereview.chromium.org/3582007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't think this needs to be reverted, but git cl dcommit went a bit wacky and I'm being conservative.
The goal is to turn on -Wnon-virtual-dtor warning for gcc. In this case, the virtual Run()'s do not appear necessary,
especially since they are private. If intended to be derived from, there is a "delete this" in the base class which would
point to requiring a virtual destructor.
BUG=45135
TEST=Target builds, validated that there are no derived classes of RRResolverWorker.
Review URL: http://codereview.chromium.org/3824002
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/3813005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal is to turn on -Wnon-virtual-dtor warning for gcc. In this case, the virtual Run()'s do not appear necessary,
especially since they are private. If intended to be derived from, there is a "delete this" in the base class which would
point to requiring a virtual destructor.
BUG=45135
TEST=Target builds, validated that there are no derived classes of RRResolverWorker.
Review URL: http://codereview.chromium.org/3824002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We now have an assigned OID in the Google corporate OID subspace.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop refcounting StreamRequest. Establish a clear ownership of the StreamRequest. Deletion implies cancellation. Use ScopedRunnableMethodFactory::NewRunnableMethod() instead of NewRunnableMethod().
Remove Start() from StreamRequest. This is an implementation detail of HttpStreamRequest, so it only exists there now.
BUG=59103
TEST=existing, this is a pure refactor.
Review URL: http://codereview.chromium.org/3746002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58192
TEST=Start chrome with --auth-schemes=NTLM and --proxy-server pointing to a Microsoft Forefront Threat Management Gateway proxy configurated for Integrated Authentication. Assuming the user is part of the same domain as the proxy, authentication should work transparently, and the user should not be presented with auth prompts. Also, net_unittests should pass.
Review URL: http://codereview.chromium.org/3676004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=13288
Review URL: http://codereview.chromium.org/3781002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58963
TEST=net_unittests
Review URL: http://codereview.chromium.org/3774002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=40797
Review URL: http://codereview.chromium.org/3646004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to support fetching HTTPS URLS over a SPDY Proxy.
BUG=29625
TEST=HttpNetworkTransactionTest.HttpsProxySpdyConnect
Review URL: http://codereview.chromium.org/3417010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3768001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a RequestSockets() API to ClientSocketPool interface.
- no RequestPriority param, all requests default to LOWEST.
- adds a |num_sockets| param to control how many sockets to try to ensure are connected.
Adds an implementation for said function in ClientSocketPoolBaseHelper.
Adds a new ClientSocketPoolBaseHelper::Flag type to modify socket request behavior. In this case, we bypass idle sockets.
Adds a preconnect concept to ConnectJob. This lets normal requests hijack preconnect jobs.
Modifies all ClientSocketPool subclasses to support new RequestSockets API().
Adds new tests.
No client actually uses this API yet. We need to plumb it up to the preconnect system.
BUG=54450
TEST=new tests in ClientSocketPoolBaseTest
Review URL: http://codereview.chromium.org/3689004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=33185
r=kmixter
Review URL: http://codereview.chromium.org/3702005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62353 0039d316-1c4b-4281-b951-d872f2087c98
|